- 11 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c3b10013ca7..3b819f3d8bbe git log 7c3b10013ca7..3b819f3d8bbe --date=short --no-merges --format='%ad %ae %s' 2019-10-11 nisse@webrtc.org Move video_sources_.clear() call to CallTest::DestroyStreams Created with: gclient setdep -r src/third_party/webrtc@3b819f3d8bbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I7788e4f9fdd09efbec4c16c26c47223e70830987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705046}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/82f84c4b8f19..eba98c4eb781 git log 82f84c4b8f19..eba98c4eb781 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 afdx@google.com spirv-fuzz: Add fuzzer pass to add NoContraction decorations (#2950) 2019-10-11 afdx@google.com spirv-fuzz: Add fuzzer pass to change function controls (#2951) 2019-10-10 paulthomson@users.noreply.github.com reduce: add large tests and fix (#2947) 2019-10-10 afdx@google.com spirv-fuzz: Add fuzzer pass to change loop controls (#2949) 2019-10-10 afdx@google.com Fixed include paths and order according to Google style. (#2957) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@eba98c4eb781 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I8a142dd1dcbefcc43ceba36f4ee0fe63d7a02a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854844Reviewed-by:
-
Antonio Gomes authored
... and the respective unittest, rtc_rtp_sender_unittest.cc This CL works out phase 7.2 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ In order to avoid colliding files and classes names with existing homonyms in renderer/modules/peerconnection, the following renames were performed: - rtc_rtp_sender_impl.cc -> rtc_rtp_sender_impl.cc - rtc_rtp_sender_impl.h -> rtc_rtp_sender_impl.h.h - rtc_rtp_sender_unittest.cc -> rtc_rtp_sender_impl_test.cc Also, RTCRtpSender became RTCRtpSenderImpl. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I40f7e7c139839beb88b72b4e509a352db3d4ecbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819811 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705044}
-
Lowell Manners authored
After a page enters the BackForwardCache, a user may navigate to a new page on the same site as the cached page (See BackForwardCacheBrowserTest.NavigateToTwoPagesOnSameSite). In the above case, it's important not to reuse the RenderViewHost(s) owned by the frames in the BackForwardCache, because this could lead to two main frames (the one in the cache, and the one the user just navigated to), existing at the same time for a single RenderViewHost (not allowed). To solve this, we can simply stop reusing RenderViewHosts that belong to a page when it enters the BackForwardCache, and begin reusing them again when it leaves the BackForwardCache. This approach also allows us to remove a work-around in navigation_controller_impl.cc that was aggressively deleting cached frames. Note: RenderViewHost is owned by RenderFrameHost, this CL changes nothing WRT object lifetimes. Change-Id: I18698fc4f737f3945ab41270bd07d1538ca096a5 Bug: 993337, 999846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833616Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#705043}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/284b45288355..69077a26ccaf git log 284b45288355..69077a26ccaf --date=short --no-merges --format='%ad %ae %s' 2019-10-11 khokhlov@google.com Add ms to legacy unit infos Created with: gclient setdep -r src/third_party/catapult@69077a26ccaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:981349 Change-Id: I249687208830bed352fabd4e9f14037007acda32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854947Reviewed-by:
-
Vadym Doroshenko authored
In order to send a crowdsourcing vote, FormStructure object should be constructed. And now there is no simple way to do this. This CL introduces constructor that takes only signatures (which are bare minimum). This constructor will be used for sending votes for username forms in username first flow. Along a way, initialization in header is done instead of initialization in constructors, in order to decrease code duplication. Bug: 959776 Change-Id: Id593dfc36ef2235302b14f3f15b97b29dae666df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849387 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#705041}
-
Benoît Lizé authored
Replaces comments with annotations for variables protected by mutexes in blink/platform. This allows the static analysis pass in clang to check locking at compile time. Changes are: - Annotate member variables with GUARDED_BY() - Add a few Mutex::AssertAcquired() assertions. These mark the mutex as acquired to the checker, and do not generate any code when DCHECK()s are off. - Add required locking to some unit tests only methods. The code wasn't incorrect before as these are typically single-threaded, but this is still required in principle. While in the neighborhood, also fix a few "git cl lint warnings": missing include guards comments, explicit constructors, and include what you use. Bug: 1013082 Change-Id: If957288537f1930f821f94296dd89e5525649ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851709 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
James Cook authored
The "Split Settings Sync" project is decoupling Chrome OS system preferences from browser preferences. This CL adds the sync protocol buffers for the new data types. C++ visitors and tests will be updated later, in the CL that adds the new ModelType. Bug: 1013466 Change-Id: I4e8c9a95a5b8107d1ca15250e4e181b1ebc19c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855218 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#705039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/545a481a74a3..90a30f154a61 git log 545a481a74a3..90a30f154a61 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 apodtele@gmail.com * src/sfnt/pngshim.c (premultiply_data): Optimize for __SSE__ only. Created with: gclient setdep -r src/third_party/freetype/src@90a30f154a61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Ia7556a6ba9a1d8fff959df1c73913d1d404a1a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855120Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#705038}
-
Javier Ernesto Flores Robles authored
Updates the current separator color to a dynamic one. Bug: 1008832 Change-Id: I1b408fb1b60a6f516fd2bfab430e18f79fbb58dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855741 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#705037}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=oshima@chromium.org Change-Id: I74adbbd6aacb924efdd2cf6cce18adee886bbba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855778Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705036}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f505d9d8..464d407d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff0bcb321c2a12f79f536cb55a591512113066f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855659Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705035}
-
Oliver Chang authored
Change-Id: I56f11fa5e877f64a42139d584fe6fcd5a8030fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855619 Commit-Queue: Oliver Chang <ochang@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#705034}
-
Renato Silva authored
This commit adapts the encryption migration screen on crOS for devices with a small screen. It also improves the messages in the event of insufficient space. Tested locally Bug: 1002097 Change-Id: I6afb449e8499047f029b8c0159df4c9cea72d3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845218 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705033}
-
Marina Ciocea authored
The logic for kRemove tab strip model changes is covered in OnInfobarRemoved. Drive-by reset tab capture indicator on StopSharing. This wasn't a bug, the indicator would get destroyed in dtor, but it's more logical to remove it on StopSharing and it makes testing easier. Bug: 996722 Change-Id: I49943226dcc4fc7eab8a4776f45aaa7c9fd98d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855738Reviewed-by:
-
arthursonzogni authored
A page using the WebBluetooth API shouldn't be frozen and shouldn't enter the BackForwardCache. When navigating away from a page: 1) The Bluetooth connection should be released. 2) The tab indicator should be removed. This won't happen if the RenderFrameHost is kept in the back-forward cache. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: I27cb850ed6e94de440486b33111332811942c930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837936 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Canon Mukai authored
Use partition alloc for zlib allocations instead of malloc. Bug: 999091 Change-Id: I3481fc08fcb943f3c458e5122a7237638a75929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855143Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#705030}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e6f9bd000949..7c3b10013ca7 git log e6f9bd000949..7c3b10013ca7 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3fcb9481..3d7980bd (704895:705004) Created with: gclient setdep -r src/third_party/webrtc@7c3b10013ca7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I3f87bc85b2c24bddf91f158f41130dee1d56a1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854943Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a5f5e7778ad7..3a1e314b0399 git log a5f5e7778ad7..3a1e314b0399 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 4b97a1108114..1ff0c181bb37 (1 commits) Created with: gclient setdep -r src/third_party/angle@3a1e314b0399 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: Ie67ca1abec8ab0a21c5fad72fca5da273e0e37d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854942Reviewed-by:
-
Yutaka Hirano authored
This is a follow-up for https://crrev.com/c/1852346. Bug: 1013087 Change-Id: Icd460a3d1df6818e84624410ca6d9f4e315902d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855622 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#705027}
-
Hayato Ito authored
http/tests/devtools/a11y-axe-core/basic-a11y-test.js http/tests/devtools/a11y-axe-core/performance/landing-page-a11y-test.js http/tests/devtools/a11y-axe-core/performance/performance-pane-a11y-test.js http/tests/devtools/a11y-axe-core/settings/shortcuts-a11y-test.js TBR=mjackson@microsoft.com Bug: 1013391 Change-Id: I12266d83f041277cdc4734caf897969d2fe64435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855544Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#705026}
-
Hayato Ito authored
external/wpt/webxr/events_referenceSpace_reset.https.html is also TIMEOUT on MacOS 10.11. It would be better to make this test TIMEOUT on all platforms. TBR=alcooper@chromium.org Bug: 1013526, 626703 Change-Id: I2543cc4cac9e33c35dff7b7f29c7f0149428de13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855542Reviewed-by:
-
Gyuyoung Kim authored
This reverts commit d7213e95. Reason for revert: This CL causes a build break on bots. Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 13 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I42c62234c64878d23057366df8823eb94a8a5e6e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852354 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705021} TBR=tkent@chromium.org,gyuyoung@igalia.com Change-Id: I336b7ba2e61ce33e829255d40643e44c68927ccc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855546Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#705024}
-
Shakti Sahu authored
Bug: 1013403 Change-Id: I259c45060c86d35de84149351539430be57478b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854521Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705023}
-
Hitoshi Yoshida authored
"async iterable" and "iterable" are literally similar, but have different definitions in spec. And it provides us following benefit to separate "async iterable" and "iterable"; - It makes easy to dispatch different functions in the code generator. https://cs.chromium.org/chromium/src/third_party/blink/renderer/bindings/scripts/web_idl/ir_builder.py?q=ir_builder&dr&l=104&rcl=489221aa216913b574354b09ff94469151b682b4 is a bad example that comes from setting "callback" property on "interface" node. - Current code generators do not support "async iterable", but they accidentally accept it as "(synchronous) iterable" without throwing errors. This CL makes it an error. Bug: 839389 Change-Id: Ie48829802ac2a73916ba081459208c0d11f13740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855540 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#705022}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I42c62234c64878d23057366df8823eb94a8a5e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852354 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#705021}
-
arthursonzogni authored
The FrameHostInterceptor observe RenderFrameHost creation and destruction. In its constructor, it simulate observing RenderFrameHost creation for every active RenderFrameHost. It misses the ones in the BackForwardCache. This causes a mismatch later when it observe a RenderFrameHost deletion. Change-Id: Ifabf5eab92f3275d71e5a7d760f44e4178e00d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816509 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
When no more intervals can be resolved, ResolveInterval(...) will return an interval that return false from IsResolved() (meaning it has no finite begin time). When this happens we should "clear" |interval_| by setting it to an unresolved interval. This fixes the behavior of SVGAnimationElement.getStartTime() which now correctly report (throws) when the last interval of element has ended. Add a new test for that and move an old somewhat related test to WPT. Also adjust SVGAnimationTestCase.js which uses this to offset the sample times (although in most cases) to avoid the debug dump when there's no current interval (no tests actually rely on the old broken behavior). This makes us match Firefox. Bug: 998526 Change-Id: Idcf348343768ffc9392e29af2e976b9a3a1e31aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849897Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#705019}
-
Morten Stenshorne authored
This ensures that we have room for the tallest piece of monolithic content, and also the tallest container with break-inside:avoid. There are more things we could pay attention to here, but at least for now we don't. We could take break avoidance between siblings into account, and also orphans and widows. Orphans and widows are honored when balancing in the legacy engine, but it's somewhat buggy; see crbug.com/1013151 - it may lead to taller columns than necessary. The net increase in passing tests isn't impressive, but this is largely due to lack of support for fragment painting. The "regressing" span-all-dynamic tests are laid out more correctly now than before, but doing things dynamically vs. doing it right away matters for the fragment painting code. This CL also introduces a mild regression. By honoring unbreakable content, we should also make sure that underflow is ignored (i.e. content that comes before the start of a fragmentainer, caused by negative margins). Otherwise we risk overstretching. This is what fast/multicol/balance-line-underflow-1.html is about. I'll submit a separate CL for that, since this one is big enough on its own. Bug: 829028 Change-Id: Iee389525c34961a7748bd5597f22c75026919671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854224 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705018}
-
Hirokazu Honda authored
There are two modes in VEA, native input mode and non native input mode. In native input mode, a input buffer given by VEA client is a graphic native input buffer. The buffer alignment is decided in minigbm implementation. It is 64 and 4 for width and height, respectively. In non native input mode, the buffer is a shared memory based buffer. The width and height is specified by VEA. crrev.com/c/1810453 changes a dimension alignment for an input buffer in HW video encoder using VA-API. The width and height are aligned by 16 before the CL. The width is aligned by 64 and height aligned by 4 since the CL. For example, if a configured encode stream size is 176x144. | A size of buffer | VA Surface size | VA surface size for | given by client | for an input buffer | a reconstructed surface N-I mode | 192x144 | 192x144 | 192x144 non N-I mode | 192x144 | 192x144 | 192x144 This change causes a lot of failures in chrome encoder test (crbug.com/1009297) and CTS (b:142210669). This CL is expected to mitigate the failures. A reconstructed surface size is the same as coded size, whose width and height both are aligned by 16. The size of a buffer is the same as coded size in non native input mode. This is fine because an input buffer is copied in a client size in non native input mode. The sizes in the above example are below. | A size of buffer | VA Surface size | VA surface size for | given by client | for an input buffer | a reconstructed surface N-I mode | 192x144 | 192x144 | 176x144 non N-I mode | 176x144 | 176x144 | 176x144 Bug: 1009297, 1005205 Bug: b:142210669, b:142217112, b:142091557 Test: EncodeDecodeTest#testEncodeDecodeVideoFromBufferToBufferQCIF on caroline Test: VEA unittest on eve Change-Id: Ibca0f951ace886fcbeb8031e886c196913f69cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847432Reviewed-by:Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#705017}
-
Yutaka Hirano authored
We would like to understand how common it is to serialize / transfer non-Origin-clean ImageBitmap. Bug: 1013087 Change-Id: Id593ee1e1e448d9cd234638d2e86d4893e13f8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852346 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: Ib32bcfd0a27a50a74d433ff77251a5f0ad14b604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855238 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Hayato Ito authored
Disable flaky SingleClientBookmarksSyncTest.ApplyRemoteUpdateWithValidGUID on all platforms. Note that the previous CL, https://crrev.com/c/1855144/, was inntended to disable this test, however, the CL actually disabled another test for http://crbug.com/1012222 accidentally. TBR=mmoskvitin@google.com Bug: 1012223 Change-Id: Iadd0fa11535eb696d2f0cef516f22270723d34ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855319Reviewed-by:
-
dpapad authored
This is in preparation of migrating this UI to Polymer3/JS Modules, in which global namespaces like sync.confirmation will not exist. Bug: 1012533 Change-Id: I7fb3f6f3767a760d09c827acec133ef3f2c020f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853804 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#705013}
-
Koji Ishii authored
The assumption is |NGLineBreaker::CreateBreakToken| always has a valid style. This patch adds DCHECK for the assumption. TBR=mstensho@chromium.org Bug: 1013040 Change-Id: Idbe5594136c8b1b9c4556dacf81631af49a56a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855066Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#705012}
-
Koji Ishii authored
This test was unstable when I tried to rebaseline before, but wangxianzhu told me that Mac10.10 bots were unstable, and its instability was fixed. Re-trying the rebaseline. TBR=wangxianzhu@chromium.org NOTRY=true Bug: 1011453 Change-Id: Ic7f54ab756538e23cf17df3774863d62be99484e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855246Reviewed-by:
-
Nick Burris authored
Update the feature detectability API to window.location.fragmentDirective per https://github.com/WICG/ScrollToTextFragment/issues/19 Also updated web platform tests and confirmed tests pass. Bug: 1000308 Change-Id: Ib2391abe3d142d57cea61840e721ed35c81089af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850364 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705010}
-
Colin Blundell authored
As part of the effort to replace base::Bind by base::Bind{Once, Repeating}, this CL converts the one usage of base::Bind() in //components/web_resource to instead be a usage of base::BindRepeating(). The rational for using base::BindRepeating() is that the callback is being passed in to a PrefChangeRegistrar, which can invoke it multiple times in response to pref changes. This CL also takes the opportunity to update the PrefChangeRegistrar API in question to take in a base::RepeatingClosure rather than a base::Closure. TBR=jochen@chromium.org Bug: 1007753 Change-Id: I7550f64eedb9d0da719f9ff8617e2c4d9d415eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847216 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#705009}
-
Daichi Hirono authored
Previously ArcAccessibilityHelperBridges has used GetCaptionStyleFromPrefs. But it started adding "important!" token to override existing style, which Android side does not recognize. The CL stop using GetCaptionStyleFromPrefs and loads caption style directly from prefs. BUG=b:141660231 TEST=GetCaptionStyleFromPrefsTests.* Change-Id: Iee017eb3c5afd28205067df842f112cc553406a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837437Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#705008}
-
Alexey Baskakov authored
Previously we did in-place immediate updates for existing apps. This was not consistent with the commit ideology since effects were becoming visible immediately. It didn't match the creation and deletion of apps: they were deferred until commit. With this CL we implement basic copy-on-write for WebApp object updates. We commit the created copy into the original for real, during the commit call. In next CLs: Fix UpdateSync algorithm to avoid excessive change_processor Put and Delete calls. TBR=alancutter@chromium.org Bug: 860583 Change-Id: I26eb53b668f74ce0c606a60af9016aa8a4cca1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851792 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
