GitLab

Move WebKitThread to the content namespace.

Re-order thread objects in BrowserMainLoop declaration to match instantiation order.

BUG=98716


Review URL: http://codereview.chromium.org/8776007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112682 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8776046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106149
TEST=DefaultProviderTest*

Review URL: http://codereview.chromium.org/8776044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112680 0039d316-1c4b-4281-b951-d872f2087c98

Make the domain gray, and move it to the right of the title so that
all titles are left aligned. Also get rid of the fade-in when entries
are hovered, because it makes the page feel laggy.

BUG=105425
TEST=Manual test of functionality on chrome://history.


Review URL: http://codereview.chromium.org/8658006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112679 0039d316-1c4b-4281-b951-d872f2087c98

Also, sort headers to the extent possible.

BUG=none


Review URL: http://codereview.chromium.org/8776008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105579


Review URL: http://codereview.chromium.org/8749016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23642
TEST=None.

Review URL: http://codereview.chromium.org/8775013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112676 0039d316-1c4b-4281-b951-d872f2087c98

Add support for cursor pre-fetching.

BUG=88651
TEST=browser_tests

Review URL: http://codereview.chromium.org/8662017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8769031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106163
TEST=content_unittests works again
TBR=scottmg@chromium.org

Review URL: http://codereview.chromium.org/8771033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112673 0039d316-1c4b-4281-b951-d872f2087c98

Also, add a few minor refinements to the other parts of the script

TBR=bruening,rnk
Review URL: http://codereview.chromium.org/8775047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112670 0039d316-1c4b-4281-b951-d872f2087c98

GCC 4.5+ somehow causes compilation errors while compiling EXPECT_EQ(false,...) and EXPECT_EQ(true,...).
This change just replaces EXPECT_EQ(false,...) with EXPECT_FALSE(...), and replaces EXPECT_EQ(true,...) with EXPECT_TRUE(...), respectively.

BUG=none
TEST=build unit_tests with gcc 4.5+

Review URL: http://codereview.chromium.org/8774036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112669 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112668 0039d316-1c4b-4281-b951-d872f2087c98

TBR=kkania

Review URL: http://codereview.chromium.org/8769033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104700
TEST=ContentSettingsObserverTest.WhitelistedSchemes


Review URL: http://codereview.chromium.org/8775005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112665 0039d316-1c4b-4281-b951-d872f2087c98

1) Add one more python builtin to avoid printing duplicate reports
2) Enable logging up to INFO level when invoking drmemory_analyze.py manually
3) "foo.exe!bar" -> "*!bar", not "*.exe!bar"

TBR=bruening
Review URL: http://codereview.chromium.org/8772039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62897
TBR=aa
Review URL: http://codereview.chromium.org/8775046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104625
TEST=Existing tests

Review URL: http://codereview.chromium.org/8554008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112662 0039d316-1c4b-4281-b951-d872f2087c98

*) If the backup default search provider was deleted from the keywords, it is taken from the prepopulated data array.
*) If a search provider with same URLs already exists, it is updated; otherwise, the prepopulated SP is added.

BUG=105423
TEST=TemplateURLServiceTest.*; For Protector: manual with sqlite3

Review URL: http://codereview.chromium.org/8704007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112661 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112659 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib

Review URL: http://codereview.chromium.org/8776042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106032
TEST=no


Review URL: http://codereview.chromium.org/8773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112657 0039d316-1c4b-4281-b951-d872f2087c98

the explicit policy to meet a minimum security threshold.
Review URL: http://codereview.chromium.org/8773028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112656 0039d316-1c4b-4281-b951-d872f2087c98

This patch teaches the extension system to use the document's origin when
computing extension permissions. Ideally, we'd use only the document's origin,
but because app extents don't cover entire origins, we need to also consider
the document's URL.

BUG=103630
Review URL: http://codereview.chromium.org/8659009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112655 0039d316-1c4b-4281-b951-d872f2087c98

R= oshima@chromium.org, flackr@chromium.org
BUG=105952
TEST=CertificateViewerUITest*.*


Review URL: http://codereview.chromium.org/8772035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112654 0039d316-1c4b-4281-b951-d872f2087c98

TBR=leiz
BUG=97248
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112653 0039d316-1c4b-4281-b951-d872f2087c98

to decide where to archive to.

BUG=None
TEST=None
R=noelallen@google.com
Review URL: http://codereview.chromium.org/8758013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112652 0039d316-1c4b-4281-b951-d872f2087c98

    
This reverts commit f9f5f14c.

Revert "Move chromeos specific code to ChromeBrowserMainPartsChromeos"
    
This reverts commit 922cff9c.

Revert "chromeos: remove power manager EXPECTs from login_browsertest"
    
This reverts commit 0a9298b6.



Review URL: http://codereview.chromium.org/8774035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112651 0039d316-1c4b-4281-b951-d872f2087c98

On Windows, rather than converting the entire certificate 
name to a string and attempting to parse out the components 
and values, iterate through the relativeDistinguishedName 
and AttributeTypeAndValue pairs to extract each name 
component.

This is to ensure that:
1) When multiple AVAs are present in an RDN, ALL AVAs are
   parsed.
2) When converting an AVA to a string, no extra escaping is
   applied.

This also fixes domainComponent parsing on OS X, so that
unittests with a domainComponent can pass.

BUG=101009, 102839
TEST=net_unittests:X509CertificateTest has two new regression
tests. Additionally, sample a variety of SSL sites and ensure no
regressions, paying attention to internationalized domains.


Review URL: http://codereview.chromium.org/8608003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112650 0039d316-1c4b-4281-b951-d872f2087c98

This cuts down on the number of strings in the executable, as well as
executable code to print them.

On Linux, this saves 208kb on a stripped official build
(chrome executable file went from 64569072 bytes -> 64782064 bytes)

On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes)

On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes)

Fix test failure in logging_unittest.cc in official builds.

Add new executable check_example for easy testing of changes to the
CHECK macros.

BUG=101561
TEST=

Review URL: http://codereview.chromium.org/8734021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98

We're still gating things at the server with trusted testers, but to be able
to do experiments with real apps we need to remove the requirement for the
experimental flag (you can't install apps from the webstore that have the
experimental permission).

BUG=98145
TEST=Should be able to install an app with the 'appNotifications' permission.


Review URL: http://codereview.chromium.org/8776022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112648 0039d316-1c4b-4281-b951-d872f2087c98

Regarding Chromium issues 73355, 95129, 95732, 97285, 103957 and Chromium-os issue 18437, 22372, we suspect the channel handles passed to the renderer have invalid file descriptors (fd). This is supported by the fact that using a channel handle with a valid name but an invalid fd will produce crashes with exactly the same stack trace as reported in these issues. Running out of fd in either the renderer, browser or the other process (GPU, broker, etc) could cause this to happen, but we are not sure if that's the real cause.

Adding check for the fd in various places to help investigate these issues further. We will be able to tell if invalid fd is passed in and if yes, which process generates it. Browser side check is only added for the broker case to limit the scale of bad user experience, while providing enough cases for investigation.

BUG=none
TEST=passed unit tests

Review URL: http://codereview.chromium.org/8735015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102714
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/8776025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99524
TEST=compositor_unittests, views_unittests, aura_unittests...


Review URL: http://codereview.chromium.org/8565019

TBR=piman@chromium.org
Review URL: http://codereview.chromium.org/8775045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112645 0039d316-1c4b-4281-b951-d872f2087c98

src/content should not depend on src/views.
 
BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8770029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112644 0039d316-1c4b-4281-b951-d872f2087c98

Removing as it's not necessary and simplifies code to make it easier to ultimately rid ProfileSyncService of cros_user,
and ultimately convert it to a ProfileKeyedService.

Before this change the two values only differ 1) on chrome os, where kGoogleServicesUsername doesn't seem to be set today (and in some cases we use cros_user as a crutch), and 2) when kGoogleServicesUsername is cleared, but that only happens on DisableForUser.  In the future I'd imagine this value to be allowed to outlive that call as well, which would be OK.

BUG=88109,93922
TEST=bits of UI that show usernames continue to show usernames


Review URL: http://codereview.chromium.org/8665011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TEST=none


Review URL: http://codereview.chromium.org/8773029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112642 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99524
TEST=compositor_unittests, views_unittests, aura_unittests...


Review URL: http://codereview.chromium.org/8565019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112641 0039d316-1c4b-4281-b951-d872f2087c98

This is bryeung CL from http://codereview.chromium.org/8748013/
which was approved by sky and failed on the commit-bot. It also improves the logic of one of my later CL in the same area.

TBR=sky@chromium.org
BUG=105046
TEST=grep *.ninja for relevant files in a large variety of configurations


Review URL: http://codereview.chromium.org/8776034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112640 0039d316-1c4b-4281-b951-d872f2087c98

The WebUI form-repost warning dialog wasn't getting closed
when you reloaded the page or navigated away from it.
bauerb pointed out that this was because the dialog's
ConstrainedWindow wasn't getting registered in the
RepostFormWarningController.

This change also updates
RepostFormWarningTest.TestDoubleReload from ui_tests to
check that we don't open multiple dialogs and that we close
the dialog when navigating away.

BUG=105546
TEST=manual: checked that old dialogs are closed on reload and when hitting the back button


Review URL: http://codereview.chromium.org/8771017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112639 0039d316-1c4b-4281-b951-d872f2087c98