- 12 Nov, 2018 40 commits
-
-
Fredrik Söderquist authored
This if cascade consumes both a fair bit of footprint while it makes the switch slightly less readable. Change-Id: Ia8cb0d14ec831ccfcf7f22154a12f16d44fbc9ad Reviewed-on: https://chromium-review.googlesource.com/c/1329147 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607223}
-
Boris Sazonov authored
This CL removes passwords checkbox enabled state dependency on ProfileSyncService::IsCryptographerReady(). This datatype can be configured without cryptographer being ready (that's what other platforms do) and removing this dependency fixes issues when this checkbox was spontaneously becoming disabled. Bug: 902880 Change-Id: I58f8b1b0375bc2bdfb77c1db1cf3f998020b935d Reviewed-on: https://chromium-review.googlesource.com/c/1323720Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#607222}
-
Boris Sazonov authored
This CL modifies SigninHelper.validateAccountSettings so that accounts are accessed only after AccountManagerFacade cache is populated. SigninHelper.validateAccountSettings is called early during startup, so postponing this call should reduce the amount of time spent waiting for accounts on UI thread. Bug: 837374 Change-Id: Ica027806d9a329e08b880abec12dc0954c540e63 Reviewed-on: https://chromium-review.googlesource.com/c/1329247Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#607221}
-
Peter Wen authored
- Submit this only when 3.4 is available on internal canary. TBR=agrieve@chromium.org Bug: 620034 Change-Id: Iebcec3271b37ecfea8ba4f3eac36ab576ec5acf1 Reviewed-on: https://chromium-review.googlesource.com/c/1324871Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607220}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 251b2c57. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" 395cf32d "Preparation of moving LayoutTests to web_tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6c56958cb13ea9fcd3418d6e3a77a8cefef274f3 Reviewed-on: https://chromium-review.googlesource.com/c/1331009 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607219}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c8e54cc..5ac7f8c6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie77677170120878281daa491b29b3531cbc26f4e Reviewed-on: https://chromium-review.googlesource.com/c/1331010Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607218}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/768184982153..279259d2591e Created with: gclient setdep -r src-internal@279259d2591e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2f6b305c7e9037f5197d90294fbc85b6292a4516 Reviewed-on: https://chromium-review.googlesource.com/c/1331218Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607217}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/662c038f3fdd..d1eeca86af6e git log 662c038f3fdd..d1eeca86af6e --date=short --no-merges --format='%ad %ae %s' 2018-11-12 pasko@chromium.org compare_samples: trivial fix in Main Created with: gclient setdep -r src/third_party/catapult@d1eeca86af6e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:903730 TBR=sullivan@chromium.org Change-Id: I4d634429ea4da913126e51853cedacfe48ab37b4 Reviewed-on: https://chromium-review.googlesource.com/c/1331409Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607216}
-
Jan Krcal authored
This CL introduces notification of remote changes for wallet metadata sync. This is vital for two reasons: - PersonalDataManager loads up to date data as soon as it gets changed; - It allows to write integration tests for wallet metadata that only observe the PDM (and thus test as end-to-end as it gets). The approach to block self-notification is a bit hacky; it will get removed in the new USS bridge as this will not listen to MultipleChanged any more. Bug: 894001 Change-Id: I1bcdd4b80187c2980c4343bfd37584ad64d93d01 Reviewed-on: https://chromium-review.googlesource.com/c/1309744 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607215}
-
Mythri Alle authored
We used to use GetCachePath as a means to control the parameters of the code caching. To disable code caching embedder returned an empty path. Now, we replaced this with a better interface with GeneratedCodeCacheSettings [cl]. We no longer need GetCachePath interface for BrowserContext [cl]: https://chromium-review.googlesource.com/c/chromium/src/+/1213093 BUG: chromium:867552 Change-Id: Ifc7993548fa73d8713b935a7cb8cc5876ff3d431 Reviewed-on: https://chromium-review.googlesource.com/c/1301973 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607214}
-
Boris Sazonov authored
This CL adds bsazonov@chromium.org to chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS. Bug: None Change-Id: Ic66e1b62b1efe5655273c6c528ea9dc1381994f0 Reviewed-on: https://chromium-review.googlesource.com/c/1326493Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#607213}
-
Colin Blundell authored
I just noticed that the variant that issues an access token for all accounts has an overload for passing |id_token|, while the variant that specifies an account has it as an optional argument. Let's use the optional argument approach for both, as we're shortly going to need to add another optional argument for scopes. Bug: 798699 Change-Id: I610cc5bf1ba596b92ccd7d18ad6aa3bcc32ac246 Reviewed-on: https://chromium-review.googlesource.com/c/1329794 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
The test left orphans / widows at their initial value (2), but did assume that we could freely break wherever we wanted. Blink honors orphans and widows requirements inside multicol containers, so set them to 1, to get the behavior that the test expects. Bug: 904263 Change-Id: Ia138da5c65b1c5da450441f38e033320bc983a94 Reviewed-on: https://chromium-review.googlesource.com/c/1331389Reviewed-by:
-
Mohamed Amir Yosef authored
Mobile bookmarks folder always exists in the local model, however it gets created on the server only after signing in with a mobile device. Therefore, when checking persisted metadata for corruption, the mobile bookmarks should be treated as optional and its absence shouldn't signal metadata corruption. Bug: 516866 Change-Id: I8be50719f0978c4fa60091e5943ee2ce80006b16 Reviewed-on: https://chromium-review.googlesource.com/c/1329679 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607210}
-
Tanja Gornak authored
sync_listen_notifications istn't used neither in production code, nor in tests. Hence removing. Bug: 880056, 801985 Change-Id: If518c9dad72b3f718ee649844a6cf3a4703bc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/1307434 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 903823, 892176 Change-Id: I30a2f92478a4b260191deb7faf4aa2a21acc2609 Reviewed-on: https://chromium-review.googlesource.com/c/1329346Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#607208}
-
Mikel Astiz authored
Instead of assuming IsTrackingMetadata() as soon as the model is ready to sync, we now do it when: a) The model is ready to sync. b) Sync is known to be enabled (either because it just got enabled, or because we know from persisted data that is was previously enabled). This makes commit-only types more similar to regular types, and allows bridges to leverage the state. For example, while sync is enabled (i.e. IsTrackingMetadata()), there should always be means to know which account ID is syncing, which is now exposed in ModelTypeChangeProcessor. From the bridge's perspective, the only transition from not tracking metadata, and metadata being tracked (sync enabled), is MergeSyncData(). ModelReadyToSync() now presents the transition from unknown (i.e. unsure whether sync is enabled or not until sync metadata is read from disk) to true/false depending on the persisted value (true if sync was running for the datatype in previous executions of the browser). Just like for regular (non-commit-only) datatypes. Bug: 830535 Change-Id: I573e27c2dcde1bd5835c30319065c178eb7b4679 Reviewed-on: https://chromium-review.googlesource.com/c/1136307Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607207}
-
Javier Ernesto Flores Robles authored
Bug: 878388 Change-Id: I862518efd3209a476f5abcebd763268bbb46cf32 Reviewed-on: https://chromium-review.googlesource.com/c/1329154 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Patrik Höglund authored
This reverts commit af760c91. Reason for revert: Appears to cause flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6367. The crash stack trace mentions SSL. If this CL is innocent, then please just reland. Original change's description: > Add more information to |error| of -didFailFavigationWithSSLError:. > > Add error.localizedDescription and error.userInfo[CWVCertStatusKey]. > > Bug: 898037 > Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29 > Reviewed-on: https://chromium-review.googlesource.com/c/1325578 > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607127} TBR=eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org Change-Id: Ieffa8431079996675b1d53f058e4059fa74b8d09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898037, 904345 Reviewed-on: https://chromium-review.googlesource.com/c/1329972Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#607205}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc4ed36d5b76..662c038f3fdd git log cc4ed36d5b76..662c038f3fdd --date=short --no-merges --format='%ad %ae %s' 2018-11-12 eroman@chromium.org Don't pass the --proxy-server flag when launching the browser for ChromeOS (remote). Created with: gclient setdep -r src/third_party/catapult@662c038f3fdd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:902579,chromium:902418 TBR=sullivan@chromium.org Change-Id: I6f914d7d5118349371d42e1d32e6d2ef9dd84833 Reviewed-on: https://chromium-review.googlesource.com/c/1331186Reviewed-by:
-
Mohamed Amir Yosef authored
FCM messages sent to lazy subscriptions are persisted if Chrome is in the background. This CL records UMA histogram for how many messages are stored at the time a message arrives. This is to estimate how large does the queue grow. Bug: 882887 Change-Id: I1f11e60862b2f356d4103faea45f54901597f27f Reviewed-on: https://chromium-review.googlesource.com/c/1296589 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#607203}
-
Marc Treib authored
TestSyncService already supports a good portion of the setters that are needed here, so this allows us to remove a bunch of boilerplate. Bug: 859874 Change-Id: I10a3e0cac0114d1df70b1ca72bec98f95aad0cb1 Reviewed-on: https://chromium-review.googlesource.com/c/1329795Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#607202}
-
Marc Treib authored
This new class encapsulates all the user-configurable bits of Sync. For now, it is built on top of ProfileSyncService's public API. Further CLs will migrate callers over to the new class, and then remove the public ProfileSyncService API. Bug: 884159 Change-Id: I2c6aa175f46712d408d7b701292390c539399531 Reviewed-on: https://chromium-review.googlesource.com/c/1283689 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Convert HTML*, Document* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I56a9eb7c23f4adaab3b367c76a8a5358d014b2e3 Reviewed-on: https://chromium-review.googlesource.com/c/1331350Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607200}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d6971eb..0c8e54cc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I221a7dcbbefae1e0bbc850077084fb05647e4b51 Reviewed-on: https://chromium-review.googlesource.com/c/1331182Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8a7d7b28b1ed..7cdd680b3802 git log 8a7d7b28b1ed..7cdd680b3802 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 taylori@google.com Merge "trace_to_text: Store thread names" 2018-11-12 lalitm@google.com Merge "trace_processor: add stats table to expose parsed stats data" Created with: gclient setdep -r src/third_party/perfetto@7cdd680b3802 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib69ee02d879cecd866e65aa0699573feaba4b980 Reviewed-on: https://chromium-review.googlesource.com/c/1331217Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716adb3d87b3..768184982153 Created with: gclient setdep -r src-internal@768184982153 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I27d979c39067c7279b5afa04734880280e65b51b Reviewed-on: https://chromium-review.googlesource.com/c/1331216Reviewed-by:
-
Mihai Sardarescu authored
On Windows, Taskbar and Desktop icons are refreshed every time |OnProfileAvatarChanged| notification is fired. This CL only fires the notification |OnProfileAvatarChanged| when the profile avatar image actually changes and avoids firing it otherwise. Bug: 900374 Change-Id: I9c930a3eab9d59aa91c785715336d520dcc813c5 Reviewed-on: https://chromium-review.googlesource.com/c/1323711 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#607196}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f2c3502f7788..cc4ed36d5b76 git log f2c3502f7788..cc4ed36d5b76 --date=short --no-merges --format='%ad %ae %s' 2018-11-12 perezju@chromium.org [pinpoint_cli] Read job config from any config file Created with: gclient setdep -r src/third_party/catapult@cc4ed36d5b76 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: I7e688abd73d5166055b53e62e6c81b510f78b3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1331185Reviewed-by:
-
Andreas Haas authored
After more than half a year of finch trial we can turn WebAssembly trap handler on Linux on by default. R=titzer@chromium.org, hablich@chromium.org, piman@chromium.org Bug: chromium:722585 Change-Id: Id52754dba6d80ce794e350216b9a0c0d93c76ebd Reviewed-on: https://chromium-review.googlesource.com/c/1322872Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#607194}
-
Corentin Wallez authored
The missing dependency would cause the resource_ids to not be regenerated when the predetermined ids file were changed, causing various compilation failures on bots. BUG=904366 TBR=thestig@chromium.org Change-Id: I310af635916e66ad7d35437d7116b2a3f7fae2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1329793Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607193}
-
Gauthier Ambard authored
This CL adds features available to the collection view root panel to the table view root panel in the settings. More specifically it adds support for the top right button. It also adds a helper to remove items from the model to the ChromeTableViewController. Bug: 894791 Change-Id: I1d0f4836f160379a0d8ab71e91f3a0ad13a38e5f Reviewed-on: https://chromium-review.googlesource.com/c/1304437 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#607192}
-
Friedrich Horschig authored
This small refactoring enables the provides to be used for objects instead of arrays which will come in handy for the AccessoryData type that is introduced with https://crrev.com/c/1320732 TBR=rouslan@chromium.org Change-Id: I237813484c1ffcfe0357a30672b893db9c9b2d32 Reviewed-on: https://chromium-review.googlesource.com/c/1326512Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#607191}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1ba4ba601cc4..8a7d7b28b1ed git log 1ba4ba601cc4..8a7d7b28b1ed --date=short --no-merges --format='%ad %ae %s' 2018-11-12 lalitm@google.com Merge "trace_processor: always print out longs in decimal" Created with: gclient setdep -r src/third_party/perfetto@8a7d7b28b1ed The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I74daebad12e03ce0dbe5e4f74a3040705f38f416 Reviewed-on: https://chromium-review.googlesource.com/c/1331184Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f75973390723..716adb3d87b3 Created with: gclient setdep -r src-internal@716adb3d87b3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I41c9e4c57d1a3ac7396c3f1f3605f36d9f1bf3f0 Reviewed-on: https://chromium-review.googlesource.com/c/1331180Reviewed-by:
-
Jérôme Lebel authored
MDCShadowElevations.m has been removed from material_components_ios/src/components/ShadowElevations https://critique.corp.google.com/#review/220518015 TBR: rohitrao Bug: 903150 Change-Id: I07d7150b3b4fa2fca01bcbbb718bc4a9c8081f60 Reviewed-on: https://chromium-review.googlesource.com/c/1329250Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#607188}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I6992d6773ec3f753fe8c225dee223b522593347b Reviewed-on: https://chromium-review.googlesource.com/c/1323449Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#607187}
-
A Olsen authored
crbug.com/433840 says we should split the read and write path for cros settings (or device settings), which will simplify the read path and get rid of its dependency on the write path. Calls to CrosSettings->Set(kSystemTimezone) don't actually affect signed device settings (unlike other cros settings), but end up calling TimezoneSettings->SetTimezone. We can simplify the cros settings interface by calling this directly. This CL replaces the last call to CrosSettings->Set(kSystemTimezone) with an equivalent call to timezone_util, which also delegates to TimezoneSettings. Bug: 433840 Change-Id: Ibaac986323cb286eab83ec7c0b29780dc2ef7d87 Reviewed-on: https://chromium-review.googlesource.com/c/1326144Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607186}
-
Arthur Sonzogni authored
This test a server redirect, for which the new url is redirected by the extension. The bug caused DumpWithoutCrashing to be reached in: * https://chromium-review.googlesource.com/c/1319710 * https://chromium-review.googlesource.com/c/1316734 The bug is fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1326481 Bug: 882661, 880741 Change-Id: I2952dd601fba7fff8b8e110d434413e22e751bba Reviewed-on: https://chromium-review.googlesource.com/c/1328983Reviewed-by:
-
Yutaka Hirano authored
This is preliminary work for reading data pipes in RequestPeer implementations. Bug: 894819 Change-Id: I93ce399fa83796ab6fd095ea7dbf4666fb1458d4 Reviewed-on: https://chromium-review.googlesource.com/c/1312184Reviewed-by:
-
