GitLab

R=danakj
BUG=

Review URL: https://codereview.chromium.org/14195014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194750 0039d316-1c4b-4281-b951-d872f2087c98

To fix layering leakage issue.

BUG=none
TEST=existing tests

Review URL: https://codereview.chromium.org/14237003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194748 0039d316-1c4b-4281-b951-d872f2087c98

Currently we have some layering leakages under webkit/ because
we have several FS modules (e.g. media modules) that
should not be known by WebKit/FileAPI (or content) layer.

Also some module implementors are forced to add extra glue interfaces
just to across layering boundaries from webkit.

This patch changes to:
- Add CanHandleType method to each MountPointProvider
- Make FileSystemContext's ctor take additional MountPointProviders and
  MountPoints, so that FS module implementors can implement their own
  provider outside webkit/ and plug it into FileAPI layer.

This is the 1st cut of a couple of planned changes.

Brief change plan (internal): https://docs.google.com/a/google.com/document/d/1XEtX0OO_RIA_c0KuKvd9yqK5l3XtsTulwXs3c-mAQ1o/view

BUG=175936
TEST=content_unittests:.*File.*
TEST=content_unittests:.*MountPointProvider.*

Review URL: https://codereview.chromium.org/14096022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194747 0039d316-1c4b-4281-b951-d872f2087c98

- Manage all callbacks passed to LoadIfNeeded in the pending queue, not in method argument.
This eliminates the need of |refreshing_| variable, and simplify the logic
when to wait and when to start loading.

- Unify the place where loaded_ is set and OnInitialFeedLoaded() is called.

- Unify directory changestamp checking logic into one place.
Previously we had it twice.

- Get local_changestamp exactly once in every path.
Previously we had it twice in some cases, and zero in
some case (see the BUG).

BUG=231220

Review URL: https://codereview.chromium.org/13933016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194746 0039d316-1c4b-4281-b951-d872f2087c98

Chromium does not use the frame flattening code on any platform, though it used
to use it for frameset flattening on Android, but that is no longer the case.

As there is no intention of ever using it, it should be removed. This change
basically removed the code related to the WebCore setting.

Committed on behalf of Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>.

TBR=darin@chromium.org

BUG=231898

Review URL: https://codereview.chromium.org/14293008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194745 0039d316-1c4b-4281-b951-d872f2087c98

Also enable three passed java tests.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14230010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194743 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/14046039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194742 0039d316-1c4b-4281-b951-d872f2087c98

This fixes "Hisilicon" GPUs, which is an instance of a
Vivante's GPU design. This involves enabling virtual
contexts, since they don't support share-groups, and further
adds a work-around for switching surfaces. Without the work-
around the view surface "inherits" the size of the last
bound surface (which for Chrome tends to be a 1x1 pbuffer)
resulting in a black screen. The following steps "repair"
the view surface every time it is made current:

    - Make it current.
    - Bind the default frame-buffer.
    - Make it not current.
    - Destroy/recreate it from the native handle.
    - Make it current again.

NOTE: The "Recreate" function is added to surface because
the Destroy/Initialize may be intercepted or modified by
wrapper surface classes. Recreate is similar to resize,
which after being forwarded by a wrapper can call
Destroy/Initialize on the 'real' surface.

BUG=179250, 229643
NOTRY=true

No try, since it's Android only and already tested.

Review URL: https://chromiumcodereview.appspot.com/13140006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/13926019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194736 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the target element (the file list) was hard coded.
Instead, we should be able to specify the target element.

BUG=none
TEST=none; just a test util change. the existing tests should pass as before

Review URL: https://codereview.chromium.org/13891013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194735 0039d316-1c4b-4281-b951-d872f2087c98

DriveSystemService exposes only the JobListInterface of DriveScheduler.

BUG=128079

Review URL: https://codereview.chromium.org/14118006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194734 0039d316-1c4b-4281-b951-d872f2087c98

remaining interactive autofill work.

R=estade@chromium.org
BUG=none
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13870019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194733 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232997
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/14199005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194732 0039d316-1c4b-4281-b951-d872f2087c98

and update the mouseover help.

BUG=116601

Review URL: https://codereview.chromium.org/13725016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194731 0039d316-1c4b-4281-b951-d872f2087c98

The test verifies that the autocomplete list is shown properly.

BUG=179976
TEST=none

Review URL: https://codereview.chromium.org/14312009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194730 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/14111003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232851

Review URL: https://codereview.chromium.org/14225020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232950
TEST=see bug

Review URL: https://codereview.chromium.org/14093019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194725 0039d316-1c4b-4281-b951-d872f2087c98

OSNAME was being used before it was set.

BUG=None
TEST=trybots

Review URL: https://codereview.chromium.org/14235010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222657
R=dtu@chromium.org

Review URL: https://codereview.chromium.org/12742009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194723 0039d316-1c4b-4281-b951-d872f2087c98

Removes force-posting and DoXXX() methods since they're unnecessary.

Also removes stream_type_ member variable since it can be easily retrieved from demuxer_stream_->type().

Review URL: https://codereview.chromium.org/14232017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232924
TBR=mnissler@chromium

Review URL: https://codereview.chromium.org/14225019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194720 0039d316-1c4b-4281-b951-d872f2087c98

Delete webkit directory on initial sync as well, as the previous bisection may have left the depot with an old copy of Webkit lying around.

BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/14265008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194718 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232877

Review URL: https://codereview.chromium.org/14205019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194715 0039d316-1c4b-4281-b951-d872f2087c98

Currently we animate icon status every time the user opens a new
window.

This CL changes the low severity update status to only animate for the
first window.

BUG=180107
TEST=Ran Chrome with --simulate-upgrade. Verified that the low
severity status was not animated when a new window was opened.

Review URL: https://codereview.chromium.org/14245003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232625

Review URL: https://codereview.chromium.org/14161020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194713 0039d316-1c4b-4281-b951-d872f2087c98

Merge AssociateStreamWithProducer message into CreateStream message for both audio output and input.

Also:

1. Removed RendererAudioOutputDevice class, since it's no longer necessary to manage asynchronously associating a render view with a stream.

2. Clean-ups: Applied several changes/bug fixes to bring the audio input classes/impls up-to-date w.r.t. the audio output classes/impls.  Filed bug 179597 for follow-up.

3. Added missing plumbing for associating audio input devices created by WebRtcAudioCapturer to render views.

4. Updated unit tests.

BUG=166779
TEST=media_unittests, content_unittests, TSAN, chrome/test/functional/webrtc_*.py, and manual testing described in http://codereview.chromium.org/11359196/

Review URL: https://codereview.chromium.org/12383016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194711 0039d316-1c4b-4281-b951-d872f2087c98

auto_login_info_bar_delegate.* -> auto_login_infobar_delegate.*, for consistency with rest of codebase.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/14312005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222681
For browser_process_impl.cc:
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/14017013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194708 0039d316-1c4b-4281-b951-d872f2087c98

This unifies the creation of GTK widgets and makes it happen in response to the infobar being shown. Currently, this generally happens at construction. Once the new ownership model lands, infobars will not yet be owned at construction time, and since widget creation includes getting a theme service from the owner, that needs to move out of the construction phase.

Incidentally, this also makes the GTK native object creation happen at the same time as the views native object creation, not that that matters much.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/14327008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194707 0039d316-1c4b-4281-b951-d872f2087c98

R=ilevy@chromium.org
BUG=
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/14330011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194706 0039d316-1c4b-4281-b951-d872f2087c98

Things like swap are concepts of an OutputSurface, not a context. Moving the
callbacks to OutputSurface will also reduce cc's knowledge of the context
guts and let us swap out the GL interface.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194394

Review URL: https://codereview.chromium.org/12545018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224974

Review URL: https://codereview.chromium.org/14198004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194699 0039d316-1c4b-4281-b951-d872f2087c98

Because open/close will change the notification status (read/shown),
it should send Updated to the observers.

BUG=232030
TEST=manually (see repro steps in the bug)
R=dewittj@chromium.org

Review URL: https://codereview.chromium.org/14299007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226680

Review URL: https://codereview.chromium.org/13483011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194697 0039d316-1c4b-4281-b951-d872f2087c98

This should be = now.

TBR=nduca@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14161019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194696 0039d316-1c4b-4281-b951-d872f2087c98

TBR=stevenjb@chromium.org
BUG=232924

Review URL: https://codereview.chromium.org/14093018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194695 0039d316-1c4b-4281-b951-d872f2087c98

In immersive fullscreen the "top container" holding the tabstrip and toolbar can slide down over the web content. Instant extended shows suggestions in an overlay web view, this must be adjusted to match the omnibox position when the top container is revealed. Instant extended also shows a suggestion+result page in the active web view, which must also be adjusted to align with the omnibox.

BUG=169414
TEST=Added to interactive_ui_tests BrowserViewTest and also manual.
On Chrome OS, enable the flags for instant extended and immersive fullscreen. Open a normal tab and one to the NTP. Test omnibox suggestions in both tabs, ensure they align with the omnibox. Hit F4 to go into fullscreen, do the same tests. Select "Show Bookmark Bar" and repeat both sets of tests.
TBR=sreeram@chromium.org for instant_extended.html changes

Review URL: https://codereview.chromium.org/13684002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194694 0039d316-1c4b-4281-b951-d872f2087c98

string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14272007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/14178005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194692 0039d316-1c4b-4281-b951-d872f2087c98