- 05 Nov, 2019 40 commits
-
-
Carlos IL authored
This fixes a bug that caused commands to be non-functional on a subresource triggered SB committed interstitial if a different type of interstitial had been shown on the same webcontents previously. The bug was triggered depending on the order different WebContentsObservers were installed (which determines the order DidFinishNavigation is called in them). This CL changes the observer that needs to fire first so it uses ReadyToCommitNavigationInstead. Bug: 1021334 Change-Id: I3e6683279523dc6b74a2266fdd2bf05e0ab4d132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896346 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#712796}
-
Ken Rockot authored
Removes dead code inside Data Decoder that was there to support its use through Service Manager clients which no longer exist. Bug: 977637 Change-Id: I379787ff50cf2d12bc364f17ed1d6a42d2c1b836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892671 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#712795}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/6be491b7bb57c3950d4fbb97fdd4a141e3fa4d63..d709b0d8926707f3143d8cf7c84350e49e56ec38 Bug: none Change-Id: I5f3eb59927053d83d5fef89a4821529cc7198f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900212 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#712794}
-
Toni Barzic authored
This effectively enables the feature by default. BUG=1005366 Change-Id: Id0144ca37888516a530a34cdc65d05d3a796078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894415Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#712793}
-
Shimi Zhang authored
No logic change, add @VerifiesOnP and make the version check at call site of SmartSelectionMetricsLogger.create(), hopefully it will not try to load SmartSelectionMetricsLogger class on below P, so it will avoid class verification failure on below P. Bug: 1021642 Test: Current tests should pass. Change-Id: I4df098ef8e074b93629aeba12608efbfc636c850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900290Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#712792}
-
Ken Rockot authored
This removes the last vestiges of Service Manager dependency from Data Decoder and its clients. Everything is ported to use the new DataDecoder client API. Bug: 977637 Change-Id: I36b011a5f5935195d5ad7352c9aca87ef14007de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892558Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Peter Boström authored
Adds pbos@ and tbergquist@ as placeholder owners for TabContextMenu_ entries in tools/metrics/actions/actions.xml. Bug: None Change-Id: I0d36329aab5ffe00f0df908b3c8d58e144cc8380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898469 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#712790}
-
Mike Wittman authored
Moves the metadata processing for upload into a separate class as it's somewhat complex but self-contained and has a narrow interface. This also allows the behavior to be tested more directly, simplifying the tests. Bug: 976864 Change-Id: Icd608d1665337fa7e8e5168d1e87e529acbd84cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897359 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712789}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e600381cfd17..f168baf4df53 Created with: gclient setdep -r src-internal@f168baf4df53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:922813,chromium:None,chromium:None,chromium:None,chromium:984162,chromium:1004848,chromium:None,chromium:None,chromium:None Change-Id: I666b6a7e013138497d61b91f4d36181b1a305b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712788}
-
Joshua Pawlicki authored
TBR=bsheedy@chromium.org Bug: 1014754 Change-Id: I4692c3e3a306b0576ac91291624b72be141fff68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900193Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712787}
-
Kehuang Li authored
We got crashes when accessing AudioInputCallback around the time we Stop/Close CastAudioInputStream. The audio_io.h is ambigeous on if the impl of Stop should be sync or async, but mostly it should be sync as AudioOutputStream::Stop. CaptureServiceReceiver::Stop is posted to another thread, and complete async, which explain the crashes we met. Therefore, add an internal stop function and let the public Stop wait for the internal stop completes. Bug: internal: 143908196 Test: On device and unittests. Change-Id: I9f6cfbd6457873094ce8c11ec6399b73012526dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898720Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#712786}
-
Xiaoqian Dai authored
When the window drag starts or slows down, fade in overview windows. Bug: 997885 Change-Id: Ica9e256df32babeb6dab3d7d027447217a577c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900127 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a13b461e6e0..1803f4ef6fe7 git log 7a13b461e6e0..1803f4ef6fe7 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 bungeman@google.com Revert "Fix empty run handling in trivial shaper iterators" 2019-11-05 robertphillips@google.com Revert "Reland "Implement sample mask and sample locations support in Vulkan"" 2019-11-05 robertphillips@google.com Revert "Add a "conservative raster" flag to GrPipeline and implement in Vulkan" 2019-11-05 bungeman@google.com Fix empty run handling in trivial shaper iterators 2019-11-05 fmalita@chromium.org [skottie] Streamlined gradient stop merger 2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-05 mtklein@google.com implement SkColorFilterShader::isOpaque() 2019-11-05 csmartdalton@google.com Add a "conservative raster" flag to GrPipeline and implement in Vulkan 2019-11-05 egdaniel@google.com Add new macro for checking device lost when making Vulkan calls. 2019-11-05 borenet@google.com [recipes] CanvasKit, PathKit, some others don't need bot_update 2019-11-05 ethannicholas@google.com Reland "Implement sample mask and sample locations support in Vulkan" 2019-11-05 mtklein@google.com unify program() and uniforms() 2019-11-05 brianosman@google.com Reland "Fully embrace skcms types in SkColorSpace API" 2019-11-05 bsalomon@google.com Cleanup kGray_8 readback. 2019-11-05 fmalita@chromium.org [skottie] Fix trim path mode interpretation 2019-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6c7208f93d6e..67527cb45293 (10 commits) 2019-11-05 fmalita@chromium.org [skottie] Use SkColor4f for gradient color stops 2019-11-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-05 benjaminwagner@google.com Fail Skpbench on unsupported hardware 2019-11-05 herb@google.com Speed up diff canvas using small bit vector 2019-11-05 mtklein@google.com add color filter support Created with: gclient setdep -r src/third_party/skia@1803f4ef6fe7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: chromium:None Change-Id: Ic218823881780ad07ce18c4aae79b9c15a20c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900120Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712784}
-
Eric Stevenson authored
Necessary for converting test JNI in content to use proxy natives. Bug: 997199, 890452 Change-Id: Id08769bcc349204e35dc1324dda659905f0c3311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888379Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712783}
-
Matt Jones authored
Bug: 1021318 Change-Id: I98b7163f149a82f737f04ede5fd2817c6bb3108d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900091Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712782}
-
David Benjamin authored
Change-Id: I464eecb3ca7ef5417b89378588593d05c452592a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899897 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
This CL migrates the GestureManager mojo client in Blink to the new BrowserInterfaceBroker, and adapts the code in the browser process to register the binder from PopulateChromeFrameBinders(), instead of doing it right inside UnhandledTapWebContentsObserver. UnhandledTapNotifierImpl. Additionally it also adapts ShowUnhandledTapTest helper class so that it properly set the mock overrides for BrowserInterfaceBroker, as it was done before for InterfaceProvider. Bug: 936482,1006361 Change-Id: I9f369e41cb8441043646b34fd67e1902f7010383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887615 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#712780}
-
Ryan Hansberry authored
This will help to more easily identify why users cannot find their Tether hosts when they provide feedback reports. Change-Id: Iff6d51f7e27eef36ed0312ba5c6ef61979ee8634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900246 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#712779}
-
Joshua Pawlicki authored
" This reverts commit 55549387. Reason for revert: breaks gfx_unittests on (none) GPU on Mac FallbackFontCommonScript/RenderTextTestWithFallbackFontCase.FallbackFont/common21 Expected equality of these values: missing_glyphs Which is: 1 0 Original change's description: > Fix RenderText itemization for complex emoji > > > > This CL is a refactoring on the way RenderText do > > ItemizeTextToRuns for the corner cases where a run > > should be split in grapheme clusters. > > > > The previous code was naming these cases: > > * Unusual characters > > * Special characters > > * Non-regular characters > > But they should be more specific on the purpose of splitting the runs. > > > > Also, the algorithm used for splitting a sequence of codepoint > > was based on the code block of the corresponding codepoints > > and few cases where trying to merge adjacent codepoint in > > a grapheme. The algorithm was incorrect multiple cases (e.g. emoji). > > > > Unicode provide a way to split a sequence of codepoints into > > grapheme and grapheme clusters. > > They provide a state machine which is using the codepoint proporties > > to decide if the current location is a grapheme boundaries. > > > > The ICU library is providing an API over the character properties > > to help iterating over graphemes. > > * ubrk_open > > * ubrk_first > > * ubrk_next > > * ubrk_close > > > > The class base::i18n::BreakIterator(..., BREAK_CHARACTER) is > > providing an easy to use wrapper over that API. > > > > > > The current CL is replacing the previous characters based splitting > > algorithm by the graphemes based version. > > > > > > > > See emoji sequence: > > http://www.unicode.org/reports/tr51/ > > 1.4.5 Emoji Sequences > > > > The full emoji list: > > * http://unicode.org/emoji/charts/full-emoji-list.html > > Emoji data, used to make our unittests: > > * http://www.unicode.org/Public/emoji/12.0/emoji-data.txt > > > > > see: UNICODE TEXT SEGMENTATION (http://unicode.org/reports/tr29/) > > see: https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubrk.h > > see: https://cs.chromium.org/chromium/src/base/i18n/break_iterator.h > > Change-Id: I6b9a9c79021f2ce0e2db7cdefdd0838b5911f445 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788804 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712704} TBR=robliao@chromium.org,asvitkine@chromium.org,etienneb@chromium.org Change-Id: I6ea8c752e40ed07522d0d336ada289934c899477 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900433Reviewed-by:
-
Peng Huang authored
Bug: 1016258 Change-Id: I2e5327139ef2a381068f11d0caaaca741da48a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895376Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712777}
-
Matt Menke authored
Now the tests always act like IPv6 support was detected locally, by injecting a bogus cached DNS probe result and mocking out time to prevent it from expiring. Previously, the tests would either do only IPv4 lookups, or IPv6 and IPv4 lookups based on the results of an IPv6 support probe on the local machine. While this didn't have a huge effect on the tests since none test IPv6 support, it did affect one of them which directly depended, and it's generally much better to have tests not behaving differently based on the environment they're running in. Bug: None Change-Id: Ic3f275f059a1cd174fadc9e49c0c43e26ee63252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899558Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712776}
-
Tibor Goldschwendt authored
Previously, the bundle allotment step didn't account for libraries packaged into the Trichrome library and, thus, duplicated many libraries of the Trichrome library into the Trichrome Chrome bundle. This CL fixes this by teaching the library allotment step about the Trichrome dependency tree so that it can allot the libraries accordingly. In fact, with this CL, the library allotment step can now handle any arbitrary dependency tree. The Trichrome dependency tree looks as follows: lib | base / | \ dev_ui vr etc. Note that webview is not yet part of the computation. See crbug.com/1021565 for more details. Bug: 1020717, 1021565 Change-Id: I651bcfd1bd15e36b4028b3f535112d3233be2dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898132 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712775}
-
Kurt Catti-Schmidt authored
This is a reland of 5e7f2837 This was reverted due to flaky tests. I was not able to reproduce the failures, but I was able to see via the logs that the failed cases were opening the first popup instead of the third. As a mitigation, I have switched the logic to find the third popup. Previously, I had added a count parameter to FindNode, so it would find the third node with that name. This change adds a name to the parent node (in this case the <input> node), and updated the logic to search for that node as a parent. Original change's description: > Fix UIA Fragment Root Navigation in Inspect > > We discovered that the fragment root change that was recently submitted > here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822 > regressed fragment root navigation in Inspect. This was not the case > when Kevin had first submitted it. I traced it down to the changes that > I made for Controller-For elements, so this change undoes those > modifications. > > In order to stabilize the content_browsertest that prompted the changes > (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it > was discovered that there were several issues in how we were > handling date-time popups. > > The first issue is that we were failing to return the proper parent > window for the fragment root. In > RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were > returning nullptr as the parent of datetime popups, which was > parenting the popup under the root desktop window in Inspect. This > change now returns the host's window, which places the popup under > the correct parent window in Inspect. > > The second issue is that there was a cardinality problem with datetime > popup windows. Since they share a BrowserAccessibilityManager with > the main window (but are under a different fragment root), > LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would > always return the main window's root kRootWebArea instead of the > popup window's kRootWebArea. So we'd have two different fragment roots > that map to the same gfx::NativeViewAccessible. This would cause > GetFragmentRootParentOf to return the incorrect parent most of the > time. This change fixes that issue by adding an extra step for popup > windows that traverses the root node and searches for the popup web > root via OneShotAccessibilityTreeSearch. > > Bug: 1019016 > Change-Id: I678425c8417334275727053243a39b1039e6f135 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102 > Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711358} TBR=sky@chromium.org Bug: 1019016 Change-Id: I73dc98eeb049788b3a7a086f5e6ac2927e2b0473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894761 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712774}
-
Robert Sesek authored
This requires making the TemplateURLParser be asynchronous rather than directly returning the result. That has a ripple effect of changing the lifetimes of some of the parameters to Parse(), such as the SearchTermsData. The Firefox importer also uses the TemplateURLParser (although it may be entirely broken, per https://crbug.com/868768). The importer assumes that all operations are synchronous, so this adds an internal helper class to manage the now-asynchronous state for TemplateURL parsing. Bug: 699342 Change-Id: I311d9e29dbbca34a4f5696b251a0fbaaadcc506b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879973 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#712773}
-
Alexis Savery authored
Add UMA histogram "Platform.SATA.PercentageUsed" for Chrome OS. This tracks the percentage used endurance indicator for SATA devices. Add UMA histogram "Platform.SATA.AvailableReservedSpace" for Chrome OS. This tracks Available Reserved Space on SATA devices. Add UMA histogram "Platform.SATA.TotalLBAsWritten" for Chrome OS. This tracks Total LBAs Written on SATA devices. Add UMA histogram "Platform.SATA.TotalLBAsRead" for Chrome OS. This tracks Total LBAs Read on SATA devices. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1881542 Bug: chromium:186116 Test: ran validate_format.py Change-Id: I61e5de000d4fdcbc7014adce4642c3bad40aefda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881749 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by: -
Xiyuan Xia authored
- Update trace file key to 'trace/1.json'. Per spec, key name should start with 'trace/' and extension should be '.json' since gtest output trace json. - Update script test data as well; Bug: 945711 Change-Id: I9fc36b154e68bae869f5221e243854847aaaf307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899309 Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#712771}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c7c30cb6. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 40c01af7 "[Chromedriver] Fix PerformAction to support multi touch points cases" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6dfe163a57288084c8b97d3f89c712fcc29a34ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899793Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712770}
-
Collin Baker authored
Change-Id: I9096e540245b7d6fcdcf225d4ea3017ce1e151b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900426 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#712769}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bce667b745aa..09a9385121be git log bce667b745aa..09a9385121be --date=short --no-merges --format='%ad %ae %s' 2019-11-05 perezju@chromium.org Revert "[Telemetry] Do not percent encode story names" Created with: gclient setdep -r src/third_party/catapult@09a9385121be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:981349 Change-Id: I180bb5f63ac360c91bd15927d831d70518181e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900117Reviewed-by:
-
Jack Lynch authored
This CL disables tests that will be broken by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1889351 Bug: 963183 Change-Id: I4f660dfad9a8e4e44d5200f61642174fba875bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894014 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712767}
-
Dale Curtis authored
A recent try where we incorrectly set negative delay in FakeAudioOutputStream revealed this. It's certainly possible that this is happening in production with OS provided streams under odd conditions, so clamp to zero in these cases. R=tguilbert Change-Id: I032bb721f339cdbe34ed513d3c40223aca66fb5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899560 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#712766}
-
Jinsuk Kim authored
The reported exception comes from HistoryNavigationDelgateFactory trying to get BottomSheetController when the activity is already destroyed. This CL puts a guard against the access to the activity in a wrong state. Bug: 990987 Change-Id: I86e9ea0611dafd301eefcb07a3a6b1ade5792a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898161Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712765}
-
meacer authored
A whole-script confusable Cyrillic domain consists of entirely Cyrillic characters that look identical to Latin characters (e.g. xn--80ak6aa92e[.]com decodes to аррӏе[.]com where аррӏе is in fact '\x0430\x0440\x0440\x04cf\x0435'). A previous change allowed whole-script confusable Cyrillic characters on non-ASCII top level domains only. This means that xn--80ak6aa92e[.]com remains punycode (TLD is .com) but xn--80ak6aa92e[.]xn--p1ai is decoded as аррӏе[.]рф (TLD is Cyrillic). However, this also allows spoofs in other non-ASCII TLDs such as аррӏе[.]中国 so it's not a sufficient measure. This change further limits allowable whole-script confusable Cyrillic domains to Cyrillic TLDs (instead of non-ASCII) and a small list of additional TLDs containing a large number of Cyrillic domains (bg, by, kz, pyc, ru, su, ua, uz). The idea is that users familiar with Cyrillic are more likely to encounter these TLDs and notice any discrepancies in the displayed domain name. Bug: 968505 Change-Id: Ib7462c9776f3640a5f60e5c79ac1a0c5d7b2028c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881887 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#712764}
-
Mitsuru Oshima authored
* Take rotation into account * Fix when display zoom is applised. The overscan is dp but w/o display zoom. To convert to DP in UI coordinates, it first have to be converted to pixel then divided by the scale factor. Bug: 1021292 Test: unittests + manual Change-Id: I82785b74013c82e9eb20a7714510e62a421337db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896374Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#712763}
-
Mason Freed authored
The Web Components V0 APIs were deprecated in August, 2018, in [1], and are being removed in M80. For those enterprises that need additional time, this new policy will enable the features to be re-enabled through M84. After M84, the policy will be removed, and the features will be disabled. For overall context on this removal, including motivation and ways to test/upgrade, see [2]. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade Bug: 911943 Change-Id: Iddf4c8294f19831705bf145b6840400adcd4baed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888598Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#712762}
-
Tommy Steimel authored
This CL pulls most of the logic out of MediaToolbarButtonController and puts it into MediaNotificationService which lives as a profile-keyed service. This allows the media session tracking to be shared between windows, and makes the MediaToolbarButtonController make more sense. Bug: 1021369 Change-Id: I03f302cb8b80099df011fa04e47df389c2d5d8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898278Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712761}
-
Devlin Cronin authored
Make CreateExtension use the semantic ExtensionBuilder to cut down on boilerplate. Bug: None Change-Id: I19fc5c74efc7f67145e9f14b445bdeb66ca933c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896390Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712760}
-
Michael Spang authored
Move the pixel to DIP conversion into root_window_bounds_transform. Also rename CreateInsetsAndScaleTransform to CreateInsetsTransform because UI scale in the transform is no longer supported. Moving the DIP conversion avoids flooring the bounds twice (during DIP conversion, and after rotation & insets). Bug: 1019015 Change-Id: Ia065b1f8f6892a193e7f545475e7c7ddbcd76f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899835Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712759}
-
Manas Verma authored
The attestation conveyance preference will be set by Payments Server, and will fallback to 'none' if field was empty. Bug: 949269 Change-Id: Ib531f6380882f495bbb098d37127d6a92b4b7ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895329Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#712758}
-
Sammie Quon authored
Test: manual, added test Change-Id: Id7b6cf15b0efcbfcf714f63146c99695956d4e0a Fixed: 1020343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898748Reviewed-by:
Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
