GitLab

Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner.

BUG=459115

Review URL: https://codereview.chromium.org/937503003

Cr-Commit-Position: refs/heads/master@{#317178}

NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes.

NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes.

DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change.

R=robertshield@chromium.org,rvargas@chromium.org
BUG=458690

Review URL: https://codereview.chromium.org/921353002

Cr-Commit-Position: refs/heads/master@{#317177}

BUG=460285
TBR=reveman@chromium.org,avi@chromium.org

Review URL: https://codereview.chromium.org/944653002

Cr-Commit-Position: refs/heads/master@{#317176}

Rationale: ocassionally I find it useful to look at json_output to debug.
Indenting the file make it a lot more readable. The downside is this increases
the file size, but it shouldn't matter for small files like these.

An example Results.json with ~2000 values tested on local machine:
Without indent: 472K
With indentation: 692K

Review URL: https://codereview.chromium.org/940123003

Cr-Commit-Position: refs/heads/master@{#317175}

BUG=454031

Review URL: https://codereview.chromium.org/917053002

Cr-Commit-Position: refs/heads/master@{#317174}

BUG=459132

Review URL: https://codereview.chromium.org/932023003

Cr-Commit-Position: refs/heads/master@{#317173}

BUG=

Review URL: https://codereview.chromium.org/937013002

Cr-Commit-Position: refs/heads/master@{#317172}

This makes video stop relying on the TextureUploader class. I've ported
the stride-handling code from TextureUploader to the
VideoResourceUpdater class, since it is the only place that will make
use for it for now.

R=enne
BUG=454575

Review URL: https://codereview.chromium.org/935383004

Cr-Commit-Position: refs/heads/master@{#317171}

TBR=jam@chromium.org
BUG=454655

Review URL: https://codereview.chromium.org/943763003

Cr-Commit-Position: refs/heads/master@{#317170}

padding-left and padding-right should be subtracted from clientWidth to measure
the available width for grid items.

BUG=453764
TEST=adjust window width of Files.app and check that the problem doesn't occur.

Review URL: https://codereview.chromium.org/916353002

Cr-Commit-Position: refs/heads/master@{#317169}

BUG=451020
R=mnaganov@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/935753003

Cr-Commit-Position: refs/heads/master@{#317168}

In the context of a dialog, inputs are preferred over spinners, because it's bad to show popups on top of popups.

BUG=437116

Review URL: https://codereview.chromium.org/936293002

Cr-Commit-Position: refs/heads/master@{#317167}

BUG=458300

Review URL: https://codereview.chromium.org/933113002

Cr-Commit-Position: refs/heads/master@{#317166}

Review URL: https://codereview.chromium.org/936333003

Cr-Commit-Position: refs/heads/master@{#317165}

The previous fix only made the offset calculation more stable, but
it still seems to race with when the device can go idle. I think
this is due to the trace command not being flushed. Since beginning
a trace is an asynchronous command, it is possible that the GPU can
still go idle after the we synchronize the timer because that is a
synchronous command. In order to guarantee that we are calculating
the offset after the asynchronous command has already begun, I have
made it so the offset is calculated before we issue the asynchronous
end trace call instead.

Technically this is still not completely fool proof because we can
have a case where we issue a trace begin and trace end immediately
and calculate the offset time before both commands are flushed, but
assuming we are actually tracing some GPU command that takes GPU time,
this should not happen very often.

BUG=None
TEST=local, trace a page for a minute.

Review URL: https://codereview.chromium.org/929543002

Cr-Commit-Position: refs/heads/master@{#317164}

and GetWifiPHYLayerProtocol

BUG=422516
R=rch@chromium.org, vadimt@chromium.org

Review URL: https://codereview.chromium.org/940133002

Cr-Commit-Position: refs/heads/master@{#317163}

This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.

Minor updates to Win64 build, including some fixes for size_t to int conversions.

Review URL: https://codereview.chromium.org/929793006

Cr-Commit-Position: refs/heads/master@{#317162}

Remove the old SSL version gathering logic in ConnectionType. Those metrics
are very difficult to read because the denominator is wrong.

In the meantime, claim the ConnectionType metrics since they're unowned.
They'll be deprecated once this new one has gathered numbers and the
SPDY use case for them has also been accounted for.

BUG=459710

Review URL: https://codereview.chromium.org/941743002

Cr-Commit-Position: refs/heads/master@{#317161}

R=dpranke
TBR=armansito@chromium.org (bluetooth)

Review URL: https://codereview.chromium.org/940613002

Cr-Commit-Position: refs/heads/master@{#317160}

This adds additional matching and output capabilities to the various GN introspection commands (desc, ls, refs). It adds --as for controlling output, and --testonly and --type for controlling which ones to show.

It adds support for matching multiple input arguments for the refs, ls, and check commands.

It adds support for finding which targets reference a config in the refs command.

Review URL: https://codereview.chromium.org/937003002

Cr-Commit-Position: refs/heads/master@{#317159}

* Adds support for tracking which domains trigger app banners.
  These metrics are split between native apps and web apps
  since developers are likely to prefer one over the other.

* Changes rappor.xml to have information about the new metrics.

BUG=458548

Review URL: https://codereview.chromium.org/939263002

Cr-Commit-Position: refs/heads/master@{#317158}

TBR=morrita@chromium.org
BUG=460243

Review URL: https://codereview.chromium.org/941063002

Cr-Commit-Position: refs/heads/master@{#317157}

BUG=
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/938163003

Cr-Commit-Position: refs/heads/master@{#317156}

WebRTC 8421:8439
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/bec05b6..00316a4

Libjingle 8417:8437
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/e8e2384..92478da

TBR=niklase@chromium.org

Review URL: https://codereview.chromium.org/945493002

Cr-Commit-Position: refs/heads/master@{#317155}

BUG=451286

Review URL: https://codereview.chromium.org/938143002

Cr-Commit-Position: refs/heads/master@{#317154}

Partner bookmarks deletion don't support undo, so the undo controller
should know if it's undoable.

BUG=460122, 460186

Review URL: https://codereview.chromium.org/943553004

Cr-Commit-Position: refs/heads/master@{#317153}

BUG=437116

Review URL: https://codereview.chromium.org/938003005

Cr-Commit-Position: refs/heads/master@{#317152}

Chrome Sync expects the various SyncableServices to properly distinguish
between ACTION_ADD and ACTION_UPDATE. As such, it is an error to send
an ACTION_ADD change for an item that already exists.

Avoid causing errors in Chrome Sync, by tracking which items are already
known to sync, and not submitting new ACTION_ADD changes for them. Support
for actually updating an existing item will be provided in a later CL.

BUG=chromium:431435
BUG=chromium:431438
TEST=components_unittests  --gtest_filter="Wifi*"

Review URL: https://codereview.chromium.org/860103002

Cr-Commit-Position: refs/heads/master@{#317151}

Cherry pick ios/neon bugfix:
https://codereview.chromium.org/940993005

Add codereview.settings:
https://codereview.chromium.org/905603002

Disable LTO for AVX2:
https://codereview.chromium.org/891933003

Roll/unroll (no-op - bad roll)
https://codereview.chromium.org/897063002
https://codereview.chromium.org/898943004

BUG=webrtc:4190
R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/942533004

Cr-Commit-Position: refs/heads/master@{#317150}

Tighten up the requirements for False Start. At this point, neither
AES-CBC or RC4 are something that we want to use unless we're sure that
the server wants to speak them.

This also rolls BoringSSL in DEPS to pull in the corresponding
tightening on the BoringSSL side. Full summary of changes available at:

https://boringssl.googlesource.com/boringssl/+log/d306f16..b180ee9

(Original CL: https://codereview.chromium.org/662543005/)

BUG=427721

Review URL: https://codereview.chromium.org/939483006

Cr-Commit-Position: refs/heads/master@{#317149}

The parent window's visibility change should not change its transient child's window modality property.

BUG=447743

Review URL: https://codereview.chromium.org/944483002

Cr-Commit-Position: refs/heads/master@{#317148}

Also makes jpeg color space enum naming more correct.

BUG=333619

Review URL: https://codereview.chromium.org/819713005

Cr-Commit-Position: refs/heads/master@{#317147}

This will attempt to convert unspecified ports (-1) to the default
at least, before checking. The check has gotten stricter and
now only allows ports between 0 and N, etc.

BUG=458443
TEST=manual for now (NaCl SDK websocket example) -- need to figure out how to get non-ephemeral test port

Review URL: https://codereview.chromium.org/938103002

Cr-Commit-Position: refs/heads/master@{#317146}

prereq for https://codereview.chromium.org/916103008

BUG=

Review URL: https://codereview.chromium.org/937233002

Cr-Commit-Position: refs/heads/master@{#317145}

On L+ devices, button text should use Roboto Medium
("sans-serif-medium"). On earlier devices, the button text should be
bold.

BUG=459794

Review URL: https://codereview.chromium.org/945483002

Cr-Commit-Position: refs/heads/master@{#317144}

BUG=none

Review URL: https://codereview.chromium.org/938623004

Cr-Commit-Position: refs/heads/master@{#317143}

BUG=342426

Review URL: https://codereview.chromium.org/931363003

Cr-Commit-Position: refs/heads/master@{#317142}

BUG=442826
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/922353003

Cr-Commit-Position: refs/heads/master@{#317141}

BUG=455898

Review URL: https://codereview.chromium.org/932313002

Cr-Commit-Position: refs/heads/master@{#317140}

This is derived from crrev.com/867003002.
RenderText::background_is_transparent() field does not directly
mean the background color is transparent. This is a flag to
control the subpixel rendering (see canvas_skia.cc) and can
be set for various reasons.

Considering this situation, it is clearer to rename the field
to subpixel_rendering_enabled().

R=msw@chromium.org
TEST=no functional changes, build succeeds
BUG=None

Review URL: https://codereview.chromium.org/941523002

Cr-Commit-Position: refs/heads/master@{#317139}