- 05 Oct, 2020 40 commits
-
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010050700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/F5O08dsIWdHTa7NozxSJmHAyJsTLlm6Zxo9jTQjw1qEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I5d2ec3cd4b0c58c9f3e71c1807f4ffee6bfc00a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450112Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813789}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/750261f41af6..00a8b5bb4fcb 2020-10-05 brianosman@google.com Revert "Revert "Convert sksl_frag.sksl to an IRIntrinsicMap"" 2020-10-05 johnstiles@google.com Create TinyUnorderedMap class for small-N data storage. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I5d7d6f8d134fd6d300c08dcc2fd9140736dc1a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813788}
-
Vasiliy Telezhnikov authored
This CL fixes color type that we pass to the skia for the FBO0. It changes two things: * Use RGB565 if the surface uses 16 bit format . * Fallback to RGBA is skia doesn't support rgb color type. Bug: 1126490 Change-Id: I6f5342ac7bb128134afc2c5182a6c6b99600c7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441311 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0afca615a816..256b2c258767 2020-10-05 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageDecorationManager.js with TypeScript 2020-10-05 bmeurer@chromium.org [ts] Type-check wasmparser_worker/WasmParserWorker.js with TypeScript 2020-10-05 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageListView.js with TypeScript 2020-10-05 sigurds@chromium.org [ts] Type-check front_end/coverage/CoverageView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idd03c1c0b2612666fca703754724dd9426064eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450118Reviewed-by:
-
Christian Dullweber authored
Set android:includeFontPadding="false" to better align favicon with URL. Use padding instead of margin to get the right background color. Show details link if there is a connection message. Show red warning triangle if there is a connection security issue. Also includes some general cleanup for margins. Bug: 1135124 Change-Id: Iff1f880b51a2a8bd60ef0606afec03fea82e9318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449372Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#813785}
-
Mike Wittman authored
This reverts commit 44f6ea57. Reason for revert: crashes in stack_unwinder::Module::Load() Original change's description: > [Sampling profiler] Enable on ARM32 Android canary for render thread > > Enables the ThreadProfiler on Android canary channel Chrome releases > for ARM32. The profiler is enabled solely on the renderer main thread > for now, pending stability and performance metrics from the wild. > > Bug: 1004855 > Change-Id: If393653adf362f3fccbfa93078f45d88284fc81b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433125 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813548} TBR=wittman@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135152, 1004855 Change-Id: I3e04e2b1f5174fb01e29bbf912f70517d1424af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448960Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813784}
-
Scott Violet authored
This is necessary as embedders are pulling from canary, not stable, which makes for a much smaller skew. BUG=none TEST=none Change-Id: I28bc2aac2038fb5757c60ee5251cb281ea10cdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450389Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813783}
-
Oksana Zhuravlova authored
Since webview_power_usage.sql now outputs power usage by core type for the host app process, all renderer processes and WebView-only threads of the host app process, this change updates the corresponding tbmv3 metric to output these values. Bug: b/166476416 Change-Id: I59da13ccc07d91341825475d028a749466f592be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436289Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813782}
-
Hazem Ashmawy authored
Here is a per-class breakdown: - CrashReceiverServiceTest: batch under UNIT_TESTS, all existing tests are unit-tests-like, they don't launch any services or any UI. - MetricsBridgeServiceTest: two tests don't actually launch any service or UI so they are moved to a separate class and batched as UNIT_TESTS, remaining two tests are marked best left unbatched because they bind and unbind to a service and depend on having a fresh instance of that service every time, restarting the process makes sure they start with a clean state. - MinidumpUploadJobTest: These tests have n TestRule that launches a browser process and loads native library, it's safer to leave them unbatched. - VariationsSeedServerTest: Tests launches (bind/unbind) to service, leaving them unbatched makes sure that the service will be killed after each test leaving a clean state. - VisualStateCallbackTest: It has only one test that depends on multiprocess mode and it should remain unbatched. Bug: 1120847 Test: run_webview_instrumentation_test_apk -f "*.android_webview.test.services*" Change-Id: I7dbf0d4d5573eb9865f612d1c087627b705c2b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440658 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813781}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ifade39ca5a9522be2dcebb8ae13b4722e4ab0e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449810Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813780}
-
Hidehiko Abe authored
Currently OS_LINUX is defined on Chrome OS build, but it is being unset. This is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I773b4d46bc2e1f1cba9e3b8d0de5503d4e40eb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449610 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813779}
-
cfredric authored
This will be used to analyze how much entropy leaked by this API can be used for cross-site tracking. Bug: 973801 Change-Id: I1691fb17d2da0268ce77617a00309ae3f5b9f92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442894Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#813778}
-
Brian Malcolm authored
A device or account can be managed by either a Dasher domain, in which case the manager will be a domain (foo.com), or by a FlexOrg, in which case the manager will be an email address (user@foo.com). BUG=chromium:1081272 Change-Id: Ib9b80777d7cd054752f8c5298cfdc23f93b881b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446829Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#813777}
-
Ramin Halavati authored
ProfileNetworkContextService is updated to use Guest policy for ephemeral Guest profiles. This change is behind disabled EnableEphemeralGuestProfilesOnDesktop flag. Please see go/guest-on-disk for more context. Bug: 1125474 Change-Id: Ic58cbbb3d90ce2edca8d43da2cadab4ef28f5aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450189Reviewed-by:
-
Frédéric Wang authored
This CL removes the CSSOMViewScrollCoordinates experimental flag and cleans up related code. The flag is enabled in the current release M85 via a finch flag. It has been enabled by default on M86+ and ToT since [1]. Bug: 721759 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2310799 Change-Id: I79c631bf7b30a3c5d6f4c1c819bec124a5096c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377706 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813775}
-
David Bienvenu authored
Currently when we do taskbar migration, we do it for every profile launched. After the first profile, this should be a noop, but we still iterate over the shortcuts. Moving migration to ChromeBrowserMainPartsWin::PostBrowserStart() will make us do it only once. Bug: 1132578 Change-Id: I07cb8ea74145407f978efcd6067523d7d79ca1df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433427 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#813774}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/74f8dbb95782..378347c17f31 2020-10-05 jleconte@google.com Bisect on a chart with empty Bug ID fails. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1134978 Tbr: oysteine@google.com Change-Id: I8bc8e875344b9e52938897296d369ab1ff2d3f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450113Reviewed-by:
-
Richard Knoll authored
Notification Triggers OT has been restarted so we want to keep collecting data for its duration. Note that the collection code has not been removed when the metric was marked as obsolete. Bug: 1104957, 1053086 Change-Id: I7a2b819f799a920aae6b83520f9797c8cb1bcd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440839Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813772}
-
Lucas Radaelli authored
This change fixes the bug where chrome was sending the full semantic tree only for the first time that semantics were enabled. This happened because the semantic tree was not getting cleared on the chrome side when disabled. when semantic were disabled / enabled, the events fired on the tree included only the diffs from the previous state of the tree. Test: web_engine_browsertests Bug: fuchsia:59680, 1134147 Change-Id: I8266d6436f9bfb9ee9e89a0f46c0916bac7a5e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442646 Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#813771}
-
David Bokan authored
This test incorrectly allows overscroll actions like gesture-navigation which would interfere with the reported overscroll delta. This CL disables overscroll actions with |overscroll-behavior:none|; however, Chrome has a bug where it consumes overscroll delta, even when overscroll-behavior is set to none. Because of this bug, this test uses very approximate values for expectations and were right on the edge of what was frequently being seen. However, due to the nature of the bug a timing change here nudged it below the thresholds so I've loosened these. Bug: 1112183 Change-Id: If4ecf7a263385ddc3211f7776aca21eb8ec3aa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442152Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813770}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c401923f3ee3..8e4cda7de008 2020-10-05 tommi@webrtc.org Give PseudoTcp its own FifoBuffer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a6a4d4e9c54a774ecfa2e3aeac74981ffd023e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450114Reviewed-by:
-
Rohit Agarwal authored
Incognito notification tests were using @TargetApi annotation to ensure not running the tests in older android versions but the @TargetApi annotation has no effect in runtime and only has Class level retention which is useful for lint checks only. This CL uses @MinAndroidSdkLevel annotation instead. Bug: 1134241 Change-Id: I25788cb1492d1d719a667b0da1683e52a5caf1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448371Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813768}
-
sauski authored
Previously limitations on the number of surveys displayed to a user were keyed on a survey trigger. This is fine when the number of surveys displayed is small and intentionally partitioned via finch, but as the number of surveys is expected to grow this could result in users being shown surveys too frequently. This CL adds a generic cooldown that prevents any survey from being shown if the user has already seen one within the last 7 days. Bug: 1110888 Change-Id: I59189b6e1d67de19bf5359de42a7ed7691810d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445270 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#813767}
-
Clark DuVall authored
Due to b/169196314 the OS does not use the split's class loader to load services even when the service is in the split's manifest. To work around this, all services need to be defined in the base module's dex. This uses a similar approach to what was done for the Application class in http://crrev.com/c/2425404. Since there are multiple Service base classes which chrome services inherit from, I ended up using jinja templates to reduce duplication of common service methods since I couldn't find a good way to do this in pure Java. Alternatively I could also copy the base Service methods for the split compat version of each Service subclass. I converted an example Service, JobService, and IntentService to show usage. A follow up will convert the rest of the services used in chrome. Note that gerrit is not doing a good job of detecting renamed files here, so Patchset 1 contains strictly the moved service files, and future patchsets have the diffs from that. I would recommend reviewing with the base set to Patchset 1. Bug: 1126301 Change-Id: I8ccda76ee410e20d847791700b2987349e05959a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441250Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#813766}
-
Kristi Park authored
This reverts commit bd7b15d0. Reason for revert: PasswordViewControllerTestCase failures for ios_chrome_integration_eg2tests_module_* https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/12479 Original change's description: > Reland "[iOS][Password Check] Rewriting Passwords test with new details screen" > > This is a reland of 7b693e30 > > Fixed failing tests: > testStoredEntriesAlwaysShown > testCancelDeletionInDetailView > testSearchPasswords > > Original change's description: > > [iOS][Password Check] Rewriting Passwords test with new details screen > > > > This change rewrites Passwords tests with new Password Details screen. > > Obsolete tests are deleted. Fixed flakiness for > > testSearchAndDeleteAllPasswords. > > > > Bug: 1075494, 1129441 > > Change-Id: Id6d44a2f77c20edb1788f1d3dcaa04e9e645cdb5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418853 > > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811668} > > Bug: 1075494 > Bug: 1129441 > Change-Id: Ibfe28ea3ee68f9fb69fcb50085da9c1c558f86d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438380 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813660} TBR=eugenebut@chromium.org,gambard@chromium.org,vsemeniuk@google.com Change-Id: Ia803bf926c7dc689daf0a25abb49008e8fd92aef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075494 Bug: 1129441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450409Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#813765}
-
Roman Sorokin authored
* Use AsWeakPtr instead of base::Unretained in the WizardController * Check chrome::IsAttemptingShutdown together with browser_shutdown::IsTryingToQuit. IsAttemptingShutdown covers call to chrome::AttemptUserExit() which is common in the Chrome OS login/policy code. Bug: 1132397 Change-Id: I6c0e28138918a998c94f82f5c9e7736df92e5ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450051Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813764}
-
Sergey Ulanov authored
content_shell uses ui.policy.Presenter API to present UI. The API wasn't listed in content_shell.cmx, so it was failing to connect to the presenter. Also added content/shell/fuchsia/OWNERS file (required by presubmit checks for all cmx files). Bug: 1067477 Change-Id: I477644a28549f9314e9ffd007d1da9abcc6c8b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443449Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813763}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b3c1e71eb1cb..01144ed91c35 2020-10-05 bclayton@google.com third_party/cppdap: Roll forward to 1fd23dda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I814d1b6e001d1d599e691c3650af9fd65171e5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449647Reviewed-by:
-
Patrick Brosset authored
The new jump-to-var feature in the devtools frontend repository is changing the way css variables and css colors appear in the UI. Because of this, 3 web tets fail. In order to land the feature in the front-end repo, I'm disabling the tests temporarily. I'll fix and re-enable them as soon as the code is in Bug: 1135145 Change-Id: I676c644c6fb2c75bf219eb40e7a5e5d914470512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448056 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813761}
-
Eric Robinson authored
This CL adds UseCounters for activation of third party frames, as well as for general access to these frames, and third parties that had frames that were both activated and accessed. Change-Id: Ib366336a2553c5625341147e82875c4265b42225 Bug: 1115657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402196 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#813760}
-
Kushagra Sinha authored
Add a bare bones AccountManagerFacade interface definition and 2 stub implementations - AccountManagerFacadeAsh and AccountManagerFacadeLacros. Additionally, add a factory function - GetAccountManagerFacade, to return the correct implementation. Bug: 1117472 Change-Id: Ied4b50e08ecee78f72412b64c86341fb097bdc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424229Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#813759}
-
Leonid Baraz authored
The flakiness seems to be a test issue: apparently calling waiter.Signal by the callback directly sporadically blocks. The fix moves this call to a threadpool, and after that change 100 runs got no failures under stress (without the fix about 20 runs out of 100 crash). I would prefer to move whole callback to the thread in DmServerUploadService, but all my attempts to do so still ended up with the test being flaky. We may need a better fix inside the code rather than the test, but for now I see no other option. Bug: 1133968 Change-Id: I8ecde7f5c65911b75679cae5130985713233016f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448657 Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#813758}
-
Caitlin Fischer authored
The study and params were added here: https://codereview.chromium.org/2108053004. Bug: 1126640 Change-Id: Ib73c71702e6fb5c0cc151ddddc20b4788e4c17d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427073 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#813757}
-
kylechar authored
Tests should use --enable-gpu-rasterization instead. For the most part this was already the case, except for any of the stories based on PolymerPage in the rendering benchmark, which are disabled anyways. Bug: 1133368 Change-Id: Icffefd3800813b1e9c156f50ff69f2c9ff3c012e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436535Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Chris Sharp authored
args.gn has been a dependency for blink_web_tests_support_data for a while, but it isn't deterministic. TBR=thakis@chromium.org Bug: 1135151 Change-Id: I8f56ad9d25c4453e1afbb8e5ddaaf7295dc5c004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449930Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813755}
-
Sebastien Lalancette authored
SharingCoordinator will now handle add/edit bookmark commands sent from the Bookmark Activity, and will make use of the new BookmarkEditCoordiator to handle showing the Edit Bookmark UI. Bug: 1133294 Change-Id: I7f69f241b49646ffb1853a4a78322f5b941b6cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441957 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813754}
-
Thiabaud Engelbrecht authored
Bug: 1134257 Change-Id: I7a5da462acc3031fbe940345c907db1abfb1d11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441946Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#813753}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/497b7a37..69b996bd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I719ca57ded415c52762bea513873242b70f91f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449909Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813752}
-
Ilya Nikolaevskiy authored
The crash is now fixed. Bug: webrtc:11485 Change-Id: I56b09aca9fb547bc49b24ae1f634b9a4a878d07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449990 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813751}
-
Sebastien Lalancette authored
This new Coordinator will enable an edit-only scenario, requiring only a minimal set of dependencies. Without this new Coordinator, the "Edit Bookmark" flow ended up being dependent on the SharingCoordinator (via the BookmarkHomeViewController). Since bookmarks can be edited via the sharing activities ("Edit Bookmark"), we ended up with a cyclic dependency. The creation of this new Coordinator enables such flow. e.g. Open a page -> Add it to Reading List -> Add it to Bookmarks -> Open Reading List -> Long-press on the entry -> Select Share -> Select "Edit Bookmark". Bug: 1133294 Change-Id: Ib646a7e79e6c46b5cd4b373417caa447a4365ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441956 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
