GitLab

Revert "Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but instead successfully completes the reconciliation." (https://codereview.chromium.org/309843002/)

The original CL causes crashes about 20 secs after launching the linux build of chromeos.

This reverts commit 660a4d00.

Conflicts:
	chrome/browser/signin/account_reconcilor_unittest.cc

Original issue's description:
> Improve the no-op reconcilor so that it doesn't "hang" after the first execution, but instead successfully completes the reconciliation.
> Improve the UMAHistogramHelper so that it can nicely take snapshots between tests, allowing the test writer to easily test ONLY the changes logged in "this" test.
> Write a new unit test that executes the reconcilor twice, and make all reconcilor unit tests execute with and without the flag.
>
> BUG=357693
> TBR=phajdan.jr@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277605

BUG=357693,386045
TEST=None
TBR=mlerman@chromium.org

Review URL: https://codereview.chromium.org/344513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277990 0039d316-1c4b-4281-b951-d872f2087c98

- All files from webkit/renderer/compositor_bindings have been moved to content/renderer/compositor_bindings
- Webkit_compositor_support is moved in content_renderer
- Webkit_compositor_bindings_unittests is moved in content_unittests
- A dummy target has been left for webkit_compositor_bindings_unittests so as to not break the build.

TBR=nduca

BUG=265753

Review URL: https://codereview.chromium.org/317163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277988 0039d316-1c4b-4281-b951-d872f2087c98

If I've never used them, they must not be useful.

BUG=none

Review URL: https://codereview.chromium.org/344513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277987 0039d316-1c4b-4281-b951-d872f2087c98

On 32-bit platform, the expected result for this test is address of
64-bit, while the actual result is address of 32-bit. So they don't
match with each other.

BUG=380492

Review URL: https://codereview.chromium.org/310323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/331283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277985 0039d316-1c4b-4281-b951-d872f2087c98

This can happen if we receive an IdleNotification after OnRenderProcessShutdown.

BUG=367711

Review URL: https://codereview.chromium.org/256803012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/339273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277983 0039d316-1c4b-4281-b951-d872f2087c98

Events are now sent to the window manager (assumed to be at connection
id 1 for now). The window manager can then do what it wants with
them. For now I made it bounce the event back to the server so
everything works as it did.

Until we get FIFO across pipes I'm putting these messages on the
ViewManager/ViewManagerClient interface. That'll change.

BUG=384433
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/338353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277982 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Rename data member variables to use unix_hacker_ style.
2) Rename methods to use CamelCase style.
3) Rename file name to web_permissions.

BUG=331299
TEST=content_unittests, content_shell. No functional changes
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/322713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277981 0039d316-1c4b-4281-b951-d872f2087c98

This cl seems to cause heap use after free on the Asan bots.
LargePage
FindLongString

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/3837/steps/browser_tests/logs/LargePage

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/4211/steps/browser_tests/logs/FindLongString
> cc: In SyncFromActiveLayer, drop all tiles not in the recorded_viewport.
> 
> Currently we do a walk over all tiles in the pending tree's pile, but
> there can be 1 million x 1 million tiles on some pages, which makes this
> method take multiple _seconds_ to complete.
> 
> These loops were added in r184525 which gave the tradeoffs that led to
> them, which are that we want to only use a single pile for all the tiles
> on this layer, but we don't want raster tiles on the active layer (when
> this activates) that can't be rastered by the pile they are attached to.
> 
> Instead of walking every pile-tile, to find the tiles that are not
> present in the current recording and invalidate them, we expand
> invalidations outside the interest rect to cover the full recording tiles,
> and we expand invalidation inside the interest rect to include any raster
> tiles that don't have a recording (such as in the offscreen animating gif
> case). We give this expanded invalidation to the pending layer, causing
> it to drop rastered tiles from the active tree that intersect with an
> unrecorded area.
> 
> R=enne
> BUG=371839
> 
> Review URL: https://codereview.chromium.org/294163009

TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/347493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile

Review URL: https://codereview.chromium.org/335353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277979 0039d316-1c4b-4281-b951-d872f2087c98

Pretty straightforward, nothing really blocks it, so we can move it
easily from ui_unittests target to gfx_unittests now.

BUG=331829
TEST=ui_unittests, gfx_unittests with/out --test-launcher-bot-mode
TBR=danakj@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/332353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277978 0039d316-1c4b-4281-b951-d872f2087c98

Since only one of GL_TEXTURE_2D and GL_TEXTURE_EXTERNAL_OES would be used. Switch active texture according to the target type and unbound the texture after use.
    
BUG=chromium:383414
TEST=Run the unittest on link and peach-pit

Review URL: https://codereview.chromium.org/324253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277977 0039d316-1c4b-4281-b951-d872f2087c98

If a frame overlaps appendWindowStart, partial append window filtering
is supported for the track, and the frame is appended to the track
buffer, this change updates the track buffer's last frame duration with
the frame's original duration instead of the possibly trimmed duration.
If the trimmed duration were used, then the discontinuity detection
logic could detect a discontinuity on the next frame for the track where
there would otherwise not be a discontinuity.

BUG=381114
R=acolwell@chromium.org
TEST=FrameProcessorTest.PartialAppendWindowFilterNoDiscontinuity

Review URL: https://codereview.chromium.org/344513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277976 0039d316-1c4b-4281-b951-d872f2087c98

(previously JsCollectGarbageAction and InteractAction).

BUG=361809

Review URL: https://codereview.chromium.org/338883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277975 0039d316-1c4b-4281-b951-d872f2087c98

Revert of views: Move MenuButton from TextButton to LabelButton. (https://codereview.chromium.org/298813002/)

Reason for revert:
This is causes ExtensionApiTest.Bookmarks to fail on Linux:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5412
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32272

TBR=erg@chromium.org,msw@chromium.org,sky@chromium.org
NOTRY=true
NOTREECHECKS=true

Original issue's description:
> views: Move MenuButton from TextButton to LabelButton.
> 
> This also converts the TextButtons in the BookmarkBarView to LabelButtons, since they need to have the same base class as MenuButton does. This also standardizes on fade eliding instead of fade eliding sometimes and ellipsis eliding in other cases.
> 
> This patch has the effect that everything on the bookmark bar also renders with GTK+ borders in GTK theme mode on Linux.
> 
> BUG=155363
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277878

Review URL: https://codereview.chromium.org/340003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277974 0039d316-1c4b-4281-b951-d872f2087c98

Looks like the test was accidentally re-enabled on Mac,
but it's very flaky and failing on the test bots.

TBR=thestig@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/338883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277973 0039d316-1c4b-4281-b951-d872f2087c98

This is effectively a revert of http://crrev.com/202763005

BUG=339004

Review URL: https://codereview.chromium.org/337323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277972 0039d316-1c4b-4281-b951-d872f2087c98

Added calamity and mgiuca (working heavily in these folders).
Removed koz (no longer works on app list).

BUG=None
NOTRY=true

Review URL: https://codereview.chromium.org/339983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277971 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for support for using remote CALayers.

The big change is to separate out ImageTransportSurfaceIOSurface into
ImageTransportSurfaceFBO and its StorageProvider. The IOSurface-
specific bits of ImageTransportSurfaceIOSurface are moved into the
StorageProvider. A separate CALayer-specific version will be added
later.

While in the neighborhood, don't make everything inherit from
GLSurfaceCGL (that class doesn't actually do anything). Move the helper
functions and classes from its file to more appropriate locations.

Make image_transport_surface_mac.cc a .mm file, because it will need
to include Objective C code in the near future. Move the
ImageTransportSurfaceFBO into its own file.

Also make the IOSurface handles in renderer_host use the 32-bit
IOSurfaceID handle type instead of uint64, since that is the type
actually used by the interface, and those other bits may find use in
disambiguating handle types.

BUG=312462

Review URL: https://codereview.chromium.org/334173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381041

Review URL: https://codereview.chromium.org/341673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277969 0039d316-1c4b-4281-b951-d872f2087c98

StopWatchingAll() can be called before InitializeAndStartWatching
is called. Before bailing out, disarm the startup watchdog.

BUG=

Review URL: https://codereview.chromium.org/341713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277968 0039d316-1c4b-4281-b951-d872f2087c98

People are using bigger and bigger monitors these days! This change only
makes a difference when RANDR-enabled Xvfb is used.

NOTRY=true

Review URL: https://codereview.chromium.org/341653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277967 0039d316-1c4b-4281-b951-d872f2087c98

this is no longer used.
r92045 removed RenderWidgetHostView::WillDestroyRenderWidget().

BUG=None
Test=None, internal only change.

Review URL: https://codereview.chromium.org/339273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277966 0039d316-1c4b-4281-b951-d872f2087c98

Remove TemplateURL::profile_.
Remove TemplateURLService::AddAndSetProfile which does nothing other than calling Add().
Merge TemplateURLService::GenerateSearchURLUsingTermsData and GenerateSearchURLUsingTermsData.

BUG=383283
TEST=git cl try
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/338363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277965 0039d316-1c4b-4281-b951-d872f2087c98

Currently we do a walk over all tiles in the pending tree's pile, but
there can be 1 million x 1 million tiles on some pages, which makes this
method take multiple _seconds_ to complete.

These loops were added in r184525 which gave the tradeoffs that led to
them, which are that we want to only use a single pile for all the tiles
on this layer, but we don't want raster tiles on the active layer (when
this activates) that can't be rastered by the pile they are attached to.

Instead of walking every pile-tile, to find the tiles that are not
present in the current recording and invalidate them, we expand
invalidations outside the interest rect to cover the full recording tiles,
and we expand invalidation inside the interest rect to include any raster
tiles that don't have a recording (such as in the offscreen animating gif
case). We give this expanded invalidation to the pending layer, causing
it to drop rastered tiles from the active tree that intersect with an
unrecorded area.

R=enne
BUG=371839

Review URL: https://codereview.chromium.org/294163009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277964 0039d316-1c4b-4281-b951-d872f2087c98

There are some DCHECK() to check iterators, but it checks
nothing in release builds.
We have to check them to avoid crashes in release builds.


BUG=364243

Review URL: https://codereview.chromium.org/338993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277963 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/324033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277962 0039d316-1c4b-4281-b951-d872f2087c98

The login and lock screens can toggle overscroll mode for the virtual keyboard without triggering a rebuild of the VK.  Thus, it is possible to be in an inconsistent state between keyboard bounds change notifications.  This patch forces any insets to be reset if overscroll mode is not enabled.

BUG=384981

Review URL: https://codereview.chromium.org/341623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277961 0039d316-1c4b-4281-b951-d872f2087c98

Default will be 200ms.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/341483007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277960 0039d316-1c4b-4281-b951-d872f2087c98

Trying to merge as many of flow control changes as possible before the
branch (we have all changed until Fri 06/13 21:20 UTC).

Test tools for udp proxying.  This involves a few refactors of test
tools but nothing which affects the internal server.

minor refactors to allow quic udp proxy testing.

Merge internal change: 69157651
https://codereview.chromium.org/331963002/


Added FEC policy per stream, which is translated to an FEC protection
value on writes further on down.

Merge internal change: 69153464
https://codereview.chromium.org/338623002/


Pull out stream/session updates from OnConfigNegotiated. Preparation for
updating stream/session with different received windows.

QUIC refector: Pull out stream/session updates from OnConfigNegotiated

Merge internal change: 69106467
https://codereview.chromium.org/337723003/


Rather than passing initial_flow_control_window all the way down the
call stack, put it inside QuicConfig as intended: each member of
QuicConfig has a "value to send" field, so populate this at the top
level.

rtenneti: when porting to Chromium, you should add
config.SetInitialFlowControlWindowToSend(kInitialReceiveWindowSize)

in QuicStreamFactory::CreateSession, just above line 837: *session =
  new QuicClientSession(...)

Store initial flow control window for QUIC in QuicConfig. No behavior
change intended.

Added the following unit tests to EndToEndTest.cc
+ DoNotSetResumeWriteAlarmIfConnectionFlowControlBlocked
+ NegotiateMaxOpenStreams

Merge internal change: 69079363
https://codereview.chromium.org/333803007/


First version of a QUIC SendAlgorithmSimulator which is designed to
simulate BBR and TCP flows and changes.

Merge internal change: 69035927
https://codereview.chromium.org/330163003/

R=rch@chromium.org, wtc@chromium.org

Review URL: https://codereview.chromium.org/330333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277959 0039d316-1c4b-4281-b951-d872f2087c98

This makes the gl_tests and gpu_unittests targets link and run and fixes
up a few other misc issues:

*) outdated nss filelists and defines
*) outdated cc file lists

R=brettw@chromium.org, piman@chromium.org
TBR=ben@chromium.org for ui/events/ change

Review URL: https://codereview.chromium.org/338633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277958 0039d316-1c4b-4281-b951-d872f2087c98

Since we don't have alt text yet, accessibility screen readers have
nothing useful to say in screen readers.  Until alt text is available,
disable the images from appearing in the screen reader.

This is done by removing the accessibility child object from a parent.
In this case, we introduce a new fake parent object for the small icon,
and make the existing parent ignore the image for the large icon and
the large image of an image notification.

BUG=381363

Review URL: https://codereview.chromium.org/325203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277957 0039d316-1c4b-4281-b951-d872f2087c98

This sets the COMPILED flag in base.js to true when compressing the
javascript sources. ChromeVox makes assumptions about what content
script files to load (which it could get from the manifest) and also
does initialization differently depending on thsi flag.  Leaving cleanup
of that to later CLs if we want to do that in the interest of changing
as little as possible during the migration.

BUG=371692
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/333503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277956 0039d316-1c4b-4281-b951-d872f2087c98

This test creates shims in the user data dir and actually starts them up and
expects them to connect to the IPC socket.

BUG=168080, 386024
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276368

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277743

Review URL: https://codereview.chromium.org/316493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277955 0039d316-1c4b-4281-b951-d872f2087c98

Changed the layout of the App Info Dialog according to UI feedback. This
includes removing the tabs, and replacing it with a single, scrollable
dialog that has all the information in a single pane.

BUG=364681,266739

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276557

Review URL: https://codereview.chromium.org/327743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354143

Review URL: https://codereview.chromium.org/332553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277932 0039d316-1c4b-4281-b951-d872f2087c98

The extended safe browsing reporting opt-in should point to the whitepaper section on malware. This CL:
- Adds a "privacy policy" link to the dialog
- Updates the existing URL to point to the specific malware section instead of the generic privacy policy

BUG=383866

Review URL: https://codereview.chromium.org/339073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277930 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes redundant internal functions which are identical, and replaces
them with one.

Moreover, the new general purpose error API function, passes now the entire
value to the request manager. This is because, very soon, we are going to
pass extra information with every error and success responses and we want to
have access to them in the RequestManager.

NOTRY=true
TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=373165, 384201

Review URL: https://codereview.chromium.org/335753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277929 0039d316-1c4b-4281-b951-d872f2087c98