- 29 May, 2019 40 commits
-
-
Sergey Volk authored
Test: Played 5.1 opus encoded audio file through chromecast by pointing the chromecast to a local server and audio comes out of the AVR at the expected channel. Bug: b/133189747 Change-Id: Ia0e77ea9f6f8b3f9cd35803dffa5888fec0335d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627759Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#664079}
-
Charles Zhao authored
Currently, for two continuous discards queries, only the second label_id is logged in target, which makes it hard for pairing for the first label_id. Change: (1) We shift currently label_id * 8192 (<< 13), (2) If a tab already has label_id !=0, then that means we had second query before labeling. we only increase the label_id by 1. (3) If a tab has label==0, that means previous label_ids are all logged with labels. We assign a new label_id to the tab. Then with offline pipeline we use label_id_pre = label_id >> 13; label_id_suf = label_id %8192 And all tabs have same label_id_pres are the same tabs logged multiple times. We can pair them with the same labeling event. Bug: 966742 Change-Id: Ia741b16c2622eb158848e166e36ba1bf03655728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627845 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#664078}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ddde8daf5768..a730bef0e754 git log ddde8daf5768..a730bef0e754 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 richardfung@google.com Add qt-arc-dev to PFQ and betty-[nyc, pi, qt]-arc boards Created with: gclient setdep -r src/third_party/chromite@a730bef0e754 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I371e4fef76038e328eff6b0b676c614e1cff8ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664077}
-
Eric Willigers authored
Rename WebAppUiDelegateImpl to WebAppUiService. TBR=msarda@chromium.org Bug: 966288 Change-Id: I4f92fc39f5c22a89e25093370e0d4753c23c7e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630376 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#664076}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d524d32f3c7c..4e2aa897a424 git log d524d32f3c7c..4e2aa897a424 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 tsepez@chromium.org Remove circular includes between cpdfdoc and core/fpdfapi/render Created with: gclient setdep -r src/third_party/pdfium@4e2aa897a424 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id6d7f4ba7ff1ba08400bd56cf0c3d19a9c870181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633440Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cee3dffa8f79..ca8e3d7c153e git log cee3dffa8f79..ca8e3d7c153e --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bclayton@google.com Reactor: Fix printing of small integer values. 2019-05-28 bclayton@google.com SpirvShader: Correctly handle phi values in the loop merge 2019-05-28 bclayton@google.com SpirvShader: Simplify the logic around the generation of the inner loop. Created with: gclient setdep -r src/third_party/swiftshader@ca8e3d7c153e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133440380,chromium:b/133481698,chromium:b/133440380,chromium:b/133481698 TBR=swiftshader-team+autoroll@google.com Change-Id: Iac6bde0fab5929670508c950d9b16e5cca4eaaa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633439Reviewed-by:
-
Kelvin Jiang authored
This CL allows users to navigate to the activity log page via URL even if the extension ID specified in the URL is invalid/uninstalled. This allows the user to see install-time activities in real-time via the following steps: 1) Navigate to the activity log via URL 2) Click on the real-time tab 3) Install the extension with the ID in the activity log's URL. Note that a listener for extension activities is already present for the extension ID. 4) In the real-time tab, the extension's install-time activities should appear. Screenshots: https://imgur.com/a/Niyc3S8 Bug: 832354 Change-Id: Ifaa0c3ea57d295f8657f067c610a093170e909a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620346 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#664073}
-
Alan Cutter authored
This CL creates a new "installable" state in AppBannerManager to distinguish whether Chrome provides the option to install (kByUserRequest) or whether Chrome promotes installation for the site (kPromotable). Before this CL we disabled PWA installation entirely if the site indicated it preferred a related app in its manifest. Now we just use it as a signal to avoid promoting install to the user but still provide them the option in the 3-dot menu. Bug: 964314, 966831 Change-Id: Ic68d21bbca021c4fad45f8225e097b1df3a46b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630128 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#664072}
-
Justin Cohen authored
When quickly navigating back or forward, it's possible to trigger the following WebKit error: "[ProcessSwapping] WebPageProxy::suspendCurrentPageIfPossible: Not suspending current page for process pid XXXX because fromItem's URL does not match the page URL." When this happens, the WKBackForwardList gets out of sync with the webView, and currentItem.URL does not match webView.URL. This workaround takes the naive approach and looks to see if the next or previous WKBackForwardList item has the correct URL. Bug: 960326 Change-Id: I2b9d9355949fcc3978aef4f37584bb4aeade75a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627703 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664071}
-
Brian Sheedy authored
Rolls the goldctl version to pick up the change that adds goldctl-side triage links. TBR=kbr@chromium.org Bug: 850107 Change-Id: If20fdc3ba8579e15b9f8c22eb562f2b07f3192ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632709Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664070}
-
Nicholas Verne authored
Bug: 967499 Change-Id: Id216582068e5ed3484637611700edc8920fbd5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631260Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#664069}
-
John Abd-El-Malek authored
There are three fixes: 1) The main fix is that network::NetworkService needs to be torn down between tests. One reason is that so a test don't leave it misconfigured for other tests. The pressing reason is that if network::NetworkService is bound to a pipe in one test it'll also be bound to that test's BrowserThreadTestBundle's sequence; that means for other tests no mojo messages will be dispatched. Fix this by resetting the interface pointer at the end of each test. 2) We need to delete the network::NetworkService object to avoid leaks; depending on connection error dispatching again might not be delivered. This is fixed by storing the pointer in SequenceLocalStorageSlot. 3) We create network::NetworkService directly instead of trying to use the global ServiceManager. For most tests this happens because there's no global Connector. However some tests would instantiate a test service manager objects, so we need to force the direct instantiation through a test only method. Bug: 966633 Change-Id: I1c181733af692e7a6742a45c10a16c863e2642a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632494 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#664068}
-
Taylor Bergquist authored
Bug: 958173 Change-Id: Iff81fa8dd3ff57cb7121d628cd5e78e8e58c157f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633350 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#664067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86837544cd02..76ce2f554e7a Created with: gclient setdep -r src-internal@76ce2f554e7a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I668311010db0a96804fc4e9ee10883386fd64b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633228Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664066}
-
Anand K. Mistry authored
If the dropdown is opened when there are initially 0 items and new items are added while it is open, the dropdown doesn't expand to accomodate the new items. This manifests in the SMB share dialog where share discovery is happening in the background. If the user opens the dropdown while the discovery is in progress, the dropdown will not be expanded when share are discovered. The user needs to close and re-open the dropdown to see the discovered shares. BUG=None Change-Id: I71c85466145301fd25366138711c43e478457210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627849Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664065}
-
Jeffrey Kardatzke authored
If you set the language to French (and likely many others), then the text describing the sys info/app/metrics checkbox can overlay on top of the screenshot image. This puts a margin on the right of that text to avoid that overlapping. Bug: 949722 Test: Manually verified on Chrome OS in French language Change-Id: I4ccb453e0f5071103058fa1025aacb426fd1f1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632535 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#664064}
-
Matthew Braithwaite authored
This is a followup to b5cccac5, and has the same motivation: to improve testability of Certificate Transparency enforcement. Injecting the time of evaluation allows a test to be written that shows that while a call may return |CT_POLICY_COMPLIES_VIA_SCTS| today, the same inputs may return |CT_POLICY_BUILD_NOT_TIMELY| tomorrow. Change-Id: If4a4519ccaf7b1470477fc4c1978de1d14e58aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626016 Commit-Queue: Matt Braithwaite <mab@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#664063}
-
Istiaque Ahmed authored
Add a flag to RunExtensionTest so that an existing event page based test extension can be loaded as SW based extension. This can be used to run extenision tests with Service Worker based extensions. This CL also converts runtime/open_options_page/ test extension to event page extension and demonstrates that the extension be loaded as SW extension and the corresponding test ExtensionApiTest.ChromeRuntimeOpenOptionsPage passes with the flag in ServiceWorkerBasedBackgroundTest.ChromeRuntimeOpenOptionsPage. Doc: https://docs.google.com/document/d/1PvXZ7VGRGdmd1s99SFByn9NCGj0GAiBhhPmfjj35ZeI/edit# Bug: 967899 Change-Id: I8821d1c9fa22795b8fe0f65f1bd073a034e24431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626455 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664062}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ee244c772a41..ded5f903261a git log ee244c772a41..ded5f903261a --date=short --no-merges --format='%ad %ae %s' 2019-05-28 geofflang@chromium.org Vulkan: Make the Vulkan renderer thread safe. 2019-05-28 geofflang@chromium.org Vulkan: Use atomics in SerialFactory. 2019-05-28 jmadill@chromium.org D3D11: Suppress failing Texture test on AMD. Created with: gclient setdep -r src/third_party/angle@ded5f903261a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967796 TBR=cwallez@google.com Change-Id: Ie0425a04fc08aeea66934d9fc31670c43a703a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633224Reviewed-by:
-
Victor Costan authored
This addresses review comments on https://crrev.com/c/1630807 Change-Id: Iabb5c56b176a179fc7c40c1ba93f7bcdbad9daaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633318 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#664060}
-
BUG=762641 TBR=mukai@google.com Change-Id: I0fdd59f83a784c236193398146c6fb8f3181f921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632536Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664059}
-
Zhenyao Mo authored
Also, simply some of the unit tests. (This relanding removed the newly added YUY2SwapChain unit test since it doesn't pass on AMD. Will add it in a separate CL with proper support detection.) BUG=909827,967860 TEST=bots,gl_unittests TBR=sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623030 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#662443} Change-Id: Ia85b82d177a455b8a3db1888ba3a3a9a924d6b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629726Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664058}
-
tby authored
The EnableAppListLaunchRecording feature flag is used to guard hashed logging (see /src/ash/public/cpp/app_list/app_list_features.cc). This CL adds a testing config for it. Bug: 951287 Change-Id: I7a7d62d2388170c921976009db256c822d2425b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631910Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#664057}
-
Tom Anderson authored
Design document: https://docs.google.com/document/d/1m5cbNLv4CgUTsBw0XaM8OaVgeq1-N1SD66Vu0VOqeb4/edit?usp=sharing Behavior when EnableDbusAndX11StatusIcons is disabled (same as old behavior): * If libappindicator is available, create an AppIndicatorIcon - libappindicator will asynchronously try to create the status icon with DBus, then with X11, then will give up. * Otherwise, create a GtkStatusIcon - GtkStatusIcon will asynchronously try to create a status icon with X11, then will give up. Otherwise, when EnableDbusAndX11StatusIcons is enabled (planned new behavior): * Try to create a StatusIconLinuxDbus. If that fails, try to create a StatusIconLinuxX11. If that fails, then give up. BUG=419673 R=thestig Change-Id: Id7ef4869f24caf726ba0e39d604a47b1e81815be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633230 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#664056}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/162eba28f207..ddde8daf5768 git log 162eba28f207..ddde8daf5768 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 jperaza@chromium.org Add crashpad_handler to chrome paths Created with: gclient setdep -r src/third_party/chromite@ddde8daf5768 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I56adb35d52cf68e97a72a844d159d9b9f48c6ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633220Reviewed-by:
-
Derek Schuff authored
This check currently only determines whether a page can load a NaCl module and doesn't consider PNaCl (previously there was also a flag to disable PNaCl). Also it does not modify the WebPluginParams. Bug: 918374 Change-Id: I90dfd18e98db26fb8db76192221004efd78341a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633233Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#664054}
-
Jun Mukai authored
This reverts commit 3e8aceb1. Reason for revert: Failures of SessionRestoreTestChromeOS in linux-chromeos-rel. see crbug.com/967929 Original change's description: > mash cleanup: Remove wallpaper.mojom > > Move wallpaper.mojom to a virtual c++ interface. > Update impl and clients, make some methods sync. > Combine mojo and non-mojo observer types. > Add a static WallpaperController::Get(), cleanup. > > Bug: 958227 > Test: No Chrome OS wallpaper regressions. > Change-Id: I23de39efd3721f40ec423eed651f1cb8fed7edd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626011 > Commit-Queue: Michael Wasserman <msw@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663937} TBR=sky@chromium.org,msw@chromium.org,dcheng@chromium.org Change-Id: I18b34e5ad58657c1d9d3e70baade46d340de1887 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958227, 967929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633549 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#664053}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1f02e8488551..66661df8e9f9 git log 1f02e8488551..66661df8e9f9 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@66661df8e9f9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I727a33950a1dba70ca9485fc56ab5cd707a205c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633219Reviewed-by:
-
John Chen authored
Disabling failing perf tests: * blink_perf.canvas/draw-video-to-hw-accelerated-canvas-2d_RAF.html?RAF * blink_perf.canvas/upload-video-to-sub-texture_RAF.html?RAF * blink_perf.canvas/upload-video-to-texture_RAF.html?RAF * rendering.mobile/microsoft_video_city NOTRY=true TBR=crouleau@chromium.org CC=aaronhk@chromium.org, fserb@chromium.org, sadrul@chromium.org, vmiura@chromium.org Bug: 967809 Change-Id: Idfae0a2e3adc5b4075a00a53f7b361fd61e9d276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633589Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664051}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f7ea76c9. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" be76d09e "[ServiceWorker] Reject update() from within installing workers" abf2ac5e "webrtc wpt: avoid race conditions" 760a2c20 "Apply iframe referrerpolicy attribute to non-initial loads." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ic9237eb2a2e840fe792776e1a06093ebc3a8c648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633210Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664050}
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: I29bdd68d565442f13dd83940884aaedcbbebb99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630380Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664049}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10e57cf61851..4ce909c11c06 git log 10e57cf61851..4ce909c11c06 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-28 iannucci@chromium.org Revert "cipd: remove windows-386" 2019-05-28 maruel@chromium.org cipd: remove windows-386 Created with: gclient setdep -r src/third_party/depot_tools@4ce909c11c06 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iea4ffdc5ed774dc7e2b773ba4c6be54d3b70791e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632948Reviewed-by:
-
Danan S authored
This functionality will instead be implemented on the server side. Bug: 937995 Change-Id: I4c862a5d90f02a541cff3293b83cfb8f981cd069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627924Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
Justin Cohen authored
ios/web quickly gets into a bad state when navigating while the currently committed url is a redirect URL. Similar to blocking navigation during session restoration, also block navigation during the redirect URL. This redirect happens very quickly, so don't update the UI -- rather ignore the tap. Not updating the UI prevents a flicker. Bug: 960326 Change-Id: Ibfe30f3341723bdc6cba122dccf21872ada2d072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630224 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Change-Id: I814de4b2943e9d6890bae260fab3e561a5f2ab23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632925Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#664045}
-
Sean Kau authored
Metric was set to expire in June. Extending metric into next year. Activity has not stabilized yet. Bug: chromium:967466 Change-Id: Ide6d07391fc919617bddc908442b9a8507d1dccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632418 Auto-Submit: Sean Kau <skau@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
David Benjamin authored
Sadly, enterprise usage of buggy middleware is still on the high side. Extend the metrics so we can continue to monitor this. Bug: 967483 Change-Id: I7b571b284315c2b0223b97e405d2e355313aac9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632779 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jonas Olsson authored
Media.Audio.Render.StreamBrokerDisconnectReason2 is still in use. This CL delays its expiry by another quarter. It also replaces me as owner of it. Bug: chromium:960094 Change-Id: Ic44d954b3fb156a12e5dd786d6cb06f7692a0da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631694 Auto-Submit: Jonas Olsson <jonasolsson@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Andrew Moylan authored
* Extend expiry on soon-to-be-expired histograms * Add expiry to all histograms per best practice * Add a second owner to all histograms per best practice The expiry date was chosen according to https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms where these histograms are "Actively in use now, useful for short [likely long] term". Bug: 967500 Test: none Change-Id: Idbfef38927d2856c99f2ad940b910695a7c4ab79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631852 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jeffrey Cohen authored
This reverts commit 8d639cb7. Reason for revert: failing test on macos10: http/tests/devtools/elements/highlight/highlight-node-vertical-rl.js Original change's description: > More physical coordinates in LayoutText and LayoutInline > > This further reduces back-and-forth flipping for LayoutNG, and makes it > clear that inspector highlight always uses physical coordinates. > > Change-Id: Iecec0c03c2a1a14d8ad2aeb29f61f3a912d5d670 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625876 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#663927} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: I1179b65f14a0e3f73454d1d271986e81acf7dbf2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633292Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664040}
-
