GitLab

The example CL to change tests (WebViewLayoutTest) to Junit4 style is this: https://codereview.chromium.org/2266353003

BUG=640116

Review-Url: https://chromiumcodereview.appspot.com/2273553002
Cr-Commit-Position: refs/heads/master@{#426889}

Reland of Accessibility: Ignore all anonymous blocks (patchset #5 id:360001 of https://codereview.chromium.org/2440833002/ )

Reason for revert:
Turns out this wasn't the root cause of the bug; even though it was the result of a bisect; sorry for the noise

Original issue's description:
> Revert of Accessibility: Ignore all anonymous blocks (patchset #15 id:280001 of https://codereview.chromium.org/2387533003/ )
>
> Reason for revert:
> crbug.com/658045
>
> Original issue's description:
> > Accessibility: Ignore all anonymous blocks
> >
> > Anonymous blocks are an implementation detail of the
> > Blink layout tree. They're surprising and not useful in
> > the accessibility tree. Get rid of them by marking them
> > all as ignored.
> >
> > While it may seem counterintuitive, this is actually
> > part of a longer-term plan to get rid of the idea of
> > ignoring nodes for accessibility, this will bring us
> > closer to just exposing the DOM tree plus generated
> > content, like FIrefox and IE do.
> >
> > The code change here is tiny, most of the change is
> > rebasing or updating dozens and dozens of affected
> > tests. I deleted a couple of tests that specifically
> > tested corner cases involving anonymous blocks;
> > the whole point of this change is to not make this a
> > special case anymore.
> >
> > Also updates this script, designed to automatically
> > pull test output from try servers to a local change:
> >
> > tools/accessibility/rebase_dump_accessibility_tree_test.py
> >
> > BUG=651614
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> TBR=aboxhall@chromium.org,dmazzoni@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=651614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/e4db7ae216888672805a38d8f8fee54c836357c9
> Cr-Commit-Position: refs/heads/master@{#426736}

TBR=aboxhall@chromium.org,dmazzoni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651614
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2439203003
Cr-Commit-Position: refs/heads/master@{#426888}

https://chromium.googlesource.com/chromium/src/+/8de5bb3d8

BUG=657839
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/2433283004 .

Cr-Commit-Position: refs/heads/master@{#426887}

The multibuffer tells the client that we are loading, even if the
content is already cached. However, if the content is fully cached,
there will be no progress updates, and the we'll never tell the client
that we stopped loading. This CL fixes that by posting a task that
checks the loading state right after startup.

BUG=657922

Review-Url: https://chromiumcodereview.appspot.com/2437273002
Cr-Commit-Position: refs/heads/master@{#426886}

Half-float conversion is more efficient on some platforms if the
multiplier used is 1.0. Also clean up the half-float conversion
code and extend testing up to 16 bits.

BUG=657627
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://chromiumcodereview.appspot.com/2444463002
Cr-Commit-Position: refs/heads/master@{#426885}

BUG=654913

Review-Url: https://chromiumcodereview.appspot.com/2414213003
Cr-Commit-Position: refs/heads/master@{#426884}

https://chromium.googlesource.com/chromium/src/+/8de5bb3d8

BUG=657839
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/2441123002 .

Cr-Commit-Position: refs/heads/master@{#426883}

This CL lands server change 136517960 by birenroy.

BUG=488484

Review-Url: https://chromiumcodereview.appspot.com/2435363002
Cr-Commit-Position: refs/heads/master@{#426882}

BUG=656975

Review-Url: https://chromiumcodereview.appspot.com/2435193003
Cr-Commit-Position: refs/heads/master@{#426881}

This CL tracks whether the browser process has an about:blank history
item for subframes during a history navigation.  If the renderer would
be staying on about:blank, it can skip asking the browser and commit
the initial about:blank page synchronously.

BUG=657896, 639842
TEST=See bug for repro steps.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
R=alexmos@chromium.org

Review URL: https://codereview.chromium.org/2438743005 .

Cr-Commit-Position: refs/heads/master@{#426880}

NetworkThrottleManager serves throttle objects to consumers (currently
HttpNetworkTransaction) that inform the consumer of their throttled state
and let the throttler track their lifetime.

BUG=600839
R=mmenke@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/1901533002
Cr-Commit-Position: refs/heads/master@{#426879}

Refactor BrowserActivationWaiter as test support and move PopupBlockerBrowserTest to interactive_uitest

(1) Making BrowserActivationWaiter a common test support
(2) move PopupBlockerBrowserTest to interactive_uitest as there exists one test that is relying on native widget activation.

BUG=658295
TEST=utilizing the test support in PopupBlockerBrowserTest

Review-Url: https://chromiumcodereview.appspot.com/2441543004
Cr-Commit-Position: refs/heads/master@{#426878}

BUG=646902
TEST=EME tests pass

Review-Url: https://chromiumcodereview.appspot.com/2440893002
Cr-Commit-Position: refs/heads/master@{#426877}

This CL removes one of workaround used by FrameLoader::load method when
the http request is associated with a form.  The workaround is no longer
needed after r400442 fixed how HTTP method and request body are
correctly plumbed through the OpenURL path.

To make sure that the layout test exercising this functionality
(shift-clicking on the form's submit button) still passes, some
follow-up changes had to be made:

- The CL needed to add support for NEW_WINDOW disposition to
  content::Shell::OpenURLFromTab

- The CL needed to tweak the test to account for the fact that
  window.opener is null after opening web contents via shift-click (I've
  verified that this behavior is present for non-form-related, GET
  requests in 55.0.2883.18 so it seems to be WAI).

BUG=344348

Review-Url: https://chromiumcodereview.appspot.com/2417983002
Cr-Commit-Position: refs/heads/master@{#426876}

SpdyFramerVisitorInterface::OnControlFrameHeaderData() is never called, so all of its implementations (and related code) can be deleted.

This CL lands server change 135920024 by birenroy.

BUG=488484

Review-Url: https://chromiumcodereview.appspot.com/2438163002
Cr-Commit-Position: refs/heads/master@{#426875}

* Add RegisteredMember subclass for compiler-enforced constructor
  time registration of child Syncables.
* Integrate CompoundSyncable in sample unit tests.

R=scf@chromium.org,lethalantidote@chromium.org
CC=wez@chromium.org
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2402153002
Cr-Commit-Position: refs/heads/master@{#426874}

https://pdfium.googlesource.com/pdfium.git/+log/ef38283688c1..fd5ae3f7cf07

$ git log ef3828368..fd5ae3f7c --date=short --no-merges --format='%ad %ae %s'
2016-10-21 npm Revert of Fix loading page using hint tables. (patchset #5 id:80001 of https://codereview.chromium.org/2437773003/ )

BUG=658168,658170

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2441783004
Cr-Commit-Position: refs/heads/master@{#426873}

Match each TaskQueue to one of few hardcoded types for metric
collection.

This patch also adds metric to track number of renderer tasks per
task queue type.

BUG=

Review-Url: https://chromiumcodereview.appspot.com/2437003002
Cr-Commit-Position: refs/heads/master@{#426872}

BUG=656178

Review-Url: https://chromiumcodereview.appspot.com/2441823002
Cr-Commit-Position: refs/heads/master@{#426871}

The IO thread blob/filesystem URL security checks were originally
introduced in r419019 and r422954.  This was merged back to M54 and
M55.

They were later moved to the UI thread (into
ExtensionNavigationThrottle) in r424937 to make them compatible with
PlzNavigate.  However, that only exists in M56.

Per linked bug, we need to tighten the security check currently in M54
and M55 for apps with a "webview" permission where the problematic
blob/filesystem URL requests aren't made from the guest process.

This is the plan for fixing this:
1.  https://codereview.chromium.org/2435593007/: Reintroduce these IO
    thread checks on M56.
2.  <This CL> Tighten the checks for the scenario above using
    ChildProcessSecurityPolicy.
3.  Merge the CL from step 2 back to M55 and M54.
4.  Remove these checks from M56 and tighten the checks in
    ExtensionNavigationThrottle.

The goal of this CL is to determine if a request is being made by a
guest process on the IO thread.  It relies on the fact that
ChildProcessSecurityPolicyImpl already has the origin
"chrome-extension://<appid>" in the origin_set_ for the guest process,
thanks to the GrantOrigin that was added to
WebViewGuest::CreateWebContents in r422976 as part of fixing issue
652784.  Therefore, it's sufficient to check whether the requested
nested URL's origin is in the origin_set_ for the process making the
request.

BUG=656752

Review-Url: https://chromiumcodereview.appspot.com/2437753003
Cr-Commit-Position: refs/heads/master@{#426870}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/580029a7..834b25f6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2437293003
Cr-Commit-Position: refs/heads/master@{#426869}

This CL fixes three corner cases:
1) This CL sets the "WebAPK update" as having succeeded if:
  - the previous WebAPK update failed
  AND
  - A WebAPK update is no longer needed
  Doing this is important because the is-webapk-update-needed check is
  done much more frequently if the "previous WebAPK update failed."
2) This CL ignores whether the "WebAPK update" has previously succeeded if
   there have been no update attempts.
   The goal is to wait at least WebApkUpdateManager#FULL_CHECK_UPDATE_INTERVAL
   since the WebAPK's first launch before checking for updates.
3) This CL sets the "WebAPK update" as having failed if Chrome is killed
  after the time that the WebAPK update is requested but before
  WebApkUpdateManager#onBuiltWebApk() is called.

BUG=639536
TEST=WebApkManagerTest.*
R=dominickn, mlamouri
TBR=tedchoc (For new dependencies to chrome_junit_tests in BUILD.gn)

Review-Url: https://chromiumcodereview.appspot.com/2430773002
Cr-Commit-Position: refs/heads/master@{#426868}

This change moves the composited toolbar to the bottom of the screen
but does not change the content offsets. This causes an empty
rectangle at the top of the screen.

BUG=652892

Review-Url: https://chromiumcodereview.appspot.com/2417323002
Cr-Commit-Position: refs/heads/master@{#426867}

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG=631271
TBR=bauerb

Review-Url: https://chromiumcodereview.appspot.com/2436863005
Cr-Commit-Position: refs/heads/master@{#426866}

BUG=504347

Review-Url: https://chromiumcodereview.appspot.com/2442783002
Cr-Commit-Position: refs/heads/master@{#426865}

Skia is interested in replacing all uses of SkAutoTUnref with sk_sp and
then hiding SkAutoTUnref with the intention of removing it in the
future. This appears to be the only use of this class in Chromium
outside of Skia itself.

Review-Url: https://chromiumcodereview.appspot.com/2438643005
Cr-Commit-Position: refs/heads/master@{#426864}

When content is overlayed(eg. reader mode), enabling download is quite troublesome.
The main issue is that download may cause infobar to show up.
As a result, this CL disables download for overlay content.
Currently it only affects the download button on media controls.
Will disable other elements in later CLs if I found that they can
trigger download.
Because the media control download button uses an internal css, cannot
use distilledpage.css to hide it.

BUG=650738

Review-Url: https://chromiumcodereview.appspot.com/2394653002
Cr-Commit-Position: refs/heads/master@{#426863}

This is a follow up CL, which merges RequestImpl and Job
together.

Prev CL is here - https://chromiumcodereview.appspot.com/2299963002/

BUG=478934

Review-Url: https://chromiumcodereview.appspot.com/2430953004
Cr-Commit-Position: refs/heads/master@{#426862}

Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order.

BUG=620414, 658303

Review-Url: https://chromiumcodereview.appspot.com/2434003003
Cr-Commit-Position: refs/heads/master@{#426861}

U_LB_COUNT is assumed to be 40 in Blink line breaking code, but it's
43 in ICU 58/Unicode 9.

Three new classes (Emoji Base, Emoji Modifier, and ZWJ) should behave
identically whether or not 'word-break: break-all' is in effect.

BUG=637001
TEST=TextBreakIterator.cpp is compiled without an error with ICU 58.
R=kojii@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://chromiumcodereview.appspot.com/2440923002
Cr-Commit-Position: refs/heads/master@{#426860}

The Physical Web scanner was initially designed to run for a relatively
short duration (less than a minute) and would report any URLs seen during
this time as nearby. With this change, the scanner will keep track of how
recently a URL was seen so that URLs that are no longer nearby can be
removed from the list.

BUG=630769

Review-Url: https://chromiumcodereview.appspot.com/2413923002
Cr-Commit-Position: refs/heads/master@{#426859}

Note on matching color spaces:
*** Roughly 90% of image profiles specify sRGB.  Most
    dsts are also sRGB (and so is our default when we
    don't know the dst).  In the sRGB->sRGB case (and in
    other cases where the src and dst match), we should
    skip the xform.  QCMS checks for matching profiles,
    but the check is very weak (only works if profiles have
    the same text description).  SkColorSpace has
    a robust check for color space equality.

Performance Notes:
***Test Srcs: Averaged across 97 images pulled from the top
   10k skps.
***Test Dsts: sRGB transfer function, 2.2, other.

HP z620 Average Xform Speed-Up (QCMS / SkColorSpaceXform)
sRGB  1.51x
2.2   1.61x
Other 1.44x
(SkColorSpaceXform is actually fastest for sRGB - I just
had to drop a bunch of images from the sRGB average,
including a few that tripped up QCMS.  SkColorSpaceXform
was recognizing sRGB->sRGB was a no-op, so including these
images skewed the results in its favor - I saw like 17x)

Nexus 6P Average Xform Speed-Up (QCMS / SkColorSpaceXform)
sRGB  2.08x
2.2   1.42x
Other 3.33x
(interesting that the fallback code is actually faster than
the special cases on Arm - likely this is because the
sqrt instructions that we're using to model the curves are
slow on this platform - would be interesting to investigate
further to see if we can do better)
*** Note that turning this on for Android is left to a
    later CL.

Correctness Notes:
***QCMS (and the Skia fallback code path) use a LUT to
   convert linear floats to the dst transfer function.
   This results in a loss of accuracy since the float
   must be rounded to an int before being used as an
   index into the table.  Both Skia and QCMS do not
   interpolate the table for performance reasons.
   Skia avoids table-based implementations for two
   common cases (sRGB, 2.2), guaranteeing a result
   within 1 (on a 0-255 scale) of the "true" value.
   QCMS may be off by as much as 5 on the steep 2.2
   curve.
***There are several fairly common sRGB profiles that
   represent the transfer function as a small LUT.
   QCMS does not recognize that it is sRGB, and
   interpolates this LUT to build a larger LUT that
   it then uses.  This results in the conversion being
   off from the "true" value by as much as 9 (on a
   0-255 scale).

Other Behavior Changes:
*** More lenient approval of ICC profiles.  QCMS rejects
    xform matrices that are not "close enough to D50" by
    some arbitrary measure.  We don't have enough data to
    know that this is or isn't necessary.  QCMS also
    rejects profiles that it thinks are "too big".  Again,
    this seems reasonable, but we'll wait until we
    understand the motivation better.

What ICC profiles are supported?
***SkColorSpaceXform supports the same subset of profiles
   as QCMS.  Adding support for A2B and Lab profiles is
   a WIP (We had support for a few of these, but we've
   dropped it as part of a refactor.  The plan is to add
   it back as a part of a more logical, complete design).

How does this relate to color correct rendering for Chrome?
***This modifies the legacy path, not the color correct
   path.
***It's still somewhat interestingly related to color
   correct rendering, since the color correct renderer
   will also use SkColorSpaceXform in some cases
   (likely just to xform scary profiles into linear F16).
***It looks like the color correct rendering path will
   rely on tagged images being handled inside Skia, but
   it's worth mentioning that this change makes it simpler
   to do flexible xforms (ex: to F16) at decode time.

NO_DEPENDENCY_CHECKS=true

BUG=

Committed: https://crrev.com/8602b7fdc54d18aff914b5ddf0bba2a406078797
Review-Url: https://chromiumcodereview.appspot.com/2426723005
Cr-Original-Commit-Position: refs/heads/master@{#426588}
Cr-Commit-Position: refs/heads/master@{#426858}

on data heavy pages via the Chrome-Proxy-Accept-Transform
header.

BUG=657658

Review-Url: https://chromiumcodereview.appspot.com/2424263002
Cr-Commit-Position: refs/heads/master@{#426857}

BUG=658053

Review-Url: https://chromiumcodereview.appspot.com/2437873006
Cr-Commit-Position: refs/heads/master@{#426856}

These checks were originally introduced in r419019 and r422954.  This
was merged back to M54 and M55.

They were later moved to the UI thread (into
ExtensionNavigationThrottle) in r424937 to make them compatible with
PlzNavigate.  However, that only exists in M56.

Per linked bug, we need to tighten the security check currently in M54
and M55 for apps with a "webview" permission where the problematic
blob/filesystem URL requests aren't made from the guest process.

This is the plan for fixing this:
1.  <This CL> Reintroduce these IO thread checks on M56.
2.  https://codereview.chromium.org/2437753003: Tighten the checks for
    the scenario above using ChildProcessSecurityPolicy.
3.  Merge the CL from step 2 back to M55 and M54.
4.  Remove these checks from M56 and tighten the checks in
    ExtensionNavigationThrottle.

BUG=656752

Review-Url: https://chromiumcodereview.appspot.com/2435593007
Cr-Commit-Position: refs/heads/master@{#426855}

This allows me to skip refactoring it for mustash. It also avoids one place
where chrome calls back into ash that I would have to refactor as well.

The method just looks up a chromeos command-line switch, so inline that
lookup where needed.

In addition, clean up some of the splash screen init logic to make it more
clear how we handle primary vs. secondary displays.

BUG=none
TEST=run chrome with and without --first-exec-after-boot, watch background
colors as displays are initialized

Review-Url: https://chromiumcodereview.appspot.com/2437393002
Cr-Commit-Position: refs/heads/master@{#426854}

This is a re-land of:
https://codereview.chromium.org/2435813002/

The reland keeps a TimesHistogramSample class in LaunchMetrics
since it's still referenced in internal code. Once this lands, the
clank/ code can be updated and this class can be cleaned up.

Original CL description:

This is general-purpose functionality that allows
recording UMA metrics before the C++ native library
has been loaded and is useful to have outside of the
Chrome layer. In particular, I will be using it from
components/variations to record information about the
first run variations seed fetch.

No functional changes in this CL.

BUG=632199
TBR=bauerb@chromium.org, thestig@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2439113002
Cr-Commit-Position: refs/heads/master@{#426853}

This fixes a bug where IsIsolateExtensionsEnabled() had been called prior to the
field trials actually being initialized, so the call returned true regardless
of the finch experiment state, resulting in a possible misconfiguration of
security state.

PreCreateThreads() seems to be the earliest place in BrowserProcessImpl where we
can do this registration.

BUG=657629

Review-Url: https://chromiumcodereview.appspot.com/2438823003
Cr-Commit-Position: refs/heads/master@{#426852}

This CL takes a few steps along the way to unify compositor code
between Mus+Ash and the browser.

1. BitmapUploader uses ui::CompositorFrameSink.
2. MusBrowserCompositorOutputSurface uses
ui::CompositorFrameSink.
3. Introduces ui::Window::RequestCompositorFrameSink that replaces
RequestSurface
4. WindowSurface/ServerWindowSurface use
MojoCompositorFrameSink interface and surface.mojom is deleted.

TODO: Merge WindowSurface and WindowCompositorFrameSink.

BUG=656975
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://chromiumcodereview.appspot.com/2430653002
Cr-Commit-Position: refs/heads/master@{#426851}

Merge internal change: 136848647

BUG=555865

Review-Url: https://chromiumcodereview.appspot.com/2417183003
Cr-Commit-Position: refs/heads/master@{#426850}