- 02 Oct, 2018 40 commits
-
-
Raphael Kubo da Costa authored
Commit d1034e1e ("sensors: Make SensorProviderProxy supplement Document, not LocalFrame") tied a sensor's lifetime to a document rather than a frame, but we continued to assume Document::GetFrame() would never return null. This is not true, as evidenced by the crash reports in bug 889754, caused by SensorProxy::ShouldSuspendUpdates() trying to invoke methods on a LocalFrame that can actually be a nullptr. The original backtrace in the bug report seems to come from sensor creation, but it is easier to trigger the same crash with a focus change after destroying a sensor's document's frame. Bug: 861675, 889754 Change-Id: Idb9ed5c18a655e113e2fb76cde6615aeefcc544a Reviewed-on: https://chromium-review.googlesource.com/1256826Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#595958}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ed6f3571d8a..55b66b22475b Created with: gclient setdep -r src-internal@55b66b22475b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2a5c88f7a759cc2af9f5524b50d04efb26217561 Reviewed-on: https://chromium-review.googlesource.com/1257606Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595957}
-
Eric Orth authored
Only used when explicitly requested. The MDnsClient is created and starts listening for MDNS messages at first use in HostResolverImpl. For now supports only a basic feature set, eg we'll DCHECK if canonname is requested (in contrast to the async resolver behavior that was unnoticed until recently due to the lack of a DCHECK). Bug: 846423 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib296ac432d392baee2454587693b2537513f461c Reviewed-on: https://chromium-review.googlesource.com/1211542Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#595956}
-
Lakshmi Kumar Dabbiru authored
Bug: 852904 Change-Id: I5236586d58bea0888964c9f9babc5b1f183768d9 Reviewed-on: https://chromium-review.googlesource.com/1242395 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#595955}
-
Yue Li authored
Bug: b/113699199 Test: Manual Test Change-Id: If5915651e4a45c6ba0baf2e7c26dbe2a47f7befd Reviewed-on: https://chromium-review.googlesource.com/1255627Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#595954}
-
Kyle Milka authored
Remove flag for ntp md ui. Change the new styling to be the default and remove the md class, this mainly affects the fakebox as the icons are styled via md-icons. Bug: 864673 Change-Id: I7eb5da522a657417c527e3aa666bab14f8485bef Reviewed-on: https://chromium-review.googlesource.com/1255600Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#595953}
-
Matthew Jones authored
Previously the BottomSheetController held on to the last activity tab until a new tab was selected. This caused a memory leak if all tabs were closed. This patch clears the last active tab if that tab is destroyed. Bug: 891094 Change-Id: I84343727dba0719792e115675153c8fffba5346d Reviewed-on: https://chromium-review.googlesource.com/1256812Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#595952}
-
Vasilii Sukhanov authored
It's a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1256777 Bug: 887914 Change-Id: Ief2696c01ee3ee38e37557ecd3d6be289bbd4986 Reviewed-on: https://chromium-review.googlesource.com/1256970Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595951}
-
Xiaoqian Dai authored
TabletModeBrowserWindowDragDelegate::scrim_ has two uses: 1) to show the blurred background and 2) to work with SourceWindowAniamtionObserver to prevent the dragged window to merge back into its source window during dragging. Since now the blur effect is not needed as more, remove |scrim_| and also modify SourceWindowAnimationObserver to make it work on its own for the purpose 2). Bug: 887739 Change-Id: Ia36ab16a2715fd761ef4fcbaba11559ecdd22f72 Reviewed-on: https://chromium-review.googlesource.com/1257369Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#595950}
-
Stephen Martinis authored
Layout test results are now uploaded into a directory indicating which step name they were run as. This is to allow for without patch runs to be recorded for analytics. This CL changes rebaseline_cl to pass the step name when retrieving resuls. Bug: 882946 Change-Id: Iad18ca54cc8804fff76f059ceab49d8c69fadd3e Reviewed-on: https://chromium-review.googlesource.com/1244598 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595949}
-
Bill Orr authored
This change adds infrastructure for the browser process to submit overlays to the XR compositor on Windows, so notifications and prompts can be display in headset when necessary. This adds a concept of a runtime observer in the browser process, so Windows-specific code may hook in to know when a webpage is presenting to a headset, and when presentation has ended. This adds alpha blend support for compositing WebXR and overlays simultaneously. This change introduces VRBrowserRendererHostWin and VRBrowserRendererThreadWin, which are analogues to the Android VrShell and VrGLThread. Finally, this change introduces SimpleOverlayRendererWin, which is throwaway code to demonstrate rendering overlays and submitting them to the XR compositor. In a followup, this will be replaced with rendering through a CommandBuffer so the actual rendering happens in the GPU process. The code is not currently enabled. BUG=819448 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3c790efef66346cb36b8401237efb6ce29fa6e5e Reviewed-on: https://chromium-review.googlesource.com/1237398 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#595948}
-
Xianzhu Wang authored
A clip rect mapped through multiple transform spaces can be (1.99999, 2.00001, 10.999998, 20.000002). Previously we use ToEnclosingRect to convert it to an integral rect and will result a rect that has 1 pixel bigger in some directions, causing incorrect clipping result. Now add gfx::ToEnclosingIgnoringError to convert a near integral gfx::RectF to the nearest integral gfx::Rect. Bug: 879173 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7ab68c04f8f1efed1dfe1810b82dd24d1a41ea5 Reviewed-on: https://chromium-review.googlesource.com/1252143Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595947}
-
Jennifer Apacible authored
Change-Id: I4321d6126848c955389512b25d0de55e01debcca Reviewed-on: https://chromium-review.googlesource.com/1249570Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#595946}
-
David Black authored
Per request from UI/UX folks, the Assistant caption bar should have horizontal insets of 8dip to give more separation between the buttons and container edge. See bug for screenshots. Bug: b:115635716 Change-Id: I2edb54e50ea63bbc7a50dd15d1c962c7aa14f7a8 Reviewed-on: https://chromium-review.googlesource.com/1256363 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595945}
-
erikchen authored
This CL begins the process of removing initialization races from Blink layout tests. Prior to this CL, a newly created main_window_ used a different navigation mechanism than a reused main_window_. The latter would use a navigation with ui::PAGE_TRANSITION_LINK [with an already constructed renderer]. The former would spawn a renderer during the ui::PAGE_TRANSITION_TYPED navigation to the layout test URL. This caused races between IPCs that occur during renderer construction, and IPCs that occur as a result of loading the layout test. This CL doesn't fix these races yet -- it simply converts initialization to use the same mechanism for both cases [using ui::PAGE_TRANSITION_LINK with an already constructed renderer]. Change-Id: I5a21bfdd9a47425f1eb9579235da5ffb4fbc19f7 Bug: 889036, 889952 Reviewed-on: https://chromium-review.googlesource.com/1257683Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595944}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 748bfebd. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange" 3e89d0d3 "Revert "Implement RTCIceTransport.onselectedcandidatepairchange"" 8c84af9b "Update beacon WPTs" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25752 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If85537293268a554e41804e862f245a19c0dd349 Reviewed-on: https://chromium-review.googlesource.com/1257144 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595943}
-
Lei Zhang authored
Also remove a redundant entry for page_info_strings_grdp. BUG=397984 Change-Id: If1d5eca82ef556b0fc34cff10c189a550fffef7c Reviewed-on: https://chromium-review.googlesource.com/1255146Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595942}
-
Stephen McGruer authored
These are flaky consistently and causing trouble for dozens of CLs on the CQ. Bug: 891116 Change-Id: Ib9b82f68e9868d18f05edb59a203ee11f430c8e6 TBR=noel@chromium.org Change-Id: Ib9b82f68e9868d18f05edb59a203ee11f430c8e6 Reviewed-on: https://chromium-review.googlesource.com/1257547Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595941}
-
Nico Weber authored
Bug: 887272 Change-Id: Ia9e6ddf68f47f0dceb8616582969199a90d52912 Reviewed-on: https://chromium-review.googlesource.com/1257202Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595940}
-
Vasilii Sukhanov authored
The CL includes: - Prevent Chrome for prompting user to save passwords when not possible - Do not show manual fallback while entering password if the password store cannot save passwords - Add a metric for attempts to prompt to save passwords when it's not possible - Add a metric for PasswordStore::Init() success rate This is a continuation of https://chromium-review.googlesource.com/c/chromium/src/+/1251452 Bug: 479725 Change-Id: Ia9b3a4e5f42a1446e41676ca69b576e4fe819a61 Reviewed-on: https://chromium-review.googlesource.com/1256969Reviewed-by:Steven Holte <holte@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595939}
-
Tatiana Buldina authored
Move ExecuteGetCurrentWindowHandle() from session_commands.cc to window_commands.cc, to make use of automatic window state validation done for window commands. Bug: chromedriver:1404 Change-Id: Id5ac4c7cea5323f12612b2dfb4dff2b819ce22ff Reviewed-on: https://chromium-review.googlesource.com/1257362Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595938}
-
Carlos Knippschild authored
This is a thorough update of the presentation of offline content on the dino page to match the currently proposed design. Bug: 852872 Change-Id: I93ead161e14da48742a2791927ed813e9d431c74 Reviewed-on: https://chromium-review.googlesource.com/1232398 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595937}
-
Fredrik Söderquist authored
The test has fixed dimensions of 100x100 pixels - the reference does not. Add same fixed dimensions to the reference to get the same clipping behavior. Bug: 890755 Change-Id: Ib3d12ad1f7ace05027b81b9c683158490ae116ab Reviewed-on: https://chromium-review.googlesource.com/1256568Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#595936}
-
Primiano Tucci authored
Also make matching API changes. https://android.googlesource.com/platform/external/perfetto.git/+log/1cae4d538d01..a80f9bc11bcb git log 1cae4d538d01..a80f9bc11bcb --date=short --no-merges --format='%ad %ae %s' 2018-10-02 primiano@google.com Merge "Fix -Wdefaulted-function-deleted warning in Patch" 2018-10-02 fmayer@google.com Fix fuzzer build. 2018-10-02 fmayer@google.com Merge "Correctly handle case where sendmsg returns less than requested bytes." 2018-10-02 fmayer@google.com Merge "profiling: Add sampler." 2018-10-02 primiano@google.com Merge "Introduce support for deferred start (fast triggering)" Change-Id: If74cfdca66a9400eee48be67a8ca5e1b430ee8a2 Reviewed-on: https://chromium-review.googlesource.com/1256846 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#595935}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I055e151ab2b4f1df0c1a374d946ffbf1572f4165 Reviewed-on: https://chromium-review.googlesource.com/c/1256248 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595934}
-
Rayan Kanso authored
Adds a BackgroundFetchError which is propagated to the developer. Bug: 889401 Change-Id: Ie4505cd0f50ab263cce5d66c854094133bc3539c Reviewed-on: https://chromium-review.googlesource.com/1246102 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595933}
-
Navid Zolghadr authored
This is a partial revert of the click target calculation CL: https://chromium-review.googlesource.com/c/chromium/src/+/1161164 which puts https://crbug.com/869919 back on the table. It still keeps the wpt test though to make sure the test is there for the final desired behavior. Bug: 890711, 869919 Change-Id: I3ea000a8f62b08b7222f91d27a6957d5a94e8388 Reviewed-on: https://chromium-review.googlesource.com/1256377 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#595932}
-
Martin Kreichgauer authored
This wraps the existing CountWebAuthnCredentials and DeleteWebAuthnCredentials functions in a new interface called PlatformCredentialStore. The Touch ID implementation of the interface encapsulates the |metadata_secret| and |keychain_access_group| parameters that currently have to be fetched from the Profile and passed explicitly. This will allow us to not leak this implementation detail into the browsing data deletion code. This also moves the existing TouchIdAuthenticatorConfig struct from //content into //device/fido/mac, so that it can be passed as the ctor argument to the credential store. This is only a structural change. No functional changes intended. Change-Id: I4eda36d82c80fa13a91f5ce5e508f4a23803574f Reviewed-on: https://chromium-review.googlesource.com/1242400Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#595931}
-
Asanka Herath authored
If an authentication challenge is received by NetworkServiceClient -- implying that there were no cached credentials or ambient identity around to respond to the challenge -- the authentication request should be canceled. A typo resulted in this pending challenge being supplied an empty username and password instead. This condition applies to requests that are made in the absence of a WebContents, and those made with an associated WebContents that went away prior to the network service notified the client of the authentication challenge. Bug: 874790 Change-Id: Ib3c866d1074b2a431a5196614ac3397bf97ea132 Reviewed-on: https://chromium-review.googlesource.com/1252868Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#595930}
-
Kai Ninomiya authored
Removes exit-time destructors in gpu::webgpu::WebGPUImplementation and gpu::BufferBacking. Bug: 101600 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I611dd3dfd3d8acdd5b051743884fa1d060fdb220 Reviewed-on: https://chromium-review.googlesource.com/c/1246418 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595929}
-
Katie D authored
Change-Id: I730fa92718409b518c9d9ada04e7378f203c40bd Reviewed-on: https://chromium-review.googlesource.com/c/1257145Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#595928}
-
Varun Khaneja authored
Bug: 867518 Change-Id: Ic6f4f6db89960c3ccdeeb3d8590ace98a8545ed7 Reviewed-on: https://chromium-review.googlesource.com/c/1253061Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#595927}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:854474 Change-Id: Iae615d06e1c6fe207a889f989df5a396aed72073 Reviewed-on: https://chromium-review.googlesource.com/c/1255574Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595926}
-
Scott Violet authored
This test is flaky on the msan bot, and I suspect it could flake on the non-msan bot as well. BUG=891383 TEST=test only change Change-Id: Ib8bdc7248faab8058fb8c37a02529214cb580f91 Reviewed-on: https://chromium-review.googlesource.com/c/1256987Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595925}
-
Tarun Bansal authored
Set the network quality in the client hints to the holdback value if network quality web holdback experiment is enabled. Change-Id: Ifc6bcef11c9f980c340d4286e4472572e871f6f7 Bug: 880545 Reviewed-on: https://chromium-review.googlesource.com/c/1227684Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#595924}
-
Gang Wu authored
Copy over the files components/ntp_snippets/content_suggestions_metrics.cc components/ntp_snippets/content_suggestions_metrics.h to components/feed/core/feed_logging_metrics.cc components/feed/core/feed_logging_metrics.h Bug: 888047 Change-Id: I7f8baff84c6d23c80f1d079b6f0e33aa69c9a2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1235314Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595923}
-
Torne (Richard Coles) authored
No behaviour change intended. Using JavaRef instead of bare jobject pointers is preferred. These changes are to prepare for an upcoming refactoring. Bug: 519562 Change-Id: Iff019df737a9d3f4edae0f5ede8c068cee3443d0 Reviewed-on: https://chromium-review.googlesource.com/c/1255662 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595922}
-
Yiming Zhou authored
This change disables caching queries to the Chrome autofill server. This will induce Chrome to always use a POST request when querying the Autofill server, instead of switching between GET and POST requests depending on the request length. An unfortunate side effect of this change is that I had to recapture nearly all the sites. Also adding a number of tests. Bug: 847905 Change-Id: Id052cb4945abd177624465e9793f55c8f034c742 Reviewed-on: https://chromium-review.googlesource.com/c/1250058Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#595921}
-
Camillo Bruni authored
Add timeout before and after setting the focus. Otherwise it's quite likely that we drop one or two characters when using InputWithSelector. Bug: 878390 Change-Id: Ib703447425160eb87683143a61e03461af1795b7 Reviewed-on: https://chromium-review.googlesource.com/c/1256984Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#595920}
-
Siddhartha authored
The addresses stored on stack are used while unwinding, which could refer back to the main thread's stack. To avoid this, replace all address on the stack to point to the copied segment. Also remove SA_ONSTACK flag since it causes unnecessary stack copies while unwinding. BUG=888434 Change-Id: I063216673529893a9458ba36d120268145224521 Reviewed-on: https://chromium-review.googlesource.com/c/1256563 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#595919}
-