- 10 Jul, 2017 40 commits
-
-
scottchen authored
Currently in guest mode, there are valid routes that are not visible, which leads to odd behavior when directly visiting those routes. This CL aims to prevent those kinds of routes from being added into settings.Route during initialization. BUG=733511 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2957153003 Cr-Commit-Position: refs/heads/master@{#485353}
-
Sorin Jianu authored
The component updater can look into the BITS queue to see if a job already exist to download a given component. This stat provides an insight of whether this optimization is useful. TBR=waffles Bug: 737730 Change-Id: I56b31ad7b382197970b2dc49e8b42a7620a8e943 Reviewed-on: https://chromium-review.googlesource.com/564178Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485352}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. This patch does the latter for a call to CBUUID::UUIDString. The function was asserting that the OS version was at least 10.10, so preserve the existing behaviour by asserting false on the else branch. Bug: 735328 Change-Id: I4db8e20ebf6db7eef1ef1f63997ec2a778bc65ee Reviewed-on: https://chromium-review.googlesource.com/565027Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485351}
-
Karan Bhatia authored
r484349 added a couple of non-trivially destructible static variables, which are prohibited by the Google style guide. This CL removes the same by replacing them with static function-local variables which are leaked. BUG=739793 Change-Id: I99a6193135092568b877990034b79faf76ae290d Reviewed-on: https://chromium-review.googlesource.com/562520Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#485350}
-
Kenneth Russell authored
browser_tests depends on $root_out_dir/test_data, which is not guaranteed to be generated by that target. Other dependencies already capture the needed subdirectories in that top-level directory. WebUI browser_tests currently assert that that directory exists. As of the fix for Issue 579666, it does if the sanitizers (ASAN, MSAN, TSAN) are disabled, or if NaCl is enabled. The only reason the build is succeeding on the ASAN bot right now is that that directory is being created on behalf of the unit_tests target, which is compiled simultaneously on that machine. Fix the runtime dependency, and conditionalize the assertion in the test harness. BUG=732815 Change-Id: Ia6d64af3bb3eb88aaa45188c353ed08c5b1434e3 Reviewed-on: https://chromium-review.googlesource.com/563040Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485349}
-
Sergey Volk authored
Previously Finch trial flags were not properly propagated from the browser process to renderers and so we had to pass the flag value explicitly via IPC from browser to renderers. But Finch flag propagation has been fixed and now we can remove the explicit IPC and get the flag value from base::GetFieldTrialParamByFeatureAsBool. Bug: 740174 Change-Id: Iba3af2626362ba3cec6798794934edd69a873f46 Reviewed-on: https://chromium-review.googlesource.com/563865Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#485348}
-
James Cook authored
More go/mustash work. The page chrome://slow allows the user to turn on performance tracing. This shows an icon in the system tray that allows the user to navigate back to that page and turn the feature off. Migrate the code from SystemTrayDelegateChromeOS to SystemTrayClient and a mojo interface method to make it work with mash. Add a little test coverage for TrayTracing, which had none. Bug: 738458 Test: ash_unittests Change-Id: I15040b88534d4644c9db288ae1abb2a6b29b30cd Reviewed-on: https://chromium-review.googlesource.com/558102 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#485347}
-
Conley Owens authored
This interface should not have been named GeolocationService to begin with. Furthermore, we may have need to create an interface to provide a Geolocation, which we would want to name GeolocationService. See also: https://groups.google.com/a/chromium.org/forum/#!msg/services-dev/udWPNlGLa84/jiO0n_ORAgAJ BUG=426384 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: If0348820fa3f64d8218efab5b22c1de9f2dcbd76 Reviewed-on: https://chromium-review.googlesource.com/559939 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#485346}
-
Kevin McNee authored
This test was affected by crbug.com/731914 . Now that this has been fixed, the test passes. In the original bug filed when this was disabled ( crbug.com/440043 ), the problem was that it was timing out. There do not appear to be any timing issues now. Bug: 440043, 731914 Change-Id: I864952b1d9a2e3f95677badd8b699f8c0b641067 Reviewed-on: https://chromium-review.googlesource.com/563978Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#485345}
-
Eric Roman authored
This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I4a8c12ff5055cee4aa917aade451ec661785f005 Reviewed-on: https://chromium-review.googlesource.com/564065Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485344}
-
Toni Barzic authored
lock_screen_apps::StateController now observes power manager and closes any present lock screen app windows when device display is turned of without explicit user action (i.e. the app window will not be closed if the user changes screen brightness to 0) or if the device suspends. BUG=740236 Change-Id: If40fe8110afd05fa0f3efa8bda870c2c66104f83 Reviewed-on: https://chromium-review.googlesource.com/564148 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#485343}
-
Jun Cai authored
This is one of the CLs that refactor sensor types at //services/device/generic_sensor. This CL simply changes the following sensor types: ABSOLUTE_ORIENTATION -> ABSOLUTE_ORIENTATION_QUATERNION RELATIVE_ORIENTATION -> RELATIVE_ORIENTATION_QUATERNION The ABSOLUTE_ORIENTATION and RELATIVE_ORIENTATION sensors already return quaternion data, so only name changes are needed. Bug: 733707 Change-Id: I935a5e835e0c9f480731be806a26ce16e76dcce9 Reviewed-on: https://chromium-review.googlesource.com/552889 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
-
nednguyen authored
TBR=perezju@chromium.org, ulan@chromium.org Bug: 728152 Change-Id: I667868293666de8580b69a6387fe5c8c7a63b7fa Reviewed-on: https://chromium-review.googlesource.com/565102 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#485341}
-
Benjamin Pastene authored
This includes: components_unittests (2 shards) content_browsertests (6 shards) unit_tests (1 shard) net_unittests (3 shards) All with a 15 min timeout. Bug: 670879 Change-Id: Id35ec77b0188decb480c4e16c9cbce246a037c1d Reviewed-on: https://chromium-review.googlesource.com/564069Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#485340}
-
Eric Roman authored
This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: Idac0cec3d1eb59fedc1793e2f60f9244d0324789 Reviewed-on: https://chromium-review.googlesource.com/564074Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485339}
-
parastoog authored
for the admin area drop-down field, show admin areas' complete names rather than codes. - If available, show the names in the device's language, otherwise, show in the default language for that country. Exp: Show Quebec and not QC, and show Québec if the device's language is set to French. - If the name of the admin area for a country is not available, show the admin area code. - Change the unit-tests accordingly. BUG=691643 Review-Url: https://codereview.chromium.org/2966103002 Cr-Commit-Position: refs/heads/master@{#485338}
-
avi authored
BUG=554289 Review-Url: https://codereview.chromium.org/2972773004 Cr-Commit-Position: refs/heads/master@{#485337}
-
Brian Salomon authored
GrBackendTextureDesc is being phased out. Change-Id: Ied5e1edbe2062851ffff2290be52008ee027c3c0 Reviewed-on: https://chromium-review.googlesource.com/563716Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#485336}
-
Philip Rogers authored
This patch removes the LayerImpl references from DidUpdateScrollOffset. Instead of looking up scroll and transform property nodes with Layers, ElementId is used. The invariant now used in LayerTreeImpl::DidUpdateScrollOffset (and Layer::UpdateScrollOffset) is that a scroll node should exist or the tree should be marked as needing a rebuild which will update the scroll node; there should be no other codepaths that update scroll offset. A TODO has been added to require that a scroll node exists in all cases. Tests have been modified to ensure property trees exist before updating scroll offset. This should be true in all real cases but is not for synthetic testing scenarios. A bug has been fixed in UpdateScrollChildPosition where the scroll layer was not actually scrollable. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I75d881a0c05a6fd81ae028bdaead9481641d201f Reviewed-on: https://chromium-review.googlesource.com/560584 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485335}
-
James Cook authored
For go/mustash we have to use mojo interfaces to communicate between the ash process and chrome browser. Add a mojo method to show the dialog. Migrate code from SystemTrayDelegateChromeOS (deprecated and doesn't exist in mash) and ChromeShellClient (also doesn't exist in mash) into SessionControllerClient. This helps consolidate more session-related code into SessionControllerClient and reduce the size of SystemTrayDelegate. TBR=oshima@chromium.org Bug: 647412 Test: existing ash and chrome tests Change-Id: I1f65f43a4fe668095325ad20c8dc0c201f706321 Reviewed-on: https://chromium-review.googlesource.com/557935Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#485334}
-
Tommy C. Li authored
- Enables on Physical Web - Enables for search suggestions - Disables on all fill_into_edit fields (which shouldn't have these) Bug: 732582 Change-Id: I4828bbf37967f87578a5d48d393b7c0e312a5ecb Reviewed-on: https://chromium-review.googlesource.com/563601 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#485333}
-
Greg Kerr authored
Represents the OS version as a number in sandbox profiles, so it can be compared to with basic equality operations. BUG=689306 Change-Id: I86aca6e1f1919738d2ebcc24b7c9a1d80f9378df Reviewed-on: https://chromium-review.googlesource.com/564057 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Yuwei Huang authored
Use white status bar color to match the color of other texts. Change-Id: I56ff20106c139b9dbacdbeaad4d1b1f122bfb76c Reviewed-on: https://chromium-review.googlesource.com/564181Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#485331}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2588b89c..edde5168 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I916dc56441f562a6b126e98a5a82c40ca8eabf52 Reviewed-on: https://chromium-review.googlesource.com/565544Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485330}
-
rnephew authored
Benchmark was acidentally re-enable on android even though it is meant to be a desktop only benchmark. TBR=charliea@chromium.org Bug: 740581, 713222 Change-Id: I59548ffaa2a3a6c5528d2282f23bd16096b41f79 Reviewed-on: https://chromium-review.googlesource.com/565322Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#485329}
-
Yuwei Huang authored
For some reason this gesture makes two-finger pan not quite responsive, while the three-finger pan gesture itself often doesn't respond either. Maybe just disable it for now and see how things work. Change-Id: I015450735e6d0a4f4d671df30b97305798992af8 Reviewed-on: https://chromium-review.googlesource.com/564183Reviewed-by:
-
Benjamin Pastene authored
This includes: sql_unittests ui_touch_selection_unittests vr_common_unittests ui_android_unittests ipc_tests gpu_ipc_service_unittests gl_tests ui_base_unittests capture_unittests media_blink_unittests android_webview_unittests storage_unittests Bug: 670879 Change-Id: Ic6c975e608d440b611bdcb25b65ef038e432ebda Reviewed-on: https://chromium-review.googlesource.com/564139Reviewed-by:
-
Sadrul Habib Chowdhury authored
BUG=740527 Change-Id: Icd7be15d4b677770d5d4b4910490262d7aba7e9f Reviewed-on: https://chromium-review.googlesource.com/565540 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485326}
-
dimu authored
- modify chrome/VERSION owner file to stop VERSION updates spamming current owners Bug:739994 R=agable TBR=thakis Change-Id: Ia6474c2ae51c85d53cdc3917c7b4cb8ef8ecee3e Reviewed-on: https://chromium-review.googlesource.com/565739Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Di Mu <dimu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485325}
-
Peter Wen authored
This CL enables webp conversion for SystemWebview. For ChromeModern and Monochrome see: http://crrev.com/c/561578 ChromeModern, Monochrome, and SystemWebview apks all have min sdk version greater than 18. Thus webp is fully supported on those versions and since they are actually all API 21+, optimizations in L, M, and N will be applicable to all devices that receive those apks. This is enabled for all release builds so that if any issues crop up just a simple release build will trigger the conversion. On dev machines it is expected to add about 30 seconds to the overall build time, up to 1 minute if the machine is under load. Bug: 695482 Change-Id: Ifb27fc0d3e015da811a2635358cec336c423a41c Reviewed-on: https://chromium-review.googlesource.com/565542Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485324}
-
Theresa Wellington authored
BUG=738798 Change-Id: Ic89d30a7ed94e110553712f84b5d02c283522604 Reviewed-on: https://chromium-review.googlesource.com/565341Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#485323}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. This means that any calls to "viewDidLoad" in this code will trigger an availability warning, because that function was added to the API in 10.10. To suppress the warning, rename the function to viewDidLoadImpl and introduce a wrapper function viewDidLoad that calls viewDidLoadImpl. Bug: 735328 Change-Id: Ifcea5787d095601dd621636380770a2c8d7acb59 Reviewed-on: https://chromium-review.googlesource.com/564095 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#485322}
-
Peter Wen authored
This CL enables webp conversion for ChromeModern and Monochrome. SystemWebview will be enabled in: http://crrev.com/c/565542 ChromeModern, Monochrome, and SystemWebview apks all have min sdk version greater than 18. Thus webp is fully supported on those versions and since they are actually all API 21+, optimizations in L, M, and N will be applicable to all devices that receive those apks. This is enabled for all release builds so that if any issues crop up just a simple release build will trigger the conversion. On dev machines it is expected to add about 30 seconds to the overall build time, up to 1 minute if the machine is under load. BUG=695482 Change-Id: Ic4377b9642e09eb1c886626f7750ad00951746e7 Reviewed-on: https://chromium-review.googlesource.com/561578 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#485321}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/72646aa580ee..30c9d9b85571 $ git log 72646aa58..30c9d9b85 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 htwiggsmith Create story tag filter dom module and tests Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I40d4605a7d48e9a749c68b5996f0662299fa3560 Reviewed-on: https://chromium-review.googlesource.com/565326 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485320}
-
Robert Liao authored
On Windows, the background downloader uses the COM Global Interface Table, and Chromium requires these instances to have COM explictly initialized. Using a COM STA TaskRunner works for this case. BUG=739461 Change-Id: I28fdc54af5ec34034498d904bba648fc40c3c2f0 Reviewed-on: https://chromium-review.googlesource.com/562537Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#485319}
-
Steven Bennetts authored
If no ONC values is provided for OpenVPN.RemoteCertKU we need to set the Shill property to an empty string value. Bug: 738119 Change-Id: I3266e0c9f81fea42734e9da7d68df9e268487423 Reviewed-on: https://chromium-review.googlesource.com/558203 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Cr-Commit-Position: refs/heads/master@{#485318}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. This means that any calls to "viewDidLoad" in this code will trigger an availability warning, because that function was added to the API in 10.10. To suppress the warning, rename the function to viewDidLoadImpl and introduce a wrapper function viewDidLoad that calls viewDidLoadImpl. Bug: 735328 Change-Id: Ieb806578cc860b483fc75023fb39a7a4af171e14 Reviewed-on: https://chromium-review.googlesource.com/564209Reviewed-by:
-
Theresa Wellington authored
Changes the location bar translation X when the location bar is RTL, and uses #getLeftPositionOfLocationBarBackground() directly rather than relying on a variable. Previously the variable was set when an #onDraw() called #getLeftPositionOfLocationBarBackground(); this resulted in #updateToolbarButtonVisibility() using a stale value. BUG=740058 Change-Id: I410dd20b7ddb0ff796935e854fd4fbd17b703d37 Reviewed-on: https://chromium-review.googlesource.com/565025Reviewed-by:
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. This patch uses @available to protect references to NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification, instead of comparing its address to zero. Bug: 735328 Change-Id: If6f428da62c1486c1d608f0afe5637f9fb2f4e07 Reviewed-on: https://chromium-review.googlesource.com/564151Reviewed-by:
-
Eric Roman authored
This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I89a3c36617c1328f0e64409b341e6483815910f7 Reviewed-on: https://chromium-review.googlesource.com/564341Reviewed-by:
-
