GitLab

If a process-isolated iframe has a zero-area intersection with its
parent frame, implicit root observations should not be able to have
isIntersecting=true.

BUG=1070332
R=vmpstr@chromium.org

Change-Id: I05e8a05af14e84d493609bbc1675a28793dc1823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166605
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762875}

Adding README.md to explain the usage of enterprise folder. Also make
it to be owned by enterprise team.

Bug: 1073607
Change-Id: I13c6ff6cb9369eae12c42bd0b3ddbf166649f634
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163430Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Yann Dago <ydago@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762874}

Keep a single ImmutableWeakReference in FragmentWindowAndroid instead of
creating a new instance with every getActivity call.

This is a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/2165148

Change-Id: I11a02521ba4dfc79f99321760e0d479500b14aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166620Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762873}

CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: I2fe8fab101a10095841e39bda40d6ce6a111ad4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164895
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762872}

Speculative fix for test flakiness in issues below.

As per dcheng@'s recommendations in issue 1066456, remove
CallbackWrappers:

1) For DWriteFontProxyImpl::GetUniqueNameLookupTableIfAvailable we can
immediately return by calling the callback explicitly.

2) For DWriteFontProxyImpl::GetUniqueNameLookupTable the callback is
enqueued in DWriteFontLookupTableBuilder in a
base::DeferredSequencedTaskRunner and gets run from there or does not
during shutdown - which is as expected. No need for an extra wrapper.

Bug: 1066456
Change-Id: I21891bd3cf5db7379b9e8d366cb405e7f43e8326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164828
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762871}

This CL introduces HashTraits<T>::kCanTraceConcurrently which serves
as a whitelist for skipping the bailout in HashTable concurrent
marking.
Default is set to false. Only Member nad Persistent types are currently
set to true.

Bug: 986235
Change-Id: I6c1636a864b761b4ec0a22ae322f9754d485d887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146543
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762870}

This reverts commit a4ce688d.

Reason for revert: Actual culprit was https://chromium-review.googlesource.com/c/chromium/src/+/2167639 This CL was incorrectly chosen as the cause.

Original change's description:
> Revert "Scope WebInputEvent types to enum namespaces."
> 
> This reverts commit 61ba611f.
> 
> Reason for revert: SyntheticGestureControllerTest consistently failing on MSan bots
> 
> Original change's description:
> > Scope WebInputEvent types to enum namespaces.
> > 
> > WebInputEvent::Type and WebTouchPoint::State are adjusted in this change.
> > 
> > This allows us to alias this enumeration to a mojo defined type that
> > will come in another CL.
> > 
> > No functional changes in this CL, largely completed via sed.
> > 
> > Change-Id: I57ad12e89aeba5a0d7e780abe0c627a0e1bc3876
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160859
> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#762491}
> 
> TBR=avi@chromium.org,dtapuska@chromium.org
> 
> Bug: 1075459
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I1d16f5cdc58abcdedbc2e6a00aa14b499069dffb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166106
> Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
> Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762773}

TBR=avi@chromium.org,dtapuska@chromium.org,hendrich@chromium.org

Change-Id: I53a1b97ca93cfc0f3a9f09e458a9e065bf74a5a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1075459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167999Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762869}

Previously ftl_host_change_notification_listener_ is created in the
InitializeSignaling() method. It is only reset in GoOffline() but
GoOffline() may call InitializeSignaling() again if the signal strategy
is null, which effectively (re)creates
ftl_host_change_notification_listener_. The signal strategy will then be
freed in OnHostOfflineReasonAck(), while the notification listener will
still be kept around until HostProcess is destroyed, which causes
use-after-free since the notification listener tries to remove itself
from the signal strategy in its destructor.

This CL fixes this by moving the creation of
ftl_host_change_notification_listener_ out into StartHost(), which
prevents it from being created in GoOffline().

Bug: 1074439
Change-Id: Ifd92447d071cf4f478794999c75a26877f9b481d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165658Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762868}

This patch adds a null check since we can reach the code while we
have a null node (see referenced bug).

This is safe because if we don't have a node, we don't need to update
the style and layout tree in order to determine focusability. In other
words, there are null checks in the CanSetFocusAttribute functions
which would return false before accessing any node information.

R=aleventhal@chromium.org, chrishtr@chromium.org

Fixed: 1074711
Change-Id: I0509b63639c3e71945d9be9966f767772916af12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166416
Commit-Queue: vmpstr <vmpstr@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762867}

This CL fixes a crash due to ChromeFeatureList#isEnabled() being
called prior to native being loaded.

BUG=1074683

Change-Id: I38b6565626cea560ac2f35ef9ffd1629042c378a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167539Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762866}

Correct the process-is-valid check in NaClProcessHost teardown, which
was inverted.

Bug: 1075546
Change-Id: I15df7b084f394d1b50f6300390a6ad0e9e9044dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165742
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762865}

Fix crash that occurs when a11y is turned on for these web tests:
- editing/selection/longpress-selection-in-iframe-removed-crash.html
- editing/selection/selection-crash.html

This is part of a suite of fixes that must occur before CL:2150233
is landed, which turns on accessibility for all web tests.

Bug: None
Change-Id: I880451aaec0c6ad8f85d54b9b971bcbc5df5225d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167417
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762864}

This cross-platform behavior already exists and controls behavior in
cookie_settings.cc, so we should use it instead on iOS.

Bug: 1075534
Change-Id: I28c9cbbfb0cf5edafbe05d07ff01159bbb09120a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165740
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762863}

find-in-page previous, next, close buttons.

Test: iPad-only. Enable pointer support flag. Check hover effect on
Bug: 1073961
Change-Id: I4096ef63930a1b788c1ee56760c3150cc984b352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166413Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762862}

* Updates the visibility of the left-hand menu entry for safety check
  to respect |pageVisibility.safetyCheck| instead of
  |pageVisibility.privacy|.
* This needs to also be merged into M83.

Bug: 1015841,1075523
Change-Id: I2d2c3672b22f114b2b9e246376e370b66641c4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167857Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762861}

Since we use Clang everywhere, we should be able to use it unconditionally.
Anyone using GCC to build should be fine too.

Bug: 1031540
Change-Id: I798586f18dcc7037ca9a8229e072467b8d56b847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166189
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762860}

Change-Id: I7133100a15cefe650e90561c3fca824bc5d8bf4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167440Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762859}

- Removed waiting for ThreadPool flushes
  Not required anymore as RegexVariantResult is no longer logged
- Ignore entries of PhoneNumberPrecompileTime
  This might be logged if tests run slowly

Bug: 1068505
Change-Id: I1f426b567225dee7a259bbba1f36e52cf4e72df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165891Reviewed-by: Alex Chau <alexchau@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762858}

These strings aren't being used in WebLayer right now but will be soon,
for Page Info UI.

Bug: 1052375
Change-Id: Ic7e904346a5657e9815a704d47768f49f66488bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166162Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762857}

The recent Vulkan-ValidationLayers roll causes errors when vulkan
is enabled. workaround the problem by returning false from vulkan
error callback, and only log the error message once.

This CL also make debug callbacks return VK_FALSE, so chrome will have
same behavior with release build.

Bug: angleproject:4583
Change-Id: Iabe55dcfcf495d39be4fc4a1f42c71f07e1ad255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166631
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762856}

TBR=bling-p10-rolls@google.com

Change-Id: I51762666252a3fc5042459ca230f2f65394fc358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166495Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762855}

TBR=mxcai@chromium.org, dominickn@chromium.org

Bug: 1074596
Change-Id: I12e457f366b41b605684290e89ad3f9b149b016d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167443Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762854}

Previously, about:flags and Experimental Settings were parsed and added
to the commandline after Local State, because about:flags relies on data
that is stored in Local State. Experimental Settings has no such
dependency, and it would actually be helpful to parse Experimental
Settings before Local State, in case any of the settings happen to
affect Enterprise policy.

BUG=1073975

Change-Id: I4ce46eecc6b54ca3cf47eff3810fc08c9b9e899a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166492Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762853}

https://webrtc.googlesource.com/src.git/+log/62a0d647d9e8..b37e59d198ad

git log 62a0d647d9e8..b37e59d198ad --date=short --first-parent --format='%ad %ae %s'
2020-04-27 saza@webrtc.org Add unittests for APM with submodule creation disabled

Created with:
  gclient setdep -r src/third_party/webrtc@b37e59d198ad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ic9cf94c13fc0ed8aad0006aa66b53f0824ed636d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167936Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762852}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/992295e37d43..ebad703a32d1

git log 992295e37d43..ebad703a32d1 --date=short --first-parent --format='%ad %ae %s'
2020-04-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-04-27 mathias@chromium.org Revert "Move `UIString` into `Platform`"

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@ebad703a32d1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id71f480893d9ceacee5d2ad0ea4d80c23800962a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167935Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762851}

Audio Service is enabled by default in all platforms
and the virtual suite is no longer necessary.

Bug: 1019245
Change-Id: Ic45413150ef52df6dbf5288b217c2a4e070c8a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153051Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762850}

https://skia.googlesource.com/skia.git/+log/78debd6f6d83..81ef385c1fcd

git log 78debd6f6d83..81ef385c1fcd --date=short --first-parent --format='%ad %ae %s'
2020-04-27 michaelludwig@google.com Expand clear-as-draw workaround for Mac with Broadwell GPUs

Created with:
  gclient setdep -r src/third_party/skia@81ef385c1fcd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1039912
Tbr: ethannicholas@google.com
Change-Id: Ic020e1ccf1013c7b735ad5ba61adff63a826a215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167934Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762849}

Bug: 1072559,1072558,1072557,1072561,986235
Change-Id: Ia903b37863e4d6c5cee980446656b02c686dcf92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162867
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762848}

The in-construction bit is considered an implementation detail of the
garbage collector and should not be relied on by user objects.

ActiveScriptWrappable objects are queried by the garbage collector for
pending activities and rooted as long as there are activities pending.

Since the GC may interrupt construction of ASW objects the virtual
methods for HasPendingActivity() and potentially GetExecutionContext()
may not be called.

While ASW(Base) HasPendingActivity() may provide a default body for
HasPendingActivity() and thus work around the construction problem,
the call to GetExecutionContext() is dispatched through CRTP and there
are three different use cases:
a) GetExecutionContext() may still be pure virtual at ASW
registration (EventTarget).
b) GetExecutionContext() may already be marked as final at ASW
registration (Node)
c) GetExecutionContext() may be a regular method (users of
ExecutionContextClient)

Use case a) would require a default body for GetExecutionContext in
ASW while use case b) prohibits that. The other alternative would have
been adding
  virtual ScriptWrappable::GetExecutionContext() { return nullptr; }

Since ExecutionContext is not a concept of platform layering would be
violated. (Even though just a forward declaration would suffice.)

Bug: chromium:1056170
Change-Id: Ibf3cfb600eaa7f3e11e76579268b52689883440c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167433
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762847}

Replace calls to ChromeSigninController with IdentityManager API.

Bug: 1074064
Change-Id: Ibe17c08c7e280633b1fac4283a6a7752df911c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165345Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762846}

This CL modifies the OpenPopup (aka window.open helper) to avoid using
unchecked WaitForLoadStop(), replacing it with waiting on a
TestNavigationObserver for the specific URL being opened.

Bug: 1014186
Change-Id: Ib28f9fe251336d1e1f3a0e6326792881e13fd671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165578
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Auto-Submit: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762845}

This is dead code.

Change-Id: I587671bc66fe30fec8d597be173f1f16f35aec1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163079Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762844}

CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: Idc5667e6d660c2335cad0df813df1288d09b6929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164753
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#762843}

Previously, this would cause a null-reference:

  <template shadowroot=open>Content</template>

This is now fixed. In addition, this CL adds two more tests of
declarative shadow dom, for the two conditions listed at [1] and
[2]. The [2] condition test also tests this CL.

[1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#root-element-is-template-shadowroot
[3] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#templates-containing-root-level-declarative-shadow-roots

Bug: 1042130
Change-Id: Id697fb3f89681981ca3ecc513451d0644430fd2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166357
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762842}

[Android sheriff]
std::sort requires a sorter which satisfies the strict weak ordering.
Otherwise some tests in debug mode crash this way:
~~~
[ RUN      ] ScheduledNotificationManagerTest.DeleteNotifications
algorithm:814: _LIBCPP_ASSERT '!__comp_(__l, __r)' failed. Comparator
does not induce a strict weak ordering
[ CRASHED      ]
~~~

TBR=dtrainor@chromium.org,xingliu@chromium.org

Bug: 1075541
Change-Id: Ic160e2c6201e6bd8702f71658613ab3eb7425a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166111Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762841}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c23316f2..4bce2eef

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Icaf53c7d8bd1f288b3b08051397cb4f1803ddf8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165915Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762840}

https://android.googlesource.com/platform/external/perfetto.git/+log/713f4f709ee7..e5a041472ebe

git log 713f4f709ee7..e5a041472ebe --date=short --first-parent --format='%ad %ae %s'
2020-04-27 eseckler@google.com processor: Fix another clusterfuzz-found recursion bug in Track parsing

Created with:
  gclient setdep -r src/third_party/perfetto@e5a041472ebe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ied30b2997cd11973cbf00afd0178cdee03132ddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167933Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#762839}

https://quiche.googlesource.com/quiche.git/+log/b4810d5b775c..b67d2985293c

$ git log b4810d5b7..b67d29852 --date=short --no-merges --format='%ad %ae %s'
2020-04-24 vasilvv Split test certificates into a separate file.
2020-04-23 dschinazi Fix TlsChloExtractor move assignment operator
2020-04-23 bnc gfe-relnote: n/a, test-only change.
2020-04-23 bnc Remove undefined and unused QuicSpdyStream::set_max_uncompressed_header_bytes() declaration.
2020-04-23 quiche-dev gfe-relnote: Replace the usage of ConnectionData::encryption_level in quic_time_wait_list_manager with a new TimeWaitAction SEND_CONNECTION_CLOSE_PACKETS. Protected by gfe2_restart_flag_replace_time_wait_list_encryption_level.
2020-04-23 nharper Add quic::ProofSource::TicketCrypter interface
2020-04-23 renjietang Add EXPECT_CALLs and use NiceMock to make tls_client_handshaker_test log look cleaner.
2020-04-23 fayang gfe-relnote: In gQUIC, move dynamic stream accounting to LegacyStreamIdManager. Protected by gfe2_reloadable_flag_quic_stream_id_manager_handles_accounting.
2020-04-23 wub Update some QuicUnorderedMap to QuicHashMap.
2020-04-23 fayang gfe-relnote: In QUIC, add exponential backoff for PTO timeout when there is not RTT measurement. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
2020-04-23 wub gfe-relnote: (n/a) In QuicConfig, change some function's return value from QuicTagVector to a const reference. No behavior change, not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=bnc@chromium.org

Change-Id: I908aa9cd7269194e464c46c393a0426f2516abb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164689Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Bin Wu <wub@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762838}

Change-Id: Ib27e9405cc4c02cfdf83a6c2222f284ac57cad75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166490
Commit-Queue: Greg Daniel <egdaniel@google.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: Greg Daniel <egdaniel@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762837}

Outcomes:

- Current support for parsing COEP/COOP from the navigation response was
  only made for the network and serviceworker URLLoader. After this
  patch this is now supported universally across every URLLoader
  (AppCache, SignedExchange, ...)

- Code for supporting ServiceWorker has been removed, since this is
  already taken care by ParsedHeader.

- COOP is no more parsed in the browser process. This was the case
  previously for response served by the ServiceWorker.

Design doc:
https://docs.google.com/document/d/1WYoa6pHg8kUzynXLBlTg08X5PTESwP9M6pN1QCMIKow

Bug: 1063832
Change-Id: I6b58e756eba68465ad0f411cf91059434c7eb923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134292
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762836}