- 13 Nov, 2020 40 commits
-
-
Ted Meyer authored
Cleaning up the field trial config here: cl/341906454 Change-Id: I8082c282de63c441e5c6c8e3875f365b1f295571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535628Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#827382}
-
adoneria authored
Until the test framework is stable, run it on updater specific builders and testers. Bug: 1147588 Change-Id: Id12ce00b509b311de575103b3a3dbebc8f890c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535911Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#827381}
-
Alexander Cooper authored
The XRWebGLBinding is defined in the WebXR Layers spec (https://immersive-web.github.io/layers/); however, it is also required by both the Lighting Estimation and Raw Camera Access specs. We are not actively working on the layers spec; however, we want to Origin Trial both Lighting Estimationa nd Raw Camera Access. This change simplifies these cross-spec dependencies by shipping the empty XRWebGLBinding interface. I2S: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/6J0yfRuMmSU Bug: 1070819 Change-Id: I8626fa854d892171542cec06a0befac76187fd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519938 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#827380}
-
Filip Gorski authored
Moves OSDDelegate into OmniboxSuggestionsDropdown (patchset 1) and flattens things out to a single class (patchset 2). Bug: 1075602 Change-Id: I71322c03538879ba1bac587f24c590f28813e14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530954Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#827379}
-
Leonard Grey authored
Adds commands for opening bookmarks: - A composite command labeled "Open Bookmarks..." that allows searching bookmarks when selected. - If user input is "long enough" (currently two characters, will be tuned), "noun first" bookmarks will begin to surface at top level. Bug: 1014639 Change-Id: I910e9ba4992e7705cce2f8c5e23104c8ba6f408e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535677Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827378}
-
Mason Freed authored
The getInnerHTML API is relatively new, and was not added to the ShadowRoot object. This CL fixes that gap, and adds testing for both getInnerHTML and setInnerHTML on ShadowRoot. Bug: 1042130 Change-Id: Ibae20d7c0e9f44b92932499234e493ba798e06b0 Fixed: 1147752 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536372 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#827377}
-
Roman Arora authored
Reverting the use of afterNextRender in favor for setTimeout causing the Tab Search bubble to not show consistently on Mac. Bug: 1148767 Change-Id: I69157b7b9c7eabbe9e73d36f177f226fdb31c795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537921Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#827376}
-
Gayane Petrosyan authored
1. Reset range counters when new generation is requested. 2. Use ranges when selection starts and ends in the same block which has nested block 3. Fix crash when selection starts or ends with a non text node which has children. Crash is because using length of text content to find last position is incorrect when there are nested children. We should use Position::LastPositionInNode(*node) instead. Bug: 1129650 Change-Id: I13e305f67c28aca7643903f96e258be8fbf8e9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533123 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827375}
-
Leonard Grey authored
The original design for this was that when the user selected a composite command, a specialized CommanderBackend object was created, and CommanderController would delegate to it to allow the user to enter details. In practice the impedance was wrong. We need extra information for the composite command (how to prompt the user), *don't* need a lot of other things in the CommanderBackend interface, need to duplicate logic re: command execution and risk lifetime issues with nested composite commands. In this change, composite commands are represented by a pair of prompt text and a lambda with a signature similar to CommandSource::GetCommands. All other logic is is handled by the controller. For a worked example, see the dependent CL https://chromium-review.googlesource.com/c/chromium/src/+/2535677 Bug: 1014639 Change-Id: I07c172584afcf4288a460362099dbd73b412daa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536050Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827374}
-
Patrick Monette authored
Bug: 971272 Change-Id: I1fd11d59ede2883b06a7a4104947419676323810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521950 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#827373}
-
Peter Kotwicz authored
This CL adds com.google.guava:guava:25.1-android to //third_party/android_deps/build.gradle and makes Chromium code use the new target. BUG=1144019 Change-Id: I680ea49ae986aa33766716cae6d883b9adaa1253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519762Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#827372}
-
Darwin Huang authored
Make ClipboardWriter keep FileReaderLoader alive until it's done reading a Blob, by using SelfKeepAlive<T>. Previously, ClipboardWriter could be garbage collected unexpectedly (ex. when the frame detaches). This could cause a use after poison in the FileReaderLoader, where: (1) A ClipboardWriter's FileReaderLoader starts reading the input blob as an async task. (2) The ClipboardWriter is destroyed (garbage collected). (3) The FileReaderLoader completes its async task of reading the input blob, and calls ClipboardWriter::StartWrite on the destroyed, owning ClipboardWriter. Additionally, add a "context destroyed" error message when a context detaches. Bug: 1142331 Change-Id: I427cd6dc02e773b2d235d45bd9ad8935b575ff71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509033 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827371}
-
Yicheng Li authored
The platform side may want to close the in-session auth dialog (for example in WebAuthn when the browser issues a timeout). Expose a DBus API for dismissing the dialog. This will have the same effect as if the user clicks the Cancel button. Change-Id: I9ab2456967d08c382302ee528b0aa6cc2a0d01c5 Bug: b/167574666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499180Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#827370}
-
Mason Freed authored
This convers the prior DCHECKs to CHECKs, and adds a more informative comment in case these are hit. To be left in for ~2 weeks just to be sure. Bug: 937746 Change-Id: I40e5da27815c9156d0d26a22d89909b8de4665d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538045 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827369}
-
Jeroen Dhollander authored
This service does not own/do anything right now, but it runs on the background thread and will be fleshed out in the (many) follow up CLs. Bug: b/171748795 Test: chromeos_unittest --gtest_filter="AssistantManagerServiceTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ica3d227a223ea9678b5a6a0e29580907835956dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518254Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827368}
-
Tommy Martino authored
This feature is launching to 95% soon. Enabling by default; cleanup CLs to remove the flag will follow once that reaches 100%. Bug: 1098328 Change-Id: Iac5c5aa8ba592c6785af0f5b1c1be4f6ea0303c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535876Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#827367}
-
Alexander Surkov authored
formatter Keep tree formatters generic: command line setup is used for testing only and thus the logic should be moved to where appropriate. DumpTestHelper class already handles all test related logic, thus move command line setup logic there Bug: 1133330 Change-Id: I330788c1b263447f4882f92dbce5c62581a6352e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533905 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#827366}
-
Julian Pastarmov authored
This is a reland of b53e31ad Original change's description: > Merge old and new list policies that were renamed > > This change moves migrating of renamed policies from the PolicyHandler > to a PolicyMigrator that happens right after the PolicyMerger has run. > This guarantees that list policies can be properly merged between > sources even if different sources provide different naming. > > BUG=1138572 > TEST=browser_tests:PolicyPrefsTest.PolicyToPrefsMapping > > Change-Id: Ibe335176ef52dabbe09c076ba57ae04d1c67c1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507771 > Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Yann Dago <ydago@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826903} Bug: 1138572 Change-Id: I410d65abdbcf81a07ca578bec619fcbcd933fce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536880Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827365}
-
chinsenj authored
This CL adds metrics for counting the number of consecutive screenshots a user takes. Visit go/capture-mode-metrics to see other planned metrics. Test: manual + added Bug: 1140182 Change-Id: Ic1b39e3601fd890ad42b9d9e18678b60793cd7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532997 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#827364}
-
David Roger authored
This is a reland of CL 2523185 Patch Set 1 is the version that was reverted. The flaky test has been moved to password_manager_interactive_uitest.cc Bug: 1076880 Fixed: 1147433 Change-Id: If419787c95fbc740e5fc825a222576a9abf4e716 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532563 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827363}
-
Fredrik Söderqvist authored
At this point we will have resolved the type and any CSS property that 'attributeName' maps to, so we can use the (stricter) test IsAnimatingCSSProperty() instead of IsTargetAttributeCSSProperty(). Similarly we can drop the AnyQName() test because it shouldn't map to a proper type/CSS property. Remove IsTargetAttributeCSSProperty() since it is now unused. Bug: 1017723 Change-Id: I12d231718b335e1c21cff98247fe4869fd3232c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537837Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#827362}
-
Thomas Tellier authored
Bug: 1104336 Change-Id: I7da10e535330b0f583d9998b334e41061fe0cd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536437Reviewed-by:
Thomas Tellier <tellier@google.com> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#827361}
-
Mohamed Adel authored
Add metrics for: Notification Permission Level: enabled/disabled Notification Display Style: alerts/banners Bug: 1148276 Change-Id: Icafd8859fa975d2207e047232f403859fc670a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532566 Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#827360}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ea4e9a46. With Chromium commits locally applied on WPT: 4a941689 "Add WPT and fix logic for XRWebGlBinding constructor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I9f5825c8f8b3957e6ec5a8033fd96d34ef18826b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538012Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827359}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c43088c6dc01..f46e6201b40b 2020-11-13 jmadill@chromium.org Revert "Roll glslang from 142cb87f803d to beec2e4a7c4d (12 revisions)" 2020-11-13 cnorthrop@google.com Tests: Add Real Commando Secret Mission trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_perftests --gtest_filter="*real_commando_secret_mission*" Change-Id: I2671838524c0a2e055ffab6f46c8f3940e87a225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827358}
-
minch authored
See doc linked at the crbug for the details. Bug: 1134809 Change-Id: Ie001e5ec75729ac61f5f5ffd10e8289982151733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536754Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#827357}
-
Nina Satragno authored
Remove an old TODO that no longer applies. Change-Id: Ib17cc59de2d4a38a31e5d9dce0eafa09687f7af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532885 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#827356}
-
minch authored
Bug: 1145363 Change-Id: Ia1d5a051aa2da436855b5891923a8b091d2039a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537592Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#827355}
-
Yicheng Li authored
These adjustments have been approved in UXImpl review so they are final. Bug: b:156258540, b:144861739 Change-Id: Iaa65c359304a406df0630da853a0e0cfe6a3302e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538151Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#827354}
-
Morten Stenshorne authored
We got rid of this for block break tokens a long time ago, but it had to be kept for inline break tokens, for one reason only: to keep a vector in the fragment builder whose size would correspond with the number of lines added. This was needed for orphans / widows support. Let's just count the lines added instead. Rather than creating a "finished" break token, just don't create a break token at all for fragments whose node didn't break. No behavior changes intended. Change-Id: I880a1d2fafb7d72a9c885013793520781c7308fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534910 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#827353}
-
Ian Kilpatrick authored
It's time to retire this flag, (primarily it is the easiest to remove to make room for the StretchBlockSizeIfAuto() bit). There should be no correctness change, potentially a slight performance change to querying baselines from tables for example. Change-Id: I6f12e9016d2c2475009a19859ce50324617d15ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491977 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827352}
-
Filip Gorski authored
TBR=yfriedman@chromium.org Bug: 1147922 Change-Id: I44024e289ce4691bef9ba037954c3b66f47884d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536449Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Joshua Peraza <jperaza@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#827351}
-
Chris Sharp authored
Updated the following policies: DeviceAllowRedeemChromeOsRegistrationOffers DeviceQuirksDownloadEnabled DeviceShowLowDiskSpaceNotification DNSInterceptionChecksEnabled ExternalProtocolDialogShowAlwaysOpenCheckbox LocalDiscoveryEnabled NtlmV2Enabled NTPContentSuggestionsEnabled Also added a default value for ExternalProtocolDialogShowAlwaysOpenCheckbox Bug: 1139306 Change-Id: Ieee92a5c66291ea3f64203e56a63c62aae283bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521304Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#827350}
-
Jacob Kopczynski authored
Bug: chromium:1127088 Change-Id: I8a65d433deb00a4d56bdef3775a70176aec5e336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535998 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#827349}
-
Garrett Beaty authored
Bug: 1148845 Change-Id: I130de84b651b361cb7893c79b916123220a915be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537153Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#827348}
-
kylechar authored
This reverts commit c6f4b552. Reason for revert: Remove diagnostic check. Original change's description: > Add diagnostic CHECKs for deserialization error. > > A crash has been traced back to a deserialization error on the > viz.mojom.FrameSinkManager RegisterFrameSinkHierarchy IPC. Add some > CHECKs to identify the root cause of bad FrameSinkId(s) being sent. > > Bug: 1115094 > Change-Id: Ie8aaf54bdddfb6d649b1386ac62edfb0df639cff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403581 > Reviewed-by: Jonathan Backer <backer@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805836} TBR=backer@chromium.org,kylechar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115094 Change-Id: I747cdb08bcb28fcd8e5f7cebee4c0d976c72c164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537578Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827347}
-
David Maunder authored
This was determined to be necessary in cl/342061697 Bug: 1148823 Change-Id: I125e177fa057e6aebd92a0750559e4a68940c312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537699Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#827346}
-
Ian Kilpatrick authored
This patch "flips" the meaning of the NGConstraintSpace::IsShrinkToFit bit, instead naming it NGConstraintSpace::StretchInlineSizeIfAuto. This is in preparation for a similar API in the block-direction: NGConstraintSpace::StretchBlockSizeIfAuto, which is needed for GridNG. See: https://chromium-review.googlesource.com/c/chromium/src/+/2523743 This may also simplify the flex layout algorithm (as we'll have the ability to natively "stretch" in both directions, instead of setting a fixed block-size). By default all layouts will now shrink-to-fit, and we'll need to explicitly stretch if desired (the default for block-layout for example). There should be no behaviour change. Bug: 1045599 Change-Id: If41aac74ae2829fd13046a0e11be6553fe80a448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513771 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#827345}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bee6408d7b67..4543697b3755 2020-11-13 gustaf@webrtc.org Set range of GetLinearAecOutput to [-1, 1] If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia838a3ec92d2ddf2c9179da8b7839a48f89e3b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827344}
-
Mason Wilde authored
Making this field required led to issues with test devices. This changes it to optional like many other fields. Bug: chromium:1146143 Change-Id: Ie0bdfe38462aef987021c42eec20749255d5ddf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536150Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mason Wilde <masonwilde@google.com> Cr-Commit-Position: refs/heads/master@{#827343}
-