GitLab

TaskScheduler: Move Sequence::traits() behind lock and add non-lock-protected shutdown_behavior() accessor

Bug: 889029
Change-Id: I045aea22fb8d5a32fee3e3bd64c0b091c9336dd3
Reviewed-on: https://chromium-review.googlesource.com/c/1343178
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610241}

Test computed values for various properties from
- css-animations
- css-shapes
- css-transitions
- css-ui
- css-writing-modes
- filter-effects

Change-Id: Iad28fe2030f922bdcaa80d6ade383c69106b8822
Reviewed-on: https://chromium-review.googlesource.com/c/1345955
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610240}

Bug: 907308
Change-Id: I472fdf61148d8f023a4b670d041593d3455c9f9f
Reviewed-on: https://chromium-review.googlesource.com/c/1347048Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610239}

This is a step in multistep refactoring. The next steps will be:

1.) web::NavigationContext::URL is never set to placeholder
    URL and always represents navigation URL
2.) Same web::NavigationContext will be reused for placeholder
    navigation to extend it's lifetime.
3.) WebStateObserver::DidFinishNavigation will be caller after
    placeholder navigation is finished and will use original
    web::NavigationContext passed to WebStateObserver::DidStartNavigation

This will partially fix crbug.com/903497 and will call
WebStateObserver::DidFinishNavigation after committed URL actually
changed.

Originally Reviewed-on: https://chromium-review.googlesource.com/c/1331044

Bug: 903497
Change-Id: I0ee2ecdfb4d20d2f14fd62e99028e8de1b81ff3b
Reviewed-on: https://chromium-review.googlesource.com/c/1347212Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610238}

This CL patched another CL by jsaul@
https://chromium-review.googlesource.com/c/chromium/src/+/1334834

1) Added No thanks button as required by legal.
2) Changed the title to better explain its usage.

Uploaded screenshot in the bug comment#4.

Bug: 905393
Change-Id: Idc6e2e89a9cad9d4f5530ea4d4a1b2731feeff5e
Reviewed-on: https://chromium-review.googlesource.com/c/1343281Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610237}

1) Avoid using std::string as a container for non-string data. The problem
   is that the underlying std::string buffer is bigger than the data we put
   inside (at least by 1 byte (null terminator), and might be even bigger).
   This may hide buffer overflow errors from ASan.

2) Make FuzzedDataProvider portable (remove //base dependency).

3) Make the types it returns more explicit (e.g. `int32_t` instead of `int`).

Bug: 907103, 906080
Change-Id: Ibe1cd5ef6cb72140459a8ba3ac301f8c2bef48b9
Reviewed-on: https://chromium-review.googlesource.com/c/1344993
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610236}

Specifics:
       +62,440 bytes main lib size
      +467,552 bytes main dex size
      +745,805 bytes normalized apk size
InstallSize:
      +280,953 bytes APK size
      +827,989 bytes Estimated installed size (Android Go)
    +2,169,863 bytes Estimated installed size
InstallBreakdown (+2,168,374 bytes):
        +2,700 bytes unwind_cfi (dev and canary only) size
        +2,146 bytes Non-compiled Android resources size
       +62,440 bytes Native code size
          +353 bytes Package metadata size
    +2,086,323 bytes Java code size
       +14,412 bytes Compiled Android resources size
Dex:
        +2,396 entries fields
        +3,284 entries methods
          +772 entries types
        +1,681 entries strings

Change-Id: I173abfb7ba5c75d10ade40de047b7f0bba257763
Reviewed-on: https://chromium-review.googlesource.com/c/1344292Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610235}

Thumbnails have been deprecated as of M69. Removing the multi-iframe
thumbnails used in third-party NTPs.

Bug: 893362
Change-Id: I6dbc1ddf8a204d9661f437bb0b0db30888ec48dd
Reviewed-on: https://chromium-review.googlesource.com/c/1324449
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610234}

Add seek backwards and forwards buttons to the media
notification.

BUG=893296

Change-Id: If4a0263295e0b824a78f214e63a9747ba89db4c9
Reviewed-on: https://chromium-review.googlesource.com/c/1306734
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610233}

The goal is to make Mobile network status be more apparent
to the user, even when WiFi or Ethernet network is connected.

To do this we now have independent tray network icons. One
Tracks Wi-Fi, the other Mobile network state.

This cl adds different rendering strategies for network
icons in the system tray.

In the future we may also want to allow Tethering icon to be
displayed on its own. We can add a new strategy when the spec
is ready.

Feature is developed behind feature flag 'SeparateNetworkIcons'.

Bug: 902409
Change-Id: I878aa4fbe02676bd235eba60979155fb57207175
Reviewed-on: https://chromium-review.googlesource.com/c/1340807
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO till 11/26) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610232}

This CL makes using ReleaseSoon with scpoed_refptr easier. It
encapsulates the call to AddRef, and forces the uses to use std::move
when calling ReleaseSoon with a scoped_refptr. Both are required to make
ReleaseSoon run safely (and correctly), but it isn't obvious that they
are needed.

An example of its use is included with this CL.

Bug: 900010
Change-Id: Ic1de31d0433ffeee52d98b630cafe643c223ed18
Reviewed-on: https://chromium-review.googlesource.com/c/1306639
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610231}

Bothing ScriptingPermissionsModifier and PermissionsAPI unittests
convert URLPatternSets to strings for easy comparison (using gmock
utilities). Extract this functionality into a shared method in
permissions_test_util.

Bug: None
Change-Id: I54f681bc69d87c4ba20c8b2973159ef671f1bbe0
Reviewed-on: https://chromium-review.googlesource.com/c/1347100Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610230}

Record the number of users who enabled/disabled Assistant service on their
devices, the sum would be the number of all eligible users. Note that
we simply report this metrics with every UMA upload and should only depend
on unique users count to take advantage of the de-dupe logic implemented
on the server-side. Ignore potential reboot or crash for now.

Test: local compile and manually test.
Bug: b:117518834
Change-Id: I5cee656db986f60104999502b4feebb8d072c79f
Reviewed-on: https://chromium-review.googlesource.com/c/1292111
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610229}

Removes three sources of flakiness in the existing VR RenderTest:
1. Switches the test page to a blank one, as the text on the original
   one sometimes resulted in several pixels being different due to AA.
2. Removes the flaky sleep while waiting for the permission prompt to
   appear in favor of a new waitForUiQuiescence.
3. Ensures that the UI is quiescent after accepting the permission
   before dumping the second image.

Also drive-by changes several methods in NativeUiUtils to try/catch
the call that throws an InterruptedException to make it less annoying
to chain multiple actions together.

Bug: 904012
Change-Id: Ic25432c947adeeba210c6c63b355a53c5c63ef14
Reviewed-on: https://chromium-review.googlesource.com/c/1344905Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610228}

HardwareDisplayController::GetRefreshInterval() was using the integer
rounded refresh rate instead of a float value. The rounded refresh was
used to construct PresentationFeedback, which ultimately gets used to
set the begin frame and exo vsync interval. On veyron_minnie this
changed the interval from 16819us to 16666us incorrectly.

Bug: 907625
Change-Id: I0e7a2a776cdadfa0bb99b67735ab93beb90a0f63
Reviewed-on: https://chromium-review.googlesource.com/c/1347444Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610227}

Bug: 833687
Change-Id: I45108654865ccdfe7b1570c93f86b4c9676942c6
Reviewed-on: https://chromium-review.googlesource.com/c/1343059
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610226}

If a notification title is between 22 and 26 characters long, it might
get truncated in the view. This is because we calculate different line
counts for a title in the layout and draw phases.
This is related to crbug.com/682266.

Instead of relying on the layout phase, we now just set a wider
right-border on the first element in the view, to make space for the
control buttons.

Bug: 785589
Change-Id: I4c6e157d732065224612766dbe02a3f21f377b2f
Reviewed-on: https://chromium-review.googlesource.com/c/1341924
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610225}

https://webrtc.googlesource.com/src.git/+log/8da7b350cf93..5eae1d994e20


git log 8da7b350cf93..5eae1d994e20 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 Peter) Slatala Remove legacy SetTargetTransferRateObserver
2018-11-21 Peter) Slatala Add check for media transport and bundle policy
2018-11-21 Peter) Slatala Create 'MaybeCreateMediaTransport' function
2018-11-21 sakal@webrtc.org Add sakal@ to OWNERS in android tests / aarproject directories.
2018-11-21 kron@webrtc.org Move HdrMetadata to ColorSpace
2018-11-21 alessiob@webrtc.org AGC2 adaptive digital: remove unnecessary flag.


Created with:
  gclient setdep -r src/third_party/webrtc@5eae1d994e20

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8cba4140f98d3698aa8f895567586561f54042a3
Reviewed-on: https://chromium-review.googlesource.com/c/1347030Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610224}

Updating capabilities returned from New Session command for W3C spec
compliance. Change verified by Web Platform Tests (13 additional
new_session tests passed).

Bug: chromedriver:1997
Change-Id: I7683acb33cbf2739a867787ba2a3fedd28be32c5
Reviewed-on: https://chromium-review.googlesource.com/c/1347065
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610223}

To support legacy Smart Lock hosts which did not mark themselves as
supporting EASY_UNLOCK_HOST (because they couldn't have), simply
ignore lack of a kSupported bit if kEnabled is present, and set the
host device as an enabled Smart Lock host.

Bug: 896082
Change-Id: Id8fb1ade25113fcb108a7658738e7bf9e0c996a0
Reviewed-on: https://chromium-review.googlesource.com/c/1345123Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610222}

This CL corrects the metrics in PLM which are thrown off by the
restarting of navigations for this preview type. In order to serve this
preview, we cancel and then posttask a new navigation to our own server.
This causes PLM to loose track of the original navigation start time.

To correct this, I've added functionality to PLM that accepts a
TimeDelta penalty that will be added to all metrics once the page load
completes.

Persisting the original navigation start time is done by copying a
ServerLitePageInfo struct between navigations and which lives on
PreviewsUserData during navigation and page load.

Bug: 874150
Change-Id: Ib31d1694ecdbd310f975a431f76a76c7e47774d7
Reviewed-on: https://chromium-review.googlesource.com/c/1334944Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610221}

Bug: 901345
Change-Id: I3fb2bcdab9a61fc818da6a4cc6439635f9421b31
Reviewed-on: https://chromium-review.googlesource.com/c/1346834Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610220}

Adds the "Inspect Elements" (Ctrl-Shift-C, Mac: Cmd-Alt-C)
to X11's main menu and Mac's developer menu. This matches
locations for "Javascript Console" (Ctrl-Shift-J).

Screenshot: https://imgur.com/a/jOFOmTn

TBR=cpu@chromium.org

Bug: 881534
Change-Id: Id17b9ca123ebc54c8e753ec25f31604ab3248f3d
Reviewed-on: https://chromium-review.googlesource.com/c/1343513Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610219}

The original change at r608013 caused WebUI regressions, some of which are
unclear on how to fix because of a separate issue with tabindex -1 and Custom
Elements, https://github.com/w3c/webcomponents/issues/774.

Need to address WebUI affected cases, before the flag is re-enabled by defalut.

Bug: 907284
Change-Id: Ie8a41df1df663d25cf06a0ed6ae42ac80512df0c
Reviewed-on: https://chromium-review.googlesource.com/c/1347429
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610218}

Credit to digit@ who supplied much of this change via a reference CL.

Rather than including one of two static linker scripts, generate the
desired script instead.  This allows an arbitrary list of additional
exported methods to be supplied if desired.

BUG=874587

Change-Id: I88eb0469dfb764bf910b8c3fe76fd4ed2c91c1e4
Reviewed-on: https://chromium-review.googlesource.com/c/1338141
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610217}

(writing-mode has nothing to do with it, FWIW)

Legacy layout is buggy here, so the expected rendering was wrong. Also
wrote a new wpt test for this. When calculating quirky line height, the
legacy engine makes room for whitespace that is to be collapsed.

Bug: 845902
Change-Id: I004d024578bb147d4f70c58fc1e3213a14174fd7
Reviewed-on: https://chromium-review.googlesource.com/c/1346465Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610216}

https://chromium.googlesource.com/chromium/buildtools.git/+log/da9b2941cbf6..04161ec8d7c7

$ git log da9b2941c..04161ec8d --date=short --no-merges --format='%ad %ae %s'
2018-11-21 thakis Roll gn to version 1496 (0790d304).

Created with:
  roll-dep src/buildtools

Bug: none
Change-Id: Iddc4c9ad79f28d024b32c41162e0df7b2a7cd1f7
Reviewed-on: https://chromium-review.googlesource.com/c/1347335Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610215}

This reverts commit a404b85a.

Reason for revert: Suspected cause of crbug.com/906242

Original change's description:
> [omnibox metrics] Copy new keyword information into log
> 
> We added new fields to the Omnibox event protobuf regarding keyword
> mode. This CL copies the new relevant information from a set of
> suggestions into that protobuf. Also adds new boolean field to a
> suggestion.
> 
> Bug: 837395
> Change-Id: I496d5235790a3c3cd1744155fe766b134a366fd5
> Reviewed-on: https://chromium-review.googlesource.com/c/1312930
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Kevin Bailey <krb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608528}

TBR=mpearson@chromium.org,krb@chromium.org,tedchoc@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837395
Change-Id: I9c4a39a1d3104a65796d43b31233cc36647f586c
Reviewed-on: https://chromium-review.googlesource.com/c/1347031Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610214}

Change-Id: I2fdd1e141a177ff9433b9cdc785bf8d4fd2afadc
Reviewed-on: https://chromium-review.googlesource.com/c/1347169
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610213}

Bug: 591099

Change-Id: I68874c4c0d099d8896ecc437730e48d12444d5a5
Reviewed-on: https://chromium-review.googlesource.com/c/1344950Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610212}

Original change's description:
> MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the
> BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only
> External Clear Key CDM to store the license in the file system, if it is
> available.

This reverts commit e9fc38c7.

The original CL was flaky due to Mac's only saving file timestamps to
second granularity. As a result it was possible for the newly created license
to be saved with a timestamp prior to the current actual time, and deleting
"old" licenses would include it in the deletion. Change is to wait for some
time on Macs only to ensure that the "new" license has a later timestamp.

BUG=808690,879812
TEST=new browser_tests pass

Change-Id: Ibd7cf65b468f98af9aa583d3f320e54c8f3f223e
Reviewed-on: https://chromium-review.googlesource.com/c/1345248Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610211}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a85a4b01ee72..d66dad7fc2c3


git log a85a4b01ee72..d66dad7fc2c3 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 iannucci@chromium.org [vpython] Re-roll to pick up user differentiation of cached envs


Created with:
  gclient setdep -r src/third_party/depot_tools@d66dad7fc2c3

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:869227
TBR=agable@chromium.org

Change-Id: I536a4155d4cc66aa1ab8928eaa385eeab070effd
Reviewed-on: https://chromium-review.googlesource.com/c/1347073Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610210}

Move ScopedAccessibilityFocus from ui/views/cocoa to ui/base/cocoa,
because it is going to be used by content/ (which, for the moment,
does not depends on ui/views, though I would like to add an explicit
dependency at some point).

Rename ScopedAccessibilityFocus to AccessibilityFocusOverrider, and
- make it track
  - whether or not the view it represents if the first responder for
    its window
  - whether or not its window is key
- override -[NSApplication accessibilityFocusedUIElement] only when
  both of those conditions are true

Apply this scheme to the two main NSViews
- BridgedContentView uses an AccessibilityFocusOverrider in
  BridgedNativeWidgetHostImpl
- RenderWidgetHostViewCocoa uses an AccessibilityFocusOverrider in
  RenderWidgetHostViewMac

Change slightly the way that NSWindow key status is tracked between
RenderWidgetHostViewCocoa/Mac.
- These changes were only send to the browser when the view was also
  first responder
- Change this to always send changes in key status, and early-out
  when the view is not first responder on the browser side.

Bug: 900846
Change-Id: I15bb144ae4570eeffa51c4609f58aa8b58b892d9
Reviewed-on: https://chromium-review.googlesource.com/c/1345121Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610209}

getDisplayMedia() allows capturing user's display content. Before launching this
feature, we want to add a kill switch that can be set from server side in case
there exists some use case that causes security or privacy problems.

Bug: 326740
Change-Id: I34cf0cb412c599712fa10b0beb40b18404cf0440
Reviewed-on: https://chromium-review.googlesource.com/c/1313192
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610208}

At the time of page load, navigation predictor may take some
action (such as prefetch). This CL records metrics
around the accuracy of the action taken.

Bug: 903945
Change-Id: Id4bea8b7e7aec1f017e070213438b20905f1d96c
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1338944Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610207}

Two private methods in BVC take in a WebState as an argument.
They call the TabHelper to get the corresponding Tab, then never use
the Tab reference.
This CL removes these unnecessary references to Tab.

Change-Id: Ie5be3d4600fafe9bd4777ece6717eb67525e8c30
Reviewed-on: https://chromium-review.googlesource.com/c/1344835Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610206}

https://skia.googlesource.com/skia.git/+log/9a370396f131..ea02708e078c


git log 9a370396f131..ea02708e078c --date=short --no-merges --format='%ad %ae %s'
2018-11-21 bsalomon@google.com Add SK_API to SkCanvas::ImageSetEntry to fix Chrome roll
2018-11-21 mtklein@google.com move NEON matrixProcs into matrixProcs.cpp
2018-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 836674c28b1e..6aab06e0e5d4 (1 commits)
2018-11-21 reed@google.com add flag to flutter
2018-11-21 bsalomon@google.com Make experimental_drawImageSet support per-quad alpha.
2018-11-21 reed@google.com Revert "Revert "add rect-parameter to makeImageSnapshot""
2018-11-21 brianosman@google.com Revert "Prefer GrAAConvexPathRenderer over ccpr"


Created with:
  gclient setdep -r src/third_party/skia@ea02708e078c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:860021
TBR=csmartdalton@chromium.org

Change-Id: I7af4b53a6c7a2fc462253becdd305574608f60a5
Reviewed-on: https://chromium-review.googlesource.com/c/1347072Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610205}

Actually made it into a method instead since I felt asking a
CWVAutofillSuggestion for its property passwordSuggestion is kind of
confusing. As a method I think it's more clear.

Change-Id: I3eb32cfff01236f099dcda720a812bdaa0f78c20
Reviewed-on: https://chromium-review.googlesource.com/c/1347101
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610204}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a285cdeb4d1a..eacc22d07da8


Created with:
  gclient setdep -r src-internal@eacc22d07da8

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iedc32bf4232895898de5aa2f3754f6fa96d7727c
Reviewed-on: https://chromium-review.googlesource.com/c/1347106Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610203}

The App Registry is discussed in chrome/services/app_service/README.md.

BUG=826982

Change-Id: If914f4237b6a42c2b212225be280218b69d676b3
Reviewed-on: https://chromium-review.googlesource.com/c/1338590Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610202}