- 17 Jul, 2018 40 commits
-
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4597e0c46fc5..dbdb3a00797d git log 4597e0c46fc5..dbdb3a00797d --date=short --no-merges --format='%ad %ae %s' 2018-07-17 stefan@webrtc.org Refactoring PayloadRouter. 2018-07-17 yinwa@webrtc.org Implement congestion window direct pushback to encoders. (Without TaskQueue) 2018-07-17 buildbot@webrtc.org Roll chromium_revision c0988740..9ec8cfdb (575517:575625) 2018-07-17 sakal@webrtc.org Update CameraCapturer to use the new CapturerObserver. 2018-07-17 ilnik@webrtc.org Revert "Enable simulcast screenshare by default" 2018-07-17 oprypin@webrtc.org Replace accidental usages of source_set with rtc_source_set 2018-07-17 ilnik@webrtc.org Enable simulcast screenshare by default 2018-07-17 mbonadei@webrtc.org Enabling clang::find_bad_constructs for common_audio. 2018-07-17 aleloi@webrtc.org Fuzz more kinds of floats in the APM fuzzer. 2018-07-17 saza@webrtc.org Cap the number of fuzzed decoder packets to 200 2018-07-17 aleloi@webrtc.org Division by zero in RNN-VAD. 2018-07-17 mbonadei@webrtc.org Enabling clang:find_bad_constructs from modules/utility. 2018-07-17 mbonadei@webrtc.org Enabling clang::find_bad_constructs for AEC3. 2018-07-17 stefan@webrtc.org Reland "Move allocation and rtp conversion logic out of payload router." 2018-07-17 pitlicek@gmail.com Call callback in IDLE state Created with: gclient setdep -r src/third_party/webrtc@dbdb3a00797d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:690537,chromium:None,chromium:690537,chromium:840115,chromium:861557 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3b5867a0365875ae906aea0d9929dd6529c31160 Reviewed-on: https://chromium-review.googlesource.com/1140903Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575837}
-
Mark Pilgrim authored
Change-Id: Icc9786d1f484687e9488bf565893afe023e2b40a Reviewed-on: https://chromium-review.googlesource.com/1135297 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#575836}
-
Fady Samuel authored
This test is no longer valid once surface synchronization is on. Bug: 855533 Change-Id: If8feae783911501b7962183b367b0c69d8371e62 Reviewed-on: https://chromium-review.googlesource.com/1141110 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#575835}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d691aeeb956f..252ec9191125 git log d691aeeb956f..252ec9191125 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 geofflang@chromium.org Vulkan: "Implement" EGL_ANGLE_display_texture_share_group Created with: gclient setdep -r src/third_party/angle@252ec9191125 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9175effb7895c44dfb94bea0ca46919cb32d3b10 Reviewed-on: https://chromium-review.googlesource.com/1140796Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575834}
-
CJ DiMeglio authored
This is a reland of 6be34509 TBR=dcheng@chromium.org,enne@chromium.org,fsamuel@chromium.org,junov@chromium.org,mlamouri@chromium.org,liberato@chromium.org Original change's description: > Prevents compositor frames from being sent when SurfaceLayer is not visible. > > This CL is 3/3 in effort to fix the regressions caused by sending > unneeded compositor frames. > > This CL provides a signal from the SurfaceLayerImpl to the VideoFrameSubmitter > to prevent compositor frames from being sent at undesired times (occlusion, not > being added into the layer tree). > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I428860047eaf4c50abc2e662914a643158f1276b > Reviewed-on: https://chromium-review.googlesource.com/1101708 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575462} Change-Id: Idba341813f1202991c8cb5da94ea72d234db56eb Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: 864358 Reviewed-on: https://chromium-review.googlesource.com/1140458Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#575833}
-
chrome://conflictsPatrick Monette authored
- Add the state of the 2 third-party related feature at the top of the chrome://conflicts page. - Add a column to chrome://conflicts for the status of each module when one of the 2 features is active. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I633899f813aa03389239c1adf8f11bf1419ade0e Reviewed-on: https://chromium-review.googlesource.com/1133965 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575832}
-
Aaron Leventhal authored
For get_characterExtents(): - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height). - The width/height should not be changed to 1 for offscreen objects. Bug: 864195 Change-Id: Ibea1f3ecb0b8f5f72c6fc967892ac9e6b1af135b Reviewed-on: https://chromium-review.googlesource.com/1138800 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#575831}
-
Ryan Sturm authored
Only data saver users should see the capping heavy pages InfoBar. Bug: 864613 Change-Id: Id7a9c41ac0476b1df9a040e91865935440824162 Reviewed-on: https://chromium-review.googlesource.com/1140682 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575830}
-
David Black authored
Previously, we opened the mic but failed to transition to voice input modality in response to the OnInteractionStarted event. This causes some latency as the input modality would not be updated until we received a SpeechRecognitionStarted event. Bug: b:80186902 Change-Id: I9cd58243fb47d1bcdaeb71736809ad7279376176 Reviewed-on: https://chromium-review.googlesource.com/1140777 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575829}
-
Daniel Park authored
Sets tint for delete icon to default icon color Darkens help and feedback color to default icon color Picture in bug link Bug: 863796 Change-Id: I08c3a5a2a261d1725a96500919ea634b253636bd Reviewed-on: https://chromium-review.googlesource.com/1141059Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575828}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a97a660d47cd..d563855ac72b git log a97a660d47cd..d563855ac72b --date=short --no-merges --format='%ad %ae %s' 2018-07-17 rharrison@chromium.org Cleanup SetSavedCalled API Created with: gclient setdep -r src/third_party/pdfium@d563855ac72b The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4cadeea42fef8dd77e80c1ee1a597231bf8716b1 Reviewed-on: https://chromium-review.googlesource.com/1140415Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575827}
-
Eyor Alemayehu authored
Currently, we call the SendTextQuery method in the assistant manager internal API to send text queries. However, this way does not set the modality to typing. As a result, TTS is played, which should not happen for text queries. Made changes such that we use the SendVoicelessInteraction method instead of SendTextQuery. Using SendVoicelessInteraction, we can set the modality to typing. Bug: b/79769347 Change-Id: I23ed23f1068196b3590b642b2e0674700624d935 Reviewed-on: https://chromium-review.googlesource.com/1139184Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Eyor Alemayehu <eyor@google.com> Cr-Commit-Position: refs/heads/master@{#575826}
-
Mohamed Heikal authored
OmniboxStartupMetrics normally waits for 30s after startup to record the histogram of the first focus event on the toolbar. In case the activity gets destroyed (calling ToolbarManager#onDestroy and OmniboxStartupMetrics#destroy) before 30s is over but after the user focused the Omnibox for the first time then we should flush the data we have to the histogram. Histogram cannot be recorded at the time of focus because that could be before native is loaded. This CL adds some code to ensure that OmniboxStartupMetrics#recordHistogram is idempotent (ie. all calls after the first are noops). Change-Id: I2a2b9dcc1368b05e7caa627891b4e4c63b0ddafb Reviewed-on: https://chromium-review.googlesource.com/1137024 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575825}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: Icba90d7f019ce799fbcdd07849c685c44e0a0243 Reviewed-on: https://chromium-review.googlesource.com/1133984 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#575824}
-
Vikas Soni authored
Move AndroidImageReader class out from media/gpu/android to a more generic location base/android as this helper class will also be used outside of the media/gpu/android. Also make the media flag kAImageReaderVideoOutput static member of this class since this flag is only used inside this class. Bug: 838725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie4da6bd555db3c3ebfa3f0f01b4009010d53e704 Reviewed-on: https://chromium-review.googlesource.com/1135812Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#575823}
-
Fernando Serboncini authored
Makes XPositionForOffset and CharacterIndexForPosition support return results inside a ligature glyph (while still not breaking ZWJs) by using a character-based TextBreakIterator inside glyphs. Reland of 1e3235b3 Bug: 473476 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I80348a10044edc89f0e85789c71dc17a56f6393d Reviewed-on: https://chromium-review.googlesource.com/1140275 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575822}
-
Farah Charab authored
Provide support for experimenting with using resource fetch priorities for resource loading tasks in blink. Bug: 860545 Change-Id: I064f287ea2c96d67f532ba7dc03abb45875947c3 Reviewed-on: https://chromium-review.googlesource.com/1128857 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575821}
-
Wei-Yin Chen (陳威尹) authored
Many JNI methods in HistoryReportJniBridge are too costly to run on the UI thread. Add assertOnBackgroundThread() to avoid possible misuse in the future. Bug: None Change-Id: If76e16aa417984d7eb27be31ca241e7e2051275d Reviewed-on: https://chromium-review.googlesource.com/1139893Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575820}
-
Chris Hamilton authored
This is non-sensical and is a way for a user to crash the browser. BUG= Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I913e0197f3b8d8bda60fa28729d4e5e0bfafbf4b Reviewed-on: https://chromium-review.googlesource.com/1140790Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#575819}
-
Minh X. Nguyen authored
This is to correct the way the (old) extension updater determines updates from the update manifest (|ExtensionDownloader::DetermineUpdates|). It currently treats extension update errors (e.g. extension not in the update manifest, invalid update version in the update manifest, ...) as no updates, which would cause a disparity with the new extension updater running in the Finch experiment. Bug: 722942 Change-Id: I4d958fb0d313f2a9cd2456eef3035d2ef5f091fe Reviewed-on: https://chromium-review.googlesource.com/1123710 Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575818}
-
David Black authored
The parameter is used in Ash to show the appropriate UI for the given interaction type. Bug: b:80186902 Change-Id: Id5cd3d52df4d5132dc87a5cfb25edb9c8cf01e2d Reviewed-on: https://chromium-review.googlesource.com/1137334 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575817}
-
Roberto Carrillo authored
This builder is meant to be used with a cron job on luci scheduler to update the bot_db as a json file in google storage readable by Findit. (Instead of having Findit attempt to parse the python files where these configs are defined, under the chromium_tests recipe module). R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv Bug: 787918 Change-Id: I668eaef3511ff82795ff80a2650ecadd741cd861 Reviewed-on: https://chromium-review.googlesource.com/1141092Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575816}
-
James West authored
Bug: 110481245 Bug: 110967761 Test: manual Change-Id: Id86ba187069699dc3d2f6ac9f1bc8864a6e41484 Reviewed-on: https://chromium-review.googlesource.com/1111680 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#575815}
-
Yue Cen authored
Bug: 835029 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icbe94f99997fe13758400e26ae29eeeb8bb234b6 Reviewed-on: https://chromium-review.googlesource.com/1103778Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#575814}
-
Shakti Sahu authored
UX: https://docs.google.com/presentation/d/14pBMf4Qrhd_a4qF6KdXJJfAZYLdmv_JN0gL8GC4SWAU/edit?ts=5b2c34ff#slide=id.g3d18eff084_2_13 Bug: 863717 Change-Id: I682470f7e0eb66d874fbc82b9ccfae19bb1a7090 Reviewed-on: https://chromium-review.googlesource.com/1139022Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575813}
-
Tien-Ren Chen authored
This reverts commit 3c0ef7a5. Reason for revert: It didn't fix the target crash. Original change's description: > [Blink] Invalidate clip path cache if mask layer is mutated > > This is a speculative fix for https://crbug.com/856818 . > > It is speculated that the clip path of an element become valid without > invalidating its cache, resulting in the associated clip nodes not > being created, and the newly created mask layer having bad layer state. > > BUG=856818 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iab7acc4eb8007d03b259e6dab4f036e2b11bd900 > Reviewed-on: https://chromium-review.googlesource.com/1130596 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574425} TBR=trchen@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 856818 Change-Id: Ib4f9d6920caa36ac31b4e1825adc926fa9c9064f Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1140456Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575812}
-
Hongchan Choi authored
Under the high pressure in WebAudio rendering using AudioWorkletThread, the |contextTime| value can be negative and the current code does not address it correctly. This CL clamps |contextTime| so it cannot past |currentTime|. Spec: https://webaudio.github.io/web-audio-api/#dom-audiocontext-getoutputtimestamp "After the context’s rendering graph has started processing of blocks of audio, its currentTime attribute value always exceeds the contextTime value obtained from getOutputTimestamp method call." Bug: 859870 Test: The time difference in the repro case does not go negative. Change-Id: I2460de263045762659319a18722ace27c2b0bd47 Reviewed-on: https://chromium-review.googlesource.com/1140505Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#575811}
-
Becca Hughes authored
Move DisplayCutoutHostImpl out of WebContentsImpl into its own file. BUG=825890 Change-Id: Id759fa7c9fd880648ec35baac853a046d90959ab Reviewed-on: https://chromium-review.googlesource.com/1131847 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#575810}
-
Shakti Sahu authored
Currently SelectableItemView contains the logic for selection as well as highlighting the UI. Separated the selection functionality into a base class since in the new download home, different types of views will implement different UI for selection. Also added the ability to insert a RecyclerView into the SelectableListLayout since in the download home the main view is created separately in DateOrderedListView. The actual wiring will be in a follow up CL. Bug: 850601 Change-Id: I33b1e68b27d6103d57c82322e5231dddfb6fd112 Reviewed-on: https://chromium-review.googlesource.com/1137332 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575809}
-
Esmael El-Moslimany authored
Bug: 863845 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5da18cebf49709c6499bba94ea82bfabbef5a773 Reviewed-on: https://chromium-review.googlesource.com/1140510 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#575808}
-
wutao authored
This cl implements a new feature to read the latest opened foreign tab on Chrome OS. Bug: 843839 Test: manual. Change-Id: Iab5e9e5eb092d8103497492c9f88bc79e323e9b5 Reviewed-on: https://chromium-review.googlesource.com/1134485 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575807}
-
Zhongyi Shi authored
QUIC Connection Migration: do not check non-migratable streams when starting to probe an alternative network. Instead, check and reset non-migratable streams when probe is successful and session is about to migrate to the probed path. Bug: 791886 Change-Id: Icdff9b77d340fedbf64ab8e8eb05d1d99aaf0b65 Reviewed-on: https://chromium-review.googlesource.com/1139314 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#575806}
-
Sandra Sun authored
This reverts commit dab53435. Reason for revert: Couldn't reproduce the test failure on a local Win7 and the failure seems unrelated to my change. Try to submit it once more and will investigate it further if it fails again. Original change's description: > Revert "Snaps after scrollbar clicking." > > This reverts commit e98df9c6. > > Reason for revert: suspect for webkit_layout_tests consistently > failing, e.g. > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/81791 > > Original change's description: > > Snaps after scrollbar clicking. > > > > After user clicking on the scrollbar's track or arrows, we should snap > > to the closest snap position of the container. This is done by simply > > moving SnapAfterScrollbarDragging() from > > ScrollableArea::MouseReleasedScrollbar() up to Scrollbar::MouseUp(). > > > > This patch also rewrites the previous > > snaps-after-scrollbar-dragging.html test using the gesture-util.js, and > > adds the new clicking tests to it as well. > > > > Bug: 860768 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I75267c3fc0917ecf5c14673a1eb480a047d03824 > > Reviewed-on: https://chromium-review.googlesource.com/1127153 > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#575191} > > TBR=bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org > > Change-Id: Iab3c3c489bda0fc6b150ba0e0a5bde8de9721798 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 860768 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1138013 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575202} TBR=bokan@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,mastiz@chromium.org Change-Id: Iaef646348cc6e1c0a6e8b0bca3deb9296f79a7e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860768 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1138473 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#575805}
-
Mohsen Izadi authored
ServerGpuMemoryBufferManager is updated to support changing the GPU service it is using, in case GPU process is crashed and restarted. If this happens, it will retry pending allocation requests as soon as the new GPU service is available. BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I56fa97c7b74ec71d7e7a18e0e3036ffd7350e296 Reviewed-on: https://chromium-review.googlesource.com/1132679 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#575804}
-
Danyao Wang authored
-webViewSecurityFeaturesDidChange is meant to update the SSL status of the last committed item. With WKBasedNavigationManager, on a back/forard navigation, there exists a small window between web view starts loading and -webView:didStartProvisionalNavigation is triggered that WKBasedNavigationManager::GetLastCommittedItem() returns the pending item instead of the last committed item. -updateSSLStatusForCurrentNavigationItem must not be called in this window, otherwise the wrong navigation item will be used. Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I57eb96f74c3a6a133b1fdad6559de093f5d125c5 Reviewed-on: https://chromium-review.googlesource.com/1141054 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#575803}
-
Francois Doray authored
Bug: 775644 Change-Id: I2e1558710c665322c1cbba93ed20176f6be83667 Reviewed-on: https://chromium-review.googlesource.com/1136984 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#575802}
-
Annie Sullivan authored
Change-Id: I29978aa75fe2a71490cdcb1fcc78e47ac672f185 Reviewed-on: https://chromium-review.googlesource.com/1141094Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575801}
-
Katie D authored
The SelectToSpeak class is messy and should be refactored to separate the input handling, state logic, and output handling. This is the first part of that refactor. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If53dc7f85b223641e82533c82ab89aa50719d198 Reviewed-on: https://chromium-review.googlesource.com/1136842 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575800}
-
Scott Violet authored
And changes ws2 to ensure client is notified when scale-factor changes. The conversion from ScreenProviderObserver to associated interface is to ensure the ScreenProviderObserver is notified *before* the bounds change because of scale-factor. To do otherwise means the client might use the wrong scale-factor. BUG=862409 TEST=none Change-Id: I78333dcabe3e4adb1e2091cba784d53d9c27be1a Reviewed-on: https://chromium-review.googlesource.com/1138866Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#575799}
-
Lei Zhang authored
Point various OWNERS files for Cloud Print code to //cloud_print/OWNERS. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0ba92831f62904415c5d5f4ddf8fcf0335e301b8 Reviewed-on: https://chromium-review.googlesource.com/1141072Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575798}
-