- 16 Nov, 2018 40 commits
-
-
Min Chen authored
Unified system tray has been launched and web notification has been moved to the top of the system tray. The old system tray logic has been removed. This cl removes the logic that swiping up on the status area tray to open the corresponding bubble and swiping down on the tray bubble to close it. cl that landed the feature: https://codereview.chromium.org/2961313003/ cl that disabled the feature: https://chromium-review.googlesource.com/c/chromium/src/+/674527/ Bug: 767679 Change-Id: Id81091360ee47c9763d2f716f246146b940ac1e2 Reviewed-on: https://chromium-review.googlesource.com/c/1334932Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#608868}
-
Tim Volodine authored
Currently unsupported url schemes like "foo://some/resource" hit a NOTREACHED() and crash in the NS code path. Also, the current code path does not invoke any webview specific callbacks. This patch ensures that the unsupported url scheme cases are handled correctly and the appropriate error callback is invoked when we hit an unsupported scheme case (aka ERR_UNKNOWN_URL_SCHEME). This patch also adds some additional parameters (i.e. method and headers) to the ContentBrowserClient:: HandleExternalProtocol() method, in order to provide all the data required to execute the callback. The HandleExternalProtocol() method is invoked in two places: 1. navigation_url_loader_impl.cc 2. resource_dispatcher_host_impl For case 1 the additional data is obtained from the network::ResourceRequest and for case 2 from net::URLRequest. Tests fixed by this patch: - ClientOnReceivedError2Test.testOnInvalidScheme - ClientOnReceivedErrorTest.testOnReceivedErrorOnInvalidScheme - AwContentsClientShouldOverrideUrlLoadingTest.testCalledForIframeUnsupportedSchemeNavigations - AwContentsClientShouldOverrideUrlLoadingTest.testWindowOpenCustomSchemeUrlInPopup BUG=896223,893567,893573,893574,841556 Change-Id: I7053b66a489c0f49eaa1428a8ee2466380710b26 Reviewed-on: https://chromium-review.googlesource.com/c/1318976 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#608867}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=henrika@chromium.org Bug: 903957 Change-Id: Id9a9bb29d5d9beb2f680472602badc3a1ac1f6e3 Reviewed-on: https://chromium-review.googlesource.com/c/1338126Reviewed-by:Max Morin <maxmorin@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608866}
-
Orin Jaworski authored
The omnibox was accepting raw text from drag data when such text was left empty by stripping Javascript schemas and whitespace. This allowed invalid omnibox edit text content, containing e.g. newline characters which would then render with confusing glyphs. This CL fixes the issue by using the sanitized text even if empty. Bug: 904380 Change-Id: Ia43a9429d200261a929e858681cb771e6b8bc91c Reviewed-on: https://chromium-review.googlesource.com/c/1334558Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#608865}
-
Xiaohui Chen authored
* Add a feature to control this, default off * Move audio_input_impl to its own file since it grows big * Introduce hotword_state_manager that controls DSP input device state. For DSP device, it works as follows: - Open input device with HOTWORD effect - Input device won't forward audio data until OKG is detected - Once OKG is detected, input device behaves like a regular input device and constantly streams audio data, note that the preamble of OKG itself is included in the initial audio data - When a conversation is finished, we need to destroy and recreated the audio input to arm DSP again. Bug: b/77916222 Test: locally build and run on eve Change-Id: I4ce17fba21fbc584cde9178c2aca53a6ed410fe9 Reviewed-on: https://chromium-review.googlesource.com/c/1334566Reviewed-by:Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#608864}
-
Xing Liu authored
This CL adds security check for redirect in network service code path for download system. Bug: 883387 Change-Id: Icd5f9eac09a1197bffc72fbf3196b96a8c88ac4c Reviewed-on: https://chromium-review.googlesource.com/c/1330063Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
Joe Mason authored
R=csharp@chromium.org Bug: 830892 Change-Id: I6c3a17c2761545f58e18d9058bf2dedc31acf39e Reviewed-on: https://chromium-review.googlesource.com/c/1338566Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#608862}
-
Mathieu Perreault authored
Bug: 906135 Change-Id: Ibdf7195d93a8dc340e6ce9cdd3ab11b4917bdd1e Reviewed-on: https://chromium-review.googlesource.com/c/1340659Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#608861}
-
dpapad authored
- Several "rm" commands are unnecessary because of rsync_exclude.txt. - Audited code that was replacing NBSP in polymer-mini.html (added in r332329). Seems to have no effect (no diff exists after running the command). Removed related TODO for Polymer 2. - Remove unused files from third_party/web-animations-js/. These files are not included in the build anyway. Bug: 738611 Change-Id: I372143a9bc1fd3f18d5aa6fb7fe735fdbdb82015 Reviewed-on: https://chromium-review.googlesource.com/c/1338334 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608860}
-
Lukasz Anforowicz authored
After r606352, default URLLoaderFactory does not make any CORB exceptions for extensions and/or apps. Separate URLLoaderFactories (relaxing CORB) need to be created for content scripts. One scenario, where separate URLLoaderFactories should be created, is content scripts injected into <webview> tag. Such scripts execute fetches with |request_initiator| set to the origin of the <webview> embedder and so permissions of the embedder need to be taken into account (e.g. a Chrome App might be able to make cross-origin requests). This CL adds a regression test for this scenario (without product code changes the new test fails with --enable-features=NetworkService flag) and fixes the product code to trigger creation of separate URLLoaderFactory when needed. For an overview of separate URLLoaderFactories for extensions, see https://docs.google.com/document/d/1fuBUmLZj1H319jMkK8waUbf5WdQS0N95J_mWXVzbP7A Bug: 846346 Change-Id: I6ac0f42df7562a01c14cbe6740417b6d94b51810 Reviewed-on: https://chromium-review.googlesource.com/c/1337822 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608859}
-
Adrienne Walker authored
Fix fuzzer crash by deleting fuzzer. ;) This fuzzer attempts to do a convoluted series of deserializing and reserializing to try to make sure that serializing an op ends up in the same op that is deserialized. However, over time, a number of changes to serialization have been added that modify what is being serialized, e.g. scaling paint records, adding clips and scales to serialized PaintRecords, scaling paint records, etc. I think this fuzzer was useful in early oopr releasing to build confidence about the number of serialization bugs, but it never caught any issues that the paint_op_buffer_fuzzer wouldn't have caught. However, it's no longer that useful. Bug: 904211 Change-Id: Ie62e296c9a5246ab74478755d738820e02bf7cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1337817 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608858}
-
Paul Irish authored
Change-Id: I312159dd7287413e0421ce8cc7a064a4efa6041f Reviewed-on: https://chromium-review.googlesource.com/c/1319034Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#608857}
-
James Darpinian authored
If the transfer buffer is resized, pointers returned by GetResultAs are invalidated. This changes GetResultAs to return a smart pointer class that allows us to detect if a result pointer is still in use when the buffer is resized and safely crash. Bug: 905889, 905890 Change-Id: I67b243a779f1a2996e7c13740c5ebdcfda16d0d3 Reviewed-on: https://chromium-review.googlesource.com/c/1336753 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608856}
-
Xiaocheng Hu authored
This patch changes Range::expand() to call VP-free version of word and sentence start/end functions, by hoisting the creation of VP from the functions into itself. In this way we reduce the usage of functions relying on VP. Bug: 657237 Change-Id: I56ea3cb88972144887eba7701cfdc3628bdbf67b Reviewed-on: https://chromium-review.googlesource.com/c/1338719 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608855}
-
Xiaocheng Hu authored
This patch changes DocumentMarkerController to use VisiblePosition- free versions of Start/EndOfWord, to reduce usage of VisiblePosition. Bug: 657237 Change-Id: I344c98c9163ddc06f338e309a6b3e372d5fc2dda Reviewed-on: https://chromium-review.googlesource.com/c/1330747 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Kush Sinha authored
Please first check the attached bug for context. The fix is to listen on AccountTrackerService and not AccountManager for account removals. We cannot listen on AccountTrackerService for account updates because AccountTrackerService does not notify its observers when an account's LST changes. Bug: 904978 Test: browser_tests --gtest_filter="ArcAuthServiceTest.AccountRemovalsArePropagated" Change-Id: I75aeda8dd280734e58e509f5a34a4b1e27b09498 Reviewed-on: https://chromium-review.googlesource.com/c/1334368Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#608853}
-
Scott Violet authored
One lives in ash, the other in the browser. The one in ash is responsible for the actual window management and animations, the one in the browser for forwarding to the one in ash and caching state. I'm happy to rename these classes in the future. BUG=756085,875111 TEST=covered by test Change-Id: Ida90f51a6b7efff82021a29e8a0185949a3e494a Reviewed-on: https://chromium-review.googlesource.com/c/1338161Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608852}
-
Peter Kotwicz authored
WebappActivity#getActivityDirectory() never returns null. Change-Id: Ie6b131677e6a69a49b8c72713235dc0891f5dbe2 Reviewed-on: https://chromium-review.googlesource.com/c/1340371Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608851}
-
Xiaocheng Hu authored
This patch stops EndOfSentence from crossing block boundaries, since block boundaries are also sentence boundaries. Bug: 778507 Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993 Reviewed-on: https://chromium-review.googlesource.com/c/1337432Reviewed-by:
-
Xiaocheng Hu authored
This patch stops the two functions from using VisiblePosition by switch to the VP-free versions of Start/EndOfSentence(). Hence, this patch reduces the usage of legacy VisiblePosition. Bug: 657237 Change-Id: I933a020f9bd6643ba1b2cd5111b8be18b2f49086 Reviewed-on: https://chromium-review.googlesource.com/c/1337816Reviewed-by:
-
Robert Kroeger authored
The draw-webgl-to-canvas-2d-repeatedly.html WebGL test is failing on Linux/Amd/Passthrough. Suppress this. BUG=906066 TBR=kbr@chromium.org NOTRY=true Change-Id: I93d75e75ecfac5bc94b272a6c0089c486122ef23 Reviewed-on: https://chromium-review.googlesource.com/c/1340367 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Change-Id: I05f3f73c8337bd2bfc07e420cdafccaf1bb04370 Reviewed-on: https://chromium-review.googlesource.com/c/1338408Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
-
Changwan Ryu authored
There is no logic change. By refactoring the offset change into a separate class, we can make it much easier to reason about and add new tests. For example, https://chromium-review.googlesource.com/c/chromium/src/+/980513 can use this test. Bug: 825858 Change-Id: I3465057c8b7fed637f61a2a02a03d5048be8c387 Reviewed-on: https://chromium-review.googlesource.com/c/1335273 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#608846}
-
ssid authored
BUG=905919 Change-Id: I6024a41113845bd6e6b50d829a0ea2b4ab3e5efb Reviewed-on: https://chromium-review.googlesource.com/c/1336527Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#608845}
-
edchin authored
This CL creates an UI integration test that tests that the page info view gets automatically dismissed on device rotation. Change-Id: I02611cc2fab5a214b74af01d15cd8d12e19eff6e Reviewed-on: https://chromium-review.googlesource.com/c/1338561 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608844}
-
Aiden Benner authored
In preparation for enabling an errorprone check that would prohibit context#getApplicationContext in favour of ContextUtils#getApplicationContext this CL suppresses existing usages in WebView. See https://bugs.chromium.org/p/chromium/issues/detail?id=560466 for context. Bug: 846456 Change-Id: I9f046f1fa64d562cc9efb7d66a65bfe793b04bfb Reviewed-on: https://chromium-review.googlesource.com/c/1340375Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#608843}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=emircan@chromium.org Bug: 903957 Change-Id: Icb47a6a89a0c8e3c1a2871064dbb5b105db0ba2f Reviewed-on: https://chromium-review.googlesource.com/c/1338412Reviewed-by:Emircan Uysaler <emircan@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608842}
-
Yi Gu authored
Currently when scroll timeline has unresolved current time, e.g. the scroll source is not scrollable, we set WorkletAnimation::start_time_ to base::TimeDelta::FromSecondsD(NaN) which is incorrect. Other changes in the patch: 1. By spec [1], unresolved time values are represented by null. Update tests to match that. 2. For WorkletAnimation with ScrollTimeline, it's legit not to set start_time_. Update DCHECKs for this behavior. [1] https://drafts.csswg.org/web-animations/#time-values-in-the-programming-interface Bug: 905358 Change-Id: Ifde3890a6a4ad9e27dda8d4a78c5b6dcbf24ef54 Reviewed-on: https://chromium-review.googlesource.com/c/1336055 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608841}
-
Max Moroz authored
We use this flag on OSS-Fuzz and trigger various asserts with fuzzing: https://bugs.chromium.org/p/oss-fuzz/issues/list?can=1&q=label%3AProj-sqlite3&colspec=ID+Type+Component+Status+Proj+Reported+Owner+Summary&cells=ids R=palmer@chromium.org, pwnall@chromium.org Bug: 900910 Change-Id: I223ad95a9626e016c99ed5cecbf6f084cba8f331 Reviewed-on: https://chromium-review.googlesource.com/c/1315959 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#608840}
-
Ross McIlroy authored
Bug: V8:8405 Change-Id: I150f74bf5de8c0a2cd784e6d1399c1c702c2936e Reviewed-on: https://chromium-review.googlesource.com/c/1339961Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608839}
-
Yi Su authored
Use dot notations to get properties on Objects in find_in_page.js. This is a preparation work for fix the bug(crbug.com/228585). Bug: 228585 Change-Id: Ia0b371b914842f515589011b7182e7f8b121c924 Reviewed-on: https://chromium-review.googlesource.com/c/1339799 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#608838}
-
Mike Reed authored
TBR=vmpstr Bug: skia:2664 Change-Id: I736158e11434fdf561328e20fee6bef01ba43ae9 Reviewed-on: https://chromium-review.googlesource.com/c/1337827 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#608837}
-
Tatiana Buldina authored
Bug: chromedriver:2663 Change-Id: I62c16df01d2f775cff86a26ef1e9acc5e95a09ce Reviewed-on: https://chromium-review.googlesource.com/c/1338573Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#608836}
-
https://chromium-review.googlesource.com/c/1312234Ravi Mistry authored
This reverts commit c5612605. Reason for revert: Breaking 11 autorollers into Chromium. See https://bugs.chromium.org/p/chromium/issues/detail?id=906114 Original change's description: > Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234 > > Bug: 875037 > Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1339339 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608783} TBR=thakis@chromium.org,hans@chromium.org,martiniss@chromium.org,ehmaldonado@chromium.org Change-Id: Ib8984eb1b295f9695758fc9700024927ba75d9ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875037 Reviewed-on: https://chromium-review.googlesource.com/c/1340521Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#608835}
-
Peter Kotwicz authored
This CL fixes IdentityService#getRuntimeHostBrowserPackageName(). In some scenarios (like the default browser supporting WebAPKs for an unbound WebAPK), calling HostBrowserUtils#getHostBrowserPackageName() updates the host browser in shared preferences. This CL changes the call so that when the IdentityService changes the host browser in Shared Preferences the identity service also clears that WebAPK's shared preferences and data directory. This CL: - Splits HostBrowserUtils#getHostBrowserPackageName() into 2 functions: HostBrowserUtils#getCachedHostBrowserPackage() which returns the host browser cached in shared preferences if it is still installed. HostBrowserUtils#getCachedHostBrowserPackage() does not update any state. HostBrowserUtils#computeHostBrowserPackageClearCachedDataOnChange() which computes the new host browser. If the computed host browser is different than the cached host browser in shared preferences, the WebAPK's shared preferences and data directory are cleared. - Reduces the number of functions with hidden calls to HostBrowserUtils#getHostBrowserPackageName(). HostBrowserUtils#getHostBrowserContext() and HostBrowserUtils#getHostBrowserUid() are changed to take a package name parameter and are moved to WebApkUtils. BUG=900464 TEST=HostBrowserUtilsTest.* Change-Id: Ie6dea7de5eaca770d8a1261c2742308bc1165419 Reviewed-on: https://chromium-review.googlesource.com/c/1310569 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#608834}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7dbb7c311f00..645a3afceae0 git log 7dbb7c311f00..645a3afceae0 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 solenberg@webrtc.org Remove unused/unnecessary things from ChannelSend. 2018-11-16 nisse@webrtc.org Add default values for PlayoutDelay in RTPVideoHeader. Created with: gclient setdep -r src/third_party/webrtc@645a3afceae0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9184912693bd50867ad728f46ada7b5ec16f15c3 Reviewed-on: https://chromium-review.googlesource.com/c/1340380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608833}
-
David Roger authored
To help the server team distinguish better the traffic coming from Chrome this CL adds a "Chromium" prefix to all Gaia sources in Chrome. A lot of sources already had this prefix, but some did not. This CL also removes the source parameter from ListAccounts calls. This source was not consistently used (because ListAccounts often returns a cached response), and was not really meaningful. ListAccounts now always use the generic GaiaSource::kChrome. TBR=treib, xiyuan, isherman, poromov, eugenebut Bug: 895010 Change-Id: I8b3837d6ddf1d04cae252f382c2dee7b99f93c75 Reviewed-on: https://chromium-review.googlesource.com/c/1329971 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#608832}
-
Collin Baker authored
This change: * removes COLOR_TAB_TEXT_INACTIVE and instead simply alpha-blends COLOR_TAB_TEXT * removes disabled unit test that uses COLOR_TAB_TEXT_INACTIVE * uses COLOR_BACKGROUND_TAB_TEXT_INACTIVE directly if a theme provides it Bug: 901610, 859243 Change-Id: I7db13a7719284ac3e27ec3bfc122d6381430df26 Reviewed-on: https://chromium-review.googlesource.com/c/1334419 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608831}
-
Lukasz Suder authored
This is a reland of 04f43afb Original change's description: > [Autofill Assistant] Displays the difference in Details if there is any. > > If there is a difference between current and new details it's > highlighted and two chips are displayed; to allow move forward or > go back (which closes CCT). > > Screenshot: https://screenshot.googleplex.com/kOoC3B1frUp > > Bug: 806868 > Change-Id: I95ff09c379398d5a5858aa3947d4c578f39b14c9 > Reviewed-on: https://chromium-review.googlesource.com/c/1335941 > Commit-Queue: Lukasz Suder <lsuder@chromium.org> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608759} Bug: 806868 Change-Id: I419ac2bb513f6fdd496fba40162c92b839952df9 Reviewed-on: https://chromium-review.googlesource.com/c/1340329Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Lukasz Suder <lsuder@chromium.org> Cr-Commit-Position: refs/heads/master@{#608830}
-
Gabriel Charette authored
post_task.h is now preferred over using dedicated base::Threads. Furthermore, this code is preventing PlatformThread::Join() called by Thread::Stop()) from being marked as a blocking operation in https://chromium-review.googlesource.com/c/chromium/src/+/1324370. This code was really only spinning up a thread to run a single task in an MTA environment. All threads in the TaskScheduler (in the browser process) are in an MTA. R=grt@chromium.org Bug: 707362 Change-Id: I5defbaeefc291f4b417c142cda60918a4cfd471d Reviewed-on: https://chromium-review.googlesource.com/c/1338221 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#608829}
-
