1. 10 Jan, 2007 9 commits
    • hyatt's avatar
      Avoid crashing when repainting multiple columns... make sure to use... · c3400247
      hyatt authored
              Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
              not the newly-computed column count.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutColumns):
              (WebCore::RenderBlock::adjustRepaintRectForColumns):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18733 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c3400247
    • hyatt's avatar
      Break up painting and hit testing of children into helper methods and... · bb7981f7
      hyatt authored
              Break up painting and hit testing of children into helper methods and add multi-column versions for both.
              
              Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
              hover works.
      
              Turn off selection gap filling in columns for now until it can be made to work correctly.
      
              Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
              account for column break adjustments that shrink the columns slightly.  Avoid clipping of the last column's
              contents by ensuring it gets all the remaining available height.
      
              Reviewed by mitz
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintColumns):
              (WebCore::RenderBlock::paintContents):
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::fillSelectionGaps):
              (WebCore::RenderBlock::nodeAtPoint):
              (WebCore::RenderBlock::hitTestColumns):
              (WebCore::RenderBlock::layoutColumns):
              (WebCore::RenderBlock::adjustRepaintRectForColumns):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::getAbsoluteRepaintRect):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18732 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bb7981f7
    • ddkilzer's avatar
      WebCore: · de087914
      ddkilzer authored
              Reviewed by Darin and Eric.
      
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=12150
      
              Don't use memset to set float to 0
      
              * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
              (WebCore::cgGradientCallback):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18731 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      de087914
    • hyatt's avatar
      Update overflow tests. Add new overflow test. · 89a04c71
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18729 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      89a04c71
    • andersca's avatar
      Reviewed by Brady. · 3443ce96
      andersca authored
              Add default constructor to SharedBuffer.
      
              * platform/SharedBuffer.cpp:
              (WebCore::SharedBuffer::SharedBuffer):
              * platform/SharedBuffer.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18728 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3443ce96
    • hyatt's avatar
      This patch gets rudimentary column layout working. Normal flow... · 177049dd
      hyatt authored
              This patch gets rudimentary column layout working.  Normal flow content only gets laid out into
              columns properly and painted correctly initially.  What doesn't work: hit testing, incremental repainting,
              column rule painting, child layers.
      
              Some work needs to be done on the render tree dumper before column tests will be
              meaningful.
      
              Also reworked overflow and fixed a bunch of bugs with the computation of overflow.  These include an error
              in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
              by not checking overflow in lowest/rightmostPosition.  Existing tests improve their rendering to match
              Firefox with this change.
      
              Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
              This should not have happened.  Covered by new test fast/overflow/table-overflow-float.html.
      
              Reviewed by mitz
      
              * page/Frame.cpp:
              * rendering/RenderBlock.cpp:
              (WebCore:::RenderFlow):
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::paintContents):
              (WebCore::RenderBlock::paintChildren):
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::lowestPosition):
              (WebCore::RenderBlock::rightmostPosition):
              (WebCore::RenderBlock::leftmostPosition):
              (WebCore::RenderBlock::avoidsFloats):
              (WebCore::RenderBlock::nodeAtPoint):
              (WebCore::RenderBlock::hitTestContents):
              (WebCore::RenderBlock::layoutColumns):
              * rendering/RenderBlock.h:
              (WebCore::RenderBlock::hasOverhangingFloats):
              (WebCore::RenderBlock::hasColumns):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock):
              (WebCore::RenderFlexibleBox::layoutHorizontalBox):
              (WebCore::RenderFlexibleBox::layoutVerticalBox):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::paintLines):
              (WebCore::RenderFlow::lowestPosition):
              (WebCore::RenderFlow::rightmostPosition):
              (WebCore::RenderFlow::leftmostPosition):
              * rendering/RenderFlow.h:
              (WebCore::RenderFlow::hasColumns):
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::paint):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::expandsToEncloseOverflow):
              * rendering/RenderTableCell.h:
              (WebCore::RenderTableCell::expandsToEncloseOverflow):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::paint):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18727 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      177049dd
    • justing's avatar
      Removed some extraneous text from this layout test. It passes now. · a21fff74
      justing authored
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18726 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a21fff74
    • thatcher's avatar
      Reviewed by Darin. · 5fb0dc75
      thatcher authored
              Rename the now ObjC++ files to be .mm and remove the explicit file types.
      
              * DOM/WebDOMOperations.m: Removed.
              * DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed.
              * English.lproj/StringsNotToBeLocalized.txt:
              * Misc/WebCoreStatistics.m: Removed.
              * Misc/WebElementDictionary.m: Removed.
              * Misc/WebIconDatabase.m: Removed.
              * Misc/WebNSAttributedStringExtras.m: Removed.
              * Misc/WebNSPasteboardExtras.m: Removed.
              * Plugins/WebNetscapePluginEmbeddedView.m: Removed.
              * Plugins/WebNullPluginView.m: Removed.
              * Plugins/WebPluginContainerCheck.m: Removed.
              * WebCoreSupport/WebViewFactory.m: Removed.
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebArchiver.m: Removed.
              * WebView/WebHTMLRepresentation.m: Removed.
              * WebView/WebHTMLView.m: Removed.
              * WebView/WebRenderNode.m: Removed.
              * WebView/WebResource.m: Removed.
              * WebView/WebScriptDebugDelegate.m: Removed.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18725 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5fb0dc75
    • darin's avatar
      JavaScriptCore: · 253d1eff
      darin authored
              - update 2007 Apple copyright for the new company name
      
              * kjs/DateMath.cpp:
      
      WebCore:
      
              - update all 2007 Apple copyrights for the new company name
      
              * css/cssstyleselector.cpp:
              * html/HTMLLIElement.cpp:
              * platform/CharacterNames.h:
              * platform/TextBreakIterator.h:
              * platform/TextBreakIteratorICU.cpp:
              * platform/graphics/ImageBuffer.h:
              * rendering/CounterNode.cpp:
              * rendering/CounterNode.h:
              * rendering/RenderBox.h:
              * rendering/RenderContainer.cpp:
              * rendering/RenderCounter.cpp:
              * rendering/RenderCounter.h:
              * rendering/RenderImage.h:
              * rendering/RenderListItem.h:
              * rendering/RenderListMarker.h:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderStyle.cpp:
              * rendering/RenderStyle.h:
              * rendering/RenderTable.cpp:
              * rendering/RenderTableCell.cpp:
              * rendering/RenderTableCell.h:
              * rendering/RenderText.cpp:
              * rendering/RenderText.h:
              * rendering/RenderTreeAsText.cpp:
              * rendering/SVGRenderTreeAsText.cpp:
              * rendering/break_lines.cpp:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18724 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      253d1eff
  2. 09 Jan, 2007 31 commits
    • justing's avatar
      LayoutTests: · 09ebd17e
      justing authored
              Reviewed by john
      
              * editing/inserting/4840662-expected.checksum: Added.
              * editing/inserting/4840662-expected.png: Added.
              * editing/inserting/4840662-expected.txt: Added.
              * editing/inserting/4840662.html: Added.
              * editing/pasteboard/4840662-expected.checksum: Added.
              * editing/pasteboard/4840662-expected.png: Added.
              * editing/pasteboard/4840662-expected.txt: Added.
              * editing/pasteboard/4840662.html: Added.
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/4840662>
              REGRESSION: Mail crash when dragging text into a link
              
              moveParagraphs fails to move content into a display:block 
              anchor because of code in positionAvoidingSpecialElementBoundary,
              and so it infinitely recurs.
              
              * editing/htmlediting.cpp:
              (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors
              that have display:block so that content is inserted in the expected
              paragraph.  This fixes the bug and weird behavior when typing before/after
              anchors with display:block.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18723 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      09ebd17e
    • rwlbuis's avatar
      Reviewed by Darin. · 25ef0bdd
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=12145
              Color parsing is too relaxed in strict mode
              http://bugs.webkit.org/show_bug.cgi?id=12166
              REGRESSION (r18480): "336633" is not parsed as a color 
      
              Fix a regression by using String::format return value.
              Also make strict mode more strict for cases where hexcolors
              lack a #.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18722 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      25ef0bdd
    • darin's avatar
      Reviewed by Maciej. · d101a955
      darin authored
              - fixed regression where redirects did not have user-agent any more
      
              Showed up as a failure in one of the http tests, so no new test needed.
      
              * loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest):
              Don't use a copy of the ResourceRequest; pass the original so it can be modified.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18721 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d101a955
    • darin's avatar
      - fix build · 468499f0
      darin authored
              * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
              Actually compile it this time.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18718 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      468499f0
    • darin's avatar
      - fix build · afa74b9b
      darin authored
              * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
              Change types.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18717 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      afa74b9b
    • darin's avatar
      - fix build on platforms where Unicode::UChar is != uint16_t · dce46426
      darin authored
              * kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
              Change types.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18716 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dce46426
    • ap's avatar
      2007-01-09 Mitz Pettel <mitz@webkit.org> · fdb27973
      ap authored
              Reviewed by Darin.
      
              - changes for http://bugs.webkit.org/show_bug.cgi?id=11078
                Forms Don't Submit (ASP Pages)
      
      JavaScriptCore:
              * JavaScriptCore.exp:
              * kjs/value.cpp:
              (KJS::JSValue::toInt32): Folded toInt32Inline into this method, which was its
              only caller.
              (KJS::JSValue::toUInt32): Added a variant that reports if the conversion has
              succeeded.
              * kjs/value.h:
      
      WebCore:
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back
              to namedItem() if its argument does not convert to a number.
      
      LayoutTests:
              * fast/dom/collection-namedItem-via-item-expected.txt: Added.
              * fast/dom/collection-namedItem-via-item.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18715 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fdb27973
    • darin's avatar
      JavaScriptCore: · 0961d165
      darin authored
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12174
                improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
      
              * wtf/unicode/icu/UnicodeIcu.h: Change parameter and return types
              to UChar32 and UChar. Removed unneeded type casts and added some
              const to functions that lacked it. Removed WTF::Unicode::memcmp.
              (WTF::Unicode::umemcasecmp): Renamed from strcasecmp since this
              doesn't work on 0-terminated strings as the str functions do.
              * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
      
              - got rid of namespace prefixes from most uses of WTF::Unicode
      
              * kjs/function.cpp:
              (KJS::isStrWhiteSpace):
              (KJS::escapeStringForPrettyPrinting):
              * kjs/lexer.cpp:
              (KJS::Lexer::isWhiteSpace):
              (KJS::Lexer::isIdentStart):
              (KJS::Lexer::isIdentPart):
              * kjs/string_object.cpp:
              (KJS::StringProtoFunc::callAsFunction):
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12174
                improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
      
              - got rid of namespace prefixes from most uses of WTF::Unicode
      
              - updated for removal of WTF::Unicode::memcmp
              - updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
      
              - unified constants for special Unicode characters in a new
                CharacterNames.h header
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/cssparser.cpp:
              (WebCore::ParseString::lower):
              * dom/Document.cpp:
              (WebCore::isValidNameStart):
              (WebCore::isValidNamePart):
              * dom/Position.cpp:
              (WebCore::Position::leadingWhitespacePosition):
              (WebCore::Position::trailingWhitespacePosition):
              * editing/CompositeEditCommand.cpp:
              (WebCore::isWhitespace):
              * editing/HTMLInterchange.cpp:
              * editing/TextIterator.cpp:
              (WebCore::CircularSearchBuffer::CircularSearchBuffer):
              (WebCore::CircularSearchBuffer::append):
              * editing/htmlediting.cpp:
              (WebCore::stringWithRebalancedWhitespace):
              (WebCore::nonBreakingSpaceString):
              * editing/htmlediting.h:
              * html/HTMLFontElement.cpp:
              (WebCore::parseFontSizeNumber):
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError):
              * html/HTMLSelectElement.cpp:
              (WebCore::stripLeadingWhiteSpace):
              * platform/Font.cpp:
              (WebCore::WidthIterator::advance):
              (WebCore::WidthIterator::normalizeVoicingMarks):
              * platform/GlyphMap.cpp:
              (WebCore::GlyphMap::locatePage):
              * platform/MimeTypeRegistry.h:
              * platform/StringHash.h:
              * platform/StringImpl.cpp:
              (WebCore::isSpace):
              (WebCore::StringImpl::append):
              (WebCore::StringImpl::insert):
              (WebCore::StringImpl::truncate):
              (WebCore::StringImpl::remove):
              (WebCore::parseLength):
              (WebCore::StringImpl::isLower):
              (WebCore::StringImpl::lower):
              (WebCore::StringImpl::upper):
              (WebCore::StringImpl::secure):
              (WebCore::StringImpl::foldCase):
              (WebCore::StringImpl::capitalize):t
              (WebCore::StringImpl::toInt):
              (WebCore::equalIgnoringCase):
              (WebCore::StringImpl::find):
              * platform/TextBoundaries.h:
              * platform/TextCodec.h:
              * platform/TextCodecLatin1.cpp:
              * platform/TextEncoding.h:
              * platform/TextEncodingRegistry.h:
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection):
              * platform/mac/TextCodecMac.cpp:
              (WebCore::TextCodecMac::decode):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateFirstLetter):
              * rendering/RenderListMarker.cpp:
              (WebCore::listMarkerText):
              (WebCore::RenderListMarker::paint):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::widthFromCache):
              (WebCore::isSpaceAccordingToStyle):
              (WebCore::RenderText::setInternalString):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::quoteAndEscapeNonPrintables):
              (WebCore::operator<<):
              * rendering/bidi.cpp:
              (WebCore::BidiState::BidiState):
              (WebCore::BidiContext::BidiContext):
              (WebCore::bidiNext):
              (WebCore::bidiFirst):
              (WebCore::BidiIterator::direction):
              (WebCore::appendRun):
              (WebCore::embed):
              (WebCore::RenderBlock::bidiReorderLine):
              (WebCore::RenderBlock::layoutInlineChildren):
              (WebCore::skipNonBreakingSpace):
              (WebCore::RenderBlock::findNextLineBreak):
              * rendering/break_lines.cpp:
              (WebCore::nextBreakablePosition):
              * rendering/break_lines.h:
              * xml/XPathParser.cpp:
              (WebCore::XPath::charCat):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18712 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0961d165
    • darin's avatar
      Another change log tweak. · 4bc5e31c
      darin authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18711 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4bc5e31c
    • darin's avatar
      Add the bug number. · add0455c
      darin authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18710 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      add0455c
    • darin's avatar
      Reviewed by Darin. · b59a1291
      darin authored
              * rendering/RenderText.h:
              (WebCore::RenderText::selectionState):
              Change the m_selectionState enum-bitfield to an unsigned-bitfield,
              because enums on Windows are signed, which caused it to become
              negative (whereas the valid values are all positive).
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18709 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b59a1291
    • darin's avatar
      Reviewed by Hyatt. · 822f23eb
      darin authored
              - http://bugs.webkit.org/show_bug.cgi?id=12175
                port break_lines.cpp to be platform independent
      
              * platform/TextBreakIterator.h: Added lineBreakIterator.
              Removed ICU-specific stuff from the header.
      
              * platform/TextBreakIteratorICU.cpp:
              (WebCore::setUpIterator): Added helper to be shared by the three different
              creation functions.
              (WebCore::characterBreakIterator): Changed to use setUpIterator.
              (WebCore::wordBreakIterator): Ditto.
              (WebCore::lineBreakIterator): Added.
      
              * platform/qt/TextBreakIteratorQt.cpp:
              (WebCore::lineBreakIterator): Added a stub.
      
              * rendering/break_lines.cpp:
              (WebCore::isBreakableSpace): Added.
              (WebCore::shouldBreakAfter): Added.
              (WebCore::needsAdvancedBreakAnalysis): Added.
              (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms
              other than Mac.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18708 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      822f23eb
    • darin's avatar
      Reviewed by Mitz. · 819745f6
      darin authored
              - added a Thai line breaking test
      
              * fast/text/international/thai-line-breaks-expected.checksum: Added.
              * fast/text/international/thai-line-breaks-expected.png: Added.
              * fast/text/international/thai-line-breaks-expected.txt: Added.
              * fast/text/international/thai-line-breaks.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18707 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      819745f6
    • mjs's avatar
      Reviewed by Darin. · ae8d355f
      mjs authored
              - move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
              
              (it's only ever used for main resources)
      
              * loader/ResourceLoader.h:
              (WebCore::ResourceLoader::setRequest):
              * loader/mac/MainResourceLoaderMac.mm:
              (WebCore::MainResourceLoader::willSendRequest):
              (WebCore::MainResourceLoader::continueAfterContentPolicy):
              * loader/mac/ResourceLoaderMac.mm:
              (WebCore::ResourceLoader::willSendRequest):
              (WebCore::ResourceLoader::didReceiveResponse):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18706 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ae8d355f
    • rwlbuis's avatar
      Reviewed by Eric. · a9031b36
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=12129
              repaint issue after setting viewBox attribute with ECMAScript
      
              Make sure RenderSVGContainer updates after setting viewBox from js.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18705 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a9031b36
    • mjs's avatar
      Reviewed by Darin. · fe030f3f
      mjs authored
              
              - remove window display throttling code; no longer used
      
              * Misc/WebNSWindowExtras.h:
              * Misc/WebNSWindowExtras.m:
              * WebView/WebFrameView.mm:
              (-[WebFrameView initWithFrame:]):
              * WebView/WebPreferenceKeysPrivate.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18704 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fe030f3f
    • lars's avatar
      Make the Qt build compile... again! · 216b5a1d
      lars authored
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18703 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      216b5a1d
    • hyatt's avatar
      Fix for background: inherit bug where background-color wasn't getting... · f235cb06
      hyatt authored
              Fix for background: inherit bug where background-color wasn't getting properly overridden.  This was a
              regression from Safari 1.3 to 2.0.
      
              Reviewed by bdash
      
              fast/backgrounds/background-color-inherit-bug.html
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18702 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f235cb06
    • hyatt's avatar
      Add new layout test for background inherit color bug. · 4064e584
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18701 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4064e584
    • beidson's avatar
      Reviewed by Brian Dash · 8d1e66de
      beidson authored
              <rdar://problem/4895178> 
              WebCore::BackForwardList vector should be backed by a HashSet to remove
              the potential expense in frequently calling BackForwardList::containsItem()
      
              * history/BackForwardList.cpp:
              (WebCore::BackForwardList::addItem): Maintain HashSet as well as Vector
              (WebCore::BackForwardList::setCapacity): Ditto
              (WebCore::BackForwardList::close): Ditto
              (WebCore::BackForwardList::removeItem): Ditto
              (WebCore::BackForwardList::containsItem): Make a hash lookup instead of iterate 
              through the Vector
              * history/BackForwardList.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18700 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8d1e66de
    • hyatt's avatar
      Fix a regression where layout is triggering on all recalcStyles, due to a bad comparison · bc9e4893
      hyatt authored
              in the multicol assignment operator.
      
              * rendering/RenderStyle.cpp:
              (WebCore::StyleMultiColData::operator==):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18699 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bc9e4893
    • darin's avatar
      And forgot change log. · 71b6fb4a
      darin authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18698 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      71b6fb4a
    • darin's avatar
      Oops, forgot one file. · 49da2a7c
      darin authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18697 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      49da2a7c
    • darin's avatar
      - rolled out Beth's RenderFlow::destroy change, which broke 5 editing tests · cea4f2df
      darin authored
              * rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy):
              Used svn merge to roll the change out.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18696 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cea4f2df
    • bdash's avatar
      2007-01-09 Mark Rowe <mrowe@apple.com> · b30006bb
      bdash authored
              Reviewed by Tim H.
      
              Build fix for 64-bit platforms.
      
              * platform/graphics/svg/SVGPaintServerGradient.h:
              * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
              (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18695 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b30006bb
    • andersca's avatar
      WebCore: · ce520eb0
      andersca authored
              Reviewed by Brady.
      
              Move some history related functions off the bridge and into FrameLoader directly.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::canGoBackOrForward):
              (WebCore::FrameLoader::getHistoryLength):
              (WebCore::FrameLoader::historyURL):
              * loader/mac/FrameLoaderMac.mm:
              * page/mac/WebCoreFrameBridge.h:
      
      WebKit:
      
              Reviewed by Brady.
      
              Remove bridge functions that are implemented directly in FrameLoader now.
              
              * WebCoreSupport/WebFrameBridge.mm:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18694 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ce520eb0
    • weinig's avatar
      LayoutTests: · 8eef2e2d
      weinig authored
              Reviewed by Mark.
      
              Update results to include outline-color.
      
              * fast/css/computed-style-expected.txt:
              * fast/css/computed-style.html:
      
      WebCore:
      
              Reviewed by Mark.
      
              Adds outline-color to list of computable styles.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
      
      WebKit:
      
              Reviewed by Mark.
      
              Adds default value for outline-color and fixes default
              values of the recently fixed *-color properties.
      
              * WebInspector/webInspector/inspector.js:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18693 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8eef2e2d
    • bdakin's avatar
      Reviewed by Hyatt. · 57c3d4cf
      bdakin authored
              Fix for a bug that Adam, Hyatt, and I noticed when debugging 
              another problem.
      
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::root): Added assertion. If we are casting to a 
              root, we should make sure we are root.
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::destroy): It is not enough to remove the 
              child boxes for anonymous blocks. We need to be more thorough when 
              cleaning these up. Adam's test case illustrates the problem well.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18690 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      57c3d4cf
    • hyatt's avatar
      Land updated computed style results. · b861641b
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18689 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b861641b
    • hyatt's avatar
      Land updated stroke results. · 583bbe88
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18688 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      583bbe88
    • hyatt's avatar
      Only dump stroke/fill if it's different from color · 6b2fb21a
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18687 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6b2fb21a