- 06 Apr, 2020 40 commits
-
-
Thomas Guilbert authored
This CL tentatively fixes the canvas-drawimage-live-video.html test flakiness. It uses uses video.requestAnimationFrame to makes sure we have new videos frames before drawing them, and making sure that the two drawn images are different. Bug: 816914 Change-Id: I430bedcd4089321eaafe76c10d808820c7726755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136204 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756773}
-
Moe Ahmadi authored
For some reason [dir=rtl] :-webkit-any(#realbox-icon, .match-icon) is less specific than#realbox-icon in RTL preventing the former CSS rule from applying to the #realbox-icon Bug: 1067503 Change-Id: I4b6c86429ca6714b37b40ce5cb745641e0c30830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134649 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756772}
-
Lei Zhang authored
Change-Id: I27698aa13afe8a065acd8eaf5a89ac6dea762aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136467Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756771}
-
chrome://termsOwen Min authored
This reverts commit 5d12d84a. Reason for revert: crbug.com/1068275. This CL may cause EulaOfflineTest.LoadOffline failure on ChromeOS. https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4659 Original change's description: > Make chrome://terms on Chrome OS same as on desktops > > To show "Google Chrome and Chrome OS Additional Terms of Service" > > Bug: 1058348 > Change-Id: I1b37825fe6970bbc7cc59f0c1b26041e350c8fa4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132419 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756677} TBR=alemate@chromium.org,rsorokin@chromium.org,tedchoc@chromium.org Change-Id: I9a35ef08a8aa9d86121327eac74ac65a00a7c29a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058348, 1068275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136431Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756770}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1be7dc68558a..504782cdbabf git log 1be7dc68558a..504782cdbabf --date=short --first-parent --format='%ad %ae %s' 2020-04-06 dproy@chromium.org [trace-viewer] Speed up rendering Created with: gclient setdep -r src/third_party/catapult@504782cdbabf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: nuskos@google.com Change-Id: Ic48d29012a29e283a0fa5f50aeb00d66b4bf67db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756769}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5c29c27e12e4a5df5c39c16b4e130f0261a532bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137658Reviewed-by:
-
Garrett Beaty authored
Bug: 1067999 Change-Id: Ie400d1b600295f3c36fcd422ab84eaf5e51caec0 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137732 Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756767}
-
Sean Harrison authored
Changing no protection options strings to match style of cookie page not recommended string. Bug: 1032584 Change-Id: I47854da34fb906e9fe2ddc39d8c725df7332f674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137445Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#756766}
-
Sylvain Defresne authored
Use `cp -c` to copy file into the bundle which uses clonefile instead of hardlink. This is as efficient in speed and disk usage. This also ensures that files in the bundle are distinct from any other files (which is important when running EG2 tests via Xcode as it tries to overwrite some files with `ditto` which fails if source and target are hardlinked together). Bug: 1042182 Change-Id: I53c08a0ee2200355b3c4249465f78189d6e294d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133930 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#756765}
-
Garrett Beaty authored
Bug: 1067999 Change-Id: I4cd7cd268e9e7d5cb799e106b92130ddf0fc9d89 No-Try: true TBR: agable@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137517Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9d3fad03dfd0..fb7cf9786cf1 Created with: gclient setdep -r src-internal@fb7cf9786cf1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: zmin@google.com,jarhar@google.com,cfroussios@google.com,aboxhall@google.com Change-Id: I1b28aacaba8e26729ebc4ce8c7a4d1c3cd3c371e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756763}
-
Brian Sheedy authored
Removes the WebGL and WebGL 2 expectations that were added due to experimenting with Intel driver 26.20.100.7323. These issues should hopefully be fixed on 26.20.100.7870. Bug: 1026468, 1053803 Change-Id: Ifc6b1cbb61fdd586962117366b316311c4f5a728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137585 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756762}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be2d34de7a06..7767e4fa4792 git log be2d34de7a06..7767e4fa4792 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 mathias@chromium.org Improve custom locations UI Created with: gclient setdep -r src/third_party/devtools-frontend/src@7767e4fa4792 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5fa911bd8adad8a241c8f938aed310f98230cf8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137651Reviewed-by:
-
Johann authored
https://chromium.googlesource.com/webm/libvpx.git/+log/667138e1f058..104adb2aa3e6 $ git log 667138e1f..104adb2aa --date=short --no-merges --format='%ad %ae %s' 2020-04-02 wtc Return VPX_CODEC_INCAPABLE on capability failure 2020-04-02 johannkoenig x86inc.asm: update to 3e5aed95c 2020-04-02 johannkoenig x86inc.asm: namespace ARCH_* defines 2020-04-02 johannkoenig x86inc.asm: only set visibility for chromium builds 2020-04-02 johannkoenig x86inc.asm: do not align .text for aout 2020-04-02 johannkoenig x86inc.asm: use .text on march32 2020-04-02 johannkoenig x86inc.asm: copy PIC macros from x86_abi_support.asm 2020-04-02 johannkoenig x86inc.asm: set PREFIX from libvpx defines 2020-04-02 johannkoenig x86inc.asm: pull settings from libvpx 2020-04-02 johannkoenig x86inc.asm: update to 3e5aed95 2020-03-31 johannkoenig x86_abi_support: use correct hidden syntax Created with: roll-dep src/third_party/libvpx/source/libvpx Change-Id: I0e6fb3bc8e520b2a4a6c68e79c6eee85fc0fd8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136986 Commit-Queue: James Zern <jzern@google.com> Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#756760}
-
zhaoyangli authored
These tests are failing in downstream device builder running EG2 tests. EG2 will run on devices in upstream main after EG1/EG2 swap. This will prevent these builders being red after the swap. Bug: 1046369 Change-Id: I198dce844e896e474c53a0e1e329af5768655119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135416 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#756759}
-
Maks Orlovich authored
Handling Accept-CH on navigation redirects right requires understanding Accept-CH in the browser, and WIP security work says that everything the browser needs in HTTP headers parsed should be parsed by network service... so the client hints type needs to live in services/network Bug: 1050726 Change-Id: I24af1ec72fb0b2f002100ca205e235e15894dc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119792 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756758}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/19d4809e1126..89624cdfd788 git log 19d4809e1126..89624cdfd788 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 ehmaldonado@google.com Reland "git-cl: Execute clang-format-diff.py using vpython." Created with: gclient setdep -r src/third_party/depot_tools@89624cdfd788 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066187 Tbr: agable@chromium.org Change-Id: Id4d47e51444d9319ddfe61c890ceefcd10927eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137652Reviewed-by:
-
Kramer Ge authored
Browser UI thread can be blocked on viz compositor or viz main. RunTaskAfterWindowReady blocks viz main on DRM thread when it is posted by PostSyncTask. These tasks need browser to call CreateWindow through mojo pipe to continue. Deadlocks are caused by this. RunTaskAfterWindowReady needs to be relaxed to lower crash rates. Bug: 1050676 Change-Id: Ie205300fa68300f129c1bb1e7d746c6399a65013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135128 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756756}
-
Zhenyao Mo authored
Before, it's initialized in PostEarlyInitialization, which is a regression introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2078475. Now it goes back to initialize in PreCreateThreads. Also add a flag and a DCHECK to make sure in the future we won't accidentally initialize it earlier. TEST=bots R=jam@chromium.org,kbr@chromium.org Bug: 1055899,1060999 Change-Id: Id9e96a45035d1f5e6173c3f24ecedd0815005d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134864Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#756755}
-
Chris Lu authored
VoiceSearchCoordinator needs a Browser to access a Browser-scoped FullscreenController. Bug: 790886 Change-Id: I24acae364cb64ecc011375045feab66e58dd432e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132852 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#756754}
-
Raphael Kubo da Costa authored
This adapts the implementation to some of the breaking spec changes introduced in https://github.com/w3c/screen-wake-lock/pull/255. Namely, WakeLockPermissionDescriptor has been removed in favor of using a regular PermissionDescriptor object with |name| set to "screen-wake-lock". That spec change also removed system wake locks (and consequently the additions to the WorkerNavigator interface) altogether, but that will be done in a separate CL, so for now we also support a PermissionDescriptor object with |name| set to "system-wake-lock". Bug: 257511, 1064685 Change-Id: I096f3fae24444da5ca6b1eeb3889a813a9e5f270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134228Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#756753}
-
Tarun Bansal authored
Make 4 histograms as LOCAL, and extend expiration date of others. Change-Id: I30e9b63aafb9b1eeec29ccdab27295b8c4d47246 Bug: 1053087,1043725,1037175,1037174, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136887 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#756752}
-
Tomasz Wiszkowski authored
This change introduces additional 56dp semi-compact suggestion variant as well as unit tests for compact omnibox suggestions. Bug: 1067799 Change-Id: I6ae57f5b8dd0b594eb69d4b2c55d59eb57f15ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134677Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#756751}
-
Wenyu Fu authored
We have several different places to launch SettingsActivity. Adding this SettingsActivityTestRule to provide a uniformed entry to launch SettingsActivity. This is the first CL in the series. This CL adds the SettingsActivityTestRule, and change the call for SettingsActivityTest. Other calls to launch SettingsActivity will be migrated in follow-up CLs. Bug: 1066660 Change-Id: I363034e543f9aabbb742d98f3e4b9aa0f0578acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135021 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756750}
-
Scott Violet authored
Noticed this when I happened to be looking for input handling of chromedriver. BUG=none TEST=none Change-Id: Ic0d04badb2e52afd51a1f7e3dd54e546c16c80d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133879 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#756749}
-
Derek Schuff authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/ebf11aaad97f..d304d90ecc17 $ git log ebf11aaad..d304d90ec --date=short --no-merges --format='%ad %ae %s' 2020-04-03 dschuff Update revision for PNaCl 2020-04-02 dschuff Update Mac deployment target to 10.9 2020-04-02 dschuff Disable clang for mips in the toolchain Core SDK build 2020-03-27 dschuff Update revision for PNaCl Created with: roll-dep src/native_client TBR=fabiansommer@chromium.org Change-Id: Ic095454470e816b6bb0d00c71d2e1fee8d946983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136034 Commit-Queue: Derek Schuff <dschuff@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#756748}
-
Lei Zhang authored
All the extra flags passed in it are no longer necessary. Bug: 1067755 Change-Id: I934198975463fcbbae8ec3bf6419ce962d0fe0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135878Reviewed-by:
-
Aya ElAttar authored
Added more granularity to SystemFeaturesDisableList by splitting system features to browser settings and OS settings. Bug: 1067537 Change-Id: I7651158fefc8f348606e98e823f4882f094b1d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134989Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#756746}
-
Erik Staab authored
This builds a CIPD package containing all built dependencies of weblayer_instrumentation_test_apk using appropriate gn args and from the branch where the current working directory is. Bug: 1058968 Change-Id: Ide146f560cdd8e1a7ae95e472efab4813ff70906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135317 Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756745}
-
Garrett Beaty authored
Bug: 1067999 Change-Id: I4c959c9139df0688ab057c6f2934fa93ae1963b4 No-Try: True TBR: agable@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137508 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2288256c9a7a..80e5216a11cf git log 2288256c9a7a..80e5216a11cf --date=short --first-parent --format='%ad %ae %s' 2020-04-06 peah@webrtc.org AEC3: Adding field-trial-based overrides for transparency parameters 2020-04-06 eshr@google.com Move AdaptationCounters from video/ to api/ Created with: gclient setdep -r src/third_party/webrtc@80e5216a11cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067597 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I67aeb292c144d155f308610186ddd0e05c7dbc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137552Reviewed-by:
-
Guillaume Jenkins authored
Adds simple helpers for policy EG tests to set policy values. Values get serialized as JSON to be sent over IPC to the app interface. This CL only adds overloads for boolean, base::Value and json-encoded NSString*, but integer, std::string, arrays and dictionaries will be added as needed. Bug: 1065522 Change-Id: I750cdc3c4456baba91510422a13acb5dea3ea501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125039Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#756742}
-
Joe DeBlasio authored
This CL adds the VRP FAQ doc. This version has been very slightly edited for clarity and grammar, but is 99% the previous draft (go/2020-04-chrome-vrp-faq-draft) Change-Id: Ie8e83d8e1fb277739ec163dd15f5b422cd9190ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134782 Commit-Queue: Andrew Whalley <awhalley@chromium.org> Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#756741}
-
James Cook authored
This reverts commit 8f16e273. Reason for revert: It doesn't fully fix the test when SplitSettingsSync is enabled. I missed one case, but I think it's easier to revert and reland. ../../chrome/browser/chromeos/login/test/js_checker.cc:110: Failure Value of: GetBool(expression) Actual: true Expected: false document.getElementById('sync-consent-impl').$$('#syncConsentOverviewDialog').hidden Stack trace: #0 0x55a3b204a99a chromeos::test::JSChecker::ExpectFalse() #1 0x55a3b204c317 chromeos::test::JSChecker::ExpectVisiblePath() #2 0x55a3aff35571 chromeos::(anonymous namespace)::SyncConsentTest::SyncConsentRecorderTestImpl() #3 0x55a3aff35193 chromeos::(anonymous namespace)::SyncConsentTest_SyncConsentRecorder_Test::RunTestOnMainThread() #4 0x55a3b1f0f111 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #5 0x55a3b195276c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #6 0x55a3b19519f9 ChromeBrowserMainParts::PreMainMessageLoopRun() #7 0x55a3b1188f84 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #8 0x7fa48e51216a content::BrowserMainLoop::PreMainMessageLoopRun() #9 0x7fa48eaa2895 content::StartupTaskRunner::RunAllTasksNow() #10 0x7fa48e5111b3 content::BrowserMainLoop::CreateStartupTasks() #11 0x7fa48e513ee7 content::BrowserMainRunnerImpl::Initialize() #12 0x7fa48e50f336 content::BrowserMain() #13 0x7fa48ef7d613 content::ContentMainRunnerImpl::RunServiceManager() #14 0x7fa48ef7d19c content::ContentMainRunnerImpl::Run() #15 0x7fa482f36c44 service_manager::Main() #16 0x7fa48ef7b5a4 content::ContentMain() #17 0x55a3b1f0ebc8 content::BrowserTestBase::SetUp() #18 0x55a3b18dd9b0 InProcessBrowserTest::SetUp() Original change's description: > cros: Fix SyncConsentTest when SplitSettingsSync is enabled > > SplitSettingsSync adds some text to the OOBE sync consent dialog. > Update test expectations to match, otherwise the test will fail when > we flip the flag. > > Bug: 1067212 > Test: browser_tests --enable-features=SplitSettingsSync > Change-Id: Iaed6053700c1cd2d5cbaadd29443cf564a7d60b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136881 > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Auto-Submit: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756667} TBR=jamescook@chromium.org,xiyuan@chromium.org Change-Id: Id5fedc0af71bb3e6d221582a61c377bbdbd1a08a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137671Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#756740}
-
Sophey Dong authored
This is flag protected by kSendTabToSelfOmniboxSendingAnimation. Screencast: http://dr/file/d/1ySVzuot-OZuP-fsyNGWTnKlf2E5Th4p-/view Bug: 1007536 Change-Id: I5911277b245ae4e7656de10f37c7cc2645016e5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131847Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#756739}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01e88bc1..26e6018d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f3f2910ccb27e84b077b3e5b791404af6285ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136252Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756738}
-
John Z Wu authored
//ios/web_view clients will record consents separately from Chrome. Bug: 1056421 Change-Id: I3a2ce5da480afdd6d62a8d7adf097c9db09dc1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134689 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#756737}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/14215fbea0c8..59b20e348f4d git log 14215fbea0c8..59b20e348f4d --date=short --first-parent --format='%ad %ae %s' 2020-04-06 rwkeane@google.com Discovery: Multiple Network Interfaces Part 1 Created with: gclient setdep -r src/third_party/openscreen/src@59b20e348f4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: If7b80dcac6f918c4857402bc9ec273b0dc66ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137543Reviewed-by:
-
Oriol Brufau authored
Since r629436, trying to inspect a 1000x1000 grid in the devtools would freeze the page. That's because, when determining the areas to be highlighted, the code would try to encode each cell independently. But there can be way too many cells. This patch changes it to encode the rows and the columns, making the algorithm linear instead of quadratic. The `highlights` object returned by `Overlay.getHighlightObjectForTest` now no longer has a `cells` property, and instead has separate `rows` and `columns` properties. I have ensured that with this patch it will be possible to inspect 1000x1000 grid (the current limit) reasonably fast. If I raise the limit to 10000x10000, then it still works well in release builds, but in debug ones it takes almost 2 minutes. BUG=1067748 TEST=http/tests/devtools/elements/highlight/highlight-css-grid.js TEST=http/tests/devtools/elements/highlight/highlight-css-grid-huge.js Change-Id: Ic285a07550b4799d3c22026bdcd387b207f23512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135618Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#756735}
-
Lei Zhang authored
IDS_FEEDBACK_SERVICE_* got abandoned in https://crrev.com/594039. IDS_FEEDBACK_READING_FILE got abandoned in https://crrev.com/708043. Change-Id: I1f7e4cfe91a5603e375e84e474f5a491374f1928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134397Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756734}
-
