GitLab

TestWebContentsFactory is a class that can create WebContents for unittests,
but can be created on the stack. This gives it the advantage of being able to
be used in tests that are already inheriting from something other than
RenderViewTestHarness.

Review URL: https://codereview.chromium.org/962393002

Cr-Commit-Position: refs/heads/master@{#318740}

Cancel() has an overly paranoid NOTREACHED, which makes it unsafe to cancel a
ProxyScriptDecider in between quickcheck and proxy script fetching. This CL
removes that NOTREACHED altogether, and adds a test to cover it.

BUG=409698

Review URL: https://codereview.chromium.org/962373002

Cr-Commit-Position: refs/heads/master@{#318739}

BUG=461610

Executed run_webapp_unittest.py with these changes and all tests passed.

Review URL: https://codereview.chromium.org/953223002

Cr-Commit-Position: refs/heads/master@{#318738}

[Telemetry] Rename PageRun to UserStoryRun part of switching from PageTestResults to UserStoryTestResults

This is the first step, next will rename PageTestResult to UserStoryTestResult.

BUG=442036

Review URL: https://codereview.chromium.org/964913005

Cr-Commit-Position: refs/heads/master@{#318737}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b3310c2..8f9e816

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/969033002

Cr-Commit-Position: refs/heads/master@{#318736}

BUG=266140
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/965933002

Cr-Commit-Position: refs/heads/master@{#318735}

BUG=461865
TEST:
1. enable physical keyboard autocorrect feature from IME settings from chrome-extension://jkghodnilhceideoidjikpgommlajknk/hmm_options.html?code=xkb:us::eng
2. type "waht" and wait for a grey triangle appear underneath "waht"
At this point, an IME window is created.
3. verify no default app icon appear in launcher for the IME window

Review URL: https://codereview.chromium.org/955983004

Cr-Commit-Position: refs/heads/master@{#318734}

BUG=461785

Review URL: https://codereview.chromium.org/946423004

Cr-Commit-Position: refs/heads/master@{#318733}

BUG=462323

Review URL: https://codereview.chromium.org/962783002

Cr-Commit-Position: refs/heads/master@{#318732}

We were using several APIs introduced after API level 14. Fix that.

BUG=462802
R=estade@chromium.org

Review URL: https://codereview.chromium.org/963993002

Cr-Commit-Position: refs/heads/master@{#318731}

BUG=462779

Review URL: https://codereview.chromium.org/968493003

Cr-Commit-Position: refs/heads/master@{#318730}

Chromium side of the implementation of tracking profile stats (number of profiles, number of signed in profiles) through the Omaha channel for Mac. Design doc: https://docs.google.com/a/google.com/document/d/15Ou8VCYNCZvke8Bw9bF3vYqD67voJBPyx_GBR8ONcCw/edit?disco=AAAAAKU7Zzg (Googler Only)

BUG=409895

Review URL: https://codereview.chromium.org/593243002

Cr-Commit-Position: refs/heads/master@{#318729}

Software rendering isn't supported on the GBM platform. Rather than
allow callers to crash due to nullptr accesses, crash explicitly so we
get more meaningfull crash reports.

BUG=461396

Review URL: https://codereview.chromium.org/958403004

Cr-Commit-Position: refs/heads/master@{#318728}

This CL introduces a new TRACE_EVENT_PHASE for memory dump
and enables the MemoryDumpManager to generate actual trace
events when CreateLocalDumpPoint is invoked.

BUG=458295

Review URL: https://codereview.chromium.org/956413002

Cr-Commit-Position: refs/heads/master@{#318727}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f48b013..696617b

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/965793004

Cr-Commit-Position: refs/heads/master@{#318726}

This adds a target to run jscompile over the unittest files.

The save/restore functions of chromeMocks are removed since they are not
necessary. chromeMocks.reset() is called automatically before each test.

It also fixes most of the errors that jscompile produces. For the unittests
where all the errors have not been fixed, jscompile is disabled for those
files. Cases where errors were not fixed include those that require
refactoring base classes to expose an interface that the corresponding
mock can use -- these are best done is a separate, targetted cl.

Also, the it2me tests are not checked because they will be removed soon.

BUG=

Review URL: https://codereview.chromium.org/959963002

Cr-Commit-Position: refs/heads/master@{#318725}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9345eef..b3310c2

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/970943002

Cr-Commit-Position: refs/heads/master@{#318724}

BUG=437508

Review URL: https://codereview.chromium.org/964443002

Cr-Commit-Position: refs/heads/master@{#318723}

BUG=none

Review URL: https://codereview.chromium.org/967213003

Cr-Commit-Position: refs/heads/master@{#318722}

BUG=460998

Committed: https://crrev.com/51c1620185396384cfe6e2f4e3359e57c6431600
Cr-Commit-Position: refs/heads/master@{#318591}

Review URL: https://codereview.chromium.org/964753002

Cr-Commit-Position: refs/heads/master@{#318721}

Current implementation use ContentSettingsPattern::Wildcard()
to reset a setting for the current visiting page, but it does not
work. This should be the embedder URL as geolocation does.

BUG=460733
TEST=manual

Review URL: https://codereview.chromium.org/972733003

Cr-Commit-Position: refs/heads/master@{#318720}

The header include guards should match the file path from root.

These entries were found using a modified version of Eric's
fix-include-guards.py script found attached in
https://code.google.com/p/chromium/issues/detail?id=435361#c7.

BUG=435361
TEST=gn_unittests
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/968193002

Cr-Commit-Position: refs/heads/master@{#318719}

Enhanced bookmark model is the data abstraction layer of enhanced bookmark.

This CL also fixes the bug that add folder returns a wrong bookmarkid.

BUG=458632, 458703

Review URL: https://codereview.chromium.org/929523002

Cr-Commit-Position: refs/heads/master@{#318718}

This will allow the caller to specify an argument to adb public keys to be
written to the device (along with any existing keys already on the device)
during wiping.

BUG=

Review URL: https://codereview.chromium.org/970573002

Cr-Commit-Position: refs/heads/master@{#318717}

All hosts should be using OAuth2 now, so ClientLogin support can
be removed.

BUG=446646,83897

Review URL: https://codereview.chromium.org/959033004

Cr-Commit-Position: refs/heads/master@{#318716}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3da9181..9345eef

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/968933003

Cr-Commit-Position: refs/heads/master@{#318715}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/45ff499..f48b013

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/968163004

Cr-Commit-Position: refs/heads/master@{#318714}

BUG=382562

Review URL: https://codereview.chromium.org/962583003

Cr-Commit-Position: refs/heads/master@{#318713}

+ Reinstate the error code to main content as important for debugging when screen shots are sent
+ Remove the 'Error code:' prefix on the net error for consistency.

Fixes related to browsing scaling:
+ Remove fixed button height to fix cropped button
+ Fix to incorrectly scaled T-rex

Design:
+ Make the faint tick in checkbox have 0 opacity
+ Fix cropped padlock icon

BUG=460116,459510,459126,458484

Review URL: https://codereview.chromium.org/952563003

Cr-Commit-Position: refs/heads/master@{#318712}

Add top_25_smooth.json as archive_data_file for top_25_smooth page set.
top_25_pages page set uses top_25.json.

BUG=418375

Review URL: https://codereview.chromium.org/966283002

Cr-Commit-Position: refs/heads/master@{#318711}

BUG=
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/964413002

Cr-Commit-Position: refs/heads/master@{#318710}

The call to WebViewImpl::setVisibilityState updates Blink's Page state
correctly, but was not notifying the WebFrameWidget's LayerTreeHost.

This patch calls a newly added method in WebFrameWidget that resolves
some rendering issues.

BUG=450674

Review URL: https://codereview.chromium.org/958973002

Cr-Commit-Position: refs/heads/master@{#318709}

DisplayController::UpdateMouseLocationAfterDisplayChange() is now called during
startup:
- In Ozone once a channel to the GPU has been established
- In X11 as a result of
  DisplayChangeObserver::OnTouchscreenDeviceConfigurationChanged()

Moving the mouse on startup:
- Causes side effects such as mouse hover
- Causes a mouse event to be generated which causes
  CompoundEventFilter::SetCursorVisibilityOnEvent() to show the
  mouse cursor.

This CL makes DisplayController::UpdateMouseLocationAfterDisplayChange() move the
mouse only if necessary.

BUG=450860
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/902123002

Cr-Commit-Position: refs/heads/master@{#318708}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2ea3d3a..45ff499

TBR=alancutter@chromium.org

Review URL: https://codereview.chromium.org/964423002

Cr-Commit-Position: refs/heads/master@{#318707}

BUG=393668

Review URL: https://codereview.chromium.org/965813003

Cr-Commit-Position: refs/heads/master@{#318706}

BUG=428729

Review URL: https://codereview.chromium.org/966913003

Cr-Commit-Position: refs/heads/master@{#318705}

This CL adds two more Android instrumentation tests for Web Notifications,
which verify that the "tag" property on a notification will replace any
previous notification being shown, and a test verifying that activating
the notification will invoke the Service Worker, closing the notification.

BUG=462251

Review URL: https://codereview.chromium.org/958993002

Cr-Commit-Position: refs/heads/master@{#318704}

It was never really taken into use (it was meant to be used by external tools
but we never figured out how they should interact w/ Telemetry) and it's out of
date.

BUG=274456
R=skyostil@chromium.org

Review URL: https://codereview.chromium.org/962673002

Cr-Commit-Position: refs/heads/master@{#318703}

BUG=463111

Review URL: https://codereview.chromium.org/968973002

Cr-Commit-Position: refs/heads/master@{#318702}

Update the list of included unit tests on iOS to list all the components
that are built on iOS (based on the list in components/components.gyp).
Use an exclusion to remove all tests that depends on //content.

Sort the list of gypi files included by components.gyp.

BUG=462585

Review URL: https://codereview.chromium.org/963683003

Cr-Commit-Position: refs/heads/master@{#318701}