- 06 Jan, 2020 40 commits
-
-
Kurt Horimoto authored
InfobarBannerOverlayCoordinator is a coordinator that will be shared amongst all infobar banners. InfobarBannerOverlayMediator is a superclass that implements behavior shared amongst all InfobarTypes, such as setting the consumer, dispatching responses for user interaction events, and setting up the overlay completion response. This CL also introduces the response infos necessary for banners: - InfobarBannerConfirmButtonTapped is dispatched to notify the model layer that the main button on a confirm infobar banner was tapped. - InfobarBannerModalButtonTapped is dispatched to notify the model layer that the modal button was tapped. - InfobarBannerCompletion is used a completion response and stores whether the dismissal was user-initiated. Bug: 1030357 Change-Id: Icb19d2a7322fd6c765c19812c02d46dcba07b97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986449 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728584}
-
Peter Kasting authored
Many callers want to do things like "if the link would open in the current tab, open in a new foreground tab instead". This provides a simple way to do that. Bug: none Change-Id: Ia49088031543905ad4d1d0122a8656c675a33e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986122 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728583}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4b11f995..1ca8124e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e4a53b083406b3579bf444890619c199b6444ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988295Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728582}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3716c2068ef3..19b43a602225 git log 3716c2068ef3..19b43a602225 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 bclayton@google.com IDs: Move inline impls below class. 2020-01-06 bclayton@google.com Pipeline: Store builtins on SpirvRoutine... 2020-01-06 bclayton@google.com Style: clang-format the tests source too 2020-01-06 bclayton@google.com Merge changes Id1120acb,Ifc6afcda,I8b5da04a,I9389ad9e,I35d60f68 Created with: gclient setdep -r src/third_party/swiftshader@19b43a602225 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If2425c68f953732fe9d61fa7eb96b88c24f9171a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988491Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728581}
-
Samuel Huang authored
Courgette's ARM support was complex and was never used (except for helping to prototype Zucchini's ARM flow, which is WIP). Recently the code is also causing Fuzzer issues. Therefore we deem it better to just remove the code. This CL performs superficial removal of ARM code. For compatibility, the enums enum ExecutableType { EXE_ELF_32_ARM = 3; } enum EncodedProgram::OP { MAKE_ELF_ARM_RELOCATION_TABLE = 7; } are deprecated and commented out, without changing other values. Bug: 1012592 Change-Id: Iad3a3c9e41470eef8ff004591e6ed42ea4315d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986211Reviewed-by:Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728580}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d0015fb415a4..25b001799ea6 git log d0015fb415a4..25b001799ea6 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 aerotwist@chromium.org Adds known errors to include expanded namespace Created with: gclient setdep -r src/third_party/devtools-frontend/src@25b001799ea6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ief430cbb8fcee159be6507a6637bc982b08a9796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988502Reviewed-by:
-
Avery Musbach authored
When you start dragging a window from overview and drag to another display, the drop target on the destination display shall be in the correct position according to MRU order. Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.DropTargetPositionTest/0 Bug: 961170 Change-Id: I5eb0dd2e7ce94654c13810b3bb0e5adfb468a707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984753 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728578}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d45c872224d..3a46886a357c Created with: gclient setdep -r src-internal@3a46886a357c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:992974 Tbr: jbudorick@google.com Change-Id: Id08835d46a5b9d2e9e79ae318e2b3d54d47fe215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988501Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728577}
-
Mia Glaese authored
MVP with the same functionality as the current TabswitcherModeTTPhone Toolbar, except for the animations. Screen videos here: https://drive.google.com/drive/folders/1bqxiTsr5SSX2p73eZrLao7GRA5ZwIkLw?usp=sharing In follow up CLs: Add animations. Dynamically remove Google logo depending on screen width. Dynamically change toolbar with OverviewModeState. Add identity disc. Bug: 1025296 Change-Id: I6b48b7854088469638a2a4cb22829f24c1e98fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975051Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#728576}
-
Dave Tapuska authored
When a vtable was added to WebKeyboardEvent in crrev.com/547be407 the CFI bot started failing because it was in fact detecting a bad cast. The test never failed before because the cast was to super class that the pointer was actually of and CFI couldn't detect this. BUG=836826 Change-Id: I4dac686561120ec5d363ddccdd47b29629d7389a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988247Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728575}
-
Lucas Furukawa Gadani authored
This tests used to fail without viz enabled, but now viz is launched on ChromeOS as of r726484. Bug: 1006633 Change-Id: I0809e9dca62b3e0b5b3e8e3ee014675279ee6ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980506Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8db9eccc0baf..40801e31ed0c git log 8db9eccc0baf..40801e31ed0c --date=short --first-parent --format='%ad %ae %s' 2020-01-06 johnkslang@users.noreply.github.com Merge pull request #2050 from ShchchowAMD/built_in_MaxVector Created with: gclient setdep -r src/third_party/glslang/src@40801e31ed0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Id7d6e06d5ab333ed7ca84b5561d4de80b4931a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988162Reviewed-by:
-
François Doray authored
The crash stack on the bug is in non-TabManager code. Let's see if the test passes when re-enabled. This CL also: - Splits the test in 2 tests to avoid timing out (local tests show that we can time out when having too many navigations in the same test). - On ChromeOS, allows discarding of the active tab in the last focused browser window if that window is not visible. Previously, the active tab in the last focused browser window was not discardable, even if the window was not visible. Bug: 772839 Change-Id: I18552a16361c8beb4d48409227b727a40cc40ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972570 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#728572}
-
Tarun Bansal authored
These tests check the Prerender implementation which has been replaced by NoStatePrefetch. Prerender used to load the full webpage while NoStatePrefetch only runs preload scanner and fetches subresources found by preload scanner. No JavaScript is executed. This makes it possible to remove some of these deprecated browsertests. Change-Id: I02bbea1494de0c67ee0447887df98a069538726b Bug: 846318,755921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985166Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6be45ec41f27..bddaf4b27a80 git log 6be45ec41f27..bddaf4b27a80 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 mtklein@google.com in gm/skvm.cpp, Fade doesn't need to wrap a shader 2020-01-06 jcgregorio@google.com Don't use CIPD_PKG_CPYTHON for P30. Created with: gclient setdep -r src/third_party/skia@bddaf4b27a80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I82d06c0b31318a0e7ca95997326537bbdcadecb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988495Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0a29f6fe80ef..a5a89d8b8dd5 git log 0a29f6fe80ef..a5a89d8b8dd5 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 lalitm@google.com Merge "perfetto: force linkstatic for all cc_library targets" 2020-01-06 lalitm@google.com Merge "trace_processor: add parsing and ingestion of mm_id of rss_stat" 2020-01-06 lalitm@google.com Merge "ui: fix process slice track" Created with: gclient setdep -r src/third_party/perfetto@a5a89d8b8dd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I741cc1c846b169633704554f08d7e0c1f9d8f1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988494Reviewed-by:
-
Olivier Li authored
Bug: 546640 Change-Id: I44db98e1cc68a91407c783b84dc2f79ce3aba432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978040 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#728568}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=sadrul@chromium.org,vmiura@chromium.org BUG=1039344 Change-Id: Ib4d1567010f972ad1d58305f2d17d0430e45039f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985677Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728567}
-
Rakesh Soma authored
per [1]. [1] https://docs.google.com/document/d/1zDUlxBwkhNXBQRNifEjK2fylRKE7WmYALej1u-bzshk Change-Id: I641595027b2e4571d44431486ac2ef2105b586c6 Bug: 1038515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973359Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#728566}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=mythria@chromium.org,ulan@chromium.org BUG=1039295 Change-Id: I418cf1c1be64257871972520008cf61749fa6032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988546Reviewed-by:
-
Tom Anderson authored
For remote connections, SHM doesn't work, but the MIT-SHM extension may still be available, so we need to do an explicit check before trying to use SHM. BUG=1035803 Change-Id: I189ab94b82922572e52b717dc2043b8404745dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980971 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#728564}
-
Andrew Grieve authored
Now that recipe doesn't pass them. Change-Id: Ic8bc5b929bbb08564f81c04a3b35b00ccc550e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987026Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728563}
-
dalyk authored
The detailed host resolution error info in ResolveErrorInfo will be used in a future cl to prepare the error page for secure DNS errors. Bug: 1037899 Change-Id: I4b297208970e15680769d65eb6cf4a8bee4d818a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978105 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#728562}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I817970d70e075df729384698b951da8162282d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988486Reviewed-by:
-
Aaron Leventhal authored
The USB/Bluetooth device chooser was announcing "No devices available" even though devices were available. The message also sometimes briefly flashed. To fix this, wait until data is initialized or initial focus occurs before showing the message. This is one part of ongoing work to improve accessibility of this dialog. Bug: 820351 Change-Id: Ia295b7514725512cf0de539d238402a51e220055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970260Reviewed-by:
Vincent Scheib <scheib@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728560}
-
Luke Sorenson authored
Bug: 1037957 Test: Not necessary. Change-Id: I49eb0d482cc176a44a21c52f9a72d5909216d40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982781Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#728559}
-
Sam Maier authored
This results in deleting tools/android/roll/android_deps Change-Id: I701f7621e44630eac87c54b1b790598e09cf3dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985814 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#728558}
-
Jared Saul authored
This histogram continues to be useful to us and is expected to stay that way for the foreseeable future. Additionally, iOS is still rolling out this feature. Fixed: 1036852, 1036853 Change-Id: Ic5112c37ab86565702f8291ab27555889d0734b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986139 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#728557}
-
Ian Clelland authored
Bug: 1033387 Change-Id: Iae271c16384dfa3282e13765693e71e6be810cdf TBR: jbroman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988508Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#728556}
-
Md. Hasanur Rashid authored
Removal of the "arch=" flag since it seems to be completely ignored. "arch=x86", "arch=x64", and no arch param all downloaded the same component. Bug: 1027238 Change-Id: Iddb23995df2b5c8e273aa96bed8a27233c72257a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984790Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#728555}
-
Raymond Toy authored
Previously NewExpectedStatusCB() returned PipelineStatusCB. have it return PipelineStatusCallback instead. This also required updating all Initialize() methods to take a PipelineStatusCallback instead, and changing the member init_cb_ to have type PipelineStatusCallback. Bug: 1007799 Change-Id: I9c9b01f9725f4347ec953c21fffd6dc199c20307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974756Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728554}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/10d8de7541ab..50b013871c53 git log 10d8de7541ab..50b013871c53 --date=short --first-parent --format='%ad %ae %s' 2020-01-04 wl@gnu.org Add reference to another oss-fuzz bug report. 2020-01-03 wl@gnu.org [woff2] Fix memory leaks and a runtime warning. Created with: gclient setdep -r src/third_party/freetype/src@50b013871c53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Id0d71db938953ee31713ca5932e89439476f9ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987397Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728553}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/15e191fdcca2..024c350baa03 git log 15e191fdcca2..024c350baa03 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 yueherngl@google.com jacuzzi: add firmware/factory branch builder 2020-01-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-03 engeg@google.com parallel.py: Increase silent timeout to 8 hours 2020-01-03 cjmcdonald@chromium.org contrib: Add a script to dump lib dependencies of platform2 ebuilds 2020-01-03 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-03 saklein@chromium.org Build API: Begin moving GomaConfig to endpoint arguments. Created with: gclient setdep -r src/third_party/chromite@024c350baa03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I4508347b234595853215566932bda4c9ccc57710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988405Reviewed-by:
-
Dominique Fauteux-Chapleau authored
See bug on how to reproduce the failure. The drop being aborted by deep scanning results in the drop data in web_frame_widget_base not being cleaned up, and causes assertion failures when a new drag is initiated. Calling OnDragExited cleans up the appropriate resources. Bug: 1033156 Change-Id: If2ab81a27ae65033c794f580344cd9c71d21f79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964533Reviewed-by:
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=sadrul@chromium.org,vmiura@chromium.org BUG=1039283 Change-Id: I2ad1b19b5579289280da1744346131aa9b6dad11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983211Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ed06c87. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6739689d61aff26f1b68dfbcbda297de0eba9589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988293Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728549}
-
Richard Knoll authored
Extending ExactTaskCreated and TaskExpired as NotificationTriggers are now using the exact task API. Bug: 1037582 Change-Id: Idc5b842efa4961d33ca4821862ba9b0ded9d951a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988347Reviewed-by:
-
Tom McKee authored
WindowPerformanceTest exists to check the behaviour of WindowPerformance instances. It used to mock a page with DummyPageHolder (which, by way of a LocalDOMWindow, would end up owning a WindowPerformance instance) as well as construct its own WindowPerformance instance. This lead to the mock objects referring to a separate, intrinsic WindowPerformance than the one being directly manipulated by the tests. This change removes the one-off constructed WindowPerformance and exercises the WindowPerformance from the mock objects instead. Change-Id: I90980074362c36b630252a82f58b973ae1963965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965942Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#728547}
-
Mike Wittman authored
Relands 6f0c3820 with the StackSamplerImplTest.CopyStackTimestamp test updated to aggregate initialize the thread context to avoid using an uninitialized value. Records timestamps along with samples and plumbs them through to the ProfileBuilder interface. The CallStackProfileBuilder subclass will be updated in a following CL to record the timestamps, to support retrospective tagging of metadata on the samples. TBR=thestig@chromium.org,oysteine@chromium.org Bug: 1034758 Change-Id: Ibc3567a195c148ac2520bc19a757e9f8762823aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979006Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/347030813829..d0015fb415a4 git log 347030813829..d0015fb415a4 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 aerotwist@chromium.org Adds support for additional localization calls 2020-01-06 tvanderlippe@chromium.org Migrate resources/ to ESM Created with: gclient setdep -r src/third_party/devtools-frontend/src@d0015fb415a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I762170457a3a80d7d4f4f2e708c4a250859e7081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988408Reviewed-by:
-
