- 22 Dec, 2020 35 commits
-
-
Song Fangzhen authored
Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 905818 Change-Id: I72e869c64a486534ceee150010febb10574cd1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595554 Commit-Queue: Ke He <kehe@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#838784}
-
Minoru Chikamune authored
This test was disabled due to flakiness. TBR: mlamouri@google.com,mlamouri@chromium.org,beccahughes@chromium.org,mario@igalia.com Bug: 1157263, 1157241, 1157239, 1157319 Change-Id: I9579f7f5f57dff4ac3bad4a458381d2be02f5984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599782Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#838783}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia8f3364a4fab1d7d431a222c4817c6b52e50313b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599931Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838782}
-
Findit authored
This reverts commit 3132a551. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 838729 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzEzMmE1NTFiZTUzNGNiMTJlZTlkYzA1ZjdkOWRlYzZlMDMzZmIzMQw Sample Failed Build: https://ci.chromium.org/b/8860248290928956432 Sample Failed Step: bf_cache_browser_tests Sample Flaky Test: OptimizationGuideKeyedServiceBrowserTest.CheckForBlocklistFilter Original change's description: > Fix sequence checker dcheck assumptions for optimization guide filters > > The bloom filter and optimization filter can get destructed on > background thread when a new component comes in after initial load > > Bug: 1160660 > Change-Id: Ia1dd5925d7513391148b677fb3e75b818a9fa190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600040 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838729} Change-Id: If61e0c71d69fd4d7ef865229c986bd890ea66527 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1160660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600537 Cr-Commit-Position: refs/heads/master@{#838781}
-
Hiroshige Hayashizaki authored
Previously, it returns - `mojom::blink::ScriptType`, - `bool is_import_map` and - a `bool` as a return value indicating whether the type is valid or not. To unify these, this CL introduces `ScriptTypeAtPrepare` that includes `kImportMap` and uses it throughout ScriptLoader. Change-Id: I6573bb2c07b81c4161d7ad51c425ac6499e2bc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593737 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838780}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8649e49d10e6..9e63abad22c3 2020-12-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b24ac092..256e7a49 (838641:838749) 2020-12-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 526e51a1..b24ac092 (838529:838641) 2020-12-21 nisse@webrtc.org Delete unneeded and incorrect logic for 32-bit time wrap around If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I11292c5ab774e1118180930f6d12a07b4e766f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599929Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608560380-1035bf8a36b405614508f1a548443341a120ef85.profdata to chrome-win64-master-1608584327-4304abe23e8dda4e43ddca7236e69787683fcf69.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I03016da9b36e73bb6587a1ecd082e5133083e1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599049Reviewed-by:
-
Daniel Cheng authored
The new tests case mutates the frame tree in a JS unload event handler that runs in the middle of Frame::Swap(), to ensure that Frame::Swap() does not accidentally corrupt the frame tree. Bug: 1139872 Change-Id: Id26039caeecaff57f1b32f9c1e312f98e2e3fb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596539 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#838777}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c65f224a7259..8986f3ce67ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I95513a5f847219db5b814736d18138946a096d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600262Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8331a0a21dcc..0b9574c6ab0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chikamune@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144488,chromium:1160994 Tbr: chikamune@google.com Change-Id: Ie764b8de6df6ea26d9089651df94566ea2c73099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600444Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838775}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608573074-c037592ba2f8332cc5c933010a8eab8414fcad34.profdata to chrome-mac-master-1608595019-a1efd1e358da4acb2ccda1ed29c9decc57e1f1a4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I47dd64dc5fb901ed8e16b3b45861566573975099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600456Reviewed-by:
-
Mustafa Emre Acer authored
Change-Id: I8ad871b406588f428d88a8cc288aff707f6ee7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600245Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#838773}
-
Yuichiro Hanada authored
This reverts commit f93b22c3. Reason for revert: It causes crashes. Please see crbug.com/1160507 Bug: 1160507 Original change's description: > Set window properties when creating widget, not after. > > Optimize ArcOverlayManager so that it observe arc windows only. > > Bug: None > > Change-Id: Ic6c5f43fea647369eac092c1c4c4d68aed7d8ce9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578377 > Commit-Queue: Mitsuru Oshima (slow: gardener) <oshima@chromium.org> > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838281} TBR=oshima@chromium.org,lpique@chromium.org,yhanada@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I11338ea9ab9fd72aa3d0b0a14b0b47a51edb1425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600417Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#838772}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608573074-24f850c78c572e5bf0ca93d4771b7966907fde32.profdata to chrome-linux-master-1608595019-a0bd318bb8a0ed35709996d06b97067430714050.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id730005e1222b7d6246c90a1da8ac609345ff049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600400Reviewed-by:
-
Sinan Sahin authored
Bug: 1161002 Change-Id: I70101620574542bd52a62442258193b45edc5326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600439 Auto-Submit: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#838770}
-
Anne Lim authored
Bug: 1160785 Change-Id: I171eb315e7de733b1c3d19b35946b85c4ed44755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600240Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#838769}
-
Alex Danilo authored
CL:2564981 coalesced some CSS together which changed the specificity of the [file-type-icon] selector, resulting in the icons on context menus being centered if the attribute was set. The attribute is set for some file types and never removed. Add code to remove the [file-type-icon] attribute, before updating the context menu default item state. Lower the CSS specificity of the [file-type-icon] rule by removing the body.files-ng prefix, so the common.css cr-menu selector rules are more specific and override the setting for background-position. Bug: 1158591 Change-Id: I1a6eaa9bc232532d599bea70d0e1e5bb669b05e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600416 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#838768}
-
Jeremy Roman authored
Presently it uses the old deprecated style, which is also slightly less efficient. Change-Id: I09ea546e2254856d19ee7f0043b10575b7356260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176657 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#838767}
-
rbpotter authored
- Refactor rollup plugin now that all chrome://resources files are read from the same folder to use a map and helper instead of duplicating logic for the Polymer and resources cases. - Add new external_paths argument to the rollup plugin, allowing URL prefixes to be mapped to directories. - Use this argument to pass the necessary mappings for resources and Polymer files to the plugin, instead of hardcoding the paths there - Allow the argument to also be extended by invokers, so that individual WebUIs can add their own mappings in addition to the defaults for chrome://resources and chrome://resources/polymer/v3_0. Bug: 1156829 Change-Id: I24ef5c43bac6d98226d34ebcb0717afb6f288869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593720 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#838766}
-
Alex Turner authored
This is a reland of 878c8c7d Reason for reland: media_blink_unittests should no longer be flaky after updating the condition in UpdateBackgroundVideoOptimzationState(). The flakiness derived from CancelableOnceCallback/Closure::IsCancelled() returning true after the callback is run. Original change's description: > Finish base::Bind -> Once/Repeating migration for media/blink and /cdm > > Use of base::Bind, ::Callback, etc. is deprecated in favor of the more > explicit Once/Repeating versions. Despite being marked as fixed, a few > directories have some remaining uses that were missed in the conversion. > This cl fixes those stragglers in the media/blink and media/cdm > directories. The presubmit is also enabled for these directories to > avoid any future regressions. > > Bug: 1141533, 1102651, 1007802 > Change-Id: I0a58ba3165c1c8873a25de76065a7425495b62b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505580 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: Alex Turner <alexmt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822344} Bug: 1141533 Bug: 1102651 Bug: 1007802 Change-Id: Id1f87603ca9d41fe4fad91d6a7b389c889669fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508930 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#838765}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec26b8d2b2f8..8331a0a21dcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chikamune@google.com,liberato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: chikamune@google.com,liberato@google.com Change-Id: If749a49145a38eb61ed646a5c33a4fa32ca715c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600224Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: Id61793132aab3c3dd830bbe7cdd1f7d67814252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599636Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Shengsong Tan <sstan@google.com> Cr-Commit-Position: refs/heads/master@{#838763}
-
Camillo Bruni authored
Additionally add checks to make the contract as per spec [1] for the source_url and base_url clear that kExternalFile modules have source_url == base_url. [1] https://html.spec.whatwg.org/multipage/webappapis.html#concept-script-base-url Bug: 1154943 Change-Id: I761e5fcdef2298c43b908ba09257e9d99dc40df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595415 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4e2b6d6b0102..11c31e0a4a73 2020-12-21 senorblanco@chromium.org Changes to build inside a Dawn checkout. 2020-12-21 cclao@google.com Vulkan: MapBufferRange should avoid wait if INVALIDATE_BUFFER is set If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id2311c896715079c6c04b9fe3ffb4adee7779ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599921Reviewed-by:
-
Alex Ilin authored
cr-customize-themes isn't fully accessible because the custom elements used to display color buttons don't have any associated aria roles. This CL improves the accessibility of cr-customize-themes by assigning role="radio" and aria-checked attributes to the color buttons. Bug: 1158409 Change-Id: I04f07e569bb11dbd9c04c82578ad0b07ea131037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591127 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#838760}
-
Andrew Nicols authored
When an element is no longer attached to the page's DOM a StaleElementException should be thrown per the JsonWire specification. R=johnchen@chromium.org, shengfa@google.com Bug: chromedriver:3675 Change-Id: I96e300388737ab62cebe07ac851254059ccaef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596290Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Auto-Submit: Andrew Nicols <andrewrn@gmail.com> Cr-Commit-Position: refs/heads/master@{#838759}
-
David Black authored
In order to support forking of the holding space welcome banner text for tablet mode, tablet mode change events needed to be dispatched to the files app extension and the files app extension needs to be able to request tablet mode enabled state at runtime. This CL adds a 'tablet-mode-enabled' class to the DOM when tablet mode is enabled. This can be used in CSS to apply tablet mode specific UI treatments. In the case of holding space, two elements are added to the DOM for welcome text. Only one text element is displayed at a time, depending on whether or not tablet mode is enabled. Note that the actual tablet mode string will be implemented in a follow up CL. Bug: 1154347 Change-Id: I4e6be688da6348a7908f48cd59bbeef6c9d2727d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591712 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#838758}
-
Aya ElAttar authored
- Partial follow-up to crrev.com/c/2461372 where originated_from_renderer_ wasn't copied in Clone(), This fixes Clone() by copying orginated_from_renderer_. - Adds unittests for OSExchangeDataProviderNonBacked to ensure Clone works properly in the future. Bug: 1154232 Change-Id: I7fcbe3d6162ac7f5a500c1292ad72d8e8c7ea8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597596Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#838757}
-
Aaron Leventhal authored
If the role logic needs to be overridden, do it via DetermineAccessibilityRole() or Init(). Do not allow RoleValue() to be overridden, as the role must no vary during the lifetime of an object. Bug: None Change-Id: I14bda422895924f495be13e67de1a598ccbebeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598621 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838756}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c65f224a7259..8986f3ce67ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I501c0815fac3a2da3d170a178304f523a72664ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600239Reviewed-by:
-
Aaron Krajeski authored
Throughout cc callers sometimes need to check if a transformation matrix preserves axis alignment or is a perspective projection. These functions already exist on SkMatrix, but we're trying to move away from SkMatrix towards SkM44. Add the helper functions to cc itself with a note to maybe add them to Skia if they start getting used outside of cc. Bug: 1155544 Change-Id: Ieb90af59775b9ec22029e9e941acbb937179c978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595831Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#838754}
-
Shengfa Lin authored
This change assumes that json/list returns chronological order; the first tab is the newest opened. ChromeDriver defaults to use the first tab of type page from json/list; however, this tab could be opened and closed by user, which could cause ChromeDriver failed to connect to the tab. Instead, we will use the last tab. Bug: chromedriver:3690 Change-Id: I813ee6e6802fba122d819fa6232dbf07f2b2cb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600237Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37fb5ece29fd..70441189dfa1 2020-12-21 paulirish@chromium.org [Lighthouse] Roll Lighthouse 7.0.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9efd30bb8e9cc9bf7b6bea12fe69add2f3ee5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599886Reviewed-by:
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in css/selectors/focus-visible-006.html and css/selectors/focus-visible-008.html. TBR=lanwei@chromium.org,mustaq@chromium.org Bug: 1145677 Change-Id: I41347fbe7a1fc2c1d88c548b0f2f6ef86ee75154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600018Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838751}
-
kenkangxgwe authored
Bug: None Test: run cast_media_audio_unittests --gtest_filter=*PostProcessorTest.* Change-Id: I742ed1cad68d81677d90b98682f1d473c05e20a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591915Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mingyu Kang <kenkangxgwe@google.com> Cr-Commit-Position: refs/heads/master@{#838750}
-
- 21 Dec, 2020 5 commits
-
-
Javier Fernández García-Boente authored
Since r807457 we changed the TextBreakIterator default's behavior so that it breaks always after a space, instead of before any space run. In order to implement this new behavior, we needed to compute as well the end of the non-hangable run of the Item being processed. In the mentioned change, we forgot to apply this behavior in the code path used when the soft-hypenation is not enabled. This CL fixes that by determining the non-hangable run end in that case. Bug: 1158747 Change-Id: I1a1324b3d775c24e44aa29b097c45e626d0ad76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597581 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#838749}
-
Jeffrey Young authored
Mock out all Ambient mode disk access in unit tests. BUG=b:165481552,b:169813071 TEST=ash_unittests --gtest_filter="AmbientPhotoControllerTest.*" TEST=ash_unittests --gtest_filter="AmbientPhotoCacheTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ic063e6b7686a74c67fbe7a23e146a9e1640abfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558590 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#838748}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdff3fcba638..960bd2dbaa6a 2020-12-21 mtklein@google.com allow arbitrary Builder Features 2020-12-21 brianosman@google.com SkSL: In the front-end, rename PipelineStage to RuntimeEffect 2020-12-21 rmistry@google.com Update go.skia.org/infra in go.mod/go.sum 2020-12-21 bsalomon@google.com compare kernel in GrBicubicEffect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Iddbd56b825422c30996b495f59bc6702abc0a5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599919Reviewed-by:
-
Ella Ge authored
Bug: 1152282 Change-Id: Ieced102dbf0f15feadd688c5cc990438d0cdec08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595846Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#838746}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb4a68ccf148..ec26b8d2b2f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106990 Tbr: liberato@google.com,juanmihd@google.com Change-Id: I5bcc2fd092fb87ad70f9cf1c6a20e768d4cb01fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599675Reviewed-by:
-
