- 14 Jan, 2021 40 commits
-
-
Kenton Lam authored
The types.js file now just contains typedefs for Closure. There are some constants defined in events.js which are actually used at runtime. Change-Id: Ibe12b78de463785e1a27f613ff6cad54facaa90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626614Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#843389}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f6d4980860b..da4de1dd41b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com,mpearson@google.com Change-Id: I3a31e0918c6eaf015492d47567e99cd6acda018e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628371Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843388}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c4a1bd4553ff..2cc3490759bb 2021-01-13 amaiorano@google.com VulkanBenchmarks: add texture sampling to Triangle benchmarks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3cadc323dededbb3be8203bb027e43e6538c4875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625938Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843387}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6c79df687e09..198dc345383e 2021-01-13 sunnyps@chromium.org Support importing NV12/P010/P016 D3D textures as EGLImage 2021-01-13 ynovikov@chromium.org Don't build angle_end2end_tests_mac_sources on iOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1116101 Tbr: timvp@google.com Test: Test: D3DTextureYUVTest* Change-Id: I37d409364c0c715b3205aeaa0d534bfe972f82fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628612Reviewed-by:
-
Erik Chen authored
This CL implements the sign() method from the platform_keys_internal extension API. It adds a new Sign() method to the crosapi KeystoreService that simply forwards the call to ash. Change-Id: If696709159d2e8d97afd3133534f325f019344fb Bug: 1164523, 1166105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626086 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#843385}
-
Kenton Lam authored
In preparation for adding webui message handlers, it will be cleaner to have the dialog-related code in a separate file. Change-Id: I926788149d63a512055d1bb1932f60362f6b6172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626811Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
-
Ghazale Hosseinabadi authored
On chrome://extensions/shortcuts, when shortcut is set, a11y announcement is not correct, since it announces "Shortcut is not set". This CL fixes this bug, i.e., when shortcut is set, it announces "Shortcut set", followed by the shortcut. a shortcut, and navigate back to re-read the set shortcut. Bug: 1031007 Test: Enable screenreading, navigate to chrome://extensions/, set Change-Id: Ib128b637222ff3e0f92742781e75d8320edb345a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625749 Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843383}
-
Kenichi Ishibashi authored
This CL changes the owner of ServiceWorkerStorageControlImpl as a preparation for service worker Storage Service migration. In an end state, storage::PartitionImpl will own the instance of ServiceWorkerStorageControlImpl in production and browser tests. In unit tests, an instance of ServiceWorkerStorageControlImpl needs to be hosted somewhere else because content::StoragePartitionImpl (which owns a remote to storage::PartitionImpl) is not available for most unit tests. This CL: * Makes ServiceWorkerContextWrapper own ServiceWorkerStorageControlImpl so that ServiceWorkerRegistry doesn't have to own it. This ownership is tentative and the ownership will be transferred to storage::PartitionImpl in the future. * Makes EmbeddedWorkerTestHelper own ServiceWorkerStorageControlImpl for unit tests. As side effects, this CL: * Moves SimulateStorageRestartForTesting() from ServiceWorkerRegistry to EmbeddedWorkerTestHelper. * Makes ServiceWorkerContextWrapper hold the file path for the database and a reference to QuotaManagerProxy so that ServiceWorkerContextWrapper can create an instance of ServiceWorkerStorageControlImpl as needed. The lifetime of ServiceWorkerStorageControlImpl in ServiceWorkerContextWrapper is almost the same as ServiceWorkerContextCore for now. Bug: 1016064 Change-Id: Ife17ba8122342808cfd9bb3f18ad69524838c6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623727 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843382}
-
Yutaka Hirano authored
The traits were needed because of FrameHostMsg_OpenURL which was removed at https://chromium-review.googlesource.com/c/chromium/src/+/2259537. Bug: None Change-Id: I87282de1ff5f4479099291e9ea39f2ee877f1fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626851Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#843381}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.90. R=rmhasan@google.com Bug: 1041619 Change-Id: Id6e03214083a962849d4f523d422928f04af0162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625920 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#843380}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I8057dbe4cf6afff55b7f92cdf3bcb99dfad31380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628000Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843379}
-
WangHui authored
Don't send error callback for request originated from within a service worker since we can't get a |AwContentsClientBridge| based on the |render_frame_id| of the |request_|. Bug:None Signed-off-by:
WangHui <wanghui210@huawei.com> Change-Id: I66172b371b305b7d8ef88f87e1a21d3097d1a5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627528Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843378}
-
Miguel Casas authored
MS Teams on ARM-based ChromeOS with the new VideoDecoder (not launched) tries to create many direct video decoders (I see e.g. 42 on kukui); some succeed but eventually they don't and the tab ends up hitting an OOM. The process is not well understood and needs further debugging. This CL replicates the kMaxNumOfInstances [1] logic from the legacy VideoDecodeAccelerator to the new direct VideoDecoder, so the new behaves like the old, allowing us to unblock the linked bug. [1] https://source.chromium.org/search?q=kMaxNumOfInstances&sq=&ss=chromium%2Fchromium%2Fsrc:media%2Fgpu%2Fv4l2%2F Landing this provision on Kukui was already discussed on . https: //chromium-review.googlesource.com/c/chromium/src/+/2372926/10#message-ca9039b5fb3eb9e1fbcd9701ddc476b257f088d6 Bug: b/170870476 Change-Id: Ice0d9f16e7ca0063c03cccdafe54e29ad5602cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628069 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#843377}
-
Daniel Hosseinian authored
Store the creation and modification dates as base::Time fields in DocumentMetadata. Bug: 93619 Change-Id: I34eedf5cf88dd102e492ed0451d3e4a4a7988cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610626 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843376}
-
Austin Sullivan authored
Refactor chrome/browser/ui Bug: 1110509 Change-Id: I39f7b5c4845890450bd187adf42b8881bdad29b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602577 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#843375}
-
Connie Wan authored
Bug: 1106846 Change-Id: Icb8f2ae377e68eef47636bd881947ad0b3e8281d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419755 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
-
Erik Chen authored
This CL refactors the ash implementation of platformKeysInternal.getPublicKey into chromeos::platform_keys. This has no intended behavior change for ash. This CL hooks up the crosapi KeystoreService::GetPublicKey by forwarding to the same chromeos::platform_keys implementation. Change-Id: I19daa05727353c65ca072e365297c0e51f6d8b85 Bug: 1164523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626044Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Austin Sullivan authored
Annotates destructor with "override" - MockFileSystemAccessPermissionContext - MockFileSystemAccessPermissionGrant Bug: N/A Change-Id: I0182c5040282b1e8da0ee0a2f91871fe68c592f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618368 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
All modules wait for each other before showing up. A timeout protects against long loading modules. It is not clear yet what the best timeout is. Thus, the timeout duration is Finch-configurable. Fixed: 1154008 Change-Id: I1dcd29a168c4f01408979c439edb47903837371f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623718 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843371}
-
Omar Morsi authored
With crbug.com/1113115 closed, ARC applications can be mentioned in KeyPermissions policy to enable ARC to access corporate keys. Bug: None Change-Id: I283c399b4d593f4b33910f2e8d160ab09be91e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561841Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Commit-Queue: Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843370}
-
David Black authored
Per last minute change, selection will no longer have a ring. It will just be a semi-transparent blue overlay. Focus ring will more snugly fit the view. Bug: 1147182 Change-Id: Ib6257dee971d3a3f6d8f11ba663b300e1fb7d1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628501 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843369}
-
Yulun Wu authored
ui/views/controls/label does not use themed colors from ash/style so app_list_item_view should explicitly modify the color for title_. Bug: 1139478 Change-Id: I590663a1c2e27c35f148a557017451c41d8db214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627874 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843368}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/59abfbcd2b03..704a1aa4c802 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I088b92d8a0eeb6116397a0584d8cb739ccf733a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628588Reviewed-by:
-
Austin Sullivan authored
PerformSafeBrowsingWriteChecks -> PerformAfterWriteChecks The method was renamed a while back. Bug: N/A Change-Id: I44c8e13e467e17c98cdbb5cea9b50e9195e08fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618496 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
-
David Black authored
When in tablet mode and in an app, the shelf config changes and the default size for holding space previews is too large. Now, shelf config changes are observed and holding space previews are resized to fit. Resizing previews surfaced a few issues also fixed in this CL: 1. Layers were not being destroyed after shifting outside the viewport. 2. More than 3 previews were visible to the user at a time. Issue 2 resulted in the 4th preview being slightly visible, making it look like paint artifacts of the 3rd preview. Not showing the 4th preview introduced some jank when shifting it in because it would appear out of nowhere before shifting into position. To soften this, added an opacity animation when creating the view. Bug: 1165326 Change-Id: Iae5d00c98b8cb24025d0275c6af49b1a13d48f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628589 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610560809-8437f20a31feb534d6a6f0fc9839520be075bc3e.profdata to chrome-linux-master-1610582310-441e5d44b17635eb24bffd5edcdc41a0f840e530.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I409d939daa45922b069918cb15f8d301c16451a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626785 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Clark DuVall authored
This should help startup on Monochrome since we can avoid loading splits that will not be used by WebLayer. This will likely have memory benefits in the field. -4.4% weblayer_startup_wall_time: https://pinpoint-dot-chromeperf.appspot.com/job/10843ff4d20000 Bug: 1146438 Change-Id: I1c1dfcda323e9f8c41d05959c580ce050f76bf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626101Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b42c4e7..712b239b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1ca4295ce68eff96583d97e65760d25e19929c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628488Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843362}
-
Stefan Zager authored
Change-Id: Ia9e3c44787c081e2495d87f500d429617c7329bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623725 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#843361}
-
Eugene Zemtsov authored
At this point only Opus encoding is supported. Bug: 1094181, 1094179 Change-Id: I05b22bcbd29e96b3823d00dbf85f007936678751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625822Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843360}
-
Mark Schillaci authored
This CL is the seventh part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. ---------- This CL adds the following: - Syncs Regular and Incognito behavior as per new reqs - Corrects unit tests for above - Adds an AXMode observer to watch for screen readers being enabled - Adds TabModelObserver to proactively dismiss dialog on tab close ---------- This CL is expanded upon the original CL here: crrev.com/c/2585587 which was reverted here: crrev.com/c/2589933 Rather than a simple Reland, this CL is the original CL plus improvementss and a bug fix to prevent further issues. AX-Relnotes: Android accessibility image descriptions behavior in incognito tabs will now match the regular tabs behavior for that profile. Bug: 1057169, 1158342 Change-Id: I92d9dd87081ca9b7efb09be93ca32f9be7050768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596417Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#843359}
-
Toni Barzic authored
Adds a way to update holding space icon preview layer without an animation, and utilizes it when the icon previews are first being shown (i.e. when the list of previews is updated from an empty list). In this case, tray icon will have it's own visibility animation, so there's no need for running a separate bounce in animation within the tray icon. Also, updates how tray icon updates are scheduled - instead of updating the tray visibility synchronously, and then scheduling a previews update, the logic is changed to update previews icon synchronously, too. (the throttling became less important now that additions of multiple items to the holding space are done in a batch, instead of one-by-one). BUG=1166014 Change-Id: I3211672072262e9fff75b04a3316c6049099c749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627169 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843358}
-
Daniel Hosseinian authored
Bug: 93619 Change-Id: I14ffeabbbfac3321167f735329c0b7b50a2709f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617131 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Xinghui Lu authored
To fully replace the old SBER checkbox with the new enhanced protection message, some tests are removed entirely because the SBER checkbox doesn't exist anymore: SafeBrowsingBlockingPageBrowserTest.VisitWhitePaper SafeBrowsingBlockingPageBrowserTest.ToggleSBEROn SafeBrowsingBlockingPageBrowserTest.ToggleSBEROff Some tests are slightly modified by removing the old extended-reporting-opt-in element: SafeBrowsingBlockingPageBrowserTest. MainFrameBlockedShouldHaveNoDOMDetails SafeBrowsingBlockingPageBrowserTest.ReloadWhileInterstitialShowing SafeBrowsingBlockingPageBrowserTest.VerifyHitReportNotSentOnIncognito For PolicyTest, remove the check of opt-in checkbox in SafeBrowsingExtendedReportingPolicyManaged and add a new test for checking the new enhanced-protection-message message with the kSafeBrowsingProtectionLevel policy. Bug: 1130721 Change-Id: Iaac03d14158d1b207a24b7799ddb8572d22c0d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622057 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843356}
-
Rakina Zata Amni authored
This is a reland of 55f04b52 Original change's description: > Copy attributes of old DocumentLoader on javascript: URL & XSLT commits > > When javascript: URL evaluates into a string, or XSLT document change > happens, we will commit a new document but won't notify the browser of > the change of documents, as no URL/origin change happens, essentially > treating it as just a content update within the previously committed > document. > > However, we actually create a new DocumentLoader and Document for the > commit, and not all attributes of the old document are actually carried > over to the new document. This CL copies most attributes from the > previous document through DocumentLoader::CreateParamsToClone(), to > ensure future navigations within the new document won't result in > confusion in the browser. Some examples of things that are now copied to > the new document: HistoryItem, http_method, http_status_code, > devtools_navigation_token (so XSLT document transformations show up > on devtools), etc. > > Bug: 1151954, 1048106 > Change-Id: Iefd620c7c3896f2f1ae2fdcc60404361363124eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589206 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843047} Bug: 1151954 Bug: 1048106 Change-Id: I045cd84d088999cb903c0899ebc40cb72219ab3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628267 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#843355}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77ba8103d34f..af9b58e287b5 2021-01-14 johnstiles@google.com Fix fragment processors and unit tests which mix ints and floats. 2021-01-14 johnstiles@google.com Factor out SPIR-V typecasting helper functions. 2021-01-13 johnstiles@google.com Revert "[svg] Perform colorspace conversions for filter effects" 2021-01-13 brianosman@google.com Support ES2-compliant for loops in SkSL-to-SkVM 2021-01-13 tdenniston@google.com [svg] Perform colorspace conversions for filter effects 2021-01-13 bsalomon@google.com Reland "Push SkYUVAInfo into GrYUVToRGBEffect." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I488f83696ce1b1dffee6083b051e0593aee2e2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628547Reviewed-by:
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/002828690efc..74ae09145aaf $ git log 002828690..74ae09145 --date=short --no-merges --format='%ad %ae %s' 2021-01-12 renjietang Retransmit initial data immediately upon receiving RETRY. 2021-01-12 haoyuewang Internal QUICHE change 2021-01-12 danzh Reset alternative path state after migrating to that path. 2021-01-12 danzh Internal QUICHE change 2021-01-12 fayang Internal QUICHE change 2021-01-12 haoyuewang Remove connection_id added to connection_dispatcher_map_ via either OnConnectionIdRetired or OnConnectionAddedToTimeWaitList in gfe_quic_dispatcher when multiple CIDs are supported. 2021-01-11 quiche-dev Automated g4 rollback of changelist 351231997. 2021-01-11 renjietang Retransmit initial data immediately upon receiving RETRY. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I97d088719240aa28b7cca890136f91fb05bed5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626828Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843353}
-
Prabir Pradhan authored
In ClientControlledShellSurface, when default scale cancellation is disabled, the client will send location values in the display's coordinate space in pixels. The server previously converted the location value into pixels but also expected that it was in the screen coordinates and performed a conversion. The server now assumes the location is already in the display's coordinate when default scale cancellation is disabled, skipping the conversion. BUG=b:177089882 TEST=manual: Try resizing and moving a PIP window on an external display at different scale factors. Change-Id: I10625001d0943c0eaaf1bd6decdb25f714e42b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618910Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#843352}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64d94deaa6a4..32f5f4343ba8 2021-01-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8ea6ff6a407d965e7d387e6f8004bc8f9112fe39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628372Reviewed-by:
-
Clark DuVall authored
I wasn't able to repro the flake locally, but this is my best guess at a fix. Bug: 1166286 Change-Id: I2d229d66ea0f16f2c2f959642cdc5baf1598fdef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628016 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#843350}
-
