GitLab

In the case of ChromeOS, function keys are no longer passed because they are re-written in c/b/ui/ash/event_rewriter.cc

BUG=None
TEST=Manually done.


Review URL: https://chromiumcodereview.appspot.com/12257032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182464 0039d316-1c4b-4281-b951-d872f2087c98

Replace static/native-desktop-only BrowserList::const_reverse_iterator by desktop specific reverse iterators as appropriate.

BUG=129187

Review URL: https://codereview.chromium.org/12262019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182463 0039d316-1c4b-4281-b951-d872f2087c98

This lands server change 42099349.

Review URL: https://codereview.chromium.org/12259004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182462 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sadrul
BUG=176266

Review URL: https://codereview.chromium.org/12253032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182461 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182460 0039d316-1c4b-4281-b951-d872f2087c98

Split language code type correction logic to an independent static
function. Then, apply unit tests to confirm that the logic correct
well-known mal-formed language code.

BUG=175673
TEST=unit_tests --gtest_filter'TranslateHelperTest.LanguageCodeTypoCorrection'

Review URL: https://codereview.chromium.org/12221085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182459 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/12261023/
Review URL: https://codereview.chromium.org/12259013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496

Review URL: https://chromiumcodereview.appspot.com/12258025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182457 0039d316-1c4b-4281-b951-d872f2087c98

This lands server change 42070992.

Review URL: https://codereview.chromium.org/12258005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182456 0039d316-1c4b-4281-b951-d872f2087c98

Deprecate FileUtilHelper::{Copy,Move} and recursive file enumerator
in favor of AsyncFileTestHelper::{Copy,Move,ReadDirectory}

BUG=146215, 174576
TEST=IsolatedFileUtilTest.CopyOut*

Review URL: https://codereview.chromium.org/12212030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182455 0039d316-1c4b-4281-b951-d872f2087c98

'localhost' can be resolved as IPv6 address and IPv4 address.
On the other hands, a test server listens at '127.0.0.1' by default.
Chrome want to connect using IPv6 address firstly. So if the server listens at
only IPv4 address, Chrome connects IPv4 address after IPv6 timeout.

This change passes server proviting host to PPAPI tests, then makes it
available from WebSocket related PPAPI tests.

BUG=175237
TEST=browser_tests --gtest_filter='*.WebSocket_*'

Review URL: https://codereview.chromium.org/12252004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/12257033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182451 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fsamuel
BUG=176122

Review URL: https://codereview.chromium.org/12253030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182450 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182449 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enne

Review URL: https://codereview.chromium.org/12261032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182448 0039d316-1c4b-4281-b951-d872f2087c98

Print good error when parse fails

Use world bounds to set up tree quad viewers so you see all the tiles as they fall offscreen.

Dont fail if the file has real JSON for frame data, instead of JSON-inside-a-string

Put number of inactive tiles at the top of the screen


TBR=ccameron
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12260030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182447 0039d316-1c4b-4281-b951-d872f2087c98

Added managed users only default extensions (will be used to push policy locally)
We need such changes on Chrome OS because it is the only way to apply whitelist
but it looks like similar code makes sense for all other platforms too.

BUG=171922
TEST=manual

Review URL: https://codereview.chromium.org/12221065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182444 0039d316-1c4b-4281-b951-d872f2087c98

Since Importer has been recently disabled, it was forgotten during refactoring GDATA -> DRIVE. This patch updates the constants' names.

TEST=Check if the importer works.
BUG=None

Review URL: https://codereview.chromium.org/12260038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182441 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182438 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation of the TestRunner library doing all the painting

BUG=111316
R=marja@chromium.org

Review URL: https://codereview.chromium.org/12207175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182435 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

BUG=170921

Review URL: https://codereview.chromium.org/12212188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182433 0039d316-1c4b-4281-b951-d872f2087c98

- Fix wrong styles what the presubmit warns.
- Change the order of '@private' and '@constructor' annotations.
- Add/remove blank lines to be better readability.

BUG=175657
TEST=Files.app launches.
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12212187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170921

Review URL: https://codereview.chromium.org/12210082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182431 0039d316-1c4b-4281-b951-d872f2087c98

Don't send vendor/product ids.
Use HTTPS.
Don't open page if screen locked.

BUG=176145
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12262027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182430 0039d316-1c4b-4281-b951-d872f2087c98

This lands server change 42070470.

Review URL: https://codereview.chromium.org/12262002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182429 0039d316-1c4b-4281-b951-d872f2087c98

filemanager: Fix GetDriveConnectionStateFunctionChange to return "offline" when DriveSystemService is unavailable.

Connection-type "offline" is returned with reason "no_service"
Also renamed related variables in JS.

BUG=175522
TEST=Verfify Files app (including "open file", "save file" dialogs) is working if Drive is disblaed, in Incognito window, in Guest mode.

Review URL: https://codereview.chromium.org/12221132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182428 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/12253007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182425 0039d316-1c4b-4281-b951-d872f2087c98

Adds missing JSdos which Closure linter warns. And removes the unused argument of FileTransferController.isDocumentWideEvent_().

BUG=175657
TEST=Files.app launches.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12258003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182424 0039d316-1c4b-4281-b951-d872f2087c98

JSON schema compiler automatically registers api functions in generated_api.cc files for the JSON files specified as schema_files in api.gyp. JSON schema compiler generates code in specific namespace, function names and file paths as per json files.

BUG=159265
TBR=mirandac@chromium.org
TBR=ben@chromium.org
TBR=kalman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12089062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182423 0039d316-1c4b-4281-b951-d872f2087c98

It has been disabled because of bugs.

TEST=Enter usb drive, right click on the usb drive item in the left nav in Files.app, choose Import media.
BUG=176203

Review URL: https://codereview.chromium.org/12255024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182422 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'EE:0213: Missing type in @param tag.' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12255010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182421 0039d316-1c4b-4281-b951-d872f2087c98

Android retry logic currently changes based on number of
devices.  This means that test runs are more flaky when only
one device is attached.  Change this to always retry 3 times.

BUG=175653
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12207172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182420 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses 'E:0210: Missing docs for parameter' errors from closure linter.

All changes are in comment, hence I believe this patch doesn't change any behavior.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12212185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182417 0039d316-1c4b-4281-b951-d872f2087c98

If there exists session sync nodes that use the cache GUID as the ID,
Chrome for Android goes into a deadlock while associating the tabs.

Since SessionModelAssociator::DeleteForeignSession uses its own
syncer::WriteTransaction, we must ensure that we only call that method
without currently holding a syncer::WriteTransaction.

BUG=175782

Review URL: https://chromiumcodereview.appspot.com/12253010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=165557, 162318

Review URL: https://chromiumcodereview.appspot.com/12250028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182415 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182414 0039d316-1c4b-4281-b951-d872f2087c98

type -> templateType
template names -> enum
base -> basic
multiple -> list
timestamp -> eventTime
unreadCount -> gone
buttonOne/Two -> buttons array

BUG=174680


Review URL: https://chromiumcodereview.appspot.com/12212037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182413 0039d316-1c4b-4281-b951-d872f2087c98

Currently all tests for TranslateHelper are implemented as browser tests.
But some small tests can run as unit tests. This change introduce new unittest
file for TranslateHelper, then replace an existing test into it.

BUG=175673
TEST=unit_tests --gtest_filter='TranslateHelperTest.*'

Review URL: https://codereview.chromium.org/12209114

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182412 0039d316-1c4b-4281-b951-d872f2087c98

particularly in the case of SSL proxies.

Errors that one is likely to see when trying to talk SSL
to a captive portal now trigger fallback.

The errors are:

ERR_CONNECTION_TIMED_OUT (Portal blackholes SSL)
ERR_PROXY_CERTIFICATE_INVALID (Portal uses self-signed cert)
ERR_SSL_PROTOCOL_ERROR (Portal talks HTTP over port 443)

BUG=176053
Review URL: https://codereview.chromium.org/12252015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182411 0039d316-1c4b-4281-b951-d872f2087c98