- 12 Aug, 2019 40 commits
-
-
Mason Freed authored
Prior to this CL, inline elements with backdrop-filter did not get a PaintLayer, because BackdropFilter wasn't in the list of attributes in CreatesGroup. That is now fixed. This was not noticed until recently because the backdrop-filter element did not create a containing block prior to [1]. [1] https://chromium.googlesource.com/chromium/src/+/4be7920fee20fd21f5c4dc432dc18d2579a487fd Bug: 992549 Change-Id: I79d8777a178eca488bb76b0909ca815467e34fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745600 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#686106}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f97fd060af46..31fc760897f7 git log f97fd060af46..31fc760897f7 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 tsepez@chromium.org Move more logic from fpdf_save.cpp down into CPDFXFA_Context. 2019-08-12 tsepez@chromium.org Remove dependence of fpdfxfa on fpdfdoc. Created with: gclient setdep -r src/third_party/pdfium@31fc760897f7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I0ba828f5a93f8c0787eb42d927030d7ba2125931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686105}
-
Jenna Himawan authored
Bug: 809294 Change-Id: I9d8a6de52f1d861678627a81c3420bf842c0e61b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744886 Commit-Queue: Jenna Himawan <jhimawan@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#686104}
-
Jacob DeWitt authored
Based on discussion at https://github.com/immersive-web/webxr/issues/783 , we are confident this will become a requirement in the WebXR spec. Also update the OpenVR render loop to re-send the input source description when the profiles array is updated. Bug: 989244 Change-Id: I77bb2b15d894fe41c532235b062163bdc87a4ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744663Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#686103}
-
Tarun Bansal authored
Bug: 913424 Change-Id: Ieda6e90d92875a38912ea8cd8739849013dbe7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743538 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#686102}
-
Hiroki Nakagawa authored
This CL creates AppCacheBackend per ApplicationCacheHost, not per renderer process, to avoid the main thread dependency from ApplicationCacheHost. This is a preparation for creating ApplicationCacheHost for nested dedicated workers on worker threads after PlzDedicatedWorker is enabled. When PlzDedicatedWorker is disabled, dedicated workers depend on their parent Document's ApplicationCacheHost on the main thread. Bug: 945673 Change-Id: I7a2cd2c76bcf91771f7ffd22fb4975b411b07748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746508 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#686101}
-
David Valleau authored
This change adds a helper function which checks the status code of the JSON validation functions in order to log a more descriptive error message. Bug: 811931 Test: tested manually on asuka device Change-Id: Ib972567ae710526bee8df18eaf9cecdb2180a374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745430 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#686100}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d7500aa800b6..3b3fe83788c5 git log d7500aa800b6..3b3fe83788c5 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 jmadill@chromium.org Use BufferID in place of GLuint handles. Created with: gclient setdep -r src/third_party/angle@3b3fe83788c5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I00ca315fdddd0e510f6761b2900ec0a061c72b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749001Reviewed-by:
-
Brian Sheedy authored
This reverts commit 6b30d4e5. Reason for revert: Affected test is Gtest-based, not Telemetry. Original change's description: > Switch GPU Angle perf to histograms > > Switches the GPU Angle perf tests to use histograms instead of the > default ChartJSON format. The use of ChartJSON was causing the uploader > script to try to upload to the perf dashboard via the IP whitelisted > endpoint instead of using a service account, which was causing the > upload to fail. > > TBR=kbr@chromium.org > > Bug: 924618 > Change-Id: I7238ff3fe188e3983e91e6391e52fb417caedfd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749455 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686089} TBR=kbr@chromium.org,bsheedy@chromium.org Change-Id: I19476a505cc3178a343987407fe0cd63fe017111 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749706Reviewed-by:
-
Josh Nohle authored
Add a comparison for did_device_registry_change_. Also, simplified the function by extracting the ClientDirective comparison and simplifying that logic. Bug: 951969 Change-Id: I61809ed953e711502c3a058c51cc1315888e8e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747376 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686097}
-
Aran Gilman authored
This was requested in the bug, but it didn't make it into the previous CL. Bug: 985961 Change-Id: I94946912d4984d052475eaf6584e459c684b1ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745131Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#686096}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bcb0bef6093..44d77e47f726 Created with: gclient setdep -r src-internal@44d77e47f726 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I769c2109f864d16ef9fc80865b0cf14ebd954816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748998Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686095}
-
Josh Nohle authored
Bug: 951969 Change-Id: I02fec9c2da5c0ceacc369ee4cd0a4d1b5ddf5d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747374 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Himanshu Jaju authored
Bug: 991971 Change-Id: I409166eceee48f43e589bded02bb0938e01349fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748947Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#686093}
-
Tarun Bansal authored
Bug: 983721 Change-Id: I15043932968a789bf7f38090ebe78436e32831f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744789Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#686092}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4a4990f4c78c..703b48c36369 git log 4a4990f4c78c..703b48c36369 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 nicomazz@google.com Merge "Add event_tokenizer_errors stat for interning errors" 2019-08-12 lalitm@google.com Merge "trace_processor: change diff test script to output final JSON format" Created with: gclient setdep -r src/third_party/perfetto@703b48c36369 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I3aaf0c5aac1f68d5bcbbcb886844d2ec09533a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748999Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. Bug: 968047 Change-Id: I2d71d797e509699f21e328b99c89543f34afe831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748896 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#686090}
-
Brian Sheedy authored
Switches the GPU Angle perf tests to use histograms instead of the default ChartJSON format. The use of ChartJSON was causing the uploader script to try to upload to the perf dashboard via the IP whitelisted endpoint instead of using a service account, which was causing the upload to fail. TBR=kbr@chromium.org Bug: 924618 Change-Id: I7238ff3fe188e3983e91e6391e52fb417caedfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749455Reviewed-by:
-
jonross authored
Both MSE_ExternalClearKey and SRC_ExternalClearKey have began failing more consistently. However each failure appears to be the test suite verifying state too early. We've seen similar patterns in other tests, where SkiaRenderer changes the timings enough that races within the tests are exposed. This change updates the filters to skip the affect test suites until we can look into giving them an appropriate startup synchronization. TBR=cblume@chromium.org TEST=vulkan_content_browsertests Bug: 963266 Change-Id: I2bce1c75d59f49cc8797ba00889d1be435333f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748005Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#686088}
-
Scott Haseley authored
Change-Id: I94b3b294a915410cb1451007679d4bfcbb983805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748075 Auto-Submit: Scott Haseley <shaseley@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686087}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. TBR=eladalon@chromium.org, sergeyu@chromium.org Bug: 968047 Change-Id: I48c2cec9df44fe4f2a27bed84163e459d4a39b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729156Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#686086}
-
Andrew Grieve authored
The template was deleted in 212f516e Change-Id: I47d1888d00bbb00b183e6ee24383bf50c4932a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748001Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#686085}
-
Shimi Zhang authored
This param is not necessary, since glue layer will figure out the WebView instance. In prepare of http://crrev/c/1745462. Bug: 918065 Change-Id: I7f64f37943d008f3160a5201a7d34d77f97db9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747247 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#686084}
-
Daniel Clark authored
Update the LocalizedControlType of <output> to "output" per https://w3c.github.io/html-aam/#el-output The DumpAccessibilityTreeTest.AccessibilityOutput was disabled without a bug link, so I re-enabled it and updated the stale baselines. For <input type='color'>, update the ControlType to "button" and LocalizedControlType of "color picker" per https://w3c.github.io/html-aam/#el-input-color Bug: 991746 Change-Id: Ibe4908e1195d25048ceb2ed6716e3bbad2f1515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743195Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686083}
-
Kyle Horimoto authored
The cellular setup flow relies on a utility script which loads a <webview> using a POST instead of a GET. This script previously was only part of the old setup flow, but the new flow also requires use of this script. Thus, I moved the script to be a shared resource, renamed it from mobile_setup_util.js to webview_post_util.js, and updated from the "mobile" naming scheme to "cellular" instead. Bug: 991826 Change-Id: I5cad54c9b37cd6404abc37e0cf93b0d23a82949e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743269Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#686082}
-
Sebastien Marchand authored
This simply add the necessary plumbing to get the total Chrome RSS from SystemMonitor, the part that computes this metric hasn't been implemented yet but having this will allow working on the components that will eventually need this (in parallel to the work being done to implement this metric). Bug: 992959 TBR: chrisha@chromium.org Change-Id: I3faec2f5092ece2d56f7483e118ab0d7c0de6946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741637 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#686081}
-
Josh Nohle authored
New Fields: - DeviceFeatureStatus.FeatureStatus.last_modified_time_millis - DeviceFeatureStatus.FeatureStatus.enable_exclusively - ClientAppMetadata.droid_guard_response - ApplicationSpecificMetadata.bluetooth_enabled Deprecated Fields: - BatchSetFeatureStatusesRequest.enable_exclusively Note: No changes to cryptauth_proto_to_query_parameters_util.{h,cc} were needed; none of the new or deprecated fields are converted to query parameters as part of GET requests. Also added and revised some comments. Bug: 899080, 951969 Change-Id: I4fbc6a68a268261ea8debdb5fe9a2150d1e96442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746553 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by: -
Jessica Tallon authored
There is a bug which sometimes can occur where a AXMenuList is marked as needing to update its children when it does not have children yet. When the children are created the NeedsToUpdateChildren flag is not cleared. During created of the AXMenuListOptions (part of AXMenuListPopup's AddChildren) they call to check if AXMenuListPopup needs update it's children and runs through the adding children, not realizing we're in the middle of an AddChildren call. When it returns the child vector is actually populated and it re-adds the very same AXMenuListOption to the vector. This creates the duplicate children. This resolves the problem by simply ensuring regardless of child status, the NeedsToUpdateChildren is always cleared before re-adding children. Bug: 987702 Change-Id: Ifc24681123f2b2bfeb4e9ecc23a897e669bb5b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735456Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#686079}
-
David Valleau authored
In order to track down the root cause of https://crbug.com/964120 this metric is being added. In this case we're concerned with printers somehow being configured with a PPD while not having any make and model information filled in. If an automatic setup meets this "empty" criteria, then we track from which of the following 4 possible sources it may have come from: 1. Print Preview 2. Printer Settings 3. Arc Print Service 4. Automatic USB Printer Configurer BUG=chromium:964120 TEST=None Change-Id: If49d58663f254b726ede57754f8dbc4a17793de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732029Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c9196fe7..ef773214 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I779703f60def9170581ba0d00a361636a3ef7ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749144Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686077}
-
Sinan Sahin authored
This CL removes the dependency on TextInputLayout by implementing the ChromeTextInputLayout and replacing the existing uses of the TextInputLayout with it. Our implementation provides a floating label and the ability to set a custom error message that will be shown below the text field. Bug: 958871 Change-Id: I0589188d08363ff7668724e01dfb481fec8f7594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710805 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
-
Elly Fong-Jones authored
This change has TabStripModelObserver remember which TabStripModels it is observing, and unregister from those if necessary on destruction. It also removes instances of now-unnecessary cleanup code in subclass destructors. This change also introduces a new observable event on TabStripModelObserver: OnTabStripModelDestroyed. This event notifies observers that the model is being destroyed so they can do any necessary cleanup. In the future most uses of TabStripModelObserver::TabStripEmpty() should migrate to OnTabStripModelDestroyed(). Bug: 991308 Change-Id: Ifed459ec4d88136db4a00e4386dc6c2095048b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739552 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#686075}
-
Bailey Berro authored
We have no plans to implement pausing/resuming print jobs in the near future, so this CL removes the unneeded logic, icons, and strings. Change-Id: If0841c9a99b347482db55a59f8177c509a0783f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746963 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
behdad authored
Bug: chromium:990470 Change-Id: I239ef42d8c9c1c42f27497f720d84ca816d49caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739387Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686073}
-
Sinan Sahin authored
Bug: 940682 Change-Id: I531e9309e8d0391b39888fabe0d25cfe92f18fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703003Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#686072}
-
Lily Chen authored
(For context, see https://crrev.com/c/1691522.) The new requirement that SameSite=None cookies must be Secure made it impossible to properly test third party cookies on WebSocket because the web_test runner does not have a wss server. This CL ports those tests, formerly in web_tests/http/tests/security/cookies/websocket/, to web_tests/wpt_internal/websocket-cookies/. Bug: none Change-Id: Ifc6d2d78a84aa6c93e297dc71b3595108a18f179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713670 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#686071}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. TBR=zhenw@chromium.org Bug: 968047 Change-Id: I994c2bcd04195a24109eb80abd0508433083d91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739808Reviewed-by: -
Scott Little authored
The test virtual/audio-service/media/controls/doubletap-to-jump-backwards-at-start.html was actually leaking memory on https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak?limit=200, so adding it here in TestExpectations didn't actually suppress the flakes, but as it appears to no longer be flaking, this CL simply removes the flake expectations here instead of moving them to LeakExpectations. TBR=steimel@chromium.org Bug: 992531 Change-Id: I19e483e4d49e41a7d03c58f0cb748aaba7d09bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749450Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#686069}
-
Michael Thiessen authored
Flakiness is fixed: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Ffocusless-spat-nav%2Ffast%2Fspatial-navigation%2Ffocusless%2Fsnav-focusless-fullscreen-video.html Bug: 979565 Change-Id: Id70dc1d265b926138173da844d2cc31e047aceae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749545Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#686068}
-
Brian Sheedy authored
Adds some sample CLs to the GPU documentation for upgrading driver/OS versions. Also updates the step that previously mentioned suppressing the pixel tests if the baselines change due to the upgrade since Gold handles this case better than the legacy pixel tests. TBR=kbr@chromium.org Bug: 916832 Change-Id: I674e7839b2582587363b4443bd33fe0a02753a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749564Reviewed-by:
-
