GitLab

BUG=348761
NOTRY=true

Review URL: https://codereview.chromium.org/296663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271529 0039d316-1c4b-4281-b951-d872f2087c98

Prevent extensions with <all_urls> from executing scripts using executeScript()
without user consent if the scripts-require-action switch is on.
Coming up next: Content scripts.

BUG=362353

Review URL: https://codereview.chromium.org/286003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271528 0039d316-1c4b-4281-b951-d872f2087c98

When we sync tilings, we always expect to sync the high res
tiling. However, in situations where our minimum contents scale
prevents us from syncing the high res tiling, we should instead
reset the raster contents scale, since those would be invalid
as well. This also ensures that we will create a new high res
tiling when we call ManageTilings.

BUG=374143
R=enne

Review URL: https://codereview.chromium.org/294463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271527 0039d316-1c4b-4281-b951-d872f2087c98

This only existed for pseudo locale testing of bidi.  I don't think anyone
is actively testing this config, so remove it.  If needed for manual testing,
we could probably come up with a way that doesn't involve a flag (e.g.,
special way to build the pak file).

BUG=None

Review URL: https://codereview.chromium.org/291913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271526 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271525 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/292053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271524 0039d316-1c4b-4281-b951-d872f2087c98

Checks for missing config.json and discovery.json.
Fixed string constants.

NOTRY=true

Review URL: https://codereview.chromium.org/293833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271521 0039d316-1c4b-4281-b951-d872f2087c98

Other types (e.g., int32) aren't keywords, so it's a bit anomalous that
the specialized handle types are. (Insisting that they be keywords makes
adding future handle types more difficult, since doing so could break
existing .mojom files.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/295773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271519 0039d316-1c4b-4281-b951-d872f2087c98

This broke the same android tests that failed 2 out of 3 times on your presubmit
try jobs.

> Decouple RVH creation from CrossProcessFrameConnector.
> 
> The RenderViewHost creation today takes a CrossProcessFrameConnector pointer, which it uses to decide whether to create a top-level or child frame view. Replace this with a boolean and associate the CrossProcessFrameConnector with the view at a later point in time.
> 
> BUG=357747
> 
> Review URL: https://codereview.chromium.org/270883003

TBR=nasko@chromium.org

Review URL: https://codereview.chromium.org/295833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271516 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/299493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271515 0039d316-1c4b-4281-b951-d872f2087c98

This line is required for app manifests, so it should be in the sample
manifest in the tutorial.

BUG=374672
NOTRY=true

Review URL: https://codereview.chromium.org/293523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271513 0039d316-1c4b-4281-b951-d872f2087c98

R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/285293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271512 0039d316-1c4b-4281-b951-d872f2087c98

The revert broke Windows interactive_ui_tests. The world has probably
changed since this was first committed.

WidgetTestInteractive.CanActivateFlagIsHonored

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/29193/steps/interactive_ui_tests/logs/stdio

> Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/)
> 
> Reason for revert:
> This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095
> 
> I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable
> 
> Original issue's description:
> > [Refactor] Consolidate the logic for whether a widget can be activated.
> >
> > This is a first step towards giving tooltips their own WindowTreeHosts on Linux.
> >
> > BUG=353533
> > TEST=None
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597
> 
> Review URL: https://codereview.chromium.org/297503003

TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/291013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373841

Review URL: https://codereview.chromium.org/289063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348761,94925
NOTRY=true

Review URL: https://codereview.chromium.org/291993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271506 0039d316-1c4b-4281-b951-d872f2087c98

1. Take OAuth client ID in JSON
2. Use protocol from devsite (still needs work)

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/294793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271505 0039d316-1c4b-4281-b951-d872f2087c98

This is currently causing a top crasher; tfarina@ rebuilt on a branch
without this patch and have confirmed that reverting it fixes the crash.

Reverting at the request of the TPMs.

> Fix WebURLLoaderImpl::Context leak if a pending request is canceled.
> 
> Now, ResourceDispatcher::CancelPendingRequest will send
> ResourceHostMsg_CancelRequest and trigger OnRequestComplete. However,
> the request is pending and thus OnRequestComplete will be queued.
> 
> There are at least two problems if OnRequestComplete is not called:
> 1. WebURLLoaderImpl::Context will never be released.
> 2. request_info->buffer leaks. The buffer holds shared memory handle
>    (file descriptor). fd leaking may lead to HW video decode failure on
>    ChromeOS (detail in chrome-os-partner:27911#63)
> 
> This issue is similar to issue 328092.
> 
> BUG=chrome-os-partner:27911,chromium:369221,chromium:369128
> R=jam@chromium.org, mmenke@chromium.org
> 
> Review URL: https://codereview.chromium.org/268423002

BUG=372342
TBR=kcwu@chromium.org

Review URL: https://codereview.chromium.org/293823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369409

Review URL: https://codereview.chromium.org/293693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271503 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures. (https://codereview.chromium.org/274193004/)

Reason for revert:
This patch was landed speculatively due to the suspicion that the removal of the ScopedAllowIO was to blame for http://crbug.com/372017. The cause of that issue was found to lie elsewhere.

Original issue's description:
> Restore base::ThreadRestrictions::ScopedAllowIO to see if it fixes linux bot failures.
> 
> BUG=61827
> NOTRY=true
> NOTREECHECKS=true
> R=asanka@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269405

TBR=mef@chromium.org
BUG=61827

Review URL: https://codereview.chromium.org/292803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271502 0039d316-1c4b-4281-b951-d872f2087c98

Add test for SimpleGeolocation.

BUG=245075
TEST=none

Review URL: https://codereview.chromium.org/289313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271499 0039d316-1c4b-4281-b951-d872f2087c98

Also log bypass during via header checking and restart browser for each page.

BUG=374413

Review URL: https://codereview.chromium.org/292453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271498 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346957

Review URL: https://codereview.chromium.org/290053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271496 0039d316-1c4b-4281-b951-d872f2087c98

Will try to resolve soon.

BUG=374943
NOTRY=true
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/294773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271495 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/290703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271493 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=wjia@chromium.org

Review URL: https://codereview.chromium.org/298433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271491 0039d316-1c4b-4281-b951-d872f2087c98

Design Doc and Proposal here:
https://docs.google.com/a/google.com/document/d/1QWIzDvf_-iZJW8CINvhxzIERwwKeg72302hNUw0ZrSM/edit

This CL depends on https://codereview.chromium.org/275543005/

BUG=371966

Review URL: https://codereview.chromium.org/280023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271490 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271489 0039d316-1c4b-4281-b951-d872f2087c98

This broke the Google Chrome Mac build.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/18028

[3268/23724 | 168.537] RULE Generating binding from ../core/fileapi/FileReader.idl
FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/skia/src/gpu/effects/skia_library.GrDashingEffect.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=206824 -DENABLE_RLZ -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_BUILDMIPMAP -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0 -DSK_DISABLE_OFFSETIMAGEFILTER_OPTIMIZATION -DSK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK -DIGNORE_ROT_AA_RECT_OPT -DSK_IGNORE_BLURRED_RRECT_OPT -DSK_IGNORE_QUAD_RR_CORNERS_OPT -DSK_GDI_ALWAYS_USE_TEXTMETRICS_FOR_FONT_METRICS '-DSK_DEFAULT_FONT_CACHE_LIMIT=(20*1024*1024)' -DSK_USE_DISCARDABLE_SCALEDIMAGECACHE -DSK_BUILD_FOR_MAC -DSK_GAMMA_SRGB -DSK_GAMMA_CONTRAST=0.0 -DSK_HIGH_QUALITY_IS_LANCZOS -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DSK_IGNORE_UNDERLINE_POSITION_FIX -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/record -I../../third_party/skia/include/utils -I../../third_party/skia/src/core -I../../third_party/skia/src/opts -I../../third_party/skia/src/image -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../.. -I../../skia/config -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/include/utils/mac -I../../third_party/zlib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O3 -gdwarf-2 -fvisibility=hidden -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wendif-labels -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wno-deprecated-register -Wno-absolute-value -Wno-selector-type-mismatch -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing  -c ../../third_party/skia/src/gpu/effects/GrDashingEffect.cpp -o obj/third_party/skia/src/gpu/effects/skia_library.GrDashingEffect.o
../../third_party/skia/src/gpu/effects/GrDashingEffect.cpp:142:5: error: use of undeclared identifier 'SkPaint2GrPaintShader'
    SkPaint2GrPaintShader(dev, paint, true, &grPaint);
    ^

> Skia roll 14765:14785
> 
> https://code.google.com/p/skia/source/list?num=19&start=14785
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/290713005

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/293803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271488 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/282373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271487 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/291893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271486 0039d316-1c4b-4281-b951-d872f2087c98

[OriginChip] Re-enable the chip when reverting the text in the omnibox.  This ensures that when we revert the text after a navigation or reload, the URL not only disappears but also the origin chip reappears.

BUG=371684

Review URL: https://codereview.chromium.org/293713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271485 0039d316-1c4b-4281-b951-d872f2087c98

TEST=AutomationApiTest.SanityCheck
BUG=360297
TBR=aboxhall,dtseng

Review URL: https://codereview.chromium.org/272923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271479 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271478 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=19&start=14785
TBR=
BUG=

Review URL: https://codereview.chromium.org/290713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271477 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271476 0039d316-1c4b-4281-b951-d872f2087c98

Fix the clock framework in end2end test to allow properly different clocks for sender and receiver.
Make the fake video codec behave more like our other codecs. (Instead of acting like 3-buffer mode)

Review URL: https://codereview.chromium.org/289083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271475 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13182: (sehr) Add android toolchain to the DEPs for native client.
r13183: (yyanagisawa) NO_NACL_GOMA is enabled by default on Windows.
r13184: (sehr) Add chromium_git variable to fix sync
r13186: (jvoung) Remove ImportHostDescCommon and use NaClDescIoDescFromDescAllocCtor instead.
r13187: (dyen) Added a way for toolchain_build to specify run conditions for commands.
r13188: (dschuff) Support windows and mac in buildbot_pnacl.py
r13189: (mseaborn) Fix typo in comment: "requires" -> "require"
r13190: (dschuff) Factor Setup{OS}Environment and SetupGypDefines into buildbot_lib
r13191: (noelallen) Breakout "Environment" for cleanup
r13192: (mseaborn) Cleanup: Use __builtin_trap() instead of dereferencing a null pointer
r13193: (mcgrathr) Set AT_BASE value in nacl_helper_bootstrap
r13194: (dschuff) Revert "PNaCl driver: Put intermediate temp files in system temp dir"
r13195: (mark) Improve nacl_host_desc_big_file_test.
r13196: (dschuff) Fix printing of NaClHandle values in sigpipe_test for Win64
r13197: (dschuff) Build PNaCl toolchain with toolchain_build_pnacl.py in cygwin
r13198: (jvoung) Make a NaClDesc ctor for creating descs from NaClFileInfo.
r13199: (noelallen) Roll Bionic

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/290813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271474 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374349

Review URL: https://codereview.chromium.org/284223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271473 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a couple of issues with the installer script regarding
installing on machines that don't have both 2010 and 2012 installed.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/290013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271472 0039d316-1c4b-4281-b951-d872f2087c98