GitLab

Revert of Minor changes to allow Pepper InstancePrivate tests to pass with gin (patchset #3 of https://codereview.chromium.org/472693002/)

Reason for revert:
Caused failures in DrMemory:

UNADDRESSABLE ACCESS of freed memory: writing 0x031c0278-0x031c0279 1 byte(s)
# 0 ppapi_tests.dll!`anonymous namespace'::InstanceSO::~InstanceSO             [ppapi\tests\test_instance_deprecated.cc:48]
# 1 ppapi_tests.dll!`anonymous namespace'::InstanceSO::`scalar deleting destructor'
# 2 ppapi_tests.dll!pp::deprecated::`anonymous namespace'::Deallocate          [ppapi\cpp\dev\scriptable_object_deprecated.cc:126]
# 3 ppapi_proxy.dll!ppapi::CallWhileUnlocked<>                                 [ppapi\shared_impl\proxy_lock.h:123]
# 4 ppapi_proxy.dll!ppapi::proxy::PluginVarTracker::DidDeleteInstance          [ppapi\proxy\plugin_var_tracker.cc:281]
# 5 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnPluginMsgDidDestroy    [ppapi\proxy\ppp_instance_proxy.cc:194]
# 6 ppapi_proxy.dll!PpapiMsg_PPPInstance_DidDestroy::Dispatch<>                [ppapi\proxy\ppapi_messages.h:670]
# 7 ppapi_proxy.dll!ppapi::proxy::PPP_Instance_Proxy::OnMessageReceived        [ppapi\proxy\ppp_instance_proxy.cc:143]
# 8 ppapi_proxy.dll!ppapi::proxy::Dispatcher::OnMessageReceived                [ppapi\proxy\dispatcher.cc:69]
# 9 ppapi_proxy.dll!ppapi::proxy::PluginDispatcher::OnMessageReceived          [ppapi\proxy\plugin_dispatcher.cc:238]
#10 ipc.dll!IPC::ChannelProxy::Context::OnDispatchMessage                      [ipc\ipc_channel_proxy.cc:273]
#11 ipc.dll!base::internal::Invoker<>::Run                                     [base\bind_internal.h:1253]
#12 base.dll!base::debug::TaskAnnotator::RunTask                               [base\debug\task_annotator.cc:62]
#13 base.dll!base::MessageLoop::RunTask                                        [base\message_loop\message_loop.cc:436]
#14 base.dll!base::MessageLoop::DeferOrRunPendingTask                          [base\message_loop\message_loop.cc:445]
#15 base.dll!base::MessageLoop::DoWork                                         [base\message_loop\message_loop.cc:552]
#16 base.dll!base::MessagePumpDefault::Run                                     [base\message_loop\message_pump_default.cc:32]
#17 base.dll!base::MessageLoop::RunHandler                                     [base\message_loop\message_loop.cc:408]
#18 content.dll!content::PpapiPluginMain                                       [content\ppapi_plugin\ppapi_plugin_main.cc:141]
#19 content.dll!content::RunNamedProcessTypeMain                               [content\app\content_main_runner.cc:415]
#20 content.dll!content::ContentMainRunnerImpl::Run                            [content\app\content_main_runner.cc:764]
#21 content.dll!content::ContentMain                                           [content\app\content_main.cc:19]
#22 content::LaunchTests                                                       [content\public\test\test_launcher.cc:475]
#23 main                                                                       [content\test\content_test_launcher.cc:123]

First appeared in http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%29/builds/631/steps/memory%20test%3A%20content_browsertests/logs/stdio.

Original issue's description:
> Minor changes to allow Pepper InstancePrivate tests to pass with gin
>
> This includes some minor changes which allow tests to when NPObject is replaced
> by gin in pepper:
> -Add shared library exports for use of PepperTryCatch and ScopedPPVarArray in
> tests.
> -Add gin as a dependency to content_unittests for use in host_var_tracker_unittest
> -Change TestInstanceDeprecated so that it doesn't execute a script from the
> ScriptableObject upon destruction. The reason for this is that the garbage
> collector is manually run from the destructor of the plugin Instance object.
> This results in destruction of the ScriptableObject and then javascript is
> re-entered via ExecuteScript. This should never happen outside tests because
> the garbage collector won't be run synchronously. Instead of running
> ExecuteScript, which just set a variable in the Instance object to verify
> that the ScriptableObject was correctly destroyed.
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/92c3074f4b4417924115f880657f1ec15da0e0ba

TBR=dmichael@chromium.org,raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351636,407372

Review URL: https://codereview.chromium.org/502143003

Cr-Commit-Position: refs/heads/master@{#291780}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/503873003

Cr-Commit-Position: refs/heads/master@{#291779}

Revert of Stop all PeerConnections upon suspend from Blink side (patchset #3 of https://codereview.chromium.org/475263002/)

Reason for revert:
Causing browser crashes due to race, BUG=404767.

Original issue's description:
> Stop all PeerConnections upon suspend from Blink side
>
> BUG=403618
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291213

TBR=jiayl@chromium.org,vrk@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403618

Review URL: https://codereview.chromium.org/482443003

Cr-Commit-Position: refs/heads/master@{#291778}

BUG=406580
TEST=None

Review URL: https://codereview.chromium.org/501143003

Cr-Commit-Position: refs/heads/master@{#291777}

This change moves all the encrypted media code out of WebMediaPlayerImpl
and into a EncryptedMediaSupportImpl class. This removes the encrypted
media related content/ depencencies from WebMediaPlayerImpl so that it
will be easier to move WebMediaPlayerImpl to a location where it can
be reused by Mojo.

Review URL: https://codereview.chromium.org/501473003

Cr-Commit-Position: refs/heads/master@{#291776}

It caused a use-after-free in DrMemory.

BUG=407372
NOTRY=true
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/500273002

Cr-Commit-Position: refs/heads/master@{#291775}

NOTRY=true

Review URL: https://codereview.chromium.org/491243003

Cr-Commit-Position: refs/heads/master@{#291774}

They were moved in r289954 and hooked up in r291369. So nothing else
is using the resources from webkit/glue/resources.

BUG=338338
TEST=None
R=jamesr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/499803002

Cr-Commit-Position: refs/heads/master@{#291773}

BUG=407272
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/507473002

Cr-Commit-Position: refs/heads/master@{#291772}

NOTRY=True

Review URL: https://codereview.chromium.org/498113004

Cr-Commit-Position: refs/heads/master@{#291771}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503873002

Cr-Commit-Position: refs/heads/master@{#291770}

BUG=407357
R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/471443005

Cr-Commit-Position: refs/heads/master@{#291769}

Pixel readback in GL_RGBA format can be a very expensive operation on
some hardware configurations.

Adding support for kAlpha_8_SkColorType to CropScaleReadbackAndCleanTexture().
For this color type, the texture is converted to grayscale on the GPU and then
read back using GL_BGRA_EXT format.
This improves the readback performance because we read four times less
data and we don't have to do any format conversions as we are reading.

Original review: https://codereview.chromium.org/384453002/
Part 2: https://codereview.chromium.org/389683002/

BUG=379983, 380779

Review URL: https://codereview.chromium.org/388953002

Cr-Commit-Position: refs/heads/master@{#291768}

Originally landed at: https://codereview.chromium.org/480533002/

- Properly pass font render settings to Skia font data functions. Otherwise Skia always returns rounded values.

- If subpixel positioning is off, round the glyph positions to match Pango's rounding logic.

BUG=402715,402374,402347
TEST=On Linux, character positions in UI text (address bar, infobars, tab titles) should be identical with --enable-harfbuzz-rendertext and --disable-harfbuzz-rendertext.

Review URL: https://codereview.chromium.org/484883003

Cr-Commit-Position: refs/heads/master@{#291767}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502573006

Cr-Commit-Position: refs/heads/master@{#291766}

This patch fixes a trivial mistake that made the fix in
https://codereview.chromium.org/459613007 a noop, and adds a regression
unit-test.

BUG=401859

Review URL: https://codereview.chromium.org/498293002

Cr-Commit-Position: refs/heads/master@{#291765}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/496313004

Cr-Commit-Position: refs/heads/master@{#291764}

* Introduced DesktopController interface. app_shell's Init process stays in ShellDesktopController
* Removed ShellAppWindowController
* Athena has its own AthenaDesktopController
* Intorduced AthenaEnv. This is now used for both AthenaMain and Unit test.
* Removed ScreenManagerDelegate and integrate it into AthenaEnv.
* Moved FocusController to ScreenManager, and removed CreateFocusRules()

BUG=397167
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/480353006

Cr-Commit-Position: refs/heads/master@{#291763}

When a PicturePile grows along either axis, the tiles on the edge where
it grew are dropped if any new pixels are added to their recordings.
This means that we need to invalidate them to inform the impl side
about the recording being dropped.

However, if we're going to re-record the tile (it intersects the
interest_rect), then there's no need to invalidate it as the old
recorded pixels remain valid.

Previously we made the assumption that when a PicturePile resized, the
interest rect's center would be to the left and above the old edge of
the pile. However, the interest rect can move at the same time as the
pile is resized, and it can live anywhere with respect to the recording
tiles being dropped.

So we invalidate everything inside the row/column of tiles that were
dropped that is outside of the interest rect by invalidating on all
four sides of the interest rect, but clamping the resulting invalidation
rects to within the dropped tiles row/column.

R=enne
BUG=386998

Review URL: https://codereview.chromium.org/504513002

Cr-Commit-Position: refs/heads/master@{#291762}

Tracked down all uses of SetHeader() and SetHeaderIfMissing() and added
input validation where necessary (using the new IsValidHeader{Name,Value}
methods in http_util, moved from web_request_api_helpers).
After that, I added a DCHECK which serves as documentation to the users
of http_request_headers: The input must not contain illegal characters.

BUG=390458

Review URL: https://codereview.chromium.org/491123004

Cr-Commit-Position: refs/heads/master@{#291761}

kKeywordEditorWindowPlacement, kPreferencesWindowPlacement haven't been
used in a few years.

Review URL: https://codereview.chromium.org/501463003

Cr-Commit-Position: refs/heads/master@{#291760}

This provides a SurfacesService that can provide SurfacePtr and id
namespaces in one call, since both are needed to do anything useful. This
also updates the mojo/cc/ bindings to get closer to binding a cc using
client (like html_viewer) with surfaces, although it's not 100% there.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/504443002

Cr-Commit-Position: refs/heads/master@{#291759}

TBR=boliu@chromium.org,kolla@chromium.org,sadrul@chromium.org

Review URL: https://codereview.chromium.org/495423004

Cr-Commit-Position: refs/heads/master@{#291758}

Multiple --grep args to git log use the OR operation. So this patch supports
both old SVN revisions as well as newer commit positions.

BUG=407291
NOTRY=True

Review URL: https://codereview.chromium.org/470803009

Cr-Commit-Position: refs/heads/master@{#291757}

https://codereview.chromium.org/470653003/ disabled uploading errors for all the data types. However, that change should have touched only favicons.

BUG=384552,396900

Review URL: https://codereview.chromium.org/504713002

Cr-Commit-Position: refs/heads/master@{#291756}

Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #8 of https://codereview.chromium.org/444603003/)

Reason for revert:
the browser tests this added are really flaky on the trybots.

see
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6541
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6582
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6576
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6574
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6573
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6572
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6567
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6566
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6565
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6564
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6561
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6557
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6556
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6554
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6554
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6549
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6548
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6544
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6544
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6541
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6539
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6537
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6530

please test this on many try runs before relanding.

Original issue's description:
> Hook up the Mac password bubble to the browser and add browser tests.
>
> BUG=328847
>
> Committed: https://chromium.googlesource.com/chromium/src/+/dae2a9adff280655fa9261b972fd62ae837b374d

TBR=dconnelly
NOTRY=true

Review URL: https://codereview.chromium.org/473423005

Cr-Commit-Position: refs/heads/master@{#291755}

https://codereview.chromium.org/476873002 introduced a regression where
shrinking the size of the extensions toolbar to 0 would not show the chevron
anymore.  Fix the regression, and add a test so it doesn't happen again.

BUG=407134

Review URL: https://codereview.chromium.org/492503004

Cr-Commit-Position: refs/heads/master@{#291754}

TBR=jamesr

Review URL: https://codereview.chromium.org/480563009

Cr-Commit-Position: refs/heads/master@{#291753}

This makes a handful of small changes to align the two implementations:

- Remove Net.SSLv3FallbackToRenegoPatchedServer. It's no longer necessary. In
  fact, the majority of SSLv3 fallbacks are to servers that /are/ renego patched.

- Gather Net.SSLCertVerificationTime* on OpenSSL.

- Move histogram calls on OpenSSL out of GetSSLInfo as that is not called once
  per handshake. Net.RenegotiationExtensionSupported is moved to common code and
  RecordChannelIDSupport to the handshake success codepath.

Net.OCSPResponseStapled is left ungathered as BoringSSL does not yet support
OCSP stapling.

BUG=405631

Review URL: https://codereview.chromium.org/493793003

Cr-Commit-Position: refs/heads/master@{#291752}

This patch should be reverted once it is fixed. We should also add a unittest
before re-enabling.

BUG=404317
TBR=wiltzius@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/502153002

Cr-Commit-Position: refs/heads/master@{#291751}

Since other methods separate supported binary image MIME types from SVG,
where SVG was detected as a "non image type" along with XML, and since I
needed a method to detect MIME types that can be displayed as an image,
I've added such a method.

BUG=398443

Review URL: https://codereview.chromium.org/471913002

Cr-Commit-Position: refs/heads/master@{#291750}

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/498393002

Cr-Commit-Position: refs/heads/master@{#291749}

Compiling Error:

../../chrome/browser/shell_integration_linux.cc:294:13: error: unused function 'QuoteCommandLineForDesktopFileExec' [-Werror,-Wunused-function]
std::string QuoteCommandLineForDesktopFileExec(
            ^
../../chrome/browser/shell_integration_linux.cc:310:12: error: unused variable 'kDesktopEntry' [-Werror,-Wunused-const-variable]
const char kDesktopEntry[] = "Desktop Entry";
           ^
../../chrome/browser/shell_integration_linux.cc:312:12: error: unused variable 'kXdgOpenShebang' [-Werror,-Wunused-const-variable]
const char kXdgOpenShebang[] = "#!/usr/bin/env xdg-open";
           ^
3 errors generated.

The above mentioned function and variables are only used from GetNoDisplayFromDesktopFile,
only when support for GLIB is enabled.

Review URL: https://codereview.chromium.org/499823002

Cr-Commit-Position: refs/heads/master@{#291748}

BUG=357693

Review URL: https://codereview.chromium.org/477103003

Cr-Commit-Position: refs/heads/master@{#291747}

Revert of Update V8 to version 3.29.16.1 (merged r23332). (patchset #2 of https://codereview.chromium.org/499943002/)

Reason for revert:
Breaks mips.

Original issue's description:
> Update V8 to version 3.29.16.1 (merged r23332).
>
> TBR=yangguo@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/755cec945ca48f3175845f38219ca06f90c423d8

TBR=yangguo@chromium.org,ulan@chromium.org,bmeurer@chromium.org,rmcilroy@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/497363003

Cr-Commit-Position: refs/heads/master@{#291746}

One piece of feedback we've received is that users want an
explicit full-screen control rather than tying it to
maximize. Simply adding a full-screen button means that the
window has six icons of varying crypticness (crypticality?)

This CL prepares the ground for adding a full-screen button
while reducing clutter. It moves the Options and Disconnect
buttons to the left-hand side of the window, while leaving
them adjacent to the window controls in full-screen mode.

There are two main changes to the CSS. The first is that we
no longer use "display: table"; I thought this was needed to
get rid of the implicit spaces between the icons, but
"display: flex" does the job just as well. The second is to
do with how the etched borders are rendered. Previously, a
button was responsible for rending both the light and dark
highlights to the left and bottom. This worked because they
were all right-aligned, but with the new layout, each button
renders all of its borders.

Review URL: https://codereview.chromium.org/498813003

Cr-Commit-Position: refs/heads/master@{#291745}

This deletes code that was previously used for deciding if the
expanded content whitelist for GPU rasterization should be used.
Blink now uses the expanded whitelist by default (that is,
WebSettings::setUseExpandedHeuristicsForGpuRasterization is
now a no-op), so this code is no longer needed.

BUG=404866

Review URL: https://codereview.chromium.org/496503002

Cr-Commit-Position: refs/heads/master@{#291744}

BUG=406055

Review URL: https://codereview.chromium.org/497333002

Cr-Commit-Position: refs/heads/master@{#291743}

Gosh the DCHECK for #inputs == 1 was located _after_ removing the
input XD

Interesting that no one else hit this problem, including myself.

BUG=407046

Review URL: https://codereview.chromium.org/498213002

Cr-Commit-Position: refs/heads/master@{#291742}

Passed after fix landed in latest Skia roll:
  http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/36066/steps/webkit_tests/logs/stdio

BUG=406425

Review URL: https://codereview.chromium.org/501103003

Cr-Commit-Position: refs/heads/master@{#291741}