- 14 Jul, 2017 40 commits
-
-
Evan Stade authored
apply to loads in the main frame. The distinction between "IsLoading" and "IsLoadingToDifferentDocument" appears to only be relevant in UI contexts (e.g. TabRendererData, which controls whether to show the throbber in the tabstrip on desktop Chrome). I think the distinction only makes sense in the context of the main frame and a load in a subframe should always be lumped in with non-top-level document loads. For example, on Android it's sometimes used to conditionally call ToolbarLayout.onNavigatedToDifferentPage(), which from other callsites definitely appears to only care about main frame navigations. Making this change means the throbber won't flicker when content is loaded in an iframe right after the main frame finishes loading, which happens a lot (see bug). With this change, we can probably remove the timer added in 89603210 which attempts to smooth out favicon/throbber flickering. Bug: 734104 Change-Id: Ie14b1c54956479021fd9aa6c4c8aa690be52f193 Reviewed-on: https://chromium-review.googlesource.com/569060Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#486854}
-
Mark Pilgrim authored
Use BindOnce in RecognitionAllowedCallback for MediaRequestPermissionCallback Bug: 714018 Change-Id: I01e4eed7b75cd8828bd0dba80ca1fc07015a517f Reviewed-on: https://chromium-review.googlesource.com/570510 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486853}
-
gklassen authored
Implements a HitTestAggregator component to facilitate cross process hit testing with minimal process hops. The HitTestAggregator maintains a list of HitTestData objects that will be created and sent with each CompositorFrame. These are aggregated into a single DisplayHitTest data structure that can be made available in shared memory to facilitate hit testing with minimal process hops for any Display. HitTestAggregator listens as surfaces are added to the current CompositorFrame to ensure that the list only includes information that matches what has been rendered in the current frame. Aggregation occurs on the BeginFrame notification. This change includes the implementaiton of the HitTestAggregator and unit test cases to verify the intended behaviour. Next steps will include completion of the creation and transport of HitTestData objects, implementation of shared memory and using this component to target incoming events. BUG=732399 Review-Url: https://codereview.chromium.org/2938953002 Cr-Commit-Position: refs/heads/master@{#486852}
-
Fady Samuel authored
Bug: 722935 Change-Id: I6f6a26ac5405308efb3793ba0dbc0dd718e9a309 Reviewed-on: https://chromium-review.googlesource.com/563777Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#486851}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/fc4ee229a653..8abb9f453798 $ git log fc4ee229a..8abb9f453 --date=short --no-merges --format='%ad %ae %s' 2017-07-14 bsalomon Remove GrTestMeshDrawOp Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I079d39f4c96134ba622dd721bd5add88132ffd15 Reviewed-on: https://chromium-review.googlesource.com/571849Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#486850}
-
Bruce Dawson authored
Running tools\win\ShowGlobals on Canary PDBs shows that the variable mojo::edk::ports::kInvalidSequenceNum shows up 21 times in both chrome.dll and chrome_child.dll. This appears to be due to a VC++ quirk in how it handles integer constants that are initialized by some expression types. Tagging the definition as constexpr should ensure that this doesn't happen. Bug: Change-Id: I5d72acc494f14880cb7cd5a0107e7d6eefbf7c7f Reviewed-on: https://chromium-review.googlesource.com/571241Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#486849}
-
Charles Harrison authored
This will make it much easier for //chrome code to test the subresource filter logic. Bug: None Change-Id: Id34d9128059ef87463a9644b903d4d64061e2180 Reviewed-on: https://chromium-review.googlesource.com/571949Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#486848}
-
Yipeng Wang authored
Change-Id: I9161dc11fab6b709ae21170c9e62e5de8676de28 TBR=dpranke@chromium.org Change-Id: I9161dc11fab6b709ae21170c9e62e5de8676de28 Reviewed-on: https://chromium-review.googlesource.com/572030 Commit-Queue: Yipeng Wang <yipengw@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#486847}
-
Annie Sullivan authored
This is being renamed in https://codereview.chromium.org/2965383002/ This CL should land after that CL rolls into chromium. Change-Id: Id36c421709d40de22771a241d431aa9c19be355b Reviewed-on: https://chromium-review.googlesource.com/570678Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#486846}
-
Scott Violet authored
WindowTreeHostManager may reuse a WindowTreeHost for a different display. This happens if all displays are removed, and then a new display is added. Ash now handles this by way of calling through to SetDisplayRoot() and SetDisplayRoot() on mus has been updated to allow this to happen. In addition this changes ash's DisplaySynchronizer to only notify mus of the current display layout after all changes have been processed. This is necessary as DisplayManager notifies observers while internally the list of displays contains both added and removed entries. This means when FocusSynchronizer could notify of state display state, which mus didn't like and caused ash to crash (hit a CHECK). BUG=740589 TEST=covered by tests Change-Id: Ie0a2a05a1b592645669355f39997f9e3a5e77c3f Reviewed-on: https://chromium-review.googlesource.com/571399Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#486845}
-
Justin Schuh authored
Fix an IWYU bug and isnan() call site. TBR=jamescook@chromium.org R=jamescook@chromium.org Change-Id: I7b586f9d093150c9419fdcd5995803d4fa2be7b3 Reviewed-on: https://chromium-review.googlesource.com/572035Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486844}
-
Eric Karl authored
|dalvik_mb| no longer follows the expected heuristic pattern, causing us to over-estimate memory on low-end devices. This is a temporary fix that removes the Dalvik VM computation when on a low-end device. Eventually we should clean up this code for all Android devices. Bug: 742534 Change-Id: I9325530d6dc8cc9369d6beb0dd072424e5b60be9 Reviewed-on: https://chromium-review.googlesource.com/571179 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Cr-Commit-Position: refs/heads/master@{#486843}
-
Vincent Scheib authored
Developers sometimes do not notice that they are using a partially supported platform when trying Web Bluetooth. Especially when using the generic --enable-experimental-web-platform-features. E.g. https://plus.google.com/117707543167867525197/posts/4nKECjvLD9D This patch adds a warning to the developer console. The definition of supported platforms comes from https://cs.chromium.org/chromium/src/content/child/runtime_features.cc?type=cs&q=WebRuntimeFeatures::EnableWebBluetooth%5C(true%5C)&l=69-71 Change-Id: I82f7e6fd800607372520d8474e339e5a7659259c Reviewed-on: https://chromium-review.googlesource.com/557372 Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#486842}
-
Dongseong Hwang authored
It's used to scale an overlay plane using external hardware (e.g. video processing), but not anymore. Chrome makes display controller scale by itself. Note: this code never shipped on any devices because it requires --enable-hardware-overlays flags on Intel, which never used by a product. TBR=danakj@chromium.org TEST=run chrome with --enable-hardware-overlays using amd64-generic BUG=683347 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I32f2b1384f4a64510aa5d692c628e874255ea6b8 Reviewed-on: https://chromium-review.googlesource.com/552926 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#486841}
-
Peter Kotwicz authored
Previously, if a user: - with the --enable-lightweight-fre command line flag - who has not previously gone through the first run experience tried to launch a WebAPK the WebAPK did not launch and the FRE was not shown. This was occurring due to Intent.FLAG_ACTIVITY_NEW_TASK not being set as part of the FRE launch intent. (The caller is WebappLauncherActivity). This CL: - Makes LightweightFirstRunActivity "singleInstance" like FirstRunActivity - Removes LightweightFirstRunActivity-only logic which finishes the current LightweightFirstRunActivity if one is already running BUG=738133 Change-Id: Ifff19eb505f91efa5ea38ba2069f6159be7e7d4f Reviewed-on: https://chromium-review.googlesource.com/563864Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#486840}
-
Daniel Bratell authored
There are two namespaces named testing used in Blink unit tests, one from gtest and one internal helper namespace. If both are visible then the gtest testing namespace won't be used unless prepended with ::, as is already done in large parts of the code. BUG=739121 R=haraken@opera.com Change-Id: I48f6a3145886253576a53d1ad9c08307ceca0d52 Reviewed-on: https://chromium-review.googlesource.com/567143Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#486839}
-
Sidney San Martín authored
Bug: 742472 Change-Id: I82a02072b308d7f7753b9a5274465cdba7c64bbd Reviewed-on: https://chromium-review.googlesource.com/571420Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martin <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486838}
-
Menglu Huang authored
The DCHECK would fail if re-open the app. Remove the DCHECK. Warm start would be handled in a separate CL. Bug: Change-Id: I0db26e976322b8e0600a7251757c8bfbc31e4c89 Reviewed-on: https://chromium-review.googlesource.com/572005 Commit-Queue: Menglu Huang <huangml@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#486837}
-
Fernando Serboncini authored
- Current Accept Languages (moved to FontGlobalContext) - FontVerticalDataCacheInstance (moved to FGC) - Linux/Android system_font_family (static on FontCache) - Font strings on SimpleFontData, FontCacheAndroid, FontCacheMac Bug: 730692 Change-Id: Ia831c0eee10396d9318bd509573b40bcc3f76775 Reviewed-on: https://chromium-review.googlesource.com/568782 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#486836}
-
Sadrul Habib Chowdhury authored
If establishing a gpu channel fails, then it could be because access to gpu is not allowed, in which case the client should use software fallback. If, on the other hand, the failure happens because the gpu process was killed, or the gpu process crashed, then the attempt to establish the channel should be retried. But instead of retrying in the clients, retry in the host, which has better information to know whether a retry attempt may be successful or not. Remove the retry logic in the renderer (in RenderWidgetCompositor), since the host (GpuClient) will be taking care of that. BUG=609316 Change-Id: Ibcc1d5e79f354ccb282bad2321fca26d1c06402c Reviewed-on: https://chromium-review.googlesource.com/571490Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#486835}
-
Xing Liu authored
Originally it's in //chrome, and was moved to //content/public. According to some discussion, now we decide to move it to //components/download/content/public. Also make download service use AllDownloadItemNotifier. Bug: 736242 Change-Id: Id709ffaa73366d97d55fabd75d6ccb2e6d611859 Reviewed-on: https://chromium-review.googlesource.com/556259 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#486834}
-
jzw authored
Review-Url: https://codereview.chromium.org/2983453002 Cr-Commit-Position: refs/heads/master@{#486833}
-
Yuwei Huang authored
This CL: * Fixes the issue of view size being incorrectly adjusted for the keyboard in landscape mode. * Fixes the race condition of missing the first keyboardWillShow event. i.e. the problem of keyboard flickers and view not being adjusted. Change-Id: I56c9533519b5dfafea5ead4940388c61b9640c68 Reviewed-on: https://chromium-review.googlesource.com/571558 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#486832}
-
Charles Harrison authored
Bug: 740070 Change-Id: I856930d7e54ef62d4fed8a9c669eaf3237aae8a3 Reviewed-on: https://chromium-review.googlesource.com/571941Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#486831}
-
Sammie Quon authored
This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. This approach of adding a back button expands the current app list button to be modal and have two functionalities depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the meantime. Screenshots: https://screenshot.googleplex.com/ZVNP0aq0cc3 https://screenshot.googleplex.com/fDcGTuoyZg5 https://screenshot.googleplex.com/ZFBzk72LLVt Test: ash_unittests --gtest_filter="ShelfViewInkDropTest.*" Bug: 721940 Change-Id: I699c6d971aea89ba201536ca8534a14b4d44b0e2 Reviewed-on: https://chromium-review.googlesource.com/555836 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#486830}
-
Jeff Carpenter authored
This reverts commit 1674a85c. Reason for revert: results were unstable upstream: https://github.com/w3c/web-platform-tests/pull/6546 A provisional PR wasn't created for the CL so there's no way this could have been avoided. Original change's description: > Capture from HTMLMediaElement: move LayoutTests to external/wpt > > This CL moves the three standard functionality LayoutTests for > mediacapture-fromelement to the external/wpt folder, adapting > them accordingly and adding the necessary webmfiles. > > Also removes the HTMLMediaElementCapture-*.html expectations. > > Bug: 619625 > Change-Id: If06df91ae918b5f0d3eacc597c88709a83227a82 > Reviewed-on: https://chromium-review.googlesource.com/566151 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486677} TBR=mcasas@chromium.org,emircan@chromium.org Change-Id: Id0c5e1a45f9d4e65929aede3a6f256eae3850a3e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 619625 Reviewed-on: https://chromium-review.googlesource.com/572087Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486829}
-
bshe authored
Bug: None Change-Id: I01edfbb7fe6331d78052cf2ee7b3214affb7c425 Reviewed-on: https://chromium-review.googlesource.com/568848Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#486828}
-
Alexey Kozyatinskiy authored
TBR=pfeldman@chromium.org Bug: chromium:743085 Change-Id: I4a95ad0f99f84a0884dee37a2eee7abced2a1921 Reviewed-on: https://chromium-review.googlesource.com/572072Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#486827}
-
Tom Sepez authored
Bug: 742459 Change-Id: I228bccccb3f094e60a45dc3b9e8267c580f3d750 Reviewed-on: https://chromium-review.googlesource.com/571018Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#486826}
-
Weidong Guo authored
Changes: 1. Initializes the search result page view using the same bounds, color and background border corner raidus as the search box view to make it hidden. 2. When there's query in the search box, grows the search result page in the same pace as the search box to make them look like a single growing view. Screenshots of animation: https://screenshot.googleplex.com/FNsJ0bE9s29 https://screenshot.googleplex.com/4ObTEsitpRK https://screenshot.googleplex.com/sHQWVWaqavH https://screenshot.googleplex.com/HVFKUXrYQhO Specs: https://screenshot.googleplex.com/409fBM7pTO2 BUG=741051 Change-Id: I2fc15631e6675169dcb0ab222ce1af4cdc9cf2d2 Reviewed-on: https://chromium-review.googlesource.com/570835 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#486825}
-
Ryan Landay authored
Currently, this method uses LinearLayout.LayoutParams to measure the views in the ListView (this code was refactored out of DropdownPopupWindow). However, this causes a crash in certain situations on Android J and K (for example, adding a LinearLayout as a footer view, calling this method, and then later trying to measure a parent of the ListView) because LinearLayout.LayoutParams can't be cast to AbsListView.LayoutParams. This CL changes this code to use AbsListView.LayoutParams to avoid this crash. Bug: Change-Id: I90b68cd812155ac87bc089f95493cdd82de77395 Reviewed-on: https://chromium-review.googlesource.com/571600Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#486824}
-
Donn Denman authored
Updates ukm.xml to have the correct metric names. We originally wrote metrics using all-caps names, and changed the code in CL 2894913003 but we forgot to update ukm.xml at that time. This just updates the ukm.xml names to reflect what's already being written. Also removed one name that's for data that's not actually written. Also removes an include that's not needed. BUG=736158 Change-Id: I31f94553ab188e7001d10a3f2f109e4d7a255233 Reviewed-on: https://chromium-review.googlesource.com/568760Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#486823}
-
Andy Paicu authored
Fixed an issue where multiple policies with different algorithms would deny scripts/styles Fixed an issue where report-only policies could cause hash-based policies to incorrectly deny scripts/styles Fixed an issue where mixing hash based and not hash based policies would deny scripts/styles because the checks were done independently Got rid of the IsAllowedByAll template system and replaced it with for loops Ensured that checks that check hashes are now incorporated in their respective allows function Removed the need for external callers to know to call the hash specific functions checks since now they are integrated Added LayoutTests relevant to the issues above Bug: 617065, 739292, 740688 Change-Id: I1b56afe899eac6358d2ef33fc7030aef568f89ac Reviewed-on: https://chromium-review.googlesource.com/570248Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#486822}
-
yolandyan authored
Since WebView is the only place where parameterization is used for instrumentation tests. This CL simplify the framework by only providing commandline flag parameterization. This is for the sake of listing out tests from Java test runner side in the follow up CL BUG=640116 Review-Url: https://codereview.chromium.org/2963683002 Cr-Commit-Position: refs/heads/master@{#486821}
-
Fady Samuel authored
I forgot to move this file in the last CL. Bug: 722935 Change-Id: Ic7e3872fe876b23b993b9d0a3f53d998e6b43ea6 Reviewed-on: https://chromium-review.googlesource.com/571265Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#486820}
-
Peter K. Lee authored
Bug: 721921 Change-Id: Idc58d5076791ea511d0efcd1df944496883de220 Reviewed-on: https://chromium-review.googlesource.com/567393Reviewed-by:
Louis Romero <lpromero@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#486819}
-
Dirk Pranke authored
This reverts commit 19e9083e. Reason for revert: This might be causing the Linux CFI failures in https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20CFI/26 and following. Original change's description: > Reland of Pass -no-canonical-prefixes to clang by default. > > This is a reland of patchset #1 of https://codereview.chromium.org/2936053003, > except that we do not pass the flag when using the ChromeOS custom > toolchains, either. > > TBR=hans@chromium.org, manojgupta@chromium.org, thakis@chromium.org > BUG=712797 > > Change-Id: I14f56c9b29234dd693719b017828c6250202a9d0 > Reviewed-on: https://chromium-review.googlesource.com/571440 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486793} TBR=thakis@chromium.org,hans@chromium.org,dpranke@chromium.org,manojgupta@chromium.org Change-Id: Iffa28553b78c79fec8daed93658ba755bd17fe1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 712797 Reviewed-on: https://chromium-review.googlesource.com/572004Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#486818}
-
oshima authored
The issue was that NativeViewHost fills the background with WHITE (default color) if the clipping window is installed. This was for fast resize scenario (resizing the view without resizing nativ view), but this also appends when native view gets clipped (which happens when you scroll). While it's a bit sounds wrong to set the resize background color even if you're not resizing, this is simplest solution. BUG=None Review-Url: https://codereview.chromium.org/2969523002 Cr-Commit-Position: refs/heads/master@{#486817}
-
Patrick Monette authored
Bug: 717696 Change-Id: I60b57042445f89122db3288983fa3e66bb29d13e Reviewed-on: https://chromium-review.googlesource.com/563697Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#486816}
-
johnchen authored
On Android devices, ChromeDriver used to use shell "echo" command to send Chrome command line to the device. Adb limits the length of the command line that can be sent this way, ranging from less than 1000 characters to about 4000 characters, depending on the Adb version. To allow longer command line to be used, ChromeDriver now uses Adb file transfer protocol to send the command line file to the device. This is the same underlying protocol used by "adb push" command. BUG=727979 Review-Url: https://codereview.chromium.org/2972913002 Cr-Commit-Position: refs/heads/master@{#486815}
-