- 22 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1e8486b1739d..f324fe10ca65 git log 1e8486b1739d..f324fe10ca65 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 sugoi@google.com Improve 565 and 5551 precision Created with: gclient setdep -r src/third_party/swiftshader@f324fe10ca65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I68fbf3a9390f18c0798e5f5120214e5130c6de00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015544Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734232}
-
Ryan Hamilton authored
While ACK decimation is not currently enabled by default, it *is* enabled via experiments ubiquitously. This may cause a regression in some perf tests, but those tests are not running with the config used in production (with ACK decimation enabled). b/79972781 BUG=842677 Change-Id: Ie2729bd8c47f9d9781e5de6aa39379c740319976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015495 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#734231}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/a32acc1be500..9ad78aa7dba2 git log a32acc1be500..9ad78aa7dba2 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 rharrison@google.com Start v2020.0 (#970) 2020-01-22 rharrison@google.com Fix the version string (#971) 2020-01-22 rharrison@google.com Finalize v2019.1 (#969) Created with: gclient setdep -r src/third_party/shaderc/src@9ad78aa7dba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ia361fdd75bca63a2289eb72364aaba5ac8c446af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734230}
-
Hiroshige Hayashizaki authored
This CL updates generated files, reflecting changes in https://chromium-review.googlesource.com/c/chromium/src/+/1991066. Bug: 906850 Change-Id: I4dc79a2afc93e7a22c8c1cf83250d05876cc6103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993003Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#734229}
-
Tricia Crichton authored
For connections to localhost, ChromeDriver should test both IPv4 and IPv6 formats to resolve issue where DevTools may not be listening on the expected protocol. Bug: chromedriver:3316, b/147285732 Change-Id: Iecbf8f4f1c8df6138fd8ef8d908217e760e13923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013892Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#734228}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b19c78ebad84..4ca0dacbce51 git log b19c78ebad84..4ca0dacbce51 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 kjlubick@google.com [canvaskit] Roll to 0.12.0 2020-01-22 kjlubick@google.com [canvaskit] Fix color opaqueness 2020-01-22 kjlubick@google.com [canvaskit] Fix colorType bug 2020-01-22 reed@google.com Revert "Revert "use SkM44 internally"" 2020-01-22 fmalita@chromium.org [skottie] Cleanup: convert shape layer adapters to new pattern 2020-01-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-22 bsalomon@google.com Fix usage enum with GL_NV_pixel_buffer_object. 2020-01-22 bungeman@google.com Glyph 0xFFFF is a valid glyph. 2020-01-22 bsalomon@google.com Disable Programs test on TecnoSparkPro3 Debug test bot 2020-01-22 egdaniel@google.com Reland "Reland "Pass in a SkColorType into SkImage_Gpu ctor."" 2020-01-22 michaelludwig@google.com Add GrQuad::bounds() benchmark 2020-01-22 reed@google.com Revert "use SkM44 internally" 2020-01-22 mtklein@google.com add --dylib to fm 2020-01-22 reed@google.com use SkM44 internally 2020-01-22 csmartdalton@google.com Add a tessellation mode that triangulates the inner polygon separately 2020-01-22 herb@google.com Reduce error control flow in addGlyphToAtlas 2020-01-22 scroggo@google.com Make SkImageInfo::validRowBytes consider alignment 2020-01-22 bsalomon@google.com Rework spefication of src/dst rects/translates throughout SkGpuBlurUtils. 2020-01-22 brianosman@google.com Clamp GrSkSLFP output to valid premul 2020-01-22 bsalomon@google.com Add functions for GL_NV_fence to GrGLInterface. 2020-01-22 robertphillips@google.com Revert "Add compressed backend textures to Metal" 2020-01-22 reed@google.com remove fun operator overloads 2020-01-22 mtklein@google.com split SkBBoxHierarchy into public/base types Created with: gclient setdep -r src/third_party/skia@4ca0dacbce51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I5d3deef4748a5fec14d02d52f0107498a21d87be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015451Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734227}
-
Jesse Schettler authored
Update cros_healthd_probe.mojom to keep it in sync with the copy in Chrome OS. Bug: 1026848 Test: DeviceStatusCollectorTest.TestCrosHealthdInfo Change-Id: I7b35f6668f0f2627976c57f7a02cc22efeddbfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013467Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Jack Rosenthal <jrosenth@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#734226}
-
Jay Harris authored
This reverts commit 6cf710fa. Reason for revert: This CL didn't cause the linked bug. That bug was a duplicate of crbug.com/1044520 which is now fixed. Original change's description: > Revert "WebApps: Implement unregistering file handlers on Linux." > > This reverts commit 32a1f8bf. > > Reason for revert: LocalNTPJavascriptTest failing on 7 builder(s) > Fixed: 1044497 > > Original change's description: > > WebApps: Implement unregistering file handlers on Linux. > > > > This will allow us to disable the file handlers for an app on Linux > > without uninstalling it. This is necessary preparation for the origin > > trial, as we need to be able to disable/enable the file handlers as > > the validity of the app's origin trial changes. > > > > Bug: 1028448 > > Change-Id: I63eb6582852ff75d3d88181ede07f0cbd010df2d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010234 > > Commit-Queue: Jay Harris <harrisjay@chromium.org> > > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#733859} > > TBR=loyso@chromium.org,harrisjay@chromium.org > > Change-Id: I67239e88d48df1d70ff1a432863b3be26d5d7bd4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1028448 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014352 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733902} TBR=yoichio@chromium.org,loyso@chromium.org,harrisjay@chromium.org Change-Id: I5052bf84dc417f11325c51e9a584e13a585c46a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015901Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#734225}
-
Connie Wan authored
This follows a similar pattern to how tabs are moved left/right: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=1591&rcl=3e23198594e08a63cc5e091e1eefe79e3dd48454 I deliberately chose not to support MoveGroupFirst() and MoveGroupLast(), since the implementation seemed too finicky and the feature seemed very niche. We can return to it if we decide it's higher priority for accessibility. Bug: 1039921 Change-Id: Ifcd078d640a84fe96f15c41a38daa82a5090641c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006219 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#734224}
-
Alex Danilo authored
Removes the util to test for visual signals feedback panel feature flag being enabled and removes the ability to show the deprecated panels. Covered by existing unit tests. Bug: 1027012 Change-Id: Ia5d2d6536d51d2f31b702308eb5d4f91350b72f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014214Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734223}
-
Andrew Moylan authored
This one part somehow escaped getting upgraded to the new Mojo names. Bug: None Test: Build Change-Id: Icb4cc5a4c65429a026866e847288a92d0542dc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015900 Commit-Queue: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#734222}
-
Ulan Degenbaev authored
Some users of the script are not Chrome engineers and cannot build trace_processor_shell Bug: chromium:1044682 Change-Id: I40e904e3eccd6bc466241e66716683d7d4da6cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015103 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#734221}
-
Sam Sebree authored
This change replaces the old time icon with the new material icon Bug: 1021339 Change-Id: I1ae90a44e01c477097c19f0b94e4e3437a709233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014153Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734220}
-
Mike Wiitala authored
The Drallion (Wilco 1.5) keyboard has a slightly different layout than Wilco 1.0: 1. The toggle mirror mode button has moved from F12 to its own key without a corresponding F key. 2. F12 now shares a key with privacy screen toggle on devices with a privacy screen. BUG=b:147241224 TEST=build and deploy chrome to a Drallion DUT: autoninja -C out_drallion/Release chrome chrome_sandbox nacl_helper; deploy_chrome --build-dir=out_drallion/Release --to={DUT_IP}; Verify that top row keys map to expected key codes: Privacy Screen -> VKEY_PRIVACY_SCREEN_TOGGLE Privacy Screen + Fn -> VKEY_F12 Privacy Screen + Search -> VKEY_F12 Privacy Screen + Fn + Search -> VKEY_PRIVACY_SCREEN_TOGGLE Mirror toggle key always maps to VKEY_MEDIA_LAUNCH_APP2 with Control held down, regardless of Fn and Search key states. Change-Id: I8df3d28d7ea9445d736ec831b4423f2c224dd592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008063 Commit-Queue: Mike Wiitala <mwiitala@google.com> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#734219}
-
dalyk authored
Secure DNS will be disabled in these windows, allowing users to complete the captive portal resolution process. Future cls will add additional conditions that will trigger captive portal probes in secure mode. Change-Id: I441d17465a9c9d11567775321ed3ddd8532598ab Bug: 10161646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984663Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#734218}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9cc8d75a2ad..bc9b29411747 git log b9cc8d75a2ad..bc9b29411747 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 bsheedy@chromium.org Workaround CrOS root partition read-only Created with: gclient setdep -r src/third_party/catapult@bc9b29411747 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1043953 Tbr: nuskos@google.com Change-Id: I660987f0c6598ee82936ed502ed292ba108a607f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734217}
-
Henrique Nakashima authored
This is the first file to be moved into the new flags module. This is CL 3/3 to move ChromeFeatureList to chrome/browser/flags:java Bug: 1041468 Change-Id: Ie52917a32896d7ee721c4b2278fa7bc6884b417d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007315 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#734216}
-
Nicolás Peña Moreno authored
In ImageResourceContent, |observers_| and |finished_observers_| can both contain an |observer|. Therefore, in RemoveObserver(), if removing from |observers_|, it's only fully removed if it does not exist in |finished_observers_|. Bug: 1041707 Change-Id: Ia21f21627d62e19788216cfc010715646ee4842d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011137Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734215}
-
Rayan Kanso authored
This is limited to bound WebAPKs. This is the first step to make WebAPKs discoverable via getInstalledRelatedApps. Bug: 1043970 Change-Id: I1cbb86159d15554c129894b6c405c1efefa42587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012287 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734214}
-
Philip Rogers authored
We calculate clip rects for the underline intersections with glyphs to clip out the underline. These intercepts are calculated by Skia and can be infinite which results in an invalid clip-out paint op. This patch skips these degenerate clips-outs. This is not done for all clips because the common case is to clip from values from the layout system which will be finite. This is not done in the intercept calculation code because infinite values are correct for extreme glyph positions. Bug: 1043753 Change-Id: I0b63eb892840994537b7fec4fd9b2313f74a7d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014310 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734213}
-
John Lee authored
This CL fixes a use case when a grouped tab is added before an already grouped tab. Before, the tab would get appended to the end of the list because it was not updating the |elementAtIndex| variable to be the correct element. Bug: 1027373 Change-Id: I1eaec3b950576ac06fd7b927cb4f23ce7810cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013584 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#734212}
-
Tricia Crichton authored
Pass currentFrameId to cookie operations where missing so that Cookie operations run against the current execution context. This conforms with WebDriver spec. This cl will affect only cases where the main context url and the frame URL are different. Bug: chromedriver:3153 Change-Id: Idc4d14628ec5c00e153a3e75e38e3648cdc226a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987078Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#734211}
-
Dave Tapuska authored
Send the DidFinishDocumentLoad IPC directly from blink. The WebLocalFrameClient callback is still necessary because of RenderFrameObservers that need to listen for the load complete. BUG=1042831 Change-Id: I39a487268c90195c8dd94c9862e7a6bd695ba213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005376 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#734210}
-
Findit authored
This reverts commit d84a78f8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 734144 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDg0YTc4Zjg2MjY2ZmI5MTllZjU0NzU4ZDZhNzdmMGZjODVmZmUyYgw Sample Failed Build: https://ci.chromium.org/b/8890527503070869360 Sample Failed Step: content_browsertests Sample Flaky Test: BackgroundTracingManagerBrowserTest.PerfettoSystemBackgroundScenarioRuleId Original change's description: > Enable system perfetto producer on all posix builds. > > It remains disabled by default by the tracing flag > --enable-features=kEnablePerfettoSystemTracing, but when enabled will > attempt to connect to the result of GetProducerSocket(). > > This will be useful for people who want system wide tracing on linux > from crashed browser processes since the tracing service will be alive > even after Chrome dies. > > Bug: 1007310 > Change-Id: I62e67bcdc9ff720da2a59497a6d3ebf855413b8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953718 > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734144} Change-Id: I1edd45928f698173aa53dc1d00f4229ef7a877d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015774 Cr-Commit-Position: refs/heads/master@{#734209}
-
Michael Thiessen authored
This is a necessary pre-cursor to cleaning up scheme initialization. No GURLs should be created before schemes are modified/added and GURL is ready to use. Enforcement of this will come in a followup CL. See the bug for additional context. Replacing static initalizers with functions ensures the GURLs are only initialized when used, which happens after test setup. Bug: 783819 Change-Id: I1d0f3e81ce47903156937e5e8e58db49d287eaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008008 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734208}
-
Li Lin authored
Bug: 1044413 Test: Manual Change-Id: I59eb13ef6e80c72c49eb9c8271ed9f70c063a9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014120Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734207}
-
Stefan Zager authored
This patch caused a leak in IntersectionObserverController: https://chromium-review.googlesource.com/c/chromium/src/+/1774244 In particular, if an explicit-root IntersectionObserver was destroyed because it had no observations and no javascript references to it, then IntersectionObserverController would continue to track the root Element. This patch overhauls the way the tracking bookkeeping is handled for explicit-root observers, and guarantees two important cases: - If the observer dies, the root will no longer be tracked. - If the root element dies, any remaining observations will be disconnected. Change-Id: Ieb3822a4735850c7baae4ef32e7826f3eda10fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008528 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734206}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/50d1a4aa725f..7763c888e0c0 $ git log 50d1a4aa7..7763c888e --date=short --no-merges --format='%ad %ae %s' 2020-01-21 jianj vp9: fix control for delta qp for uv 2020-01-17 jzern add static_assert.h 2020-01-16 bpfoley Validate data used by vpx_codec_control... 2020-01-16 jianj vp9: add delta q for uv channel. add tests. 2020-01-13 chengchen Add comments to frame counts. 2020-01-10 jzern vp9_encoder.c,cosmetics: fix some typos 2020-01-10 jzern simple_encode*.cc: add missing copyright 2020-01-10 johannkoenig trivial: fix spelling errors 2020-01-09 jianj Fix test failure with --size-limit 2020-01-02 chengchen Copy frame counts to the encode result. 2020-01-07 courbet Avoid reloads in vp9_read_mode_info. 2019-12-18 wonkap Add text to clarify the unit of variables for target bitrate Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ia6da9c7fa7239908ea95025290b420af37e123c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014984Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#734205}
-
Kenneth Russell authored
Shipping the passthrough command decoder on macOS is planned soon and it's crucial to test this configuration on incoming ANGLE CLs. Bug: angleproject:2273 Change-Id: I6fad76febc0e417fd6f741215a52443958345e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013864Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734204}
-
Luum Habtemariam authored
In crbug.com/767924, we started syncing printers with invalid PPD references. Since tracking, we found enough users with saved printers in this invalid state to fix. Bug: chromium:987869 Test: written tests confirm correct resolution Change-Id: I406bdaf3e7658db42db9c408feadba6f579edb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008135Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#734203}
-
Rob Buis authored
Adjust tests so that response returns text/css in order to not fail these tests once stylesheet loading gets more strict. Bug: 752830 Change-Id: I51ada4de148c384842911f001761b97f71a9082a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007112Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#734202}
-
Ian Kilpatrick authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1966385 we move IsFixedBlockSizeIndefinite out of MaySkipLayout and into the caching layer. This wasn't paired with moving this bit into AreSizeConstraintsEqual. This caused us to skip a layout, when we couldn't. :( Bug: 1043071 Change-Id: Idbb68e136efe21b77394466a16a7ec3b06abe06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015101Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#734201}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Ica20f108c27b33a04a547713d344e0d11f646278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011291Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#734200}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibd8f735fe8857ee365bf2f4419f53a9c3e3b6df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015224Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#734199}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a5aa6680ce4..bdd89366d34e git log 6a5aa6680ce4..bdd89366d34e --date=short --first-parent --format='%ad %ae %s' 2020-01-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@bdd89366d34e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Id785b3c5c49d0b89690271dbe7a548c0f32820a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734198}
-
Xing Liu authored
This CL adds code to compare a version in Finch parameter and local version cached in PrefService, and show a notification when the version from Finch is newer. The notification logic will be added in following CL. Bug: 1042124 Change-Id: Ie2ab1250557517554abb142a0a0c5ee31eb95d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006418Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734197}
-
Liquan (Max) Gu authored
menthod -> method Change-Id: I93d84de0e7105a27ae765488cf0ec000c0c84909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015048Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734196}
-
Dan Harrington authored
This CL begins organizing code for Feed v2 by pulling some enums into a new common directory. Putting shared code in a different place makes it easier to understand implications of modifying code, and will make it easier to understand what pieces of code effect the 'v2' effort. I'm starting with a few enums because they are very likely to remain identical. More code will be moved here soon. Bug: 1044139 Change-Id: I51f83f2fdc212aba9f72a1e9afd2ef8e79437e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012903 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#734195}
-
Peng Huang authored
Currently, SkiaOutputDeviceBufferQueue::Reshape() will cancel all pending swap completion callbacks. It will generate wrong UMA data. So instead of canceling pending callbacks during Reshape(), we just make the image bind to the callback be weak ptr. So the callback can handle it properly. Bug: None Change-Id: I05e943d193ff868063538899eb899fcd767ae7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013807 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#734194}
-
Ayu Ishii authored
This test fails because the cleanup to "unsubscribe" cookies would occur after the registration has already been unregistered for non-workers. This change removes the cleanup to "unsubscribe" and just relies on "unregister" for cleanup. The flaky failures can be reproduced locally using the following gn args and commandline. (Googlers: http://screen/E7px76cVS2E) gn args: dcheck_always_on = true ffmpeg_branding = "Chrome" is_component_build = false is_debug = false mac_deterministic_build = true proprietary_codecs = true symbol_level = 1 use_goma = true command: python third_party/blink/tools/run_web_tests.py -t LinuxTest third_party/blink/web_tests/external/wpt/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.js --gtest_repeat=20 Bug: 1029713 Change-Id: Ifa766b974bddfcc6ee43e60be0766c1cb80cb742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014100 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#734193}
-