GitLab

Refactor SelectFaviconFrames to make it easy to use SelectFaviconFrames on objects other than SkBitmaps.
Changed the selection and score calculation code to operate on std::vector<gfx::Size> instead of an std::vector<SkBitmap>.

Bug=10802066
Test=SelectFaviconFramesTest.* pass
TBR=thakis

Review URL: https://chromiumcodereview.appspot.com/10872093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153590 0039d316-1c4b-4281-b951-d872f2087c98

temporary download directory to avoid Chrome pending on user input of a new
filename.

BUG=144624
TEST=browser_tests --gtest_filter=SSLUITest.TestBadHTTPSDownload


Review URL: https://chromiumcodereview.appspot.com/10868111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153589 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138118


Review URL: https://chromiumcodereview.appspot.com/10874068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141898


Review URL: https://chromiumcodereview.appspot.com/10832349

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153585 0039d316-1c4b-4281-b951-d872f2087c98

Resource files are in http://codereview.chromium.org/10883041/

This is trying to re-created stevenjb's cl:
http://codereview.chromium.org/10883041/

BUG=144723
TBR=oshima

Review URL: https://chromiumcodereview.appspot.com/10879106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153584 0039d316-1c4b-4281-b951-d872f2087c98

These were split out from dharcourt@chromium.org's review here:

https://chromiumcodereview.appspot.com/10868050/

BUG=133746
TBR=asargent@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10870116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153583 0039d316-1c4b-4281-b951-d872f2087c98

* DriveResourceMetadata::AddEntryToDirectory now takes a FilePath and scoped_ptr<DocumentEntry>.
* DriveFileSystem::AddUploadedParams now take a directory FilePath and a scoped_ptr<DocumentEntry>.
* Anon helper function PostError in drive_resource_metadata.cc posts an async callback error.
* DriveFileSystem's OnCreateDirectoryCompleted renamed to AddNewDirectory. The old synchronous AddNewDirectory is gone, replaced by a call to DriveResourceMetadata::AddEntryToDirectory, continuing with DriveFileSystem::ContinueCreateDirectory.
* DriveFileSystem's CreateDirectoryParams has moved to the header file so AddNewDirectory may be called by the unit test.
* DriveFileSystem's RenameEntryLocally, RenameAfterGetEntryInfo and NotifyAndRunFileMoveCallback now require a non-null callback.
* AddUploadedFileToCache calls OnDirectoryChanged directly instead of the indirection through NotifyAndRunFileMoveCallback. Also additional DCHECKs in AddUploadedFileToCache.
* callback_runner no longer necessary in AddUploadedFileOnUIThread.
* entry replaced with doc_entry everywhere to avoid confusion with GDataEntry.
* virtual_dir_path replaced with directory_path everywhere for consistency.
* delete FindEntryCallback, which is no longer used.

BUG=142048
TEST=unit tests
Review URL: https://chromiumcodereview.appspot.com/10876075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129861
TEST=NONE
TBR=alexeypa@chromium.org, isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10878087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153581 0039d316-1c4b-4281-b951-d872f2087c98

Added break statement in MediaTransferProtocolDaemonClient::FileEntry::InitialFromResponse function.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10873076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144436

Review URL: https://chromiumcodereview.appspot.com/10873095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144326
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10872094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153578 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10882070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153577 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137342
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10872098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153576 0039d316-1c4b-4281-b951-d872f2087c98

Flash isn't using 3D in this case, so using Swiftshader to present just slows it down


BUG=142107


Review URL: https://chromiumcodereview.appspot.com/10875074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143745

Review URL: https://chromiumcodereview.appspot.com/10829436

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153574 0039d316-1c4b-4281-b951-d872f2087c98

Remove MediaDeviceMapService references from |DeviceAttachedIntentSource::OnMediaDetached| function.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10868110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153573 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107201
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10868115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91551

Review URL: https://chromiumcodereview.appspot.com/10869003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10872076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10828217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133829
TEST=launch an app, then reload via the page reload button or the Reload link.

Review URL: https://chromiumcodereview.appspot.com/10641017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153567 0039d316-1c4b-4281-b951-d872f2087c98

The ClearKeyCdm implements the ContentDecryptionModule. It's a wrapping of the media::AesDecryptor to do real decryption work. The wrapping layer only translates input/output parameters and convert the async calls in media::AesDecryptor to sync calls.

TBR=scherkus@chromium.org
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152672

Review URL: https://chromiumcodereview.appspot.com/10837252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153566 0039d316-1c4b-4281-b951-d872f2087c98

Add !defined(OS_IOS) to if defined(OS_MACOS) around functions GetSandboxProfileForSandboxType and GetCarbonInterposePath.

These functions are not applicable to iOS.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10871013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153565 0039d316-1c4b-4281-b951-d872f2087c98

Reland of http://codereview.chromium.org/10877025/.  Accidentally included other code in the CL when manually landing after the CQ got stuck, so had to revert (See http://codereview.chromium.org/10880048/)

Remove no longer used NetNanny and ESET anti-virus error
strings and ESET error code.

TBR=agl@chromium.org, thakis@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10870103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153564 0039d316-1c4b-4281-b951-d872f2087c98

This CL is equivalent to CLs http://codereview.chromium.org/10799005, 
http://codereview.chromium.org/10836293, and
https://chromiumcodereview.appspot.com/10823406, which were previous attempts 
to land the same functionality.  

TBR=jam@chromium.org

BUG=123998
BUG=144751


Review URL: https://chromiumcodereview.appspot.com/10867065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143742
TBR=oshima

Review URL: https://chromiumcodereview.appspot.com/10870113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10876080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153558 0039d316-1c4b-4281-b951-d872f2087c98

This should help us figure out what's happening when something goes wrong.

BUG=140773


Review URL: https://chromiumcodereview.appspot.com/10871080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10879093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153556 0039d316-1c4b-4281-b951-d872f2087c98

inside their own processes. And we have another set of helpers that ensure we actually set
a sandboxing policy and don't forget to start the sandbox prior to running the tests.

Also simplified the handling of unexpected failure and termination of the sandbox'd process.

TODO: we still don't have a good story for testing fatal errors. We will eventually need
some form of exit tests.


BUG=n/a
TEST=sandbox_linux_unittests


Review URL: https://chromiumcodereview.appspot.com/10878033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138614


Review URL: https://chromiumcodereview.appspot.com/10855190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153554 0039d316-1c4b-4281-b951-d872f2087c98

Add watching for how many bytes are read. Useful for future analytics, and to
see periods of increased downloads.

BUG=130212
TEST=Included browsertest


Review URL: https://chromiumcodereview.appspot.com/10829342

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153553 0039d316-1c4b-4281-b951-d872f2087c98

. Show() variants
. SetInitialFocus()
. SetWindowTitle()
. Accessibility setters.
. WindowImpl overrides
. Activate/Focus restoration
. Close()
. Modality

http://crbug.com/142962
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10870110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143454

Review URL: https://chromiumcodereview.appspot.com/10867091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153550 0039d316-1c4b-4281-b951-d872f2087c98

The classes content::MockRenderProcessHostFactory and TestRenderViewHostFactory do not exist on iOS;  they would not make sense on iOS.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10878074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153549 0039d316-1c4b-4281-b951-d872f2087c98

Previously, every call to WebAccessibilityObject called an internal
updateBackingStore method, which could cause the WebAccessibilityObject
to be detached. It was inefficient to call it with every method call, and
also led to a heap-use-after-free.

With this patch, updateBackingStoreAndCheckValidity is called once before
accessing a WebAccessibilityObject, so we can next remove the internal
calls to updateBackingStore, fixing the heap-use-after-free.  This also
consolidates calls to isNull, isDetached, and isValid to just use
isDetached.

BUG=129301


Review URL: https://chromiumcodereview.appspot.com/10871085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153548 0039d316-1c4b-4281-b951-d872f2087c98

We track three sources: Actual user-initiated deletes, pre-sync deletes (initiated by prepopulate merge code), and cleanup deletes (on entries with empty fields).

BUG=143249,140732
TEST=No user visible changes.


Review URL: https://chromiumcodereview.appspot.com/10873075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153547 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153546 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dominicc@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10882062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153545 0039d316-1c4b-4281-b951-d872f2087c98

- Add a bash fun to unpack python jsons and get target to make
- Changed top level scripts to pass args (factory props)
- renamed bb_run_tests -> bb_run_unit_tests
- renamed bb_run_content_shell_instrumentation_tests ->
          bb_run_instrumentation_tests

BUG=144470

Review URL: https://chromiumcodereview.appspot.com/10878031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153544 0039d316-1c4b-4281-b951-d872f2087c98