GitLab

Replaces obsolete methods of gfx::Font and gfx::FontList with new ones.

BUG=265485
TEST=none

Review URL: https://codereview.chromium.org/140693017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248926 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Tested manually, by setting the downloads directory to Drive, and then trying to install an unpacked extension.
BUG=340925

Review URL: https://codereview.chromium.org/132633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248925 0039d316-1c4b-4281-b951-d872f2087c98

Instead of PasswordManager and PasswordGenerationManager being
WebContentsUserData instances, they are changed to be owned by
ContentPasswordManager (which is in turn owned by PasswordManagerDelegateImpl,
which is a WCUD). Convenience functions are added to
PasswordManagerDelegateImpl in order to get Password(Generation)Manager from a
WebContents instance.
BUG=335099, 335026
TBR=thakis

Review URL: https://codereview.chromium.org/151413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248924 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/147933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248923 0039d316-1c4b-4281-b951-d872f2087c98

This brings support for setting ASan options via system property and
a fix for "can not describe address in more detail".

BUG=325685

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248922 0039d316-1c4b-4281-b951-d872f2087c98

Previously the processing of Drive entries are delegated to the
running profile of the apps, but now it is passed to the owning
profiles of each entries.

BUG=339706

Review URL: https://codereview.chromium.org/145973016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340846

Review URL: https://codereview.chromium.org/154983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248920 0039d316-1c4b-4281-b951-d872f2087c98

This CL do random cleanup involved with DirectoryModel.

* Remove unused parameters and variables.

* Remove methods that just delegates to another method or are called from one
  place, in order to reduce the number of jump when reading codes.

* Merge the specialSearch method into changeDirectoryEntry by extracting the
  difference of the two mehtods to createDirectoryContents_.

BUG=none
TEST=manually

Review URL: https://codereview.chromium.org/151413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248919 0039d316-1c4b-4281-b951-d872f2087c98

One GC cycle is not enough to collect DOM wrappers.
To test that all DOM wrappers are reclaimed,
this CL adds a function that triggers multiple GC cycles.

BUG=307614

Review URL: https://codereview.chromium.org/153803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248918 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/152033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248917 0039d316-1c4b-4281-b951-d872f2087c98

Add AddNewDirectoryOptions() argument to AddNewDirectory.
Send date parameters with FilesInsertRequest.

TBR=benwells@chromium.org for chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc
BUG=340553
TEST=unit_tests

Review URL: https://codereview.chromium.org/140513008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248916 0039d316-1c4b-4281-b951-d872f2087c98

Replaces obsolete methods of gfx::Font and gfx::FontList with new ones.

BUG=265485
TEST=Run app_list_unittests.

Review URL: https://codereview.chromium.org/151693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248915 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/143663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248914 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248913 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg

Review URL: https://codereview.chromium.org/154263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248912 0039d316-1c4b-4281-b951-d872f2087c98

Takes ShapeBounding rectangles into consideration in WindowContainsPoint. This is a followup on https://chromiumcodereview.appspot.com/10990010.

BUG=319795
TEST=in chromoting session to a Ubuntu machine launch chrome and drag a bookmark changing the order of bookmarks (should not hang).
TEST=in chrome://settings page drag "Google Dashboard." link to omnibox (should not hang).

Review URL: https://codereview.chromium.org/153953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248911 0039d316-1c4b-4281-b951-d872f2087c98

There is about 0.5ms of trace overhead per frame on the fast
path, so we might as well remove that so traces contribute
less noise.

This also merges 'browser_main' and 'browser_compositor'
threads since there isn't always both and they are small to
begin with. Best to do this before cleaning up the names on
the dashboard.

BUG=321439

Review URL: https://codereview.chromium.org/139743018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248910 0039d316-1c4b-4281-b951-d872f2087c98

Spark needs this for launching chrome apps.

Bug=340819

Review URL: https://codereview.chromium.org/133163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248909 0039d316-1c4b-4281-b951-d872f2087c98

A maximize animation triggers recreating the layer of the
window. Recreating the layer forces the bounds of the window to 0. A
maximize results in the origin going to 0. Together this meant a
maximize from any where resulted in the code not thinking a move
happened.

This patch special cases NativeWidgetAura::OnBoundsChanged to assume
that if the old bounds was empty at 0,0 and the new bounds is not
empty that a move happened.

BUG=335486
TEST=covered by test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/153803006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248908 0039d316-1c4b-4281-b951-d872f2087c98

as early as possible (even before host resokution has started).

Create QuicServerInfo in QuicStreamFactory and pass the ownership
to QuicCryptoClientConfig::CachedState.

This is a parital release. Will be hooking up persisting and
reading of the data (including waiting for the disk read to finish)
in the next release.

R=wtc@chromium.org

Review URL: https://codereview.chromium.org/149413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335275

Review URL: https://codereview.chromium.org/144623006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340100

Review URL: https://codereview.chromium.org/132913007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248903 0039d316-1c4b-4281-b951-d872f2087c98

Replaces obsolete methods of gfx::Font and gfx::FontList with new ones.

BUG=265485
TEST=Run unit_tests.

Review URL: https://codereview.chromium.org/152343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248902 0039d316-1c4b-4281-b951-d872f2087c98

None guest users include authenticated users (regular user, owner), kiosk
users and login screen where there is no user.

BUG=340843

Review URL: https://codereview.chromium.org/154863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248901 0039d316-1c4b-4281-b951-d872f2087c98

The RenderWidgetHostViewAndroid::HasTouchEventHandlers notification is no longer
used, remove accordingly.

Review URL: https://codereview.chromium.org/153953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248900 0039d316-1c4b-4281-b951-d872f2087c98

This localizes just the application name (so that Official builds of
the Android app will be called "Chrome Remote Desktop"). Followup CLs
will make the remaining strings localizable.

BUG=270362

Review URL: https://codereview.chromium.org/149293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248899 0039d316-1c4b-4281-b951-d872f2087c98

For future extensibility, encode the fields of QuicPublicResetPacket
as a CryptoHandshakeMessage, which is essentially a QuicTagValueMap.

Move the CryptoHandshakeMessage class to its own files.

Move the QuicTagValueMap type from crypto_protocol.h to
quic_protocol.h.

Merge internal CL: 60963943

Note: net/quic/crypto/crypto_handshake_message.{cc,h} were added
separately in https://codereview.chromium.org/154643006.

R=rch@chromium.org,rtenneti@chromium.org
BUG=none
TEST=net_unittests

Review URL: https://codereview.chromium.org/147763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340948
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/144713008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248897 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=256855

Review URL: https://codereview.chromium.org/146523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248895 0039d316-1c4b-4281-b951-d872f2087c98

The functionality is the same, just moving the code to a new place.

BUG=333995

Review URL: https://codereview.chromium.org/144013009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248894 0039d316-1c4b-4281-b951-d872f2087c98

- Update password confirm UI per mock;
- Show password confirm UI with an error message after 1st failed attempt;
- Rename message box screen to fatal error screen;
- Show fatal error screen on 2nd failed attempt;

BUG=330206

Review URL: https://codereview.chromium.org/137803008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248893 0039d316-1c4b-4281-b951-d872f2087c98

Implment UnusedResourcesAreAvailable to send the unused resources back if there are
no pending ACKs.

Also handle the LoseAllResources from ResourceCollection to send back the resources.

R=danakj, sievers

Review URL: https://codereview.chromium.org/153683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248892 0039d316-1c4b-4281-b951-d872f2087c98

As a preparation to implement DispatchInstallEvent(), this implements
following two methods:
- SendMessage()
- SendMessageAndRegisterCallback()

Unlike my previous patches, this supports:
- Sending messages without explicitly starting the worker
- Sending multiple messages concurrently
- Receiving a response for each message

Now each message can be sent with a unique 'request_id', which can be
used to send back a response to a particular message.

BUG=313530
TEST=ServiceWorkerVersionTest.\*
R=alecflett@chromium.org

Review URL: https://codereview.chromium.org/139923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248889 0039d316-1c4b-4281-b951-d872f2087c98

Previously, files.app opens drive apps in the desktop of the running profile.
This CL adds lines to move the opened browser to the active desktop.

BUG=336093
TEST=manually

Review URL: https://codereview.chromium.org/153543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248888 0039d316-1c4b-4281-b951-d872f2087c98

Replaces obsolete methods of gfx::Font and gfx::FontList with new ones.

BUG=265485
TEST=Run ui_unittests.

Review URL: https://codereview.chromium.org/152733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248887 0039d316-1c4b-4281-b951-d872f2087c98

Because of a typo during refactoring, the url wasn't passed correctly. This patch fixes the typo.

TEST=Tested manually with an image on the downloads shelf.
BUG=340176

Review URL: https://codereview.chromium.org/145973017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248886 0039d316-1c4b-4281-b951-d872f2087c98

Password manager now ignores autocomplete='off' by default; user may specify a flag that says otherwise.

(Recommit after original commit reverted in https://codereview.chromium.org/130183003 due to unit test memory leak.)

BUG=177288

Review URL: https://codereview.chromium.org/146023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248885 0039d316-1c4b-4281-b951-d872f2087c98

Also use bold font for the stats table of the active ICE connection for highlight.


BUG=244648

Review URL: https://codereview.chromium.org/68103011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248882 0039d316-1c4b-4281-b951-d872f2087c98

```------------------------------
"Signin" is not a word.
"Sign into" doesn't make any more sense than "sign outof".

As a phrasal verb, it stands as a unit.
* "Bob signed in to Chromium to sync his settings."
* "Bob signed into Chromium, and it hurt. Next time he'll be more careful while
   signing and walking in the chemistry lab."
Don't hurt Bob.

As a phrasal noun, "sign-in" should be hyphenated.

Follow these simple[1] rules for correct usage:

* "signin" is not a word
* "sign in to", not "sign into" (you wouldn't "sign outof" Chrome)
* as a noun or noun adjunct, "sign-in", not "sign in":
    "Sign-in happens at the sign-in screen."
* as a participle + adverb:
  * "signed-in" before a noun: "who is the signed-in cat?"
  * "signed in" after a noun: "why is the cat signed in?"

Additionally, do not capitalize "in" or "out" in title case.
* "Sign in Again", not "Sign In Again"

[1] May not be simple.
```

------------------------------

Secondly, we should say "sign in" instead of "log in" in most places.

---------------------------------

Sources:
* go/uxwordlist
* https://net.educause.edu/elements/attachments/educause/pdf/ch07_tab01.pdf

I'd like to have kuscher check my work. Including aruslan and derat for sign-off
because the changes are somewhat extensive.

BUG=315617
NOPRESUBMIT=true
R=kuscher@chromium.org, bulach@chromium.org, derat@chromium.org

Review URL: https://codereview.chromium.org/145273019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248881 0039d316-1c4b-4281-b951-d872f2087c98