- 26 Oct, 2019 40 commits
-
-
Koji Ishii authored
* 3 crashes in native-file-system. * Mostly image rebaselines where scrollbar buttons became grayed when the scroll position is at begin/end. Probably someone fixed this. * A few pixel differences in rendering fonts, for vertical flow and "AM" in the date picker. TBR=ikilpatrick@chromium.org NOTRY=true Change-Id: I1f8a9eb2fbb816f27bf2eb8d51e423919dbbf9a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882249Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709765}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/76763cb90a43..e7c8e80dbb2e git log 76763cb90a43..e7c8e80dbb2e --date=short --no-merges --format='%ad %ae %s' 2019-10-26 jmadill@chromium.org Roll chromium_revision 60074bf9..5fe256ab (709436:709762) Created with: gclient setdep -r src/third_party/angle@e7c8e80dbb2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1017514 Change-Id: I75189db50e4ed3012535b7f11962c845b0d303a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709764}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id966f672c5140eed017b1ee5fc7fc0c6864e279f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881782Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7294eccd. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload mek@chromium.org: external/wpt/webmessaging tdresser@chromium.org: external/wpt/navigation-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic24792683389612d50c91fc6ae560d64eee074e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882129Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709762}
-
Henrique Ferreiro authored
Bug: 919392 Change-Id: Idbc7d23d127027834c70f09821ae0f389ce260be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876347Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#709761}
-
Jinsong Fan authored
There two cases of the bug: 1. When the touch handles are on the same line, or one of them is invisible, the RectBetweenBounds becomes a line, and not union the handle rect, cause the context menu covers the touch handles. 2. Long press on any text, the showSelectionMenu is coming before concluding the selection. While the handles remain hidden for the duration of a longpress drag, including the time between a longpress and the start of drag motion. So, the handle rect is empty and cause the context menu covers the touch handles. The CL removes the empty check of RectBetweenBounds, so it always union the handle rect to fix case 1. For case 2, leave it to Ajith's CL to fix(http://crrev/c/995653). Bug: 1013477 Test: manual Change-Id: Ie4fbe0669b28d1a0e7ac0894d2ba07569b63dd05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857838 Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709760}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f494d2ca. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4761910bd36f2a3a31059d16b0282a074133d256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882128Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits referencing the viz::mojom::InputTargetClient mojo interface using the old APIs to the new mojo types. Bug: 955171 Change-Id: I1ff61c9eda3479fb4462dfee94f7e98a520b8a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879895Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#709758}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/d3ddd33257..c20eb36aa7 TBR=lomitch@chromium.org Change-Id: Ibf03a314458df89fc08c0225f6af06b7a443b485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879463Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709757}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I80f354c018103ad8e42d2e27a37b2f4fea77aa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881780Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709756}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4812325d..0e9cc938 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibbaa7b007e7187a1d1cb7daca95af12b2ce60024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882127Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709755}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::ChildProcess with removing ChildProcessRequest. Bug: 955171 Change-Id: I8b95086f4c3c2cc39d559ff32f983a0c60f335f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879629Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4b1db19bd426..7568fa8a28d9 git log 4b1db19bd426..7568fa8a28d9 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 crouleau@chromium.org [Pinpoint] Use --run-full-story-set flag. Created with: gclient setdep -r src/third_party/catapult@7568fa8a28d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:982027 Change-Id: Ic908b4a209011255db62628f4de2fe2a889bf051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881891Reviewed-by:
-
Fergal Daly authored
I deleted it incorrectly in https://crrev.com/c/1862137 but it's failing. TBR=altimin@chromium.org Bug: 1004786 Change-Id: Ibfdc2f4f3d720b6f40e66cb02ed8f96ef4441380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881005Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709752}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iea82c12a112e89f26ff04d6e89510af394765e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881760Reviewed-by:
-
Jamie Madill authored
Was missing the correct prefix. Bug: 1017514 Change-Id: I05ed5952664e23b632727f7f6c9366bd5bd494ac Tbr: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881992Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#709750}
-
Miyoung Shin authored
This CL converts MediaMetricsProvider{Ptr, Request} in content and media to the new Mojo type. Bug: 955171 Change-Id: I12a9cd0c377a6081ad00f3503682d13078bc6b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880990Reviewed-by:Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#709749}
-
David Bokan authored
This CL adds a browser-side to the AgentMetricsCollector. Each renderer periodically (on state changes and every 5 minutes) sends its current list of acive agents to the browser side. This is recorded in a global map. Tuple-origins are recorded with both their protocol and registrable domain. The "unique" version of the metric de-duplicates same protocol+ registrable domain agents to simulate a potential OOPIF coalescing stragegy. Non-tuple-origins are always counted as unique and are sent as an empty string. Change-Id: Ie841c6c145c508c4769af7a0048b27c1e22aec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876878Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Fergal Daly authored
The previously filtered unit_tests are passing locally and also on bot runs - Linux-dbg run of the entire unit_tests suite (not sure why it ran everything and not just the filtered tests) https://chromium-swarm.appspot.com/task?id=481a4b30b854e210 - Android-dbg run of just the filtered tests https://chromium-swarm.appspot.com/task?id=481a597f7de9f510 Change-Id: I50314cab92ef7a5c688fc70e3ac246146ce33dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880888 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#709747}
-
Jazz Xu authored
Bug: 1015547 Change-Id: Ieade9352ce689c07f22710e11545adf571d93446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867193Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709746}
-
Jamie Madill authored
Was specifying jsoncpp_revision instead of patched_yasm_revision. Bug: 1017514 Change-Id: Ib16f9bb28843c17c24fabcf344fdaf50846b4a5e Tbr: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882087Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e95fc85cb76d..e38e11986f00 git log e95fc85cb76d..e38e11986f00 --date=short --no-merges --format='%ad %ae %s' 2019-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 98ef1d68..04c3c4c8 (709549:709704) Created with: gclient setdep -r src/third_party/webrtc@e38e11986f00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I14227578a2c7e61840d6661fec4e58b33d4a05bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881498Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Icab170512ca6ee133efd358524c9a8d92abaa2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879446Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709743}
-
Chris Lu authored
If there are no badges retrieved from GetInfobarBadgeItems(), then just set self.badges to nil instead of attempting to copy the vector into an array. Bug: 1016360 Change-Id: I591e48ad28232856da6e0ce695850522e37d425d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872484Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#709742}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to Create function in RemoteFactory interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Convert MakeStrongBinding to MakeSelfOwnedReceiver. Bug: 955171 Change-Id: I68e72fbd4963d5c6b80fdbe7c1140ae65ac6debc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877877Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709741}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6c015a4605f6..a8c4e3a48ffd git log 6c015a4605f6..a8c4e3a48ffd --date=short --no-merges --format='%ad %ae %s' 2019-10-26 sanikak@chromium.org auto_updater: Changes for local file transfer abstraction 2019-10-26 dhaddock@chromium.org Send applicable_models from paygen.json to test_params.TestConfig. Created with: gclient setdep -r src/third_party/chromite@a8c4e3a48ffd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I36c1b046a7241e05ff9e1f290df69a796a2f3a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881895Reviewed-by:
-
Dan Beam authored
This happened by accident in r709236 when polishing realbox icon sizes. R=dpapad@chromium.org Fixed: 1018095 Bug: 1017495 Change-Id: I23345b12d14e400eb014c0a6b25b88708e4a631f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881483 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#709739}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::RenderMessageFilter with replacing RenderMessageFilterAssociatedPtr with AssociatedRemote. Bug: 955171 Change-Id: I46f955af3356479fba5355d180d1345402f8b1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880232Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46788bec. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ibe0648506d34e857ea8baaf3f9578de4957b82e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880965Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::BrowserAssociatedInterfaceTestDriver and mojom::WebContentsFrameBindingSetTest with using AssociatedRemote and PendingAssociatedRecevier. Bug: 955171 Change-Id: Ifd937d9c3014af8616d12426ad239dce98efee59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880407Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e79107e01bb4..ebba8d75bf65 git log e79107e01bb4..ebba8d75bf65 --date=short --no-merges --format='%ad %ae %s' 2019-10-26 erikchen@chromium.org Add more tracing to git cache. Created with: gclient setdep -r src/third_party/depot_tools@ebba8d75bf65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I2bac6f09961cfc1b41a7d8078de13b67d9b6aa78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881893Reviewed-by:
-
dpapad authored
This is in preparation of porting to Polymer3 Bug: 1012533 Change-Id: If15a48c57bc28a014c548d6d8e8136fdce462080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881989Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#709734}
-
Chris Mumford authored
Switching several error callback implementations to use base::OnceClosure explicitly. All of these previously used base::Closure (implicitly repeating), but all of them would only ever run the error callback the first time an error orrurred. The affected classes are: 1. DemuxerStreamAdapter 2. StreamProvider 3. MediaStream Bug: 1007810 Change-Id: I872ea38eb27ec00c99137435c0408a93f292f9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879949Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#709733}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to functions in ResourceBundleFileLoader class. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtrInfo to mojo::PendingRemote. - Convert mojo::Binding to mojo::Receiver. - Convert FooPtr to mojo::Remote. Bug: 955171 Change-Id: Ia5f954e8c7e5fb57672ae374df5619e97789aaaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873818Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709732}
-
Sanket Joshi authored
This is a test refactoring change that introduces a directory under controls-new-ui called color-scheme-validation. The folder is meant to hold the tests that need to validate a control or its picker across various color schemes (ex high contrast/forced colors mode). There are a few motivating factors for this change: 1) To validate the refreshed look of controls under high contrast mode, we had created a subset of the controls-new-ui tests under controls-new-ui-high-contrast. The tests in the HC directory are (more-or-less) copies of tests in controls-new-ui. After this change, the controls-new-ui-high-contrast tests can be deleted, and instead, we just run the color-scheme-validation tests in high contrast mode and have a separate set of expected images. This way, we can avoid duplicated tests. 2) There are some controls/pickers (ex. select in-page, date-suggestion-picker) that are not tested in HC mode. This change ensures that all controls under controls-new-ui will be tested in HC mode. 3) The UX design choices made for the refreshed look for controls means that there are appearance differences between Chromium and Edge. To validate the look of Edge's design, we run the controls-refresh tests with a different set of expectation files downstream. With this change, we can restrict the set of distinct baselines we need to maintain downstream to just the color-scheme-validation directory. This should help restrict downstream merge conflicts to only when we make look-and-feel or color scheme related changes. Bug: 1012517 Change-Id: I66ee5ef951e7b0cf1f259a07269e95e4f076c63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877611 Commit-Queue: Sanket Joshi <sajos@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709731}
-
Andrew Xu authored
This reverts commit dd8e4931. Reason for revert: <INSERT REASONING HERE> Original change's description: > Fix the issue of hotseat's end padding > > There should be a 4-pixel padding between hotseat's end and edging > app icon. The padding is implemented via shelf view's > |app_icons_layout_offset_|. However, update on > |app_icons_layout_offset_| does not change the shelf view's layout > directly. As a result, the padding may be missing. This CL fixes such > an issue by refreshing the shelf view's layout right after value update. > > Bug: 1017979 > Change-Id: I0aceaf6a20331cfca410ad1b418b461ac9d60e90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809063 > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Andrew Xu <andrewxu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709491} TBR=manucornet@chromium.org,andrewxu@chromium.org Change-Id: I50647d508c8704a3dd7bc58e28695b1ce71e3318 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881486Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709730}
-
Tommy Steimel authored
For some reason, the previous queue_music icon was a bit off. This CL uses a new icon from the UX team. Bug: 1013639 Change-Id: Ic8b14816d3589b25e1e9292ca3f1d0e9f249c3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860321 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#709729}
-
Victor Fei authored
The motivation behind this change is that we want text pattern APIs to access the text content of both native buttons and ARIA role=button. In order to achieve the above, we need to be able to serialize button element's children to AXTree. This change enables all children of button to be exposed in the AXTree. Additionally, if the button's children are text only and also exposed in the Browser Accessibility tree, screen readers may double speak the button's name. To prevent this, if button's only child is a static text we mark the button Browser A11y node as leaf. On Android, we treat all its Browser A11y button nodes as leaves and expose no child. Summary: -------------------------------------------------------------------- BEFORE: Exposed in AXTree & Browser A11y Tree (BATree): native button | role=button single text child: AXTree[N],BATree[N] | AXTree[N],BATree[N] BATreeAndroid[N] | BATreeAndroid[N] complex children: AXTree[N],BATree[N] | AXTree[Y],BATree[Y] BATreeAndroid[N] | BATreeAndroid[Y] -------------------------------------------------------------------- AFTER: Exposed in AXTree & Browser A11y Tree (BATree): native button | role=button single text child: AXTree[Y],BATree[N], | AXTree[Y],BATree[N], BATreeAndroid[N] | BATreeAndroid[N] multiple children: AXTree[Y],BATree[Y] | AXTree[Y],BATree[Y] BATreeAndroid[N] | BATreeAndroid[N] -------------------------------------------------------------------- Note: According to the ARIA spec (below), the children of role=button are presentational, which means they should not be exposed to ATs (a.k.a. should all be treated as leaf nodes). However, we need the button contents to be exposed sometimes because they may contain many rich, interactive descendants such as buttons inside a calendar popup and screen readers need to interact with these contents (See https://crbug.com/689204). Additionally, Firefox also expose the children of both native button and role=button. Due to the above, we decided to departure from the ARIA spec and not enforce the leafiness of buttons. ARIA && core-aam specs: https://w3c.github.io/aria/#button https://www.w3.org/TR/core-aam-1.1/#exclude_elements ~~~~~~ Note: The actual functional changes are in the two files below, the rest are tests: content/browser/accessibility/browser_accessibility.cc content/browser/accessibility/browser_accessibility_android.cc third_party/blink/renderer/modules/accessibility/ax_node_object.cc ~~~~~~ Bug:1013609 Change-Id: Ia7c4bac9940b34dd3a3122938057cb48e847b76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845810 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709728}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::RenderFrameProxyHost with replacing AssociatedBinding and RenderFrameProxyHostAssociatedRequest with AssociatedReceiver and PendingAssociatedReceiver. Bug: 955171 Change-Id: I7596694adc6bcd54dcd96e4359c6d0dad35e4e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880227Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d2bf14695546..6c015a4605f6 git log d2bf14695546..6c015a4605f6 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 dburger@chromium.org Remove unittests from grunt-kernelnext-release builders. 2019-10-25 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@6c015a4605f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3ddda7f6871ab1241c9983d0376796a96059bb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881971Reviewed-by:
-
