- 19 Jul, 2017 40 commits
-
-
Chris Harrelson authored
for low-end Android devices. TBR=piman@chromium.org Bug: 746018 Change-Id: I40f0dbddd1efc8a751fc3d48c97446e1f04bbeeb Reviewed-on: https://chromium-review.googlesource.com/576607 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#487958}
-
Hayley Ferr authored
Added an UMA_HISTOGRAM_ENUMERATION to report how often we hit each touch action. Bug: 745718 Change-Id: I21d48c48a30f5b7699b078212ae105d34506c156 Reviewed-on: https://chromium-review.googlesource.com/571270Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487957}
-
Hidehiko Abe authored
This is preparation to remove MockCryptohomeClinet, as preparation to replace Callback by OnceCallback in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: I2c326050e48dae5671a796f152c7e723ccba601d Reviewed-on: https://chromium-review.googlesource.com/570119 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#487956}
-
Tom Anderson authored
BUG=575778 TBR=dpranke@chromium.org NOTRY=true Change-Id: I7fd31e3bd0b2d35e3a26b49a1a85c45b3efd7315 Reviewed-on: https://chromium-review.googlesource.com/578442Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487955}
-
Scott Little authored
These two tests are flaky on the Linux ChromiumOS bot: https://uberchromegw.corp.google.com/i/chromium.chromiumos/waterfall?show=Linux%20ChromiumOS%20Tests%20(1) TBR=zork@chromium.org Bug: 746526 Change-Id: Id2bcf3b9ece0fb25efeff129569d8e96e598ba52 Reviewed-on: https://chromium-review.googlesource.com/578319Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#487954}
-
Fernando Serboncini authored
Also, disabes HarfBuzz's atomic refptr TSan warning Bug: 730692 Change-Id: I69c7fd5ab20896b6abd864506ae394732f8aa6e1 Reviewed-on: https://chromium-review.googlesource.com/544625 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#487953}
-
Jian Li authored
Move the downloaded archive file from download directory into the offline pages archive directory and create the metadata record for it in offline pages metadata database such that it can be opened as an offline page. BUG=738199 TEST=new tests Change-Id: I548e3cfe93f962f8533918384e5205e94a55e5bf Reviewed-on: https://chromium-review.googlesource.com/557159 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#487952}
-
Scott Chen authored
Bug: 741897 Change-Id: I7577fb447f90f83db283b5712bdf3e9fca390889 Reviewed-on: https://chromium-review.googlesource.com/574684 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#487951}
-
Christopher Grant authored
BUG=739999 Change-Id: Id184dec6bee3723435ecab66048b071cb8a6b127 Reviewed-on: https://chromium-review.googlesource.com/577954Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#487950}
-
Scott Violet authored
WindowTreeHostManager has a special code path when the primary display changes to an existing display. This gets that code path working for mus. BUG=none TEST=covered by tests Change-Id: I5558a93303eeb9ca6a8f3c6769661d71d92d97fe Reviewed-on: https://chromium-review.googlesource.com/576399Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487949}
-
Eric Roman authored
Bug: 679030 Change-Id: If8794e2432994b88deb28e0edc2b38a986f07cbb Reviewed-on: https://chromium-review.googlesource.com/576747 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#487948}
-
Kyle Horimoto authored
This notification is not actually shown by the Tether component yet; this functionality will be part of a follow-up CL. Bug: 672263, 740635 Change-Id: Ic9b40af6a90631fbc0624b39375224e8d2f6221a Reviewed-on: https://chromium-review.googlesource.com/577063 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487947}
-
Elly Fong-Jones authored
During browser startup or shutdown, there may be no tabs on the TabStripModel while the browser's menu has already been created. In this case, it isn't safe to ask the model about its active tab, so don't. Bug: 730002 Change-Id: I18dfa17228dc061685dd62ba000d1607c6995290 Reviewed-on: https://chromium-review.googlesource.com/575876 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487946}
-
Toni Barzic authored
Enables lock scree apps for dev channel, and adds a flag that can be used to enable the feature to chrome://flags: * enable-lock-screen-apps enables lock screen apps BUG=715781 Change-Id: I3a4638d16af1585b6c18445ee7f405e55b0c2db5 Reviewed-on: https://chromium-review.googlesource.com/576658Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#487945}
-
lukasza authored
These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=tommi@chromium.org Review-Url: https://codereview.chromium.org/2977633004 Cr-Commit-Position: refs/heads/master@{#487944}
-
Wei-Yin Chen (陳威尹) authored
Remove dead links. Update Sheriff-o-Matic. Bug: None Change-Id: Iae4a42c049a664ce6aa85815924b22055919e838 Reviewed-on: https://chromium-review.googlesource.com/578170Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487943}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7d6336b80e30..5f09d557a14b $ git log 7d6336b80..5f09d557a --date=short --no-merges --format='%ad %ae %s' 2017-07-19 benjhayden Add missing import histogram_grouping.html to csv_builder.html. 2017-07-19 dproy Exposes extra_search_paths for vulcanizer script Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie73b918947705fd99a09377fe55427b4b211baf3 Reviewed-on: https://chromium-review.googlesource.com/578231 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487942}
-
Sidney San Martín authored
Bug: 742691 Change-Id: I4a80e92818261149d2a0b23e713245ae389ed5f3 Reviewed-on: https://chromium-review.googlesource.com/575846 Commit-Queue: Sidney San Martin <sdy@chromium.org> Reviewed-by:
ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#487941}
-
proberge authored
If a user is typing as the Chrome Cleanup prompt is opening, there's a good chance that a Space or Enter keyboard click will accept the dialog, surprising users who did not intend to consent to the Chrome Cleanup. This works around the issue by setting the initial focus on the details button. This brings the user to a new tab with more details about Chrome Cleanup and allows them to start cleanup from there. Bug: 690020 Change-Id: Ibac7fe55ecc403e831e8fc4fc469c980557b83d4 Reviewed-on: https://chromium-review.googlesource.com/575355 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487940}
-
Steven Bennetts authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/357960ebb8e0..80232cab3e7d $ git log 357960ebb..80232cab3 --date=short --no-merges --format='%ad %ae %s' 2017-07-18 dhaddock Make checking update_engine_client --status more robust. 2017-07-11 shinyak Disable goma soft stickiness 2017-07-18 akeshet summarize_build_stats: include a link to historical last-slave metrics 2017-07-18 chrome-bot Update config settings by config-updater. 2017-07-17 dhaddock Don't call crossystem clear_tpm_owner_request=1 during au_e2e. 2017-07-17 akeshet sysmon: fix crash when facing a process with empty commandline 2017-07-14 rahulchaudhry chromeos_config: add machine_pool argument to ToolchainTestFull. 2017-06-29 ayatane sysmon: Remove unused venv run_tests 2017-07-07 dhaddock Add performance monitoring script during update. 2017-07-14 akeshet chromeos_config: mark guado_moblab as important 2017-07-14 rahulchaudhry patch: get GIT_AUTHOR_DATE in standard format. 2017-07-13 akeshet expunge all references to graphite, statsd 2017-07-12 bhthompson cbuildbot: promote zoombini paladin to important 2017-07-12 bhthompson cbuildbot: promote tidus paladin to important 2017-07-13 ayatane sysmon: Add puppet metrics tests 2017-07-13 ayatane sysmon: Add prod metrics tests 2017-07-13 ayatane sysmon: Improve how other metric is calculated 2017-07-13 ayatane sysmon: Add proc metrics tests 2017-07-13 ayatane sysmon: Add osinfo metrics tests 2017-07-13 ayatane sysmon: Remove duplicate net metrics 2017-07-13 ayatane sysmon: Add sysmon.net_metrics tests 2017-07-12 ayatane sysmon: Add sysmon.git_metrics tests 2017-07-12 ayatane sysmon: Add sysmon.loop tests 2017-07-14 akeshet sysmon: round cpu % to integer 2017-07-07 pwang chromeos_config: release_cts_gts: Use hw_tests 2017-07-13 dhaddock Make CollectDevServerHostLog more robust. 2017-07-13 davidriley release_stages: Generate suite report for Paygen stages. 2017-07-13 davidriley paygen_build_lib: Add job_keyvals to ScheduleAutotestTests. 2017-06-27 jamescook cbuildbot: Add chrome-informational suite 2017-06-22 bhthompson Remove strago build configs 2017-07-07 dhaddock Make au_EndToEnd faster when the DUT powerwashes when we downgrade. 2017-07-12 ayatane sysmon: Add sysmon.main tests 2017-07-11 ayatane sysmon: Fix typo 2017-07-07 nxia Do not add CLs to suspect candidate if the Pre-CQ was cancelled. 2017-07-06 nxia Record trybot_cancelled action with build_id of pre-cq build. 2017-07-12 bhthompson cbuildbot: promote bob paladin to important 2017-07-12 bhthompson cbuildbot: promote auron_yuna paladin to important 2017-07-12 bhthompson cbuildbot: update paladin promotion comment 2017-06-30 bhthompson Promote eve and lakitu-st paladin builders to important 2017-07-12 lgoodby chromeos_config: restore whirlwind-paladin to important 2017-07-12 ayatane sysmon: Fix references to ts_mon units 2017-06-14 stevenjb cros_chrome_sdk: Look for recent LATEST- file 2017-07-12 stevenjb Revert "crome_stages.py: Pass --internal to chrome-sdk (Take 2)" 2017-07-11 ayatane sysmon: Use chromite metrics 2017-07-10 ddavenport chromite: Use EXPERIMENTAL= in tree status 2017-06-22 stevenjb crome_stages.py: Pass --internal to chrome-sdk (Take 2) 2017-07-10 vapier fix incorrect use of string identity tests 2017-07-10 vapier gerrit: do not highlight 0 labels as green 2017-07-07 xixuan build_config: remove smaug-paladin. 2017-06-19 phobbs lib/metrics.py: Infer ts_mon field_spec 2017-06-29 phobbs Move super() calls in constructor to the end. 2017-06-18 phobbs metrics.py: Add __eq__ methods 2017-06-13 phobbs lib.metrics: Upgrade ts-mon 2017-07-07 chrome-bot Update config settings by config-updater. 2017-07-05 phobbs cbuildbot: Set task_num differently on reexec 2017-07-05 nxia Do not check UploadPrebuiltsStage status of compilecheck builds. 2017-07-05 nxia Fix misleading logs in relevant_changes. 2017-07-06 akeshet summarize_build_stats: fix incorrect monarch link 2017-06-30 vapier gerrit: support unsorted search results 2017-06-29 yunlian chromiumos-sdk: use lumpy to replace x86-generic in test. 2017-07-05 akeshet chromeos_config: fix linter errors 2017-06-16 vapier alerts: catch all httplib exceptions too 2017-07-05 hidehiko Fix Android diff list URL and show it on buildbot summary. 2017-07-05 shapiroc Run all models in parallel for the same stage 2017-06-28 ddavenport chromite: Rename "ignored" to "experimental" 2017-06-07 ddavenport chromite: Filter out ignored builders 2017-07-05 akeshet chromeos_config: temporarily mark whirlwind-paladin experimental 2017-06-30 edjee Revert "chromeos_config: mark lakitu-gpu-paladin experimental" 2017-06-30 pwang Kick off arc-gts-qual from release builder 2017-05-17 ayatane [sysmon] Add doctests 2017-06-29 dgarrett paygen_build_lib: Remove nplusone (npo) concept. 2017-06-29 nxia Remove failure_type check for BuildFailureMessage. 2017-06-27 nxia Do not upload BuilderStatus pickle files for builds. 2017-06-30 chrome-bot Update config settings by config-updater. 2017-06-28 nxia Move GetBuildFailureMessage to generic_stages. 2017-06-28 nxia Consider a successful and self-destructed CQ as success. 2017-06-22 nxia Wait slaves to pass UploadPrebuilts when deciding self-destruction. 2017-06-29 bmgordon cros_sdk: Improve error message outside cros root 2017-06-27 pwang kick off arc-cts-qual suite from canaries. 2017-06-28 dhaddock ChromiumOSUpdater: Allow it to deal with clobber_stateful being False. 2017-06-26 lpique cbuildbot: Switch to telemetry_unit_server 2017-06-22 phobbs ts_mon_config: Refactor _ConsumeMessages 2017-06-27 wonderfly Revert "chromeos_config: Make lakitu-paladin experimental." 2017-06-27 wonderfly [cbuildbot] Remove lakitu derivative' incremental builders from waterfall 2017-06-28 yueherngl zoombini: add builder configuration 2017-06-23 bhthompson Add quawks paladin with bvt-arc HW tests 2017-06-23 bhthompson Add tidus paladin with bvt-cq HW tests 2017-06-23 bhthompson Add edgar paladin with bvt-cq HW tests 2017-06-28 ayatane sysmon: Fix yet another typo 2017-06-27 bhthompson Swap HW tests between bob and kevin for the CQ 2017-05-19 nxia Remove dependency on BuilderStatus pickles for cros_best_revision 2017-06-28 chrome-bot Update config settings by config-updater. 2017-06-28 chrome-bot Update config settings by config-updater. 2017-06-27 cmtice Add 'lakitu' and 'whirlwind' to toolchain builders. 2017-06-26 nxia Support getting platform_version for a build_config. 2017-06-28 chrome-bot Update config settings by config-updater. 2017-06-26 shapiroc Changed unibuilds to use model names for testing 2017-06-28 chrome-bot Update config settings by config-updater. 2017-06-27 jclinton chromeos_config: add reef-uni to cheets boards 2017-06-28 chrome-bot Update config settings by config-updater. (...) Created with: roll-dep src/third_party/chromite Bug: Change-Id: I15f4810c757fdfe7674a58bb3da621a274d50f01 Reviewed-on: https://chromium-review.googlesource.com/577761Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487939}
-
Kyle Horimoto authored
The issue was that my getNoNetworksString_() function returns a string, but the @return stated that the function returned a boolean. Bug: 672263, 746234 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieb244f304a159dd4ff9c7c5cf20041e742408064 Reviewed-on: https://chromium-review.googlesource.com/577758Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#487938}
-
Kinuko Yasuda authored
Mojo URLLoader version. Perf-wise this might not be ideal but should work, and we should be able to switch to C++-based impl after we settled over the basic design. Bug: 736308 patch from issue 2977553002 at patchset 1 (http://crrev.com/2977553002#ps1) Change-Id: I326452da833118e08e1b6c8d325374a7443c0f29 Reviewed-on: https://chromium-review.googlesource.com/567610 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#487937}
-
Sergey Ulanov authored
Bug: 731302 Change-Id: Ie1f9ae4a7e950d5541a37f4e35f83e84df2733e2 Reviewed-on: https://chromium-review.googlesource.com/576407 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#487936}
-
Peter Beverloo authored
Requesting notification permission could previously happen from any context, which included iframes and insecure origins. Starting with Chrome 61 we're restricting this to top-level secure contexts. Usage will continue to be allowed in iframes once permission has been granted from a top-level frame. Origins could easily work around such a restriction by posting a message to their Service Worker, so it doesn't make sense to impose it. BUG=695693 TBR=stevenjb (http -> https in site settings unit test) Change-Id: I33fe4278ed3ecd388872c74e6f299589855ea835 Reviewed-on: https://chromium-review.googlesource.com/558095Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#487935}
-
Vasilii Sukhanov authored
'true' is a non-default value and skip_zero_click isn't synced. If one creates a sync data from PasswordFormData and pushes it to PasswordSyncableService then it should match what CreatePasswordFormFromDataForTesting returns. Bug: Change-Id: Ib6e08d0510906e192bcdb14347059b3d262c1ac3 Reviewed-on: https://chromium-review.googlesource.com/577538Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#487934}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/925f52d03b73..0c15ae82f0d5 $ git log 925f52d03..0c15ae82f --date=short --no-merges --format='%ad %ae %s' 2017-07-19 bsalomon Revert "Revert "Revert "Revert "Improvements to GPU dither."""" 2017-07-19 bsalomon Add SkDebugf trace event handler. Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I4d904af741c7e746fa9dc90f44a87c45cd7a2240 Reviewed-on: https://chromium-review.googlesource.com/577757Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487933}
-
Christopher Cameron authored
TBR=kbr Bug: 734255 Change-Id: Ia74542d870a037ce54a702735145cd64c0c923ba Reviewed-on: https://chromium-review.googlesource.com/574681Reviewed-by:
ccameron chromium <ccameron@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#487932}
-
rdevlin.cronin authored
privacy.websites.protectedContentEnabled is enabled per-platform, and the platform list includes "cros" and "cros touch". But the determination of the platforms in binding.js includes "chromeos" and "chromeos touch". As a result, the protectedContentEnabled feature is never actually available on a CrOS platform (despite being documented as such). It appears that, since it's addition in https://crrev.com/cc3a5c8ca42579c0f9f710c18f51c566b4c75e86, this has been unavailable on ChromeOS: See https://chromium.googlesource.com/chromium/src/+/cc3a5c8ca42579c0f9f710c18f51c566b4c75e86/chrome/renderer/resources/extensions/schema_generated_bindings.js#318 and https://chromium.googlesource.com/chromium/src/+/cc3a5c8ca42579c0f9f710c18f51c566b4c75e86/chrome/common/extensions/api/privacy.json#88 where the patch was added. Update the platforms listed to be those that are used in the features system. Also update the browser test to correctly check the privacy.websites.protectedContentEnabled feature on all platforms, as well as expanding it to test setting preferences. BUG=746064 Review-Url: https://codereview.chromium.org/2966613002 Cr-Commit-Position: refs/heads/master@{#487931}
-
Scott Violet authored
None of the implementations do anything, so no point in keeping it around. BUG=none TEST=none Change-Id: Ic892b01b1f4896105982e2646731d65d53499c54 Reviewed-on: https://chromium-review.googlesource.com/576662 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#487930}
-
Robert Ma authored
First CL! :) Bug: Change-Id: I171a77c0d0d99316cc9d2ce3ac7aa4fdcc83fa9d Reviewed-on: https://chromium-review.googlesource.com/575703Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#487929}
-
Sylvain Defresne authored
Commit 5ab428852e35dc177a8c37a2df9dc9ccf768c65a adds Contents.json for all .imageset in the material-design-icons that are required for asset catalog compilation. Add //third_party/material_design_icons:ic_touch_app as a dependency of //remoting/ios/app/resources:assets as it is now fixed. Bug: 734054 Change-Id: Icc4e484ba1ed22c1af06a4c074b3d0cf0ba00bf9 Reviewed-on: https://chromium-review.googlesource.com/576037Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#487928}
-
Mike Dougherty authored
Bug: None Change-Id: If5029a3b39078bfad7e7d4e8ea21f0ac2acfa8e1 Reviewed-on: https://chromium-review.googlesource.com/576077Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#487927}
-
Hector Dearman authored
Reland https://chromium-review.googlesource.com/c/574029 this time with MSAN disabled. This reverts commit efe60ec8. Bug: 742958 Change-Id: I6fb6d84ce3686aac033a24a2b3dc790d81d8e44e Reviewed-on: https://chromium-review.googlesource.com/577852 Commit-Queue: Hector Dearman <hjd@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#487926}
-
Morten Stenshorne authored
Change-Id: I00ae6625688bb740ecf0235c98e25f41296b359f Reviewed-on: https://chromium-review.googlesource.com/553298Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#487925}
-
Kyle Horimoto authored
any notification click. The issue was that we opened settings on any OnNotificationClicked() callback. However, this callback is invoked for *any* notification click, even when notifications from another app/feature are clicked. To fix this issue, we now explicitly check to make sure that the ID of the clicked notification matches one of the IDs we care about. This CL was originally: https://chromium-review.googlesource.com/c/571856/ But was reverted as part of: https://chromium-review.googlesource.com/c/576013/ My original CL is the initial upload on this CL, and my changes to fix the breakage are in the subsequent patch version. Bug: 672263, 738225 Change-Id: Ieae494d786f5fd3b50535d3d34f4a17ce30b0152 Reviewed-on: https://chromium-review.googlesource.com/577762Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#487924}
-
Catherine Chung authored
Provides a test FeatureEngagementTracker that makes all non-relevant conditions true so you can test per-feature specific conditions/configurations. Bug: 734132 Change-Id: I83e6f0be55870ae1eb812d0688d0cb416672ab3f Reviewed-on: https://chromium-review.googlesource.com/570509 Commit-Queue: Catherine Chung <catherinechung@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#487923}
-
Mitsuru Oshima authored
This is m61 version of last attempt: https://codereview.chromium.org/2906803002/ renamed * maximize_mode_xxx files to tablet_mode_xxx * Class name MaximizeModeXxx to TabletModeXxx * variable names maximize_mode(xxx) to tablet_mode(xxx) * comments "maximize mode" to "tablet mode" BUG=726476 R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org TBR=reveman@chromium.org TEST=None Rename MaximizeMode to TabletMode This is m61 version of last attempt: https://codereview.chromium.org/2906803002/ renamed * maximize_mode_xxx files to tablet_mode_xxx * Class name MaximizeModeXxx to TabletModeXxx * variable names maximize_mode(xxx) to tablet_mode(xxx) * comments "maximize mode" to "tablet mode" BUG=726476 R=skuhne@chromium.org, sky@chromium.org, reveman@chromium.org TBR=reveman@chromium.org TEST=None Change-Id: I138134efe0b8af559d04c7682ee13b93e63cbbc6 Reviewed-on: https://chromium-review.googlesource.com/572945 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487922}
-
Georges Khalil authored
BUG= Change-Id: Idf2062ce75eccd76ee73fdded76628ba8819875f Reviewed-on: https://chromium-review.googlesource.com/576054Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#487921}
-
Xiaocheng Hu authored
This reverts commit af3f414f. Reason for revert: Already found a lifecycle issue when called from DidMeaningfulLayout(). Hence reverting the CL before M61 branch. Original change's description: > Tentatively change TextIterator to CHECK clean layout, instead of DCHECK > > This patch changes the DCHECK of clean layout in TextIterator to CHECK, > so that we can catch remaining lifecycle issues. > > Bug: 739060 > Change-Id: I0ee0a152b438d3d8e1f97de0acd2844b190ef703 > Reviewed-on: https://chromium-review.googlesource.com/575597 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487454} TBR=yosin@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 739060 Change-Id: I569f5cf9898e49fdf24de28635db370d0c8047f9 Reviewed-on: https://chromium-review.googlesource.com/577649Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#487920}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1195fa0a2590..7d6336b80e30 $ git log 1195fa0a2..7d6336b80 --date=short --no-merges --format='%ad %ae %s' 2017-07-19 loloangela Fixed errors related to bad-continuation Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib308a2fca06144f1e93c12b402a7f525bc89f32a Reviewed-on: https://chromium-review.googlesource.com/576486 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487919}
-