- 12 Jun, 2018 40 commits
-
-
Henrik Boström authored
TBR=guidou@chromium.org NOTRY=True Bug: 777617 Change-Id: Ia6e81728d3dfac35c9b1724252e7539b3aae181a Reviewed-on: https://chromium-review.googlesource.com/1096944Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#566381}
-
Vaclav Brozek authored
As pointed out in a chromium-dev discussion [1], PasswordHashData is the only piece of the password_manager component used in //chromeos. However, it is part of a target which ultimately depends on a big chunk of components. This CL therefore isolates the struct to a separate target with no dependencies other than base and crypto. It also ensures that the struct is always initialized and const methods marked as such. Finally, it also moves the older and related SyncPasswordData struct and some helper functions into the new target, to avoid reintroducing the large dependencies through HashPasswordManager. [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/nX63vp-75_U/h7H19i9dAQAJ Bug: 850931 Change-Id: I0733f46bbc924bf63c43ff3cf25b148c2baef8e8 Reviewed-on: https://chromium-review.googlesource.com/1092863 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566380}
-
Ramin Halavati authored
Remove debug data from traffic annotation FYI tests. Change the script to be not sensitive to error text and fail only if the test returns non-zero error code. Bug: 844014 Change-Id: If48630e5730d391aef86ce68bbc513bed796cdbb TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1096769Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#566379}
-
Elad Alon authored
One motivation for this, is to avoid the last log captured on a business day from expiring over the weekend, before it has a chance to be uploaded. Bug: 775415 Change-Id: I2f750b6c558e49f6a179f32f4a708fb5b997dbf2 Reviewed-on: https://chromium-review.googlesource.com/1096760Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#566378}
-
Daniel Bratell authored
In jumbo build experiments, one obstacle for using jumbo for chrome/ui is that there are too many kIconSize is the global anonymous namespace. This patch renames them according to their use, but other options are available (and are used) such as moving the constants into the functions where they are used or into a less global namespace. Bug: 773275 Change-Id: I62db42da677cffc53087aede879deaf5245b3640 Reviewed-on: https://chromium-review.googlesource.com/1076237Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#566377}
-
Bernhard Bauer authored
With the removal of Chrome Home code, this code is now dead. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id8a1613c4119707418b2ff2fa3582c368072c71e Reviewed-on: https://chromium-review.googlesource.com/1087270Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566376}
-
Yuichiro Hanada authored
Code under ui/keyboard should be used only on Chrome OS. This CL stop s keyboard_unittests from running on non Chrome OS buildbots. Bug: 847109 Test: trybots Change-Id: I75d8c34d0ba575d45ac7bf981a167b469755ed90 Reviewed-on: https://chromium-review.googlesource.com/1006742 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#566375}
-
Kent Tamura authored
custom-elements: Element created by createElementNS(ns, qname, options) with valid custom element name and undefined options should be upgraded immediately createElementNS(XHTML_NS, 'my-element', undefined) was not being upgraded immediatedly, though both createElementNS(XHTML_NS, 'my-element') and createElementNS(XHTML_NS, 'my-element', {}) were. Bug: 841725 Change-Id: Iccc4f0e98b1de65288381dd9ac106e71bfc5d0c8 Reviewed-on: https://chromium-review.googlesource.com/1096812Reviewed-by:Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#566374}
-
Sylvain Defresne authored
Bug: 798408 Change-Id: I53b9d7f84ab95aece369e4ec37db687ce70b3a4c Reviewed-on: https://chromium-review.googlesource.com/1095016 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#566373}
-
Naoki Fukino authored
This CL adds a command to toggle the visibility of hidden Android folders, and add a gear menu option item corresponding to the new command. Bug: 851385 Test: Manually tested. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I30e3fb385e7e6f801f23259a2b6905a8e2615f83 Reviewed-on: https://chromium-review.googlesource.com/1096802 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566372}
-
Mark Cogan authored
This CL adds drag support to the tab grid page control using the standard UIControl touch-tracking methods. It updates the behavior of the control to call ValueChanged actions when the control is dragged, and TouchUpInside actions when a new segment is selected. Bug: 849649 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I365c8447f4e6ef215a7558bdab2522867154be38 Reviewed-on: https://chromium-review.googlesource.com/1093470 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566371}
-
Igor authored
Clean up of some files from chromeos. Bug: None Test: Code compiles Change-Id: I6ce3866f1f599f3c7b548f3ac34065aba40dc63a Reviewed-on: https://chromium-review.googlesource.com/715738Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#566370}
-
Sylvain Defresne authored
All the code has been converted to use base::BindOnce or base::BindRepeating, so remove the old deprecated functions. Bug: 701275 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I42b9e3ee5446c6d7fab43572d7fbb29f78b798e2 Reviewed-on: https://chromium-review.googlesource.com/1095259Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#566369}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c789e08d522..9614a313b836 git log 6c789e08d522..9614a313b836 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps 2018-06-12 qingsi@google.com Pass the RtcEventLog instance to ICE via JsepTransportController. Created with: gclient setdep -r src/third_party/webrtc@9614a313b836 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:845700 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idbad5d10fd3cd0e745af105e4267b8cf5098de94 Reviewed-on: https://chromium-review.googlesource.com/1096706Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566368}
-
Oriol Brufau authored
These properties provide the author with the ability to control margins through logical, rather than physical, direction and dimension mappings. Intent to Implement and Ship: CSS flow-relative margins, paddings and borders https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc Spec: https://drafts.csswg.org/css-logical/#margin-properties BUG=850000 TEST=external/wpt/css/css-logical/logical-box-margin.html The test still has some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: I891c3bab3cd4ee810da0ed8e8fb907c141898817 Reviewed-on: https://chromium-review.googlesource.com/1075050Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#566367}
-
Henrik Boström authored
This is in preparation for RTCRtpTransceiver/Unified Plan support. "Calling removeTrack with valid sender should set sender.track to null" Asserting that direction changes from 'sendrecv' to 'recvonly', this is explicit in the spec[1]. "Calling removeTrack with currentDirection blah should set direction to blah" The tests that meant to set up currentDirection to be 'sendrecv' or 'recvonly' before removeTrack() were incorrect. Tests updated to set up currentDirection correctly. Also updated them to use async/await because that's much nicer. These all fail because we don't have transceivers yet, but when running these changes in the RTCRtpTransceiver WIP CL[2], they all pass. [1] See step 10 of https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-removetrack [2] https://chromium-review.googlesource.com/c/chromium/src/+/1025771/ Bug: 777617 Change-Id: Ie3c077d14ea30038a06a98ecbeea475ac824dd9c Reviewed-on: https://chromium-review.googlesource.com/1095275Reviewed-by: -
Tetsui Ohkubo authored
According to UX spec, notification list in UnifiedSystemTray should have the latest notification at the bottom, and the oldest notification at the top. Also, the bottom of the notification list should be pushed up when system tray is expanded. UX spec: http://shortn/_SbJoaT9xpn TEST=manual BUG=851830 Change-Id: I00e985461a2b8b8beccc5e96965ba594b618b5df Reviewed-on: https://chromium-review.googlesource.com/1090593Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#566365}
-
Findit authored
This reverts commit 586e21ec. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 566362 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU4NmUyMWVjNGZkOWE1ZDQ3YjY2NjI4YmJjYTI3MjgyNDIwMzkxYTMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/66085 Sample Failed Step: compile Original change's description: > [scheduler] Add a perftest to measure basic scheduling costs. > > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452 > Reviewed-on: https://chromium-review.googlesource.com/1085295 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566362} Change-Id: Ie33113aec2652806e27fb627d93392b0fcb7d2f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1096775 Cr-Commit-Position: refs/heads/master@{#566364}
-
Joel Hockey authored
Verify that entries have been added or removed using waitForFiles rather than tree-item-autogen-id values. This makes the test more resilient to any changes in the navigation tree that might cause IDs to change. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I953eb315c77ceaca31a3d7c529d1232a3b362ba3 Reviewed-on: https://chromium-review.googlesource.com/1092560Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566363}
-
Alexander Timin authored
Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452 Reviewed-on: https://chromium-review.googlesource.com/1085295Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566362}
-
Dominic Battre authored
This CL removes the following characters from generated passwords as they are visually not easy to distinguish and users may still need to type a generated password from time to time: - l (lowercase L) - I (capital i) - 1 (one) - O (capital o) - 0 (zero) - o (lowercase O) Bug: 846694 Change-Id: Iea1a62abf6565bcad74a2ff762c0ad69bb36eba0 Reviewed-on: https://chromium-review.googlesource.com/1096756Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#566361}
-
A Olsen authored
Certain policies contain JSON - that is, for the admin to use them properly, they should set them to a JSON string that conforms to a particular schema. Until this change, that JSON was not being validated, and errors were not getting reported to the user. This change adds validation schemas for two JSON policies - DefaultPrinterSelection and AutoSelectCertificateForUrls - and adds a histogram for tracking how often JSON policies fail validation. However, it doesn't actually enable validation of these schemas yet. == More details: SimpleJsonStringSchemaValidatingPolicyHandler changes: Type mismatches are always rejected - that is, if the value is not a string or a list of strings (whichever is appropriate) it is rejected. SimpleJsonStringSchemaValidatingPolicyHandler is changed slightly in this CL so that type errors are validated first, then JSON errors second, with some leniency if the allow_embedded_json_errors_ flag is set. Unit tests: Added some unit tests for SimpleJsonSchemaValidatingPolicyHandler. (I should have added these last CL). Bug: 834804 Change-Id: I8e7fd2097e5aad37636862543958f4a803fa018d Reviewed-on: https://chromium-review.googlesource.com/1078751 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#566360}
-
Tarun Bansal authored
Bug: 817049 Change-Id: Ic58e5688b0bb14803a9b6f01100500dd567b9fbc Reviewed-on: https://chromium-review.googlesource.com/1066919 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#566359}
-
Koji Ishii authored
This patch removes 74 flag-specific baselines that match to their base expectations, probably due to multiple rebaselines. TBR=atotic@chromium.org, cbiesinger@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If239268ac7517c0d2055dab7ad43d782e53a6c49 Reviewed-on: https://chromium-review.googlesource.com/1096803 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#566358}
-
Marc Treib authored
Followup to https://crrev.com/c/1089061 and https://crrev.com/c/1090836. This one mostly adds tests around refresh token removal and invalid refresh tokens. Bug: 842697 Change-Id: Ib41a6030dc1f5e5a53995f294467d83611d212c5 Reviewed-on: https://chromium-review.googlesource.com/1091057 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#566357}
-
Joel Hockey authored
* Run from gen/ui/file_manager/file_manager/test.html when testing on the bots rather than src. The change here is for the create_test_main.py script to use correct relative paths from gen dir for resources that are loaded. * Group tests into multiple scopes to be run separately. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9a354ea6cf7a6f765fb0cdf73d7041a8286e1ec Reviewed-on: https://chromium-review.googlesource.com/1092212Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566356}
-
Mahesh Machavolu authored
ShowSelectionMenu queries for TouchHandle height while passing this information to Java for positioning the Floating Popup Menu. Only Start Handle height is being queried at all times. During an active selection, it is possible Start Handle is hidden but End handle is only visible. In these cases, Start handle height would be zero. So, return end handle height in these cases. Bug: 851346 Change-Id: I087d12d95b86abfc1068d4fb9f331837912ca7a9 Reviewed-on: https://chromium-review.googlesource.com/1094818 Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566355}
-
David 'Digit' Turner authored
The Java LibraryLoader and Linker classes are going to be merged in a future CL. As a preparation step, this CL only deals with the corresponding JNI methods, by moving all of them to base/android/linker/linker_jni.cc. BUG=NONE R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org Change-Id: Idb2cb4ff49041b036146b5e5888123e4094dfa41 Reviewed-on: https://chromium-review.googlesource.com/1095040 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#566354}
-
Siddhartha authored
The metric recorded is over 1GB limit most ofthe times. BUG=843419 Change-Id: I199c2ed548f28be99d37fe797e0fad47a8d71fb2 Reviewed-on: https://chromium-review.googlesource.com/1096420 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566353}
-
Jan Wilken Dörrie authored
This change implements IsPowered() and SetPowered() for WinRT Bluetooth Adapters using the UWP API. While this API is not yet available when running x86 binaries on an x64 system, it works fine for x64 binaries. Bug: 821766 Change-Id: I7e3cbc30a610d1cf9caea55f2a5feb42725f5a5c Reviewed-on: https://chromium-review.googlesource.com/1085907 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#566352}
-
Ilya Nikolaevskiy authored
It ended up not used anywhere (a separate media switch is used instead). Bug: chromium:794608 Change-Id: I84c502dabb1e1e59b541983643ea3c09bffd1b30 Reviewed-on: https://chromium-review.googlesource.com/1092574Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#566351}
-
Sasha Morrissey authored
Update FileManagerPrivate.getEntryProperties() call to return capabilities (permissions) for entries as well. Bug: 719959 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I40fbb9665afb4cd0a3c1d6124a2543db55ac89d0 Reviewed-on: https://chromium-review.googlesource.com/1068767 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#566350}
-
Gyuyoung Kim authored
Revert "Reland: Call blink::WebMemoryCoordinator::OnPurgeMemory in RenderThreadImpl::ReleaseFreeMemory" This reverts commit f3ab72bc. Because this CL caused about 11% performance regression on Android. TBR=haraken@chromium.org, kbr@chromium.org Bug: 850977 Change-Id: Iaeb2697bbd4651bf40d6e437ff2a7efe19c647b0 Reviewed-on: https://chromium-review.googlesource.com/1096575Reviewed-by:
Gyuyoung Kim <gyuyoung.kim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#566349}
-
oscarjohansson authored
In Jumbo builds the declaration "using base::Time" (also "using base::TimeDelta") conflicts with a typedef in X11 system header. This commit will remove the declarations and use the namespace prefix instead. The function CalculatePingDays in extension_updater.cc has been renamed since a function with the same name exists in chrome_update_client_config.cc. Bug: 850484 Change-Id: I67a2e6f8710f5c730344b8d47be742c72f1667c6 Reviewed-on: https://chromium-review.googlesource.com/1092693Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#566348}
-
Alexei Filippov authored
If the thread is interrupted during mach_msg(), the system call will be restarted. However, the libsyscall wrapper does not adjust the timeout by the amount of time already waited. Using MACH_RCV_INTERRUPT will instead return from mach_msg(), so that the call can be retried with an adjusted timeout. BUG=848114 Change-Id: Ia009ea40b0fac619575eb6aa2988ae75f0e97413 Reviewed-on: https://chromium-review.googlesource.com/1092014Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0f4cd854b5c3..fdacd1639e2a git log 0f4cd854b5c3..fdacd1639e2a --date=short --no-merges --format='%ad %ae %s' 2018-06-12 nednguyen@google.com Add typ test to Catapult CQ Created with: gclient setdep -r src/third_party/catapult@fdacd1639e2a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7ae18d491b149d2d14b3a23411f5b24b759c28c6 Reviewed-on: https://chromium-review.googlesource.com/1096734Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566346}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a10370c44be8..b63c4663d478 git log a10370c44be8..b63c4663d478 --date=short --no-merges --format='%ad %ae %s' 2018-06-11 ehmaldonado@chromium.org gclient: Use only recursedeps to decide whether to process a dependency (Trigger recipe roller) 2018-06-11 ehmaldonado@chromium.org gclient: Use only recursedeps to decide whether to process a dependency. 2018-06-11 brucedawson@chromium.org Improve post_build_ninja_summary.py's incremental build handling 2018-06-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@b63c4663d478 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:839925,chromium:839925,chromium:787983 TBR=agable@chromium.org Change-Id: I067bdf689595ed16809b3cd667c29b62b71e5798 Reviewed-on: https://chromium-review.googlesource.com/1096219Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566345}
-
Dominic Battre authored
For incognito mode we probably don't want to send pings. This CL enables the PasswordRequirementsSpecFetcherImpl to deal with a situation where it has no URLLoaderFactory. In case no network communication can happen, it just returns an empty spec. Bug: 846694 Change-Id: I039f168e4d5ea0c5b4676938475236292af1d554 Reviewed-on: https://chromium-review.googlesource.com/1090924 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Jiaquan He authored
- Duplicate directory structure: find ui/app_list/ -type d | sed -En 's/ui/ash/p' | xargs mkdir -p - Move files from //ui/app_list to //ash/app_list: find ui/app_list -type f | sed -nE 's/ui//p' | \ xargs -I{} tools/git/move_source_file.py ui{} ash{} - Move non-code files from //ui/app_list to //ash/app_list: find ui/app_list -type f | sed -nE 's/ui//p' | xargs -I{} mv ui{} ash{} - Prune //ui/app_list safely (run this command several times:) find ui/app_list/ -type d | xargs rmdir - Update paths in .gn files: grep -rIl --exclude-dir={.git,out*} "//ui/app_list" * | \ xargs sed -i 's/\/\/ui\/app_list/\/\/ash\/app_list/g' grep -rIl --exclude-dir={.git,out*} "\$root_gen_dir/ui/app_list" * | \ xargs sed -i 's/\$root_gen_dir\/ui\/app_list/$root_gen_dir\/ash\/app_list/g' - Manually update //tools/gritsettings/resource_ids. - Fix trivial build errors and most lint errors. - git cl format. Bug: 733662 Change-Id: Id399977a8fc9840ce095b5a353313a1578d58937 Reviewed-on: https://chromium-review.googlesource.com/1085630 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Traffic annotation FYI bot for windows fails without any result. This CL just adds some debug logging to it and will be reverted when the problem is found. Bug: 844014 Change-Id: Id7be8e8c2d8a67f9686b8f57991769bf796f05a7 TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1096754 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
