1. 05 Mar, 2018 23 commits
  2. 04 Mar, 2018 7 commits
  3. 03 Mar, 2018 10 commits
    • Fan Yang's avatar
      In QUIC, free MemSlices in stream send buffer out of order. Protected by... · 4e3e36ef
      Fan Yang authored
      In QUIC, free MemSlices in stream send buffer out of order. Protected by FLAGS_quic_reloadable_flag_quic_free_mem_slice_out_of_order.
      
      Merge internal change: 187322087
      
      R=rch@chromium.org
      
      Change-Id: Ic43ef75d6155e36934e634cce056217d4fbd1992
      Reviewed-on: https://chromium-review.googlesource.com/946328Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
      Commit-Queue: Fan Yang <fayang@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540765}
      4e3e36ef
    • Scott Violet's avatar
      aura: Makes declaration/definition position match · bb729f9e
      Scott Violet authored
      no code change, just moves definition to match declaration for
      WindowTreeClient.
      
      BUG=none
      TEST=none
      TBR=jamescook@chromium.org
      
      Change-Id: I232363402b059af48671a7002656f8515123f15e
      Reviewed-on: https://chromium-review.googlesource.com/947893Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Scott Violet <sky@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540764}
      bb729f9e
    • Michael Lippautz's avatar
      [oilpan] Fix incremental marking compilation · 54a68198
      Michael Lippautz authored
      Tbr: haraken@chromium.org
      Bug: chromium:757440
      Change-Id: I878f3f9f59488046ec0907f198ee6cd5e7cd2d13
      Reviewed-on: https://chromium-review.googlesource.com/947965Reviewed-by: default avatarMichael Lippautz <mlippautz@chromium.org>
      Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540763}
      54a68198
    • Scott Violet's avatar
      Adds factory functions for creation of WindowTreeClient · 0010b8db
      Scott Violet authored
      These make construction slightly clearer in that only arguments that
      are needed can be supplied.
      
      BUG=none
      TEST=covered by tests
      
      Change-Id: Ie4029896ff24957b1f7264ef6fb64fba018625ab
      Reviewed-on: https://chromium-review.googlesource.com/946882
      Commit-Queue: Scott Violet <sky@chromium.org>
      Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540762}
      0010b8db
    • Jeremy Roman's avatar
      [remoteobjects] Convert JavaScript arrays to Java types. · 97754f10
      Jeremy Roman authored
      A fairly direct copy of CoerceJavaScriptListToArray, including adding the
      "do not coerce to string" behavior for elements.
      
      CoerceJavaScriptDictionaryToArray has the same behavior, so hopefully this
      distinction can be left out of the Java-side code.
      
      Bug: 794320
      Change-Id: Ib9decbe9cbc332ac59b1590b10ff310057ee8544
      Reviewed-on: https://chromium-review.googlesource.com/946872Reviewed-by: default avatarBo <boliu@chromium.org>
      Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Commit-Queue: Jeremy Roman <jbroman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540761}
      97754f10
    • David Grogan's avatar
      [css-tables] Test extra height distribution to row groups · 5ae9d5d6
      David Grogan authored
      When a table has a specified fixed height that is more than needed by
      its rows chrome only distributes the extra height to the first table
      body, ignoring thead, tfoot, and other tbody elements.
      
      Note this only contains tests, not a fix.
      
      Bug: 708345
      Change-Id: Ib477306459a2f49feffe354e2cf3fed9b27e74e1
      Reviewed-on: https://chromium-review.googlesource.com/942040
      Commit-Queue: David Grogan <dgrogan@chromium.org>
      Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540760}
      5ae9d5d6
    • Jeremy Roman's avatar
      Replace WrapArrayUnique function with std::make_unique in partition_alloc_unittest.cc. · 8fbce50d
      Jeremy Roman authored
      std::make_unique is the more usual way to do this, and Blink doesn't even
      have WrapArrayUnique anymore for this reason.
      
      Bug: 755727
      Change-Id: I9dc78827b8ef84da7c297ebc147a3ef157d0acc1
      Reviewed-on: https://chromium-review.googlesource.com/946125Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
      Commit-Queue: Jeremy Roman <jbroman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540759}
      8fbce50d
    • Greg Thompson's avatar
      Remove extra brace from IDS_RELAUNCH_REQUIRED_TITLE_DAYS. · 9a5443d0
      Greg Thompson authored
      BUG=817450
      TBR=jshin@chromium.org
      
      Change-Id: Iddd24e24699f8c94e7a51e56b4beed8867a4dc20
      Reviewed-on: https://chromium-review.googlesource.com/947964Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
      Commit-Queue: Greg Thompson <grt@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540758}
      9a5443d0
    • Jeremy Roman's avatar
      Add link to longer explanation of Blink 'readability/parameter_name' style warning. · 319fe2f4
      Jeremy Roman authored
      Hopefully this makes it easier to what the rule being tested is.
      
      Change-Id: I381d15956be4ba6d15a9b54c18bf01657228eda4
      Reviewed-on: https://chromium-review.googlesource.com/946116Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
      Reviewed-by: default avatarPeter Mayo <petermayo@chromium.org>
      Commit-Queue: Jeremy Roman <jbroman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540757}
      319fe2f4
    • Scott Violet's avatar
      Revert "Move downloadResponseHandler to components/download" · 73899cc3
      Scott Violet authored
      This reverts commit 824bbddf.
      
      Reason for revert: reverting in hopes of making tree green. The linux x64 bot has been flakely failing. For example, https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59821%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout and 
      
      FAILED: obj/components/download/internal/common/internal/download_response_handler.o 
      /b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/components/download/internal/common/internal/download_response_handler.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_CLANG_REVISION=\"325667-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCOMPONENTS_DOWNLOAD_IMPLEMENTATION -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -fdebug-prefix-map=/b/c/b/linux_clobber/src/out/Release=. -no-canonical-prefixes -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-header-guard -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem/b/c/b/linux_clobber/src/build/linux/debian_sid_amd64-sysroot/usr/include/nspr -std=gnu++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../components/download/internal/common/download_response_handler.cc -o obj/components/download/internal/common/internal/download_response_handler.o
      In file included from ../../components/download/internal/common/download_response_handler.cc:5:
      ../../components/download/public/common/download_response_handler.h:16:10: fatal error: 'services/network/public/mojom/url_loader.mojom.h' file not found
      #include "services/network/public/mojom/url_loader.mojom.h"
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 error generated.
      
      Original change's description:
      > Move downloadResponseHandler to components/download
      > 
      > No major change in functionality, just moving the files
      > 
      > Bug: 803135
      > Change-Id: I93737ed4539c1b3ddc25212814ef9b9c903ac882
      > Reviewed-on: https://chromium-review.googlesource.com/944545
      > Reviewed-by: Helen Li <xunjieli@chromium.org>
      > Reviewed-by: David Trainor <dtrainor@chromium.org>
      > Reviewed-by: Bo <boliu@chromium.org>
      > Commit-Queue: Min Qin <qinmin@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#540736}
      
      TBR=boliu@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xunjieli@chromium.org
      
      Change-Id: I1863660ebd431022abe2bf919ab38925fead91af
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 803135
      Reviewed-on: https://chromium-review.googlesource.com/947983Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Scott Violet <sky@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#540756}
      73899cc3