- 28 Sep, 2018 40 commits
 - 
- 
Patrik Höglund authored
I have a green waterfall which confirms the experimental src-side config works now, so make BuildBot use the new config. This will make it easier to switch from BuildBot to LUCI. This CL needs to land concurrently with the infra CLs + restart of the WebRTC Chromium FYI master since the bots change names as a part of this process. Bug: 877018 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2811718874bb9f6079488fc0ee17e6f324ae50b0 Reviewed-on: https://chromium-review.googlesource.com/1249103 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595033}
 - 
Stephane Zermatten authored
The reset and stop actions control what happens after the script has finished executing. Without any of these, after the script ends, Autofill Assistant checks for more scripts that can be run, keeping in mind which scripts have been run and what their status was. If the script ran a reset action, the memory of which scripts were run is forgotten. Autofill Assistant restarts on the current URL, as if nothing had happened. If the script ran a stop action, Autofill Assistant shuts down after the end of the script. The UI and everything attached to it goes away. Bug: 806868 Change-Id: I924aa2e0681c7824fb6fd70e24f1477a997577eb Reviewed-on: https://chromium-review.googlesource.com/1245796 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595032}
 - 
Gemene Narcis authored
This CL moves HttpCredentialCleaner instance inside password_manager_utils.cc in order to be added in the clean-up runner's queue. Bug: 871140 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaf321e3b136c235ea9eb0ab1489acbeefa8208d1 Reviewed-on: https://chromium-review.googlesource.com/1249071 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595031}
 - 
Anders Hartvoll Ruud authored
Currently, custom property animations are applied in quite a roundabout way: StyleResolver applies the value assisted by CSSVariableResolver, which may call into StyleResolver again depending on the variables it sees during resolution. It has a const_cast. It side-channels a HashSet via StyleResolverState. It's just not nice. To fix this, create CSSVariableAnimator which owns the state and functionality we need to apply the animated properties (in the right order). This is a pure refactor. It is already covered well by tests, specifically by animations/custom-properties/registered-var*. Change-Id: I6ed4ef2457f990d89930a5c802e01e64ac420174 Reviewed-on: https://chromium-review.googlesource.com/1243087Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#595030}
 - 
Marina Ciocea authored
This reverts commit 57c883df. Reason for revert: Temporary check is no longer needed because we gathered enough data for investigating https://crbug.com/867827#c40. Conclusion: global allocator is initialized by the time audio service reports UMA metrics. Original change's description: > Temporary check global histogram allocator in audio service output controller. > > Add a temporary check to investigate audio service experiment output controller > histograms count mismatch. If histogram persistent memory is not setup before > output controller metrics are reported, the check will fail > (see https://crbug.com/867827#c40). This CL will be reverted in a couple of days > after gathering data from canary. > > Bug: 867827 > Change-Id: I08cce13476f851d9ab24434add30f65abbf1e600 > Reviewed-on: https://chromium-review.googlesource.com/1215246 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589879} TBR=guidou@chromium.org,olka@chromium.org,marinaciocea@chromium.org Bug: 867827 Change-Id: Ie9f4ebabf8dfd4773466be0e75d878ce3508f19e Reviewed-on: https://chromium-review.googlesource.com/1250881 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#595029}
 - 
Koji Ishii authored
For AddSelfOutlineRects to reach to LayoutInline that has a continuation, this patch splits the logic in AddSelfOutlineRects so that it can be called recursively. In doing so, the logic flow and functions are organized to match to the one in LayoutObject tree. Bug: 889721 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I79e00ea7c37c94bf06e564a69fe7fc5da4f72349 Reviewed-on: https://chromium-review.googlesource.com/1246881 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#595028}
 - 
Hayato Ito authored
No behavior change. Re-oder declarations so that related functions are grouped together. Bug: 869308 Change-Id: I63db39350291cef18deb96c6a4bb9d1a27eedfcd Reviewed-on: https://chromium-review.googlesource.com/1250822Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#595027}
 - 
Kenichi Ishibashi authored
After calling |fallback_callback_|, we shouldn't use |url_loader_client_|. Before this CL ServiceWorkerNavigationLoader attempted to call OnCompleted(net::ERR_ABORT) on the client when a request is routed to service worker but the request was fall back to network. This wasn't a serious problem as the client wasn't active at that point but ideally we shouldn't use it. Change status to kCompleted when the request is fallback to network. Bug: N/A Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0c59b1b69e6916c05a36f79b6ea9a9962bbb173c Reviewed-on: https://chromium-review.googlesource.com/1249468Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595026}
 - 
Ben Wells authored
This enables individual default web apps to be gradually rolled out to different segments of the population. Bug: 855281 Change-Id: I733af23d24b906dd3f494af86a5a89cab6040d0a Reviewed-on: https://chromium-review.googlesource.com/1242580 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595025}
 - 
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/466fcd2bc4b3..9b89897915c5 Created with: gclient setdep -r src-internal@9b89897915c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I790eab707c062a611aea17b15a29d8d946baac7b Reviewed-on: https://chromium-review.googlesource.com/1250801Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595024}
 - 
Findit authored
This reverts commit b5d11746. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 595002 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjVkMTE3NDYzNzAyOGM1ZjMxYWM1OTYxMTQ0MTEwMWRmZTEwMzU3Zgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/26603 Sample Failed Step: content_browsertests Sample Flaky Test: SignedExchangeAcceptHeaderBrowserTest/SignedExchangeAcceptHeaderBrowserTest.DisabledOrigin/3 Original change's description: > Send SXG accept header of navigation only to limited origins for Origin Trial. > > Before this patch: > The SXG accept header is sent to all origins when SignedHTTPExchange feature > or SignedHTTPExchangeOriginTrial feature is enabled. > > After this patch: > The SXG accept header is sent when > - SignedHTTPExchange feature is enabled. > or > - SignedHTTPExchangeOriginTrial feature and SignedHTTPExchangeAcceptHeader > feature are enabled and the origin of the URL is in the OriginList of > SignedHTTPExchangeAcceptHeader field trial. > > Bug: 887201 > Change-Id: Ic67a8bc0644b1b6172030ff75162c04663dd33f0 > Reviewed-on: https://chromium-review.googlesource.com/1242768 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595002} Change-Id: Ic52f50aa70de8d3f21c55fff4517e7b0d58565fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887201 Reviewed-on: https://chromium-review.googlesource.com/1251022 Cr-Commit-Position: refs/heads/master@{#595023}
 - 
Achuith Bhandarkar authored
BUG=None Test=browser tests. Change-Id: Ifa7477e130ffb8e7b526a40d903382c9dce9e116 Reviewed-on: https://chromium-review.googlesource.com/1235715Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#595022}
 - 
Mathias Carlen authored
Before this patch, the client and server protos differed in the fields ids and the structure of the element to wait for. This resulted in selectors being empty and timeout values off. This patch fixes the numbering and replaces the element field with a repeated string field. After this patch, WaitForDomProto messages can properly be parsed. Props to szermatt@ for finding this difference. R=rouslan@chromium.org Bug: 806868 Change-Id: Ib2c9822c6ef24001706b78c339f3d4b97c3aa947 Reviewed-on: https://chromium-review.googlesource.com/1249274 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595021}
 - 
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c0b96b43..d50988f0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I972893012e34368d8f5a358c48aad6ba0a761735 Reviewed-on: https://chromium-review.googlesource.com/1250053Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595020}
 - 
Gauthier Ambard authored
This CL removes the limitation of the width of the tools menu string as it is now possible to span them on multiple lines. Bug: 833947 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I98126537ff4e57a23e297a8dee3b862c2b6a1120 Reviewed-on: https://chromium-review.googlesource.com/1238502Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595019}
 - 
Ramin Halavati authored
The following preferences are removed from the persistent storage list for incognito mode: - kBackgroundTracingLastUpload - kDefaultAudioCaptureDevice - kDefaultTasksByMimeType - kDefaultTasksBySuffix - kDefaultVideoCaptureDevice - kMediaGalleriesRememberedGalleries - kMediaGalleriesUniqueId - kPartnerBookmarkMappings - kPepperFlashSettingsEnabled - kPerformanceTracingEnabled - kWebRTCIPHandlingPolicy - kWebRTCMultipleRoutesEnabled - kWebRTCNonProxiedUdpEnabled These preferences are either never changed from incognito mode, or if changed, they do not need to be written to user profile. Bug: 861722 Change-Id: I03fb38784b57460b4d2e74c1abfdb01e83ddbda2 TBR: guidou@chromium.org TBR: oysteine@chromium.org TBR: satorux@chromium.org TBR: tommycli@chromium.org TBR: wychen@chromium.org TBR: zork@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1250521 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595018}
 - 
Mikel Astiz authored
The class allows legacy datatypes (non-USS), which implement SyncableService, to be integrated within the USS architecture, making it possible to reuse central objects like ClientTagBasedModelTypeProcessor and ModelTypeWorker. Design Doc (Googlers only): https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4 In this first patch, we introduce the bridge itself. Follow-up patches will introduce the necessary plumbing to exercise it. Expected main benefits: - Unify logic across datatypes by avoiding subtle behavioral differences across architectures. - Remove lots of code (~25K LoC), hence: a) reduce Chrome binary size. b) reduce maintenance cost. c) eng ramp-up time. - Improve resource footprint (less RAM, ~50% savings). - Reduce the gap for datatypes to actually migrate to USS. - Unblock multiple cleanup work, including a massive simplification of DataTypeManager and related classes, including controllers. Bug: 870624 Change-Id: I1bd7f553bf22886c5136e7e12f13b37a3dc77a39 Reviewed-on: https://chromium-review.googlesource.com/1164742Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#595017}
 - 
Sylvain Defresne authored
Two overloads of TestChromeBrowserState::AddTestingFactory were introduced to prevent downstream tree while landing CL https://crrev.com/c/1235718. Remove them as the downstream tree has been ported to the new API. Bug: 809610 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I802f40e3a31ccb306fb08a1d8256ac12674b8702 Reviewed-on: https://chromium-review.googlesource.com/1248703Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595016}
 - 
Andreas Haas authored
R=mcilroy@chromium.org Bug: v8:7295 v8:8015 Change-Id: I5de6e97a1e1ede6da0dc678579685bf5161abd35 Reviewed-on: https://chromium-review.googlesource.com/1237674Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#595015}
 - 
Alexandre Courbot authored
Add the V4L2Queue class, that manages buffers allocations and queuing. Users of this class don't have to manage the set of free buffers themselves, which will help factorizing a considerable amount of code and reduce the potential for bugs. Users of V4L2Queue can obtain a unique reference to a free buffer that they can prepare and queue. Dequeued buffers come in the form of a refcounted buffer instance, which puts the V4L2 buffer back into the list of free buffer as it is destroyed. This greatly simplifies V4L2 buffers lifecycle, which is now managed by short functions which invariants can be precisely enforced. BUG=792790 TEST=Make sure VDA test was compiling and running Change-Id: I7b4724fbc444c4cd8ed077617a1aaadcbe4c8011 Reviewed-on: https://chromium-review.googlesource.com/1170706 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#595014}
 - 
Simon Zünd authored
R=lazyboy@chromium.org Bug: v8:7283, v8:8015 Change-Id: I7a311c864bb2c6a5587215fc8e4057247ec15d8a Reviewed-on: https://chromium-review.googlesource.com/1238454 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595013}
 - 
Kent Tamura authored
:unresolved selector is a part of Custom Elements V0, and should be removed with document.registerElement(). This is a leftover of http://crrev.com/587495. Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ This CL also fixes an issue of CSSSelectorParser:: RecordUsageAndDeprecations(). It didn't show a deprecation message if the function was called with style_sheet_==nullptr, then was called with a valid style_sheet_. Change-Id: I5b1b16c722da7bc85fe24a63432e0805fbbed087 Bug: 660759, 889336 Reviewed-on: https://chromium-review.googlesource.com/1250345Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#595012}
 - 
Gauthier Ambard authored
Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id18a4a4fb0495a77dfae370f8e5cf2118614aae9 Reviewed-on: https://chromium-review.googlesource.com/1249207Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595011}
 - 
Chris Hall authored
This change corrects the accessibility semantics of the bookmarks folder navigation tree. Before this change, the indices on the bookmark folder items were incorrectly always being read out as '1 of 1' even when there were multiple items within the menu, this was because each role='treeitem' was followed by a role='group' sibling. This change uses aria-owns to reparent the descendents role='group' under the containing folder, which more closesly matches the semantic meaning of the nested folders. Now indicies are read out correctly as '1 of 2' or similar. This also changes the top level role from 'navigation' to 'tree' as aria requires that every 'treeitem' is within either a 'tree' or 'group'. Change-Id: I58ade626e8df6a7bd87be32d05d9d86679bc6200 Bug: 854345 Reviewed-on: https://chromium-review.googlesource.com/1238756 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595010}
 - 
Kinuko Yasuda authored
Bug: 884220 Change-Id: I02ab44bb09d69a75bfdc5336fb1250a7b574c758 Reviewed-on: https://chromium-review.googlesource.com/1250501Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#595009}
 - 
Kent Tamura authored
"The Great Blink mv" renamed CamelCase file names to snake_case, but it didn't update comments. This CL fixes it in core/{dom,editing,html}. Such comments were found by |git grep "//.*\\b[A-Z][a-zA-Z]*\\.[a-z]"| This CL has no behavior changes. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7a71e9252625fd80338a2739c139f9eaf82f6322 Reviewed-on: https://chromium-review.googlesource.com/1250322 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595008}
 - 
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45984b703fb3..466fcd2bc4b3 Created with: gclient setdep -r src-internal@466fcd2bc4b3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I559106edb89775922e322983a8950a6beacb9bdc Reviewed-on: https://chromium-review.googlesource.com/1250117Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595007}
 - 
Yuki Yamada authored
This CL adds blink::Event::IsErrorEvent() and also defines the type cast ToErrorEvent() as blink::BeforeUnloadEvent does. These will be used in following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1215512 Bug: 872138 Change-Id: Iaa2f6a1eb54dc8f4baecaeac44dc4cf48c6d8f04 Reviewed-on: https://chromium-review.googlesource.com/1250502Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#595006}
 - 
BUG=762641 TBR=minch@google.com Change-Id: If91d77ac45a938440f5fe90843bf405017ad106e Reviewed-on: https://chromium-review.googlesource.com/1249739Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595005}
 - 
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e8dd07969872..c0b82333ab27 git log e8dd07969872..c0b82333ab27 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 jgilbert@mozilla.com Polyfill BitCount for ARM/ARM64 on MSVC. Created with: gclient setdep -r src/third_party/angle@c0b82333ab27 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I3553bab8ded47484da804e803954e085ead62c10 Reviewed-on: https://chromium-review.googlesource.com/1250112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595004}
 - 
Leo Zhang authored
FATAL:binding_state.cc(90)] Check failed: !is_bound(). Attempting to bind interface that is already bound: chromeos.ime.mojom.InputChannel ::TestClientChannel::CreateInterfacePtrAndBind() Bug: 859432 Change-Id: I7b2ac928afe97b8adb1a1f89348a904d47be851b Reviewed-on: https://chromium-review.googlesource.com/1250564Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595003}
 - 
Tsuyoshi Horo authored
Before this patch: The SXG accept header is sent to all origins when SignedHTTPExchange feature or SignedHTTPExchangeOriginTrial feature is enabled. After this patch: The SXG accept header is sent when - SignedHTTPExchange feature is enabled. or - SignedHTTPExchangeOriginTrial feature and SignedHTTPExchangeAcceptHeader feature are enabled and the origin of the URL is in the OriginList of SignedHTTPExchangeAcceptHeader field trial. Bug: 887201 Change-Id: Ic67a8bc0644b1b6172030ff75162c04663dd33f0 Reviewed-on: https://chromium-review.googlesource.com/1242768Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595002}
 - 
Jennifer Apacible authored
More organisational work. Change-Id: If77efd0bd31b0355069fa633538548152d92f3d0 Reviewed-on: https://chromium-review.googlesource.com/1250084Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#595001}
 - 
John Z Wu authored
Bug: 886956 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ida9f92b1bea9093d6a46b5d9eeb4ee7da4306141 Reviewed-on: https://chromium-review.googlesource.com/1249919 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#595000}
 - 
Yoshifumi Inoue authored
This patch makes line dirty marking faster introduced by the patch[1] as below[2]: - layout/attach-inlines.html +19.6% - layout/line-layout-repeat-append.html +1.5% - paint/appending-text.html 932.06ms to 152.46ms (on local machine) For "layout/line-layout-repeat-append.html" and "paint/appending-text.html", |MarkLineBoxesDirtyFor()| for no longer source of slowness and isn't appeared in profiling resulting. This patch does two things: 1. Change |LayoutText::RemoveAndDestroyTextBoxes()| makes number of calls of DirtyLinesFromChangedChild() as same as both legacyn and LayoutNG. 2. Change |NGPaintFragment::MarkLineBoxesDirtyFor()| not to scan next siblings. [1] http://crrev.com/c/1235267 Introduce line dirtiness to NGPaintFragment [2] https://pinpoint-dot-chromeperf.appspot.com/job/144d34a7640000 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I95262ba6f4b525e7e452ab866cfff5b78ba3a757 Reviewed-on: https://chromium-review.googlesource.com/1248622Reviewed-by:Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594999}
 - 
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a82c66710062..45984b703fb3 Created with: gclient setdep -r src-internal@45984b703fb3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I629fb43b01bd5730e2c4d6bf00fae2bb6635094d Reviewed-on: https://chromium-review.googlesource.com/1250116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594998}
 - 
Koji Ishii authored
These tests fail because of stale or no-longer-necessary flag-specific expectations. Updated or removed by reviewing the recent test results. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I83fb87ec7820c9e99342f37aeabc292e711f61f2 Reviewed-on: https://chromium-review.googlesource.com/1250384 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#594997}
 - 
Koji Ishii authored
popup-allowed-from-gesture-initiated-event was changed to testharness.js. LayoutNG had flag-specific expected.txt due to different space collapsing in text dump. This patch removes the stale expected.txt. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id6b262611153d3cc0ad44a6454c3d7ede44d7d48 Reviewed-on: https://chromium-review.googlesource.com/1249472 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#594996}
 - 
Koji Ishii authored
These failures are due to recent changes in its base expectations, but LayoutNG flag-specific rebaselines were still old. Re-reviewed the differences from the new base, they are only inline positioning differences. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7261b7a2a380acb46da3832c780c2d5dbe7e61a7 Reviewed-on: https://chromium-review.googlesource.com/1249470 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#594995}
 - 
Findit authored
This reverts commit 3e67df64. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 594943 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNlNjdkZjY0YmJmOTFkOGE3YjYxZDliZGYwYjBmMWVkZTNmMDViZmEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8744 Sample Failed Step: chromeos_unittests Original change's description: > Install Messages PWA when host is set or verified. > > This change moves the logic for installing the Android Messages PWA into > a helper class which is a HostStatusProvider::Observer. This allows it > to install the PWA when a host is set and also when signing into a new > Chromebook if the account already has a valid host. > > Bug: 887775 > Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b > Reviewed-on: https://chromium-review.googlesource.com/1248130 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594943} Change-Id: I7c249598402a82eaa23aca2e8c06acb429d9097c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887775 Reviewed-on: https://chromium-review.googlesource.com/1249737 Cr-Commit-Position: refs/heads/master@{#594994}
 
 -