GitLab

BUG=616657
R=pfeldman@chromium.org,thakis@chromium.org

Review-Url: https://codereview.chromium.org/2038593002
Cr-Commit-Position: refs/heads/master@{#398046}

BUG=599902

Review-Url: https://codereview.chromium.org/2039943002
Cr-Commit-Position: refs/heads/master@{#398045}

We've branched for 53 now, so the admin policy for enabling RC4 has
expired. Remove it completely.

Farewell, RC4. There was a time when you saved us from the beast and
rabid poodles. By luck, you didn't have triskaidekaphobia, unlike our
other friends who chained blocks together. (Boy are they annoying.
It'd be wonderful if we could ditch them someday.)

But you always had your biases, which made it hard to trust you with
secrets. Now we have new friends who do the cha-cha twenty times a
day and learned counting from some French mathematician. We just
don't have room for you anymore.

BUG=375342

Review-Url: https://codereview.chromium.org/2030263002
Cr-Commit-Position: refs/heads/master@{#398044}

Review-Url: https://codereview.chromium.org/2039723003
Cr-Commit-Position: refs/heads/master@{#398043}

It allows to remove common initialization lists in constructors.

BUG=none

Review-Url: https://codereview.chromium.org/2034303004
Cr-Commit-Position: refs/heads/master@{#398042}

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.

Review-Url: https://codereview.chromium.org/2037073002
Cr-Commit-Position: refs/heads/master@{#398041}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=cpu@chromium.org

Review-Url: https://codereview.chromium.org/2037853002
Cr-Commit-Position: refs/heads/master@{#398040}

Adds an experimental option to enable Ignition for low-end Android
devices.

BUG=v8:4868

Review-Url: https://codereview.chromium.org/2039793003
Cr-Commit-Position: refs/heads/master@{#398039}

R=brettw@chromium.org, inferno@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2006173002
Cr-Commit-Position: refs/heads/master@{#398038}

https://chromium.googlesource.com/skia.git/+log/55fdcccf01d4..38d1adf1f7f4

$ git log 55fdcccf0..38d1adf1f --date=short --no-merges --format='%ad %ae %s'
2016-06-06 liyuqian Allow animation in Android viewer
2016-06-06 msarett Name parametric gamma curve types

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review-Url: https://codereview.chromium.org/2047433002
Cr-Commit-Position: refs/heads/master@{#398037}

In order to correctly handle report-only, we need to stop thinking of
nonces as a one-time bypass in 'ScriptLoader', and start thinking of it
as an ongoing check associated with a request (as it's specced in
https://w3c.github.io/webappsec-csp/#script-src-algorithms). This patch
moves nonce checking into 'FrameFetchContext::canRequest' by attaching
it to 'ResourceLoaderOptions', and using that new data inside the
'ContentSecurityPolicy::allow*' checks to ensure that each active policy
gets a crack at reporting violations.

To prevent regression, this patch adds a number of unit tests, moves
the existing nonce layout tests to a separate directory, and adds a
few layout tests as well.

BUG=614416,611652,614802

Review-Url: https://codereview.chromium.org/2020223002
Cr-Commit-Position: refs/heads/master@{#398036}

BUG=617142

Review-Url: https://codereview.chromium.org/2037573004
Cr-Commit-Position: refs/heads/master@{#398035}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dbae8a5c..6aed5443

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2043733002
Cr-Commit-Position: refs/heads/master@{#398034}

This flips the remaining Win builders on the chromium, chromium.chrome,
and chromium.perf waterfalls, as well as the matching trybots. The
remaining GYP win builders are FYI bots, memory bots, and the official
builders; the latter should be flipped ASAP after this lands to avoid
any skew.

R=brucedawson@chromium.org
BUG=605319

Review-Url: https://codereview.chromium.org/2030823002
Cr-Commit-Position: refs/heads/master@{#398033}

This CL contains several change to uplift sandwich:

1) Finds Android DeviceUtil object from device serial only once
per command line to speed up sandwich graph generation.

2) Makes SandwichRunner.output_dir mandatory so it can always dumps
error files in case of error or intermittent failures.

3) Lets AndroidChromeController dismiss crash dialogs when browser
or renderer process crashes.

BUG=582080

Review-Url: https://codereview.chromium.org/2040993002
Cr-Commit-Position: refs/heads/master@{#398032}

When SendData/SendvData is called, it might be that OnClose
has been invoked without an error, in which case
BidirectionalStream::Delegate::OnFailed would not have been
invoked. This is theoretically possible, but I am not
aware if such case would exist.

This CL removes the assumption that SendData/SendvData
is only called when stream is alive. If stream is
destroyed, propagate that as an ERR_UNEXPECTED to caller,
instead of crashing with a segfault.

BUG=606394

Review-Url: https://codereview.chromium.org/2032733002
Cr-Commit-Position: refs/heads/master@{#398031}

With the conversion to keyIdentifier there are some issues that need
to be fixed with layout tests. Add the exact string identifiers to
event_sender so that it is clear between the LayoutTests
and the implementation the identifier can be the same.

BUG=607349

Review-Url: https://codereview.chromium.org/2039233002
Cr-Commit-Position: refs/heads/master@{#398030}

Ensure that the end radius stays within finite float range, to
avoid degenerate cases down the line.

BUG=616993
R=fs@opera.com

Review-Url: https://codereview.chromium.org/2041653002
Cr-Commit-Position: refs/heads/master@{#398029}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f58ecb6416a4..0c6dbf87bab3

$ git log f58ecb641..0c6dbf87b --date=short --no-merges --format='%ad %ae %s'

BUG=617174

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2035403003
Cr-Commit-Position: refs/heads/master@{#398028}

BUG=599327

Review-Url: https://codereview.chromium.org/2046573002
Cr-Commit-Position: refs/heads/master@{#398027}

BUG=none
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2027063002
Cr-Commit-Position: refs/heads/master@{#398026}

for events sending from Windows. Now we use a mouse message from GetMessageExtraInfo to decide
the actual input device type.

GetMessageExtraInfo needs to be mask-checked against 0xFFFFFF00, and then compared
with 0xFF515700. True when this mouse message was generated by a Tablet PC pen or touch
screen. Otherwise it is from a mouse device. Additionally, in Windows Vista or later,
the eighth bit, masked by 0x80, is used to differentiate
touch input from pen input
(0 = pen, 1 = touch).

Reference:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms703320(v=vs.85).aspx

BUG=614820

Review-Url: https://codereview.chromium.org/2020143003
Cr-Commit-Position: refs/heads/master@{#398025}

BUG=614452

Review-Url: https://codereview.chromium.org/2034833002
Cr-Commit-Position: refs/heads/master@{#398024}

https://chromium.googlesource.com/skia.git/+log/401e77cfe126..55fdcccf01d4

$ git log 401e77cfe..55fdcccf0 --date=short --no-merges --format='%ad %ae %s'
2016-06-06 robertphillips Remove GrRenderTarget from GrPipelineBuilder

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Review-Url: https://codereview.chromium.org/2037403002
Cr-Commit-Position: refs/heads/master@{#398023}

Also switch bits of components_unittests's gn file from the
"include everything, conditionally exclude some bits again"
to the "include only what you need" pattern that's preferred
in gn files.

BUG=431177

Review-Url: https://codereview.chromium.org/2034083003
Cr-Commit-Position: refs/heads/master@{#398022}

Before in the NoState-Prefetch benchmark tasks graph, Sandwich had
the common/cache-validation.json tasks as a leaf. But it could
lead to issue when selecting final tasks with -e REGEX, and
but forgetting to have the regex matching this important task as
well as the subset of task the user initially wanted to run.

This CL addresses this issue by merging the previous tasks
common/cache-validation.json and common/urls-for-resources.json
into a single common/patched-cache-validation.json tasks, and
have all the benchmark subgraphs depending on them so we are
sure to always run the cache validation at least once before the
benchmark runs.

This CL take this oportunity to output further statistics in the
CSV related to the cache genration such as the number of
sub-resources of an URL, the number of expected cached resources
and the actual number of successfully cached resources, to
identify at scale on many URLs from the CSVs potential issues
the WPR patcher could still have on some webpages.

Moreover, this CL take this change in the extract metrics task
change as an opportunity to parse the fat loading trace JSON
file only once per URL repeat row, in order to make theses tasks
faster.

BUG=582080

Review-Url: https://codereview.chromium.org/2033093002
Cr-Commit-Position: refs/heads/master@{#398021}

Change DEPS to reference a new netty-tcnative commit that contains
David's patch:

"Don't reach into BoringSSL's SSL structs. Doing so is deprecated
and will break in the future."

Review-Url: https://codereview.chromium.org/2038063003
Cr-Commit-Position: refs/heads/master@{#398020}

MeminfoMemFree is currently recorded by sysmon; the problem with this is
we don't get the data for all devices.  MemFreeDerived is newly relevant
for new memory pressure heuristic.

BUG=internal b/26029747

Review-Url: https://codereview.chromium.org/2028233002
Cr-Commit-Position: refs/heads/master@{#398019}

It doesn't look like this code is used and besides  AutofillExternalDelegate::has_shown_popup_for_current_edit_ looks like same variable.

Review-Url: https://codereview.chromium.org/2040933002
Cr-Commit-Position: refs/heads/master@{#398018}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f6e084e..dbae8a5c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2044453002
Cr-Commit-Position: refs/heads/master@{#398017}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f6720c26fcd4..f58ecb6416a4

$ git log f6720c26f..f58ecb641 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2041753003
Cr-Commit-Position: refs/heads/master@{#398016}

BUG=617063

Review-Url: https://codereview.chromium.org/2035683003
Cr-Commit-Position: refs/heads/master@{#398015}

Keeps the V8 wrappers alive as long as there're event listeners or pending
promises and such.

BUG=616761
TEST=manual, see repro steps in the bug

Review-Url: https://codereview.chromium.org/2038573002
Cr-Commit-Position: refs/heads/master@{#398014}

This cl replaces traceWrappers method with getHeader. The motivation for the
original traceWrappers method was only to get HeapObjectHeader anyway, and this
refactoring simplifies current code and makes further enhancements (such as
incremental tracing :) easier.

LOG=no
BUG=468240

Review-Url: https://codereview.chromium.org/2045453002
Cr-Commit-Position: refs/heads/master@{#398013}

https://chromium.googlesource.com/chromium/src/+/4095e6cfa

BUG=603137
TBR=drott@chromium.org

Review URL: https://codereview.chromium.org/2046513002 .

Cr-Commit-Position: refs/heads/master@{#398012}

This CL adds the tracking of the following per-user-lens metrics in report.py:
- Cumulative cost of requests
- Cumulative cost of preloaded requests

This provides extra insight over just having the number of such requests.

Review-Url: https://codereview.chromium.org/2039853003
Cr-Commit-Position: refs/heads/master@{#398011}

Make CSSProperty store a Member<const CSSValue>, instead of a
Member<CSSValue>. This is pre-work for making CSSValueLists store const
CSSValues.

BUG=526586

Review-Url: https://codereview.chromium.org/2037973002
Cr-Commit-Position: refs/heads/master@{#398010}

Usrsctp is used in WebRTC to handle packets in the data channel.

BUG=

Review-Url: https://codereview.chromium.org/2039483003
Cr-Commit-Position: refs/heads/master@{#398009}

This CL fixes RenderViewImplTest.OnNavigationHttpPost when PlzNavigate is
enabled by having RenderFrameImpl::NavigateInternal chose to use LoadDataURL
instead of WebLocalFrame::load in the same cases as what the current
architecture is doing.

It also ensures that the WebURLLoader will not replace the ResourceResponse it
receives with one provided by the browser when loading a data url. In this
case, the browser has no response to provide. so we should use the one
generated by the HandleDataURL task.

BUG=475027

Review-Url: https://codereview.chromium.org/2037733002
Cr-Commit-Position: refs/heads/master@{#398008}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b32933fb..4f6e084e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2039203002
Cr-Commit-Position: refs/heads/master@{#398007}