GitLab

Review URL: https://chromiumcodereview.appspot.com/16041004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202754 0039d316-1c4b-4281-b951-d872f2087c98

In the network list on the settings page, the pop-up bubble for a managed
network has that network's list entry as its parent. The list entry must
allow overflow to be visible so that the bubble does not get clipped.

BUG=243659
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/15690006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202753 0039d316-1c4b-4281-b951-d872f2087c98

After recent refactorings chrome/browser/api and a few
chrome/browser/profiles/
includes are not necessary anymore. c/b/api was removed in r195919 by Peter
and
some c/b/profiles/ were moved in r201167 by Pawel.

BUG=138280,144783, 140037, 144050, 146851, 233552
TEST=checkdeps.py passes.
TBR=joi@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16182002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179951

Review URL: https://chromiumcodereview.appspot.com/13825014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202751 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178543

Review URL: https://chromiumcodereview.appspot.com/14985005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202749 0039d316-1c4b-4281-b951-d872f2087c98

This breaks 'git cl upload'.

> chrome/browser: Remove unnecessary entries from DEPS files.
> 
> After recent refactorings chrome/browser/api and a few chrome/browser/profiles/
> includes are not necessary anymore. c/b/api was removed in r195919 by Peter and
> some c/b/profiles/ were moved in r201167 by Pawel.
> 
> BUG=138280,144783, 140037, 144050, 146851, 233552
> TEST=checkdeps.py passes.
> R=joi@chromium.org, thestig@chromium.org
> 
> Review URL: https://codereview.chromium.org/16072002

TBR=tfarina@chromium.org

Review URL: https://codereview.chromium.org/15974007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202748 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244572,152006

Review URL: https://chromiumcodereview.appspot.com/16023019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202747 0039d316-1c4b-4281-b951-d872f2087c98

Removed unused code path and moved counting to proper location.
Added counter native printing code, because native dialog on ChromeOS is actually Cloud Print Web Dialog.

BUG=244059

Review URL: https://chromiumcodereview.appspot.com/15716006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202746 0039d316-1c4b-4281-b951-d872f2087c98

d:\src\w\crbk\src\chrome\nacl\nacl_listener.cc(149) : error C2220: warning treated as error - no 'object' file generated
d:\src\w\crbk\src\chrome\nacl\nacl_listener.cc(149) : warning C4703: potentially uninitialized local pointer variable 'ipc_fd' used

NOTRY=true
TBR=ncbray@chromium.org
BUG=n/a

Review URL: https://codereview.chromium.org/16107003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202745 0039d316-1c4b-4281-b951-d872f2087c98

The function's signature states it returns a std::string, so it shouldn't
NULL on failure. This is also consistent with the other Add functions.

TEST=unit test

Review URL: https://chromiumcodereview.appspot.com/15867003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202744 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes BrowserContext so it store a DownloadManager
directly (as UserData), instead of storing a refptr to it.

Client code (mostly tests) that used refptrs was changed to use either
raw pointers or to use scoped_ptr/ScopedVector in case of
DownloadManagers created by it.

The Bind() in DownloadManagerImpl::CheckForFileRemoval() is now using
a weak pointer to itself.

BUG=237871
TEST=content_unittests and {unit,browser}_tests with *Download* and *SavePage*

Review URL: https://chromiumcodereview.appspot.com/15701007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202743 0039d316-1c4b-4281-b951-d872f2087c98

These all pass locally, but they fail on the bots.
BUG=180861
R=piman@chromium.org
TBR=piman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15891013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244605
R=sky@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15827010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202741 0039d316-1c4b-4281-b951-d872f2087c98

Goes to https://support.google.com/chrome/?p=cws_app_launcher.

BUG=225068

Review URL: https://chromiumcodereview.appspot.com/14007002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202740 0039d316-1c4b-4281-b951-d872f2087c98

This causes left/right to page flip on boundary and up/down to do nothing. This
patch also makes out of bounds selections on the last page snap to the last
available item instead of not switching page.

This patch updates the OSX app launcher to be consistent with revision 200812.

BUG=237092

Review URL: https://chromiumcodereview.appspot.com/15648003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202738 0039d316-1c4b-4281-b951-d872f2087c98

GL_ARRAY_BUFFER and GL_ELEMENT_ARRAY_BUFFER could definitely be
non-zero, as seen in testing. So always restore 0. Also move them to the
last things to be restored. This patch seem to be helping a lot with not
destroying app UIs.

BUG=230195
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16096004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202737 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Cancel and re-prioritize worker pool tasks.
> 
> This adds a task graph interface to the worker pool and
> implements a simple queue instance of this interface for
> use by the tile manager.
> 
> The task graph interface can be used describe more
> complicated task dependencies in the future and
> provides the immediate benefit of seamlessly being
> able to cancel and re-prioritize tasks.
> 
> BUG=178974
> 
> Review URL: https://chromiumcodereview.appspot.com/14689004

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/16178002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202736 0039d316-1c4b-4281-b951-d872f2087c98

This is to make triple-tap select a paragraph.

BUG=236402
TEST=triple-tap on a paragraph and make sure the whole paragraph is
     selected.

Review URL: https://chromiumcodereview.appspot.com/16018006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202735 0039d316-1c4b-4281-b951-d872f2087c98

Recently layout tests changed to use content_shell instead of DRT. Content_shell attempts to use the sandbox if it can, and that made the Valgrind layout test bot unhappy. All other Valgrind bots disable the sandbox, and layout tests should too.

TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16087005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202732 0039d316-1c4b-4281-b951-d872f2087c98

After recent refactorings chrome/browser/api and a few chrome/browser/profiles/
includes are not necessary anymore. c/b/api was removed in r195919 by Peter and
some c/b/profiles/ were moved in r201167 by Pawel.

BUG=138280,144783, 140037, 144050, 146851, 233552
TEST=checkdeps.py passes.
R=joi@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/16072002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202729 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229940

Review URL: https://chromiumcodereview.appspot.com/16115002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202728 0039d316-1c4b-4281-b951-d872f2087c98

BUG=177394

Review URL: https://chromiumcodereview.appspot.com/15754003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202726 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202725 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151268:151287&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16146004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=221543

Review URL: https://chromiumcodereview.appspot.com/15086005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202723 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a method HasWord(string) to SpellcheckCustomDictionary and changes
the internal data structure in SpellcheckCustomDictionary from a vector to a set
for more efficient querying. Spelling service client will use the new method to
send IN_DICTIONARY feedback to spelling service for words that are in user's
custom spellcheck dictionary. Spelling service client will use this method in
upcoming CLs.

This CL also modifies IPC message "SpellCheckMsg_Init" to pass a set instead of
a vector of custom dictionary words. The browser sends this message to the
renderer to initialize spellcheck.

BUG=170514

Review URL: https://chromiumcodereview.appspot.com/15940004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202722 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238041

Review URL: https://chromiumcodereview.appspot.com/15897003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202721 0039d316-1c4b-4281-b951-d872f2087c98

http://src.chromium.org/viewvc/chrome?revision=202702&view=revision

TBR=cmp@chromium.org

Review URL: https://codereview.chromium.org/15846019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202720 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/16069006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202718 0039d316-1c4b-4281-b951-d872f2087c98

This function returns an object whose keys are the notification
IDs of all notifications created by that extension.

BUG=240924

TBR=miket@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15715008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202716 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the existing "WebRTC hack" where the native audio layer runs at 44.1 but WebRTC at 44.0. Now when native WebRTC supports 44100, it is possible to add the same support to WebRTC in Chrome.

BUG=243450
TEST=content_unittests and misc. WebRTC clients using 44.1 as sample rate on input and output devices.

Review URL: https://chromiumcodereview.appspot.com/15907005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202713 0039d316-1c4b-4281-b951-d872f2087c98

This searches for shortcuts in the usual locations containing the app's old
name, deletes them, and creates new shortcuts in the places where there were
pre-existing shortcuts.

BUG=153981

Review URL: https://chromiumcodereview.appspot.com/14993013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202712 0039d316-1c4b-4281-b951-d872f2087c98

This is breaking chrome on windows 8, can't relaunch in desktop
see bug

BUG=244453

> Make InputMethodWin TSF-aware.
> 
> This patch set introduces following event handlings
> so that InputMethodWin can work with TSF-based IME.
> - Focus handling (OnFocus/OnBlur)
> - TextInputType handling (OnTextInputTypeChanged)
> - Composition Handling (OnDidChangeFocus/ConfirmCompositionText)
> 
> Basically this is just a quick fix and InputMethodWin
> should be refactored eventually.
> 
> BUG=239690
> TEST=Manually done on Windows 7 with --enable-text-services-framework
> 
> Review URL: https://chromiumcodereview.appspot.com/14698032

TBR=Yukawa@chromium.org

Review URL: https://codereview.chromium.org/15897010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202709 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202708 0039d316-1c4b-4281-b951-d872f2087c98

I've been unable to repro the crash, but perhaps there's a way for
VersionUpdaterWin::OnReportResults to be invoked twice. This change
detaches the VersionUpdaterWin instance from the GoogleUpdate instance
when it releases its reference.

BUG=236413,242895
R=mad@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15649007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202707 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mstarzinger@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15891008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202704 0039d316-1c4b-4281-b951-d872f2087c98

Merge some member functions and rename others.

Clean up SpdyHttpStream logic a bit.

BUG=243643

Review URL: https://chromiumcodereview.appspot.com/15936003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202703 0039d316-1c4b-4281-b951-d872f2087c98

This is the Chrome-side half of a CL to allow mmaping and skipping validation
for chrome-extension: files we have seen before and know are safe.  To do this
we need to know the path of the file on disk, but we don't entirely trust the
renderer not to tamper with it.  To work around this, a nonce is passed along
with the file handle.  This nonce can be used by the NaCl process to acquire the
file handle directly from the browser process, as well as a fresh copy of the
file handle.

This change significantly revises the OpenNaClExecutable method of the
PPB_NaCl_Private interface.  The method was added anticipation of this CL, but
the overall design shifted after the method was added.

BUG=https://code.google.com/p/chromium/issues/detail?id=224434

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202278

R=dmichael@chromium.org, jschuh@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/14750007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202702 0039d316-1c4b-4281-b951-d872f2087c98

This DCHECK triggers very rarely. Adding additional info to the
DCHECK so we have a better idea of why it's failing.

BUG=244398

Review URL: https://chromiumcodereview.appspot.com/16023016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202701 0039d316-1c4b-4281-b951-d872f2087c98

Similar to http://crbug.com/237823.

BUG=244259

Review URL: https://chromiumcodereview.appspot.com/15706007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202700 0039d316-1c4b-4281-b951-d872f2087c98