GitLab

Bug: 819567
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3683ea8b25ef5e8df47a897eb8f12d392f091b7a
Reviewed-on: https://chromium-review.googlesource.com/988737Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547555}

This is build dependency optimization for the build like below
https://chromium-build-stats.appspot.com/ninja_log/2018/04/02/win75-c4/ninja_log.win75-c4.chrome-bot.20180402-000428.8888.gz/trace.html from https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/135170
obj files for browser_tests compiled around 215s~245s wait remoting/webapp unnecessarily.

Change-Id: I47fecd63b063382fde5e4c200f378eff7563521e
Reviewed-on: https://chromium-review.googlesource.com/989855Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547554}

This makes the STS EventRewriter work with Sticky Keys mode, and
is basically a revert of commit 0c0f3795
along with porting other modifications made since that commit.

Bug: 819860
Change-Id: I340295ac0ca6e24057fcb9d4a0890d77b3cf0439
Reviewed-on: https://chromium-review.googlesource.com/988849
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547553}

This CL cleans up a few things that I realized while
debugging other CLs in the area:
- |available_va_surfaces_| is a std::list on ToT, but has
 queue semantics, so it's changed int his CL.
-  s/output_buffers_/available_va_surfaces_/ because that's
 what they are.
- s/TryOutputSurface/TryOutputPicture/ because that's what
 the method does.
- s/pictures_/picture_map_/ to better define what it is. After
 dcastagna@ suggestion, it's made a base::small_map in PS7

Comments updated throughout these variables.

No change in behaviour intended, but tested nonetheless with
vp8/9-h264 crosvideo playback.

Bug: 822346
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2117ceac29f7d6ed23d698c4abd5c72e0140ae47
Reviewed-on: https://chromium-review.googlesource.com/988512
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547552}

This CL adds more test coverage for an extensions ability to xhr file urls
through an extension frame. To XHR a file url an extension should have "Allow
access to file URLs" setting enabled and also have host permissions to file:///.
Tests are also added for activeTab.

This also helps discover a bug with the network service implementation of the
same.

BUG=816685

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic53a1ad9c25a5db56c69eb421734f76ba9f95a1e
Reviewed-on: https://chromium-review.googlesource.com/985798Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547551}

Change-Id: Id2debad3159b74fe50a89368aa940d686a0f015b
Reviewed-on: https://chromium-review.googlesource.com/990081Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547550}

While chrome operations are deciding how to rework how CQ deals
with buildbucket-experimental builders.

R=ehmaldonado@chromium.org, nodir@chromium.org

Bug: 828111
Change-Id: I44c10d9328763cff1bdf609d89841e5aa5aa2f0f
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/991082Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547549}

After https://chromium-review.googlesource.com/c/chromium/src/+/982098,
enabling oop rasterization by the command line disables gpu rasterization
which in turn disables oop rasterization and uses software rasterization
instead.

This also fixes uses of GrContext that are no longer supported in
GpuImageDecodeCache.

Bug: 826987, 793508
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifdf1f18eb34e9e63eeb6e39cb66a6ab77e10afcd
Reviewed-on: https://chromium-review.googlesource.com/986744Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547548}

Ensures that the developer can't alter viewports or projection matrices
mid-frame. Covers:

XRSession.depthNear
XRSession.depthFar
XRWebGLLayer.requestViewportScaling()

Bug: 828113
Change-Id: If61262fafaf497a2231b9a57eefa4dd6dbb481eb
Reviewed-on: https://chromium-review.googlesource.com/990719Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547547}

If we enforce that each new map value is greater than the previous one
then that ensures that no duplicates are allowed without doing a lookup
for every insert.

Bug: 827551
Change-Id: Idcc24b1070cc1707362f37a7f76198053882148a
Reviewed-on: https://chromium-review.googlesource.com/982610
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547546}

This reverts commit 1c854a22.

Reason for revert: Failures were not due to this test.  Passes locally.

Original change's description:
> Disable test FrameTreeTest.FindFrames
> 
> Test FrameTreeTest.FindFrames is flaky. Disable it.
> 
> TBR=creis@chromium.org
> 
> Bug: 826599
> Change-Id: I3536ef001db9f8df4193ad7c709cc4f7c4246d97
> Reviewed-on: https://chromium-review.googlesource.com/985996
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Commit-Queue: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546808}

TBR=creis@chromium.org,ricea@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 826599
Change-Id: I1b3aeeaccb8458fc57959efdf236d126280cde5b
Reviewed-on: https://chromium-review.googlesource.com/990752Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547545}

The crash log in 826186 suggests that the previous surface was already
destroyed by the time the next activates. It's unclear how we get into this
state.

One possible theory is surfaces are activating out of order:

1. CompositorFrame with LocalSurfaceID 2 activates.
2. CompositorFrame with LocalSurfaceID 3 activates.
3. LocalSurfaceID 2 is marked for destruction.
4. CompositorFrame with LocalSurfaceID 2 activates again.
5. Garbage collection happens, and LocalSurfaceID 2's surface is destroyed.
6. CompositorFrame with LocalSurfaceID 4 activates, but the previous surface,
   LocalSurfaceId 2 has been destroyed so SetPreviousFrameSurface crashes trying
   to access 2.

The only way to get into this state if is if there are two pending CompositorFrames
for a FrameSink at once. It's unclear how this can happen because cc should not
be issuing a new CompositorFrame until the previous CompositorFrame has activated.

Perhaps there's a cc bug? This CL adds a diagnostic check to verify that
LocalSurfaceIds activate in a monotonically increasing fashion.

Bug: 826186, 672962
Change-Id: I2c3826c63d2538fa9562be683d864a11de904dd0
Reviewed-on: https://chromium-review.googlesource.com/990200
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547544}

Split out cases from a master "cookie-store-tests.js" suite,
allowing them to be enabled/debugged separately.

Also updates observation tests to use the new "change" event,
and deletes "static" since we can assume a dependency on a test
server here.

Bug: 783229
Change-Id: I9e29ea74a2f0513a033a8f9c71da2836c000ee27
Reviewed-on: https://chromium-review.googlesource.com/986649
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547543}

https://chromium.googlesource.com/angle/angle.git/+log/d104918fd531..5a7e61bbda82

$ git log d104918fd..5a7e61bbd --date=short --no-merges --format='%ad %ae %s'
2018-03-29 lfy GLES1: glNormal3(f|x)

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: If06aa967ee5cb916f99c9316dbfbbdb688bfed3b
Reviewed-on: https://chromium-review.googlesource.com/990234Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547542}

Bug: 824691
Change-Id: I78c4e15d956b858b385464e4265143ddfd1651ed
Reviewed-on: https://chromium-review.googlesource.com/990481Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547541}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d466d22d8e2..31e7d56c28f1

$ git log 0d466d22d..31e7d56c2 --date=short --no-merges --format='%ad %ae %s'
2018-04-02 rmistry Support setting Auto-Submit during "git cl upload"
2018-04-02 ehmaldonado gclient setdep: Add support to create new variables.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:631551,chromium:760633


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ia87a7c017f69d30bc5cd22d7f3df08e3e5bc8a8a
Reviewed-on: https://chromium-review.googlesource.com/990715
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547540}

Duplicate, Map, and MapAt on these various types do not and should not
need to modify the calling object.

Bug: 826213
Change-Id: Ice07621c23f36da00e20a13076a783cf1e41d7f2
Reviewed-on: https://chromium-review.googlesource.com/990673Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547539}

The syscall madvise(MADV_FREE_REUSE) is used to update accounting for
memory-usage, and is intended to be paired with madvise(MADV_FREE_REUSABLE).

Bug: 823915
Change-Id: Iedbeebf58c1c8dd85ce25615d0ddcfc5eb1d4afb
Reviewed-on: https://chromium-review.googlesource.com/988194Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547538}

This change is to further investigate crbug/756447:
* Fixes some vague error reporting in BlobReader
* Adds a feature flag around IDB big value wrapping (and re-enables it)
* Adds UMA metrics around blob reading and IDB large value reading.

Bug: 756447, 788681
Change-Id: I398fee4e69582e76f0a81449ff26a45ec3abe32f
Reviewed-on: https://chromium-review.googlesource.com/988843
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547537}

Change-Id: Iea75bf9bce3d1409122b94154c262667696a95f4
Reviewed-on: https://chromium-review.googlesource.com/985966
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547536}

This updates rlz.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I802e3e09554fc8564c265d6bb6a9df08ec368081
Reviewed-on: https://chromium-review.googlesource.com/990240Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547535}

V8's side of this function fails safely, leaving trap handlers disabled and
relying on bounds checks. There's no reason to make this a fatal failure
here. This also lets us remove the special cases around sanitizers, operating
systems, and architectures, because V8 knows what configurations are supported
for trap handlers.

Change-Id: I461af9590f336e912f94e5cf169f50ddd985b839
Reviewed-on: https://chromium-review.googlesource.com/988257Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547534}

Session name with '\' or '/' is not valid anymore.

Bug: 820546
Change-Id: Ib79acb5902aa8ef5c686e15463258e32519df052
Reviewed-on: https://chromium-review.googlesource.com/981304Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Martin Rodriguez <rodmartin@google.com>
Cr-Commit-Position: refs/heads/master@{#547533}

This reverts commit 5796b828.

Reason for revert: We might need to leave the flag around
for longer than expected due to field bugs such as crbug.com/809909


Original change's description:
> Remove use-monitor-color-space flag
> 
> This CL removes the flag to disable this feature, since it
> has been in Beta 66.0.3359.30 without any major problems
> so far.
> 
> Bug: 771345
> Change-Id: I7283cc05ded90ca3ec24ba227fc80654ad5f3325
> Reviewed-on: https://chromium-review.googlesource.com/912016
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544122}

TBR=avi@chromium.org,mcasas@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 771345
Change-Id: Ic6b32229d9fea3c5e3d47d06dbbb596f854fa647
Reviewed-on: https://chromium-review.googlesource.com/990213Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547532}

The SetTransferableResource path used to be used for renderer compositor
frames, but those go directly to the display compositor now. Instead it
is used in a couple ChromeOS-specific cases: reflector, and rotation
animation, where ChromeOS takes a screenshot and inserts it into
another ui::Compositor.

Since software resources aren't needed, document this in a comment, and
with a DCHECK, and then no need to add SharedBitmapId registration
code.

R=kylechar@chromium.org

Bug: 730660
Change-Id: I1312c4e58a84431bad1d4c5e23432784ccd206fa
Reviewed-on: https://chromium-review.googlesource.com/987113
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547531}

Enabled on trunk since the UMA-over-HTTP experiment will now
be ramped to enabled at 1% on stable, and Variations-over-HTTP will
be set to disabled at 1% on all channels. Also added a testing config
for VariationsHttpDisabled.

Bug: 766233
Change-Id: Ie19f57ef7b5535d389d05e277652ff888818d006
Reviewed-on: https://chromium-review.googlesource.com/990086Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547530}

Folder crashes during closing animation. |activated_folder_item_view_|
may be nullptr at that time, so fix it by checking nullptr.

BUG=813211

Change-Id: Iff04425a5178d55222195dc44742a83dfe50ae63
Reviewed-on: https://chromium-review.googlesource.com/990714Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547529}

This change adds `priority` to the list of fields in
ResourceLoadInfo.  Notably, this is important for recording page
load metrics when the Network Service is enabled.

BUG=816684

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I47fc9bf91ea76ee38acd8bb2bf485a21e88f455f
Reviewed-on: https://chromium-review.googlesource.com/986622
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547528}

BUG=354380
TEST=existing tests

Change-Id: Ia1075716e092ef0edd64eca4907414ac5e10fca2
Reviewed-on: https://chromium-review.googlesource.com/985073
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547527}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/388a231904b1..4725eead5924

$ git log 388a23190..4725eead5 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 baileyberro smbprovider: Add Remount protos

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I5c5bf21ae3ee1e25b65fdb752bf2595c274d05a0
Reviewed-on: https://chromium-review.googlesource.com/989668Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547526}

Bug: 678885
Change-Id: I0916fcb1e6ec72e2703c0b61f2af04aa53661ffe
Reviewed-on: https://chromium-review.googlesource.com/942464
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547525}

https://webrtc.googlesource.com/src.git/+log/23ffbe78f3b3..a859c1ac3e12

$ git log 23ffbe78f..a859c1ac3 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic18df8294cf5e33efdba27575ea9cf1f5369eaa5
Reviewed-on: https://chromium-review.googlesource.com/990089Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547524}

iOS apps are not notified if the user opened a file in Extension via
Open In.. menu. So the old metric name (No action) was not correct,
because this value was reported if the user discarded download or opened
in extension.

This CL renames the enum and histogram values to "No action or opened
via extension".

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6eea112f9016a46a3a91d094e4dd1b1364b20c2e
Reviewed-on: https://chromium-review.googlesource.com/986714
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547523}

In unit tests, this isn't true as the object is a MockResourceContext. For now the quick fix is to check for the safe browsing service being available before trying to add its throttle, as it isn't set in unit tests.

Bug: 828062
Change-Id: Ibb2d65307b72f02fe1e0de27797ca834f01cb184
Reviewed-on: https://chromium-review.googlesource.com/990724Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547522}

- Add libcronet.so to cronet_tests rpath.
- Use trivial ProxyResolutionService to avoid crashes.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3a114b098a4d78e4087be948dfd3ce303d6df737
Bug: 813226
Reviewed-on: https://chromium-review.googlesource.com/987521Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547521}

Also do not override payment app's name and icon if they
are not valid.

Change-Id: Ib2b9f2f4d5adca9c3ae8513c1152f878a53cb723
Reviewed-on: https://chromium-review.googlesource.com/986639Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547520}

We need to clip infobar child elements to the "bar" portion of the infobar.
Previously, this couldn't be done simply by clipping to the infobar bounds,
because the top arrow meant the infobar bounds extended up past the bar.  Now
that arrows are dead, |child_container_| is no longer necessary.

BUG=none
TEST=none

Change-Id: Ib9c2ec62638eff1043d6e7a43bdb6648e0a08289
Reviewed-on: https://chromium-review.googlesource.com/989286
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547519}

The geometry in client controlled uses only for client area, while it is
for the entire widget for other cases. This allows each case to implement
their own logic to compute the widget bounds.

Bug: b/33693796
Test: no functional change.
Change-Id: Ie9bb5272d4c4cbf2b86f8f428a3fa8c774490d67
Reviewed-on: https://chromium-review.googlesource.com/990072
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547518}

Test CustomTypesTest.EasyUnlockProximityRequiredUseAfterInvalidation
crashes after test NativeExtensionBindingsSystemUnittest.InitializeContext:

#
# Fatal error in v8::ToLocalChecked
# Empty MaybeLocal.
#

Received signal 4 ILL_ILLOPN 7f8a3c12c732
...
#4 0x7f8a3c12c732 v8::base::OS::Abort()
#5 0x000006bb0dd2 extensions::V8ValueFromScriptSource()

Change-Id: I802a95a50fb488623c7dab23c416d1c99fc2ec80
Reviewed-on: https://chromium-review.googlesource.com/989733Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547517}

This allows to reland the following WebRTC change that was reverted:
https://webrtc-review.googlesource.com/c/src/+/65700
The tests will be updated once the change is rolled in.

Bug: webrtc:7933
Change-Id: I7e8b3a0b4772d73a7e74a077310a9fa9cda331c2
Reviewed-on: https://chromium-review.googlesource.com/989025
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547516}