GitLab

SHERIFFS: PLEASE DO NOT REVERT THIS CL BECAUSE OF A SMALL AMOUNT OF LAYOUT
TEST FLAKINESS. If a few layout tests begin to show flakiness after this CL
lands, please add them to TestExpectations and email me (masonfreed@) to
investigate. Though I tried to identify all potentially flaky tests, a few
may have slipped through.

With this CL, the --enable-display-compositor-pixel-dump flag becomes the default
for content_shell. With this flag in place, layout test pixel dumps are performed
from the browser side, instead of from the renderer side. Note that to avoid a
significant amount of layout test flakiness, another change was also made to
not add the --run-all-compositor-stages-before-draw flag by default. There is
a bug (crbug.com/894613) tracking that problem separately.

With the flip of this switch, several modifications had to be made to the
TestExpectations file. First, there are a number of tests that change their
appearance slightly when being captured from the browser, and these tests need
to be rebaselined. These are summarized below, and will be rebaselined as a
separate CL, once this one lands and has had time to stabilize.

These bugs track the items added to TestExpectations:
 - crbug.com/887140: HDR support
 - crbug.com/881040: Media controls now contain an overflow menu.
 - crbug.com/667551: A bunch of tests are listed under this bug, and just
                     require rebaselining to fix non-material single-pixel
                     antialiasing failures.
 - crbug.com/891427: These either start failing, or become flaky, when the
                     --enable-display-compositor-pixel-dump flag is enabled.
                     They need to be debugged prior to re-enabling.
 - crbug.com/895556: These tests double their background size when the flag
                     is enabled. They need to be fixed or rebaselined.

Bug: 667551, 891427, 881040, 887140, 894613, 895556
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I46946e6377f659c9dedc0dfaa20e7658e8cc519d
Reviewed-on: https://chromium-review.googlesource.com/c/1213864
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603127}

For non-trivial types (notably sequences), this is simpler and similarly efficient.

Change-Id: I129f433debcf5eb81755ce48056c58f4da6cf785
Reviewed-on: https://chromium-review.googlesource.com/c/1301848Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603126}

This change is in preparation for ChromeVox bluetooth braille support.

Bug: 882261,899052
Test: call chrome.bluetooth.startDiscovery(); obtain address to bt braille display; chrome.bluetoothPrivate.connect(); verify ChromeVox displays braille over bt after restarting brltty with -d "bluetooth:<addrr>".
Change-Id: I4df43484de9d4bacd05d72fa6406820ee7c0aa2d
Reviewed-on: https://chromium-review.googlesource.com/c/1299577Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603125}

Policy WebAppInstallForceList's description is accidentally changed in
a previous CL. Revert it back.

Change-Id: Iba0dd737f3c0583ee43962c4e04a64cd01be1d0b
Tbr: pastarmovj@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1301840
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603124}

Bug: 581518
Change-Id: Ibc9c4948d924e106e3da60408e401875217a47f9
Reviewed-on: https://chromium-review.googlesource.com/c/1291215
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603123}

As a first step of simplifying CustomTabActivity, I extract all the code related
to TrustedWebActivityUi and use Dagger to organize dependencies for
TrustedWebActivityUi.

I make use of recently introduced activity lifecycle dispatching: https://crrev.com/c/1283256

Bug: 887926
Change-Id: Ia36a026a7f297e7c0f101189945c44454d12fa6e
Reviewed-on: https://chromium-review.googlesource.com/c/1281102
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603122}

Also fixes bugs with the SwitchItem and adding test for the
ChromeTableViewControllerTest platform test helper.

Bug: 894791
Change-Id: Ib2d4631ac65ce380dbe18d43603a34e74baec66c
Reviewed-on: https://chromium-review.googlesource.com/c/1297977
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603121}

https://android.googlesource.com/platform/external/perfetto.git/+log/0d828e8bb275..57c89d98ac4c


git log 0d828e8bb275..57c89d98ac4c --date=short --no-merges --format='%ad %ae %s'
2018-10-26 eseckler@google.com perfetto: Make gn check succeed when building with chrome


Created with:
  gclient setdep -r src/third_party/perfetto@57c89d98ac4c

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ie19803b65a2abdbfec84ec88073d5af4812f1343
Reviewed-on: https://chromium-review.googlesource.com/c/1301541Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603120}

It's not used.

Change-Id: If99b1617dfd3fe83d87665c3d428d3348ad30d3b
Reviewed-on: https://chromium-review.googlesource.com/c/1301874Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603119}

https://skia.googlesource.com/skia.git/+log/e2fd74b48f6f..7d20bc42f453


git log e2fd74b48f6f..7d20bc42f453 --date=short --no-merges --format='%ad %ae %s'
2018-10-26 herb@google.com Remove memory used by unique glyphs
2018-10-26 reed@google.com use utils for deprecated TextAlign
2018-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4c84379fd3cb..fde88d96a58b (1 commits)
2018-10-26 scroggo@google.com Blacklist CG platform generator on incInterlaced
2018-10-26 scroggo@google.com Reland "New GIF codec; new third_party/wuffs dep"


Created with:
  gclient setdep -r src/third_party/skia@7d20bc42f453

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I26cdb4ac80469f2545d6c2dea9423bad769546b0
Reviewed-on: https://chromium-review.googlesource.com/c/1301540Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603118}

This was causing the ProfilingProcessHostAndroidTests to fail with
network service running out of process because the network process was
getting the wrong name. Utility services only set a name on the tracelog
if there is not currently a name set:
https://cs.chromium.org/chromium/src/content/utility/utility_service_factory.cc?l=133&rcl=a2b08947596e1510f3a6fa2f65c2491eeeb4e9ec

This modifies the library loaded hooks to only use the name "Browser" if
this is actually the browser process.

Bug: 872343
Change-Id: I0af79db900a604a11aab0a80c5870a420aca920a
Reviewed-on: https://chromium-review.googlesource.com/c/1300294Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603117}

Toggle "closed" class when open/close menu to achieve transition animation.
This CL only has opening animation.

TODO: Add close animation; Add wave like animation to label when opening menu.

Bug: 814507

Change-Id: I2a036297741f34905fe868c7ea0a99e9ea91cea3
Reviewed-on: https://chromium-review.googlesource.com/c/1286949
Commit-Queue: Jazz Xu <jazzhsu@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603116}

This reverts commit fcce12fe.

Reason for revert: base_unittests failures: crbug.com/899263.

Original change's description:
> [base] Use TaskRunner instead of MessageLoop in FileDescriptorWatcher
> 
> Do not use MessageLoopForIO as it is used to post tasks anyway.
> 
> R=​gab@chromium.org
> TBR=gab@chromium.org
> BUG=891670
> 
> Change-Id: Ib255c6a5a5dd55c2654eaa284d43d7f78f06b244
> Reviewed-on: https://chromium-review.googlesource.com/c/1299239
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603076}

TBR=gab@chromium.org,fdoray@chromium.org,altimin@chromium.org

Change-Id: I1185c518e8243837cafdbee68d163b0cfdf611fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/1302013Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603115}

`fetch chromium --no-history` was the intuitive thing to try, which errors.

Change-Id: Ie0d3befe87730bffded40c20611f77ed30ed5006
Reviewed-on: https://chromium-review.googlesource.com/c/1299930Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603114}

Cycle time and failure rate looks good.

Bug: 893614
Change-Id: I43fcdf7f8e1b920ec784c0c67025e72aa7169873
Reviewed-on: https://chromium-review.googlesource.com/c/1299973Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603113}

Bug: None
Change-Id: Ic6b61b87089688a0b7230748408ef146ce6e1925
Reviewed-on: https://chromium-review.googlesource.com/c/1299333Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603112}

Bug: none
Change-Id: Ieff79c886c4b9e5cd994e30a6017fd7a26052b45
Reviewed-on: https://chromium-review.googlesource.com/c/1298634
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603111}

Bug: 898161
Change-Id: I0f9f09f64318424fedad0ce3fabb116902c561aa
Reviewed-on: https://chromium-review.googlesource.com/c/1299776Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603110}

Question on tasks blocking forever contains answer that applies to the general
case. This CL adds a new question that answer the general case:
How to make a blocking call without affecting other tasks?

The question:
How to make a blocking call that may never return without affecting other tasks?
references the general case and confirms that it also works in that case.

Change-Id: I2237853301b946c661fcdc623188e26877633404
Reviewed-on: https://chromium-review.googlesource.com/c/1300033
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603109}

Now that the change has been merged to the HTML spec we can remove
the suffix.

Fixes web-platform-tests/wpt/issues/13736

BUG=846858

Change-Id: Ic12b90c44126f801827bba7057a53fe640fa2859
Reviewed-on: https://chromium-review.googlesource.com/c/1301841Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603108}

This test can be enabled again.

BUG=841933

Change-Id: I8729daf0584da308f089502f0730ae398befb022
Reviewed-on: https://chromium-review.googlesource.com/c/1299550Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603107}

All clients of BCKSF uses the new API taking a base::Callback<>
instead of the deprecated API that was using a raw function
pointer.

Remove the now obsolete deprecated API.

Bug: 809610
Change-Id: I18359b2f91a1a6d9445affcf4720eed528d74af3
Reviewed-on: https://chromium-review.googlesource.com/c/1297354Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603106}

These DCHECKs can be triggered during user touchscreen pinch, and are
blocking work in
https://chromium-review.googlesource.com/c/chromium/src/+/1286437/.
Temporarily disable them until we can handle GesturePinch events
properly.

Bug: 897216
Change-Id: I2a37c468133340a95ec2b3f580a966dd71451482
Reviewed-on: https://chromium-review.googlesource.com/c/1301567
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603105}

Screenshot: https://screenshot.googleplex.com/kgCWVfNQx5e.png
Issue: b/118246783

Bug: 806868
Change-Id: I20f38afdbcdeb66c14b747aaa7b92f03ebf460a6
Reviewed-on: https://chromium-review.googlesource.com/c/1299159Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603104}

Bug: 808287
Change-Id: I98e37d5baba3fd8784bbcaf8dcdafdf7f83518d1
Reviewed-on: https://chromium-review.googlesource.com/c/1296838Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603103}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cce05b09..262cfc4a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie37e4419fd2dd9b157a4db6b1d4c08720db1c9c5
Reviewed-on: https://chromium-review.googlesource.com/c/1301564Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603102}

Use wtf_size_t where appropriate.

BUG=879657

Change-Id: I26f766e7f6f29c6beaf0d396d665f1eba1235d83
Reviewed-on: https://chromium-review.googlesource.com/c/1298246
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603101}

This is a reland of 0275d360 with a fix
for x86 builders, which have VR disabled.

Original change's description:
> [vr] On-demand install VR dynamic feature module
>
> With this CL we initate the module install once the user enters VR on a
> WebXR/VR page. In more detail this CL
>
> - Introduces native VrModuleDelegate used to request VR module from
>   native,
>
> - Refactors GvrDevice to request the VR module as part of its
>   initialization flow,
>
> - Adds native side of the VrModuleProvider for Java-native
>   communication.
>
> Bug: 862689
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b
> Reviewed-on: https://chromium-review.googlesource.com/c/1241458
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602922}

TBR=tedchoc@chromium.org,billorr@chromium.org

Bug: 862689
Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1301568Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603100}

This also removes the MaterialDesignController mode enum and converts to a bool.

This also adds a test that tablet mode changes won't affect the MD controller
when it's forced to non-touch mode.

Bug: none
Change-Id: I185dbeec48189865e19b4432c1556b6a7d5692dd
Reviewed-on: https://chromium-review.googlesource.com/c/1298498
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603099}

Bug: 899222
Change-Id: I4b87bc05b9333f74bd7c2286f8e2a913732ac6ce
Tbr: sahel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1301565Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603098}

De-parameterizes one test that doesn't care about the MD mode.

Removes a death test that won't consistently pass now and will soon be
completely meaningless.  (This was the source of the previous landing failure.)

Bug: none
Change-Id: I30fd5ed1ff06a14d757dbccdf8ac1d51cc0ac19e
Reviewed-on: https://chromium-review.googlesource.com/c/1300109Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603097}

If a cached resource is from an opaque response, it will by design takes
up more cache storage space than its real size. The indication inside the
data grid of Application > Cache Storage shows the response type so users
won't be baffled about unexpectedly huge cache storage usage.

Resolved the merge conflict in CL1256018.

Bug: 847462
Change-Id: I885dd62cc3528d29fd4abd789e4727aca028ba59
Reviewed-on: https://chromium-review.googlesource.com/c/1259299Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603096}

Bug: 898303
Change-Id: Icbc202b2924ebca3bd633073175f216b47a858d0
Reviewed-on: https://chromium-review.googlesource.com/c/1297449
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603095}

When an app hosting TWA is uninstalled or has it's data cleared, we show a
notification that prompts the user to clear the data of corresponding websites.

This CL implements the actual clearing. It should be performed in the same way
as in the preferences for single websites, so I extract and reuse a method from
SingleWebsitePreferences.

Bug: 888949
Change-Id: I020ac697c16c08ad03b88a4ecd0c099ab5655275
Reviewed-on: https://chromium-review.googlesource.com/c/1290936
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603094}

std::isnan seems to be used a lot more in the tree and other cmath
functions are used in base_rendering_context_2d.cc, so let's use
std::isnan here too.  This has a side benefit of working on some
older toolchains that don't like to mix math.h and cmath.

While we're at it, include the required header files for other
standard library types.

Change-Id: I61c9333c984dd1332f1f18ce21550474a193275c
Reviewed-on: https://chromium-review.googlesource.com/c/1301440Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#603093}

This CL instantiates the ServiceManagerContext before creating
the BrowserMainRunner. It splits the startup path into two,
with/without starting the full browser. The changes are implemented
behind a flag "allow-start-service-manager-only".

Bug: 846846,729596
Change-Id: I3584db0d89a10e59d6041e0f4412aaffdc840568
Reviewed-on: https://chromium-review.googlesource.com/c/1113802
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603092}

https://skia.googlesource.com/skia.git/+log/603c5da17491..e2fd74b48f6f


git log 603c5da17491..e2fd74b48f6f --date=short --no-merges --format='%ad %ae %s'
2018-10-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset


Created with:
  gclient setdep -r src/third_party/skia@e2fd74b48f6f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@chromium.org

Change-Id: I81513ad4b54319c199819eb08a01adf504aa1bcf
Reviewed-on: https://chromium-review.googlesource.com/c/1301537Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#603091}

Bug: 876125
Test: manual
Change-Id: I4e68cb980e829c4070d2735dd6dc4e1b6649d539
Reviewed-on: https://chromium-review.googlesource.com/c/1300217Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603090}

This patch is similar to crrev.com/c/1289430. Previously the test was
relying on worklet console log which might be racy on main. Using
computed style is better and more compatible.

Bug: 887659
Change-Id: I7fd64fcfb4a135d13e02574602111299d672139f
Reviewed-on: https://chromium-review.googlesource.com/c/1301563Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603089}

This function is now used to zip the remoting installer on mac. That
zip contains a .sh script that the build server extracts and tries to
run, so make sure it remains executable after unpacking.

Bug: 875279,870611
Change-Id: Ia515a997f9d67943daa8e09907b52ec070650de2
Reviewed-on: https://chromium-review.googlesource.com/c/1301793
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603088}