- 10 Sep, 2020 40 commits
-
-
Manuel Rego Casasnovas authored
StyleBuilderConverter::ConvertBorderWidth() is computing the zoom twice, the value we set in |result| variable is already zoomed. But then we have some extra lines that zoom it again and check if the final value is between 0px and 1px, to return 1px. This is wrong, as |result| was already zoomed, we can avoid that second operation and use that value to do the check directly. This was causing issues in the past but in very corner cases (so not very easy to reproduce). However due to the change on how subpixel border widths are managed (now they're floored, see r770064) this issue is causing that some borders are invisible. Added one WPT test that would fail with scaling factor 1.5. Also added a internal test using "zoom" property. BUG=1126396 TEST=external/wpt/css/css-backgrounds/border-width-small-values-001-*.html TEST=wpt_internal/css/css-backgrounds/border-width-zoom-001.html Change-Id: I27baac92036f7761e1616d55e90e4ed80cbb8914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401030Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#805717}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I56875368287704e6b49ab8528c81a7b54e0b1c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402194Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#805716}
-
Andreas Haas authored
The issue is fixed in V8, but the regression test needs the Chrome embedding. The V8 fix gets reviewed in https://crrev.com/c/2367858. Bug: chromium:1117258 Change-Id: Iac2cb32d2877074cd1e6a2d39d242838b34f2563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368359Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805715}
-
Morten Stenshorne authored
Still flaky. TBR=johnidel@chromium.org Bug: 1077216 Change-Id: I2d99f56edbabb22c980d761dd02be1cee4af7349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403362Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805714}
-
Morten Stenshorne authored
Fails here: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/84937 TBR=qinmin@chromium.org Bug: 580766 Change-Id: I762cd32aac3bd438f33877d2ae51ed3ada81d056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403244Reviewed-by:
-
Morten Stenshorne authored
CL:2371729 didn't actually disable it. Still flaky. TBR=justinmiron@chromium.org,fergal@chromium.org Bug: 1121444 Change-Id: Ia9f55651c33b8139e2646fc25d084f2fd433b2dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403360Reviewed-by:
-
Nigel Tao authored
Change-Id: I4cacda602ab66fc165c89b656b156dccfba0588d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398750Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#805711}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: If1285abe18ee761bb69d3d6e3b165ed847755e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398978 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#805710}
-
Olivier Robin authored
For an unknow reason, UIDevice orientation always returns unknown in unittests when scenes are enabled. Breadcrumbs ignore orientation when it is unknown in the first report. This is a result of the class initialization. But there is no real reason to ignore unknown as an histogram value as it is a valid value. Change-Id: Id33db23db1755907292e23bdd89e3d6379f303e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398660Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/29b1f07f4ab2..84508b9666d5 2020-09-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e9ccdaed to 30a5da05 (421 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I75200b94b185d1344acd8820a08aabc47c0e1c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805708}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e9c8b7155d4..822283dbb736 2020-09-09 deadbeef@webrtc.org Prepare for usrsctp being updated. 2020-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa7a6a96..6e37a7f7 (805300:805451) 2020-09-09 joedow@google.com Fixing a crash when capturing non-DPI aware windows at high DPIs 2020-09-09 mbonadei@webrtc.org Switch from "rtc_ios_xctest_test" to "test". 2020-09-09 philipp.hancke@googlemail.com objc: add rollback type to RTCSdpType 2020-09-09 ivoc@webrtc.org Make AV sync robust to failures to set a desired minimum delay 2020-09-09 eshr@google.com Add NV12 video buffer type 2020-09-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a50ca66b..aa7a6a96 (802712:805300) 2020-09-09 mbonadei@webrtc.org Add 'requests' to .vpython. 2020-09-09 hmaniar@nvidia.com Adding field trial to control send buffer size 2020-09-08 titovartem@webrtc.org Use time controller based task queue factory in PC level tests. 2020-09-08 titovartem@google.com Follow up on https://webrtc-review.googlesource.com/c/src/+/180360 2020-09-08 asapersson@webrtc.org Use field trial list in CpuSpeedExperiment. 2020-09-07 philipp.hancke@googlemail.com authors: add comments about individual / org sections 2020-09-07 mbonadei@webrtc.org Revert "Reland "reenable mouse_cursor_monitor tests on linux"" 2020-09-07 nisse@webrtc.org Delete unused counters added_zero_samples_ and discarded_packets_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083527,chromium:1104245 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae31423c27a4196b6bc578ff18f1ad5e5b59ee7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403057Reviewed-by:
-
Victor Hugo Vianna Silva authored
Per the plan laid out in the linked bug, we need to persist whether the "natural decoupling" happened, i.e. this information must be kept across browsing sessions. This CL adds a boolean sync pref for this and exposes getter and setters for it all the way up to the Java code. Bug: 1125622 Change-Id: Ibeea8745f45d65cf016dbe0b316bd48228f34b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398524 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#805706}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I666b338a5060005e6b79bf009449d80d0ceb988a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385300Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805705}
-
Simon Zünd authored
This is a reland of 73ac7d88 The reland changes the test locale from 'es-ES' to 'es'. 'es-ES' is unavailable on Mac, while 'es' works (confirmed crash and fix locally). Original change's description: > Keep DevTools navigator.language in-sync with chromiums app language > > DevTools is considered part of the Chromium UI, so it should be > displayed in the same language as the Chromium UI and not the configured > accepted language (chrome://settings/languages). > > This CL moves the code where we override the DevTools renderer > preferences around so it works consistently across platforms. It also > installs an event handler in case the user changes his language settings > so `navigator.language` has consistently the same value in the > DevTools renderer. > > R=petermarshall@chromium.org > > Bug: chromium:1125490 > Change-Id: Iaac568d82357d6ae7c50d5022d687f4f1741b147 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398538 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805219} Bug: chromium:1125490, chromium:1126379 Change-Id: I3b24b73ecb19d8290393a8ebf72db424bc098eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401464Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#805704}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6cf96585524..8d1bf91b4dab 2020-09-10 treehugger-gerrit@google.com Merge "Use deobfuscated symbol name in callsites" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I494cd5dcfec1af5d7bc223e0c576ec8a09605247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403051Reviewed-by:
-
Swapnil authored
We have many extensions stuck in CREATED stage which is reported in ExtensionManagement::UpdateForcedExtensions when extension list is fetched from kInstallForceList pref. We add the extensions to |settings_by_id_| dictionary. This dictionary may be overridden by the entries in kExtensionManagement pref and it is possible that the extensions which are listed in forced list may be listed in kExtensionManagement pref as "allowed" or "blocked". In these cases, we might not install the extension as ExtensionSettings policy overrides the policy for force installed extensions. This CL adds a new failure reason which is reported when extension listed in forced list policy has its installation mode overridden by ExtensionSettings policy to something else. Bug: 989526 Change-Id: I20995df211d5e09492c35c09e7c5152deba2fdd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390181 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#805702}
-
Alex Ilin authored
'ntp-customize-themes' has been refactored as a separate component in ui/webui/resources/cr_components/customize_themes. This CL migrates the new tab page to use the standalone component. All duplicate files from new_tab_page are being removed. This CL also adds a new ChromeCustomizeThemesHandler class that implements customize_themes::mojom::CustomizeThemesHandler interface. The most of the implementation methods were copied from chrome/browser/ui/webui/new_tab_page/new_tab_page_handler.cc This handler is going to be reused by several WebUIControllers, including NewTabPageUI. Bug: 1115301 Change-Id: Ica5cc63cba52a5a64692d9089f83a81ca49039c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353449 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805701}
-
Camillo Bruni authored
- Avoid v8::NewStringType::kNormal where possible - Use v8::NewStringType::kInternalized for object properties Bug: v8:10884 Change-Id: Ic7ec1e8dbdc1c56a72ed651da361b920c8145e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398544 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#805700}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I32dc74fae8e59cc5ccc8512304b5de298c776982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382316Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Benoit Lize authored
Threadsafe static local variables call into the C runtime on Windows, which may not be safe in the allocation path (see linked bug). Don't use them for code which is on this path. This is using base::LazyInstance. It currently fulfills our needs, though it is not ideal for a couple reasons: - Not guaranteed to stay independent from local statics. - Can allocate in some paths (mostly DCHECK()s) As such, this is temporary, and we should either make sure that LazyInstance is suitable, or have a replacement local to PartitionAlloc. Bug: 1126432 Change-Id: I9cffed6f313c3fb380383a1607f0e6f27397c2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401469Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805698}
-
Benoit Lize authored
This CL adds a thread cache to PartitionAlloc. It is optional, only applies to thread-safe partitions, and uses the same freelist encoding and bucketing as the main allocator. The thread cache is added "in the middle" of the main allocator, that is: - After all the cookie/tag management - Before the "raw" allocator. That is, the general allocation flow is: 1. Adjustment of requested size to make room for tags / cookies 2. Allocation: a. Call to the thread cache, if it succeeds, return. b. Otherwise, call the "raw" allocator <-- Locking 3. Handle cookies/tags, zero allocation if required On the deallocation side, the process is reversed: 1. Check cookies / tags, adjust the pointer 2. Deallocation a. Return to the thread cache of possible. If it succeeds, return. b. Otherwise, call the "raw" allocator <-- Locking The thread cache maintains an array of buckets, the same as the parent allocator. A single thread cache instance is only used by a single partition. Each bucket is a linked list of allocations, capped to a set maximum size. Elements in this "freelist" are encoded the same way they are for the main allocator. Only the smallest buckets are eligible for caching, to reduce the memory impact. There are several limitations: - Only a single partition is allowed to have a thread cache - No periodic purging of thread caches is done - No statistics are collected The last two limitations will be addressed in subsequent CLs. Regarding the first one, it is not possible to use Chrome's native thread local storage support, as it allocates. It is also desirable to use thread_local to improve performance. Bug: 998048 Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This reverts commit 44a2bf3d. Reason for revert: New test times out. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38462 Original change's description: > [lacros] Support mojo connection in testing environment > > This CL supports setting up mojo connection between lacros and ash in > testing and debugging environment, and it is done via a unix domain > socket. > > Unix domain socket is only used in testing, not production because it > allows a random process to connect to ash-chrome as long as it knows > the socket path. > > Currently, only one lacros-chrome is allowed to connect to ash-chrome, > so in the testing environment, test launcher will run tests serially, > and will change to run in parallel once ash-chrome supports multiple > clients. > > Bug: 1120582 > Change-Id: I9736b03218f8fe937a7d642a35d6ee49b7e081f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384543 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805537} TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org Change-Id: I911a4d8bd80e8f0a217243503986a1a6d4a16338 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1120582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403460Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/917a2d741e92..3d41d509a6a9 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5f71fdf34b76 to b24900a1aa39 (2 revisions) 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 41c93c550b07 to 29b1f07f4ab2 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1042393,chromium:819294 Tbr: reed@google.com Change-Id: I2af5cbf40df4253a6757a6e64aab2e8824e03bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403047Reviewed-by:
-
Denis Kuznetsov authored
Fix a11y focus-related issues on Marketing opt-in and EULA screens. Bug: 1024092 Change-Id: Ic976091e42ed2c46324445288e2c2b794d87883e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401659 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805694}
-
Olivier Robin authored
Change-Id: I2ca6df4452e375d4f381d4b015f877fa99d16e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400985Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Alex Rudenko authored
Renaming the variable that controls if the overlay will be repainted ignoring the throttling for clarity and reducing the throttling time to 50ms to reduce lags. Change-Id: Ifca6c5e0badf2978fce595604e19082233bac8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401034Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805692}
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: I6930da9f938db2f3bfe4c5062dce30fc4847f3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401037 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Hans Wennborg authored
When using CRC hashing, that assert doesn't hold, but a weaker variant does. Also disallow compiling with FASTEST defined, because I don't think that longest_match variant would be safe with CRC hashing. It doesn't guarantee that the fourth of the hashed bytes will be compared. Bug: 1113596 Change-Id: I20ede29835b9c6b4bdc09fc1836864ffa2b10a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401023 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805690}
-
arthursonzogni authored
Rename the WPT tests so that they now match the new report.body.type: - access-from-coop-page-to-openee_coop-ro.https.html - access-from-coop-page-to-opener_coop-ro.https.html - access-from-coop-page-to-other_coop-ro.https.html - access-to-coop-page-from-openee_coop-ro.https.html - access-to-coop-page-from-opener_coop-ro.https.html - access-to-coop-page-from-other_coop-ro.https.html The report-to API is now working thanks to: https://chromium-review.googlesource.com/c/chromium/src/+/2390748 This patch also updates the expectations accordingly using the latest run: https://wpt.fyi/results/html/cross-origin-opener-policy/reporting?sha=74b5a27a35&label=master&max-count=1 Bug: 1090273 Change-Id: I9f1e4528a5209f81e544247b7857db6cf7fa4ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398720Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805689}
-
Alice Wang authored
This CL refactors AccountManagerTestRule#addAndSignInTestAccount() method so that we can reuse it to refactor SyncTestRule. Bug: 1126814 Change-Id: Ie49ffb174e18f09d28f4253a7b2cdd34ffce9142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401035 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805688}
-
Christian Dullweber authored
Fetch a favicon for the current page and display it in the new PageInfo UI. Use fallback icon when no icon is available. Also fix a failing assert with the long click callback. Screenshot: https://crbug.com/1077766#c30 Bug: 1077766 Change-Id: Ia1a911fe9d06c4c1bc30f9721102253b535294e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390320Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#805687}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/87f25134a8c1..498d5ea20aed 2020-09-10 cwallez@chromium.org Rename BC6HRGBSfloat to BC6HRGBFloat If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia6502fdf833a14f331170b075ddf6d7809691077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402652Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 30a5da05. With Chromium commits locally applied on WPT: 6e8ec7a9 "sensors: Drop tests for Sensor.start()/stop() return types." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Iefdd30404690e7b202854feef83d6de26b381a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401082Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805685}
-
Roberto Moura authored
This CL implements the changes listed in sub section "The View Revealing Vertical Pan Handler" under section "Architecture" of the thumb strip design doc: go/bling-thumb-strip-design . Modify the view revealing vertical pan handler in order to handle both the transition from Hidden to Peeked states and vice-versa, as well as from Peeked to Revealed and vice-versa. -Instead of one boolean property that states whether the view is hidden or revealed, switch to property that can take one of 3 states (Hidden, Peeked, and Revealed). -The animateViewReveal method of the ViewRevealingAnimatee protocol now takes as argument the target state that the animatee should animate to. Bug: 1094335, 1123512, 1123729, 1124380 Change-Id: Ieb7979b19005a3612b7515ac1fc9bfc376c10bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362594 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805684}
-
Wez authored
Bug: 1125623 Change-Id: Ib09d0fe8f694107cf77c9b5172b9f03df015bf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396161Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#805683}
-
Andreas Haas authored
V8 uses a signal handler to implement memory bounds checks for WebAssembly. Therefore signal handler have to be allowed in all V8 fuzzers. R=ochang@chromium.org Bug: chromium:1124755 Change-Id: I3be9fedaf87e78bfd81196e0d847f7b31781a17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401468Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805682}
-
Minoru Chikamune authored
The test was failing on Android L and M bots. This problem was solved with the CL below. https://chromium-review.googlesource.com/c/chromium/src/+/2395195 Bug: 1102041, 1049056 Change-Id: I75b72b3914efb1de1a58c21af778f424c29b6b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398603 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805681}
-
Maksim Sisov authored
It was accidentally disabled for non-ozone. It meant to fail for Ozone/Wayland/X11, but it hasn't been caught because linux-ozone-rel doesn't run interactive_ui_tests. This will be addressed in a follow up. TBR=sky@chromium.org Bug: 1085700 Change-Id: I7d5bf9548aef630cf09839d1bb2c6ad46b9de4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401050Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#805680}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a187dd58a048..2de7d3af0c0e 2020-09-10 paulthomson@users.noreply.github.com spirv-fuzz: Add SPIRV_FUZZ_PROTOC_COMMAND (#3789) 2020-09-10 paulthomson@users.noreply.github.com Add missing include (#3788) 2020-09-09 paulthomson@users.noreply.github.com Improve spirv-fuzz CMake code (#3781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I690a942ac0295b00e418428fe41223a412033fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402644Reviewed-by:
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/930fbec75b..3c8b5d7587 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/930fbec75b..3c8b5d7587 No changes required to .def files. Bug: None Change-Id: I9ec81aafc9986662f47ebd0425d0984fcb95ce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401465Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#805678}
-
