GitLab

Change-Id: I3d3d04bfbc33e7f3e607dbb6ca91d7ea945a3bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614550
Auto-Submit: ssid <ssid@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751196}

EventHandler::HandleMouseMoveOrLeaveEvent has some unused variables,
such as only_update_scrollbars and force_leave. only_update_scrollbars
is removed, because no callers set this to true. force_leave should be
decided from mouse event's type if it is mouse leave type. Also, make
sure the mouse event's type set to "WebInputEvent::kMouseLeave" before
passing to HandleMouseLeaveEvent.

I also add some todo to further clean this class in the future.


Bug: 1016560
Change-Id: I58c1f479602a423fc6e5668c59e78994c633012c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095876
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751195}

These metrics are used to assess pipeline health or planning and should
not ever be deprecated.

Bug: 1053030
Change-Id: I2283c48f0bdca899bbd0c34d327ed337f453734e
Fixed: 1053012, 1055411, 1053020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090715
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751194}

Checks to see if a URL contains a target embedded inside it in a way
that needs to trigger a safety tip. This function will return a "safe
url" which is the embedded target. Currently we consider the following
as Target Embedding: sth-google.com-sth.com, sth.google.com-sth.com,
sth-google-com-sth.com, sth.google.com.sth.com, sth-googlé.com-sth.com
where the embedded target is google.com. In addition to these if a TLD
is used that is considered to be an important TLD but that domain does
not actually exist we consider that a target embedding as well. (e.g.
google.edu instead of google.com in the above examples.)

A more detailed explanation could be found in the project document:
https://docs.google.com/document/d/18YQjj17a820SLVWuIF7cOay_Y8Cq7nt721m67WqCtW0/

Change-Id: Id8ced3db6dc74326dddbe45c0a6c6e8cf53f1c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096026
Commit-Queue: Behnood Momenzadeh <behnoodm@google.com>
Auto-Submit: Behnood Momenzadeh <behnoodm@google.com>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751193}

Its only additional method can be replaced with a free function.

Bug: None
Change-Id: I30837e1488bd3c2e56b0ca58e4a79e1621df7ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107613Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751192}

This is to run tests for
https://luci-milo-dev.appspot.com/p/chromium/builders/ci/linux-rel-swarming-staging/1810

Bug: b/144318226
Change-Id: I95ead7a533f853e0350a5d55fdd9518f86c87989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105692
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Cr-Commit-Position: refs/heads/master@{#751191}

This is based on a comment from robliao@ in https://crrev.com/c/2099238.
This change avoids converting the UTF-16 device path to a UTF-8 path and
therefore makes it possible to call the W versions of Win32 APIs.

Change-Id: I833c2cc7806cd0a61cbad236ebd9fd1985654635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106752Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751190}

This reverts commit 181c9ba9.

Reason for revert: reland by mistake, will reland it together with the fix

Original change's description:
> Reland "[Ash] Simplify AccessibilityControllerImpl to remove duplications"
> 
> This reverts commit 812f314f.
> 
> Reason for revert: culprit found
> 
> Original change's description:
> > Revert "[Ash] Simplify AccessibilityControllerImpl to remove duplications"
> > 
> > This reverts commit 2f2a33d5.
> > 
> > Reason for revert: <INSERT REASONING HERE>
> > It looks like this CL breaks some test case
> > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18262?blamelist=1#blamelist-tab
> > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885542762262570176/+/steps/exo_unittests/0/logs/Deterministic_failure:_All__x2f_SurfaceTest.AcquireFence__x2f_0__status_CRASH_/0
> > 
> > 
> > Original change's description:
> > > [Ash] Simplify AccessibilityControllerImpl to remove duplications
> > > 
> > > AccessibilityControllerImpl had a lot of duplications. Let's fix that.
> > > Also, now it controls fullscreen and docked magnifiers. Before that,
> > > we have to go AccessibilityDelegate and MagnificationManager to do
> > > this.
> > > 
> > > Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d
> > > Bug: 1051892
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688
> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#751086}
> > 
> > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com
> > 
> > Change-Id: Ifbd8e25594790d7417af06c84651d3837ad17b5d
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1051892
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107028
> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> > Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751181}
> 
> TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org
> 
> Change-Id: If1d69e1f28c1e850c55c038ea7138c75da9ea885
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1051892
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107545
> Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751188}

TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org

Change-Id: I382410f4fabc53c4ae5045310b22b729d5ec6cc7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1051892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107546Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751189}

This reverts commit 812f314f.

Reason for revert: culprit found

Original change's description:
> Revert "[Ash] Simplify AccessibilityControllerImpl to remove duplications"
> 
> This reverts commit 2f2a33d5.
> 
> Reason for revert: <INSERT REASONING HERE>
> It looks like this CL breaks some test case
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18262?blamelist=1#blamelist-tab
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885542762262570176/+/steps/exo_unittests/0/logs/Deterministic_failure:_All__x2f_SurfaceTest.AcquireFence__x2f_0__status_CRASH_/0
> 
> 
> Original change's description:
> > [Ash] Simplify AccessibilityControllerImpl to remove duplications
> > 
> > AccessibilityControllerImpl had a lot of duplications. Let's fix that.
> > Also, now it controls fullscreen and docked magnifiers. Before that,
> > we have to go AccessibilityDelegate and MagnificationManager to do
> > this.
> > 
> > Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d
> > Bug: 1051892
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#751086}
> 
> TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com
> 
> Change-Id: Ifbd8e25594790d7417af06c84651d3837ad17b5d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1051892
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107028
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751181}

TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org

Change-Id: If1d69e1f28c1e850c55c038ea7138c75da9ea885
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1051892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107545Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751188}

This reverts commit 7e0c31e0.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 751185 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzdlMGMzMWUwNTVjNTNmNTdiNGE0OTM2NzI1NGIzZGQxN2RmZGY3MjAM

Sample Failed Build: https://ci.chromium.org/b/8885536633435759808

Sample Failed Step: compile

Original change's description:
> Adding new parameter raster_mode to CreateSharedImageProvider
> 
> Adding a new parameter, raster_mode, that determines if the newly
> created CanvasResourceProvider of SharedImage is GPU or CPU.
> 
> In later changes we need to be able to specify this to be false, while
> it was defaulted to true inside the CreateSharedImageProvider.
> 
> Here we are just adding the new parameter and fixing all callsites with
> true (as it was the earlier value).
> 
> Bug: 1035589
> Change-Id: Ifb640dacf59b0c12ec098645f341bedc93a3ad96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104213
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
> Reviewed-by: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751185}


Change-Id: I4256551657c56f8f422dd8870d4cf9c139b81f81
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1035589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108065
Cr-Commit-Position: refs/heads/master@{#751187}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f1850bf0..1bf5f826

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I591df630a0e81579def72744be2eaba8424fe9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106324Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751186}

Adding a new parameter, raster_mode, that determines if the newly
created CanvasResourceProvider of SharedImage is GPU or CPU.

In later changes we need to be able to specify this to be false, while
it was defaulted to true inside the CreateSharedImageProvider.

Here we are just adding the new parameter and fixing all callsites with
true (as it was the earlier value).

Bug: 1035589
Change-Id: Ifb640dacf59b0c12ec098645f341bedc93a3ad96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104213Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751185}

The feature was introduced to use context document's ResourceFetcher for
subresources of HTML imported documents.

We've enabled the feature since M80, and we have not got an complaint
since then.

Bug: 961614
Change-Id: Ic842c2f9105ca7f7371a493b7debc2cca70cc862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103998Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751184}

https://chromium.googlesource.com/angle/angle.git/+log/273f9c7c26d7..f98084edfc01

git log 273f9c7c26d7..f98084edfc01 --date=short --first-parent --format='%ad %ae %s'
2020-03-17 amy.liu@arm.com Fix ShaderStorageBufferReadWriteOffset end2end test

Created with:
  gclient setdep -r src/third_party/angle@f98084edfc01

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: courtneygo@google.com
Change-Id: Icfc4f43c4dba2a89098312dcff1d2de248cd9443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107786Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751183}

This reverts commit 10dc6813.

Reason for revert: spec revert for crbug.com/1062423

Original change's description:
> Regenerate test certs with shorter validities
> 
> macOS 10.15 limits the maximum validity of locally trusted certificates
> to 825 days, documented at https://support.apple.com/en-us/HT210176
> 
> This updates the test certs that interact with the macOS APIs to meet
> that requirement.
> 
> In doing so, the CRLSet logic is also updated to be able to create
> fake CRLSets during testing for serials with the high bit (0x80) set
> in the first byte of the serial. These have a leading 0x00 in the
> actual encoded form, to ensure they're positive INTEGERs, while the
> CRLSet logic expects that leading byte to be stripped for the internal
> representation.
> 
> Bug: 1061024
> Change-Id: Ie225545b493550cac7e007c0978e843af3b52a37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103370
> Reviewed-by: Matt Mueller <mattm@chromium.org>
> Reviewed-by: Carlos IL <carlosil@chromium.org>
> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#750972}

TBR=rsleevi@chromium.org,mattm@chromium.org,carlosil@chromium.org

Change-Id: I80de382a42ab031eb96106b0e81135656f80bbb0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1061024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107698Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751182}

This reverts commit 2f2a33d5.

Reason for revert: <INSERT REASONING HERE>
It looks like this CL breaks some test case
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18262?blamelist=1#blamelist-tab
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885542762262570176/+/steps/exo_unittests/0/logs/Deterministic_failure:_All__x2f_SurfaceTest.AcquireFence__x2f_0__status_CRASH_/0


Original change's description:
> [Ash] Simplify AccessibilityControllerImpl to remove duplications
> 
> AccessibilityControllerImpl had a lot of duplications. Let's fix that.
> Also, now it controls fullscreen and docked magnifiers. Before that,
> we have to go AccessibilityDelegate and MagnificationManager to do
> this.
> 
> Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d
> Bug: 1051892
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751086}

TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com

Change-Id: Ifbd8e25594790d7417af06c84651d3837ad17b5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1051892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107028Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751181}

This delegate will be used to implement server-side copy/move, and
to intercept certain operations (eg. read directory) to provide UI in
error cases.

Bug: 1054704, 1054689
Change-Id: I506a8e606c3fdf40d9a0016dfde1b9954c1b4f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106039Reviewed-by: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751180}

This reverts commit 4b6040f2.

Reason for revert: not responsible for breakage.

Original change's description:
> Revert "Add CertProvisioningWorker class"
> 
> This reverts commit d8c37dee.
> 
> Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1062423
> 
> Original change's description:
> > Add CertProvisioningWorker class
> > 
> > CertProvisioningWorker class implements core logic for building
> > a CSR with DM server and importing corresponding certificate.
> > 
> > Bug: 1045895
> > Test: CertProvisioningWorkerTest.*
> > Change-Id: Ida540f2b330d0dac9e86f53568f29287559a1ad8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078582
> > Commit-Queue: Michael Ershov <miersh@google.com>
> > Reviewed-by: Pavol Marko <pmarko@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#750986}
> 
> TBR=achuith@chromium.org,pmarko@chromium.org,miersh@google.com
> 
> Change-Id: I06d5c2889f05563980a20b42ff00c635da5677db
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1045895
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107394
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751138}

TBR=achuith@chromium.org,pmarko@chromium.org,jbudorick@chromium.org,miersh@google.com

Change-Id: I0e1010a22b003d7e91f3bf1cba46f2b8d66c8de3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108063Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751179}

Move computed_style_property_map.cc::ComputedTransformComponent()
to ComputedStylePropertyMap::ValueForTransformOperation() in preparation
for its upcoming use by animations code.  It has been moved verbatim
except for renaming it according to current conventions.

Add ValueForMatrixTransform to COmputedStyleUtils class. It previously
had no declaration in the header.

This causes no behavioral change.

Change-Id: I94faea6fac02a2ee37b88d32fed326142c0ec01e
Bug: 933761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106497Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751178}

Change AddExtension method in ManifestFetchData class so that it
accepts the Manifest::Location instead of std::string as we would need
it in case of offline installation from cache in
https://crbug.com/1051870.

Bug: 1061402
Change-Id: I336e240d659095f94796d3aec06c51f4b577d6ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100820
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751177}

Right now in the ReportMainFrameCausedNoDamage, we set the
begin_main_frame_data_.previous_sequence to 0 only if the frame
args is the same as the current main-frame args.

This CL turns the if statement into a DCHECK. It basically means:
if the no-damage report comes, it must come before the next
ReportBeginMainFrame.

Bug: None
Change-Id: I6c02855c5fac4721a430cd03610c8ead17d8a411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105400
Auto-Submit: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751176}

Instead of an error.

BUG=none
TEST=none

Change-Id: Idb16fdbc6171c4481adbcfe2ab88f7b17aa5b5a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108062Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751175}

Previously a script (testing/scripts/run_android_wpt.py) was writing
the commandline to a file, but that isn't the right place as it meant
any arguments from wpt were effectively dropped. This makes chromedriver
write the commandline flags to a file for webview as it does for weblayer
and clank.

BUG=1059990
TEST=test only change

Change-Id: I221bee623066712607395b50c50a70d156a24560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108000Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751174}

Fix the flaky test which was waiting for the URL
which we didn't actually need.

BUG=1060626

Change-Id: Ib29ebabf9c0ff0bf803fbc7f2af5c1dde7ac525d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106970Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751173}

https://pdfium.googlesource.com/pdfium.git/+log/e6420a421590..56686c32e743

git log e6420a421590..56686c32e743 --date=short --first-parent --format='%ad %ae %s'
2020-03-17 thestig@chromium.org Fix some typos in fpdf_formfill.h.
2020-03-17 tsepez@chromium.org Remove another usage of CFXJSE_Value from CFXJSE_Class.
2020-03-17 tsepez@chromium.org Replace CFXJSE_Value with CFXJSE_HostObject in FormCalc JS.
2020-03-17 nigi@chromium.org Roll third_party/depot_tools/ 816c2b354..8cf12290b (116 commits; 21 trivial rolls)
2020-03-16 tsepez@chromium.org Remove use of CFXJSE_Value to return formcalc JS results.

Created with:
  gclient setdep -r src/third_party/pdfium@56686c32e743

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I26757531320761012bb03af99fcada0fadbe04c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#751172}

We are reverting crrev.com/c/2017646c and crrev.com/c/2018501. We
decided that blocking mature extensions and themes is better
implemented on the Chrome Web Store server side.

The MatureExtensionChecker has already been removed in
crrev.com/c/2099237. Since the MatureExtensionChecker was the only
mechanism for adding disable reason BLOCKED_MATURE, we can now remove
this disable reason in Chrome. Moreover, since the mature extensions
tool-tip only shows when disable reason BLOCKED_MATURE is present, we
can remove the tool-tip as well.

Bug: 1060451
Change-Id: I5b702b61a14b8ab515ce6718d590415ce6933cb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101849Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751171}

This function is only used to migrate legacy drive paths, so hide it
from being used by others.

Also change IsUnderDriveMountPoint() to work with DriveFS paths instead.
The function is used in places where there is no profile object easily
available, so avoid using DriveIntegrationService to implement it.

Bug: 1003238
Change-Id: Ia50f6df50e195ea246b3adf000777fa5d2151101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105666
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751170}

Android version of a11y_helper.mojom is version 20, update
Chrome version to match this.

Rename eventText to event_text, to ensure consistency among
other variables in mojom file.

Bug: none
Test: build passes
Change-Id: I4899a59adb0553803e109319e155a89e4b91bb18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102993Reviewed-by: Hiroki Sato <hirokisato@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751169}

In crrev.com/c/2092697, a memory upper threshold was introduced
to control real time URL check. However, it turns out the change
won't work because high-end and low-end devices are still being
controlled by the same flag "kRealTimeUrlLookupEnabled". Once
high-end devices are launched, finch will warn us with "both
high-end and low-end studies apply to the same feature flag and
affects the same population." See the warning in cl/300834155.

To avoid the conflict, it might be easier if we revert the change
in crrev.com/c/2092697, and add a new flag named
"kRealTimeUrlLookupEnabledForAllAndroidDevices".
The new flag will be independent of the old flag, so it won't be
affected by the high-end devices launch.

Bug: 1014202
Change-Id: Id7c0ef84a0ba8f45ea5628fcec472a678450445b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104869
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751168}

Bug: 1026426
Change-Id: I7ab64f81a48d400e8bab92c4d977d0ea0d50a11e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107233
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751167}

Bug: 1037961
Change-Id: I8a81e4c1295dc15c373846694c165eacdba71843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099085Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751166}

NOTRY=true
R=ulan@chromium.org
TBR=ulan@chromium.org

Bug: 1062438
Change-Id: If81aed43750d93d5c61b02e22c8e40b9f2acec81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108060Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751165}

Do not save data if the SavingBrowserHistoryDisabled
pref/policy is enabled.

BUG=1051239

Change-Id: I81f64b1bb257039e7c6d5081ad94572986b9f674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106465Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751164}

Migrating contents of site_settings individually based on elements with
tests, to avoid extremely large CLs.

Bug: 1026426
Change-Id: I6f62a6b36bf049398464ea803cfcd382b8137747
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103753
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751163}

Moving Homepage related settings code to homepage.settings package

Change-Id: Iaf198f4a25cc03b32a1de997577d466916470437
Bug: 1052060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095468
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751162}

Take 2 of the change, original CL was reverted due to tests flakiness:
https://chromium-review.googlesource.com/c/chromium/src/+/2102542

In this new change, we're making less drastic changes to existing tests.
Rather, we add a new test case which covers exactly the bug's symptoms -
making sure its fix won't be regressed in the future.

Tests flakiness was occurring in the iphone-device builder. I've tested
this new patch against that builder ~3 times now and it looks much better
than when using the previous patch.

Bug: 1058388
Change-Id: I459f8c3f66e7ac2d6c11232a75ad95b8c6026cae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106802
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751161}

The latter is a better name for the contents of that file, as it
is no longer a Polymer behavior. Also re-running clang-format.

Bug: None
Change-Id: I1e638271b5d973c426d392ee3fc9dbd7e0114bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107055
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751160}

In order to correctly snap box sizes to pixels using SnapSizeToPixel,
the function FragmentData::PaintOffset() needs to be used. This function
provides an accurate location/offset of the box in question. However,
this the paint offset is determined in the PrePaint lifecycle phase. To
accommodate this, LocalFrameView::NotifyResizeObservers is moved to
LocalFrameView::UpdateLifecyclePhasesInternal. In addition,
UpdateLifecyclePhasesInternal is refactored so that all lifecycle
steps prior to paint are run in a loop. The loop is broken when one of
the following 3 conditions are met:

1) the target state < kPaintClean
2) No changes to layout are pending
3) Resize observer loop limit is reached

Resize Observer can now observe changes to the device pixel content box.
ResizeObserverEntry now reports the dimensions of the pixel snapped
content box.

Bug: 1055579
Change-Id: Ibc7b2e4e0a8468f9af74c8cfaadd02e4f0bcfc1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071575Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#751159}

This cl adds a space after "set for Chrome." in the
per app time limit interstitial error page.

Bug: 1061620
Change-Id: Ib84175aeb057ae31b7b45259d1cb81e984477821
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107813Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751158}

This patch closes a Cast virtual connection between a client and a
session in two cases:

1. The corresponding PresentationConnection is closed by the renderer.
2. The client sends a "leave session" message.

Case #2 could be implemented by #1, but for now, they are both
supported for backwards compatibility.

Bug: 1059053
Change-Id: I4bfaf5fd4a49adc16980f9ef12b2502c308c1770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099606Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751157}