GitLab

CachingWordShapeIterator splits runs in the logical order, but
ShapeResult::offsetForPosition() expected the input to be in the visual
order.

This patch fixes ShapeResult::offsetForPosition() to handle the list
of ShapeResult from CachingWordShapeIterator in the logical order.

This is a regression of "Change Font::offsetForPositionForComplexText
to use CachingWordShapeIterator"[1]. Unfortunately tests in the CL did
not catch this logic/visual inconsistency. The test was updated to
include it.

The test string has a diacritic mark at offset 1, and the test ensures
offsetForPosition() dose not return 1. All platforms pass this criteria,
however, only Mac test runner does not return offset 5 (Mac content
shell is fine) so Mac -expeted is added separately.

[1] https://codereview.chromium.org/1248453004/

BUG=518347
TEST=editing/selection/offset-from-point-complex-scripts.html

Review URL: https://codereview.chromium.org/1314543003

git-svn-id: svn://svn.chromium.org/blink/trunk@201181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524826

git-svn-id: svn://svn.chromium.org/blink/trunk@201180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make selectMisspellingAsync() to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |selectMisspellingAsync| class to use
|toNormalizedEphemeralRange()| in |VisibleSelection| class instead of
|toNormalizedRange()| as a preparation of templatizing |VisibleSelection| to use
templatized positions instead of DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1319433002

git-svn-id: svn://svn.chromium.org/blink/trunk@201179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make DeleteSelectionCommand to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange()

This patch changes |DeleteSelectionCommand| class to use |toNormalizedEphemeralRange()|
in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation
of templatizing |VisibleSelection| to use templatized positions instead of
DOM position to represent range.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309423002

git-svn-id: svn://svn.chromium.org/blink/trunk@201178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524804

git-svn-id: svn://svn.chromium.org/blink/trunk@201177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When selecting more than 1 touch device during device mode in devtools, only
the touchevent scripts for the last selected device are cleared upon exiting
device mode. Events such as 'ontouchstart', coming from previous devices,
will persist.

BUG=133915
TEST=Reproduction steps are in https://crbug.com/133915#c46

Review URL: https://codereview.chromium.org/1313793005

git-svn-id: svn://svn.chromium.org/blink/trunk@201176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NoBluetoothChooser
ChosenDeviceVanished
ChooserCancelled

1st of 3 patches:
1. This patch.
2. Wire up the chooser on the Chrome side. (https://codereview.chromium.org/1286063002/)
3. Update the test assertions and remove now-unused errors. (https://codereview.chromium.org/1284143006/)

BUG=500989

Review URL: https://codereview.chromium.org/1293593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

getComputedStyle(e).transform currently doesn't return the correct 
values for non-transformable elements. Both FF and IE return the correct 
values. This patch makes getComputedStyle(e).transform return the 
correct value for non-transformable elements as well.

BUG=517620

Review URL: https://codereview.chromium.org/1312023003

git-svn-id: svn://svn.chromium.org/blink/trunk@201174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524711
NOTRY=true

Review URL: https://codereview.chromium.org/1317733002

git-svn-id: svn://svn.chromium.org/blink/trunk@201173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The text autosizer demarcates certain nodes as "clusters" that autosize
using a consistent font multiplier (see http://tinyurl.com/TextAutosizer
for a full description). Clusters can nest forming a tree, and a root
cluster is assumed to be available to all Nodes except the LayoutView.

This patch fixes a bug where no root cluster was created by a LayoutView
which contained LayoutObject children (in this case, a sole pagination
anonymous block) but no Node children. A similar situation can occur
with completely empty documents.

Asserts & comments have been added to clarify the root cluster concept.

BUG=521657

Review URL: https://codereview.chromium.org/1308693003

git-svn-id: svn://svn.chromium.org/blink/trunk@201172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=457450

Review URL: https://codereview.chromium.org/1312983006

git-svn-id: svn://svn.chromium.org/blink/trunk@201171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524764

git-svn-id: svn://svn.chromium.org/blink/trunk@201170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524596

Review URL: https://codereview.chromium.org/1306993005

git-svn-id: svn://svn.chromium.org/blink/trunk@201169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in preparation for making the FloatRect constructor from LayoutRect
explicit.

BUG=524259

Review URL: https://codereview.chromium.org/1303413004

git-svn-id: svn://svn.chromium.org/blink/trunk@201168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/1311013004

git-svn-id: svn://svn.chromium.org/blink/trunk@201167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Four methods on blink::Element that provide special functionality for the html
element (document.documentElement in JS) are updated for compatibility with root
layer scrolling.

BUG=518885
R=eae@chromium.org

Review URL: https://codereview.chromium.org/1310323003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move logic from cstor for reusing it in future CLs.

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1319613002

git-svn-id: svn://svn.chromium.org/blink/trunk@201165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=488634
NOTRY=true

Review URL: https://codereview.chromium.org/1303413005

git-svn-id: svn://svn.chromium.org/blink/trunk@201164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201142

BUG=524594
TBR=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/1303423004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201140

BUG=252696
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/1306723007 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A remote frame can be detached by setting its .style.display = 'none'.
  If we attach it again by setting its .style.display = '', the frame
  becomes widget/FrameView-less. This CL sets the widget of the frame.

BUG=517291
Test=With --site-per-process, navigate an <iframe> to cross site.
  See that resizing the frame works correctly, e.g.:
    document.querySelector('iframe').style.width = '400px';
  Now hide the iframe, and then make it visible:
    document.querySelector('iframe').style.display = 'none';
    document.querySelector('iframe').style.display = '';
  See that resizing the frame still works correctly. It will fail
    without this CL.

Review URL: https://codereview.chromium.org/1309343002

git-svn-id: svn://svn.chromium.org/blink/trunk@201161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201031

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1317683004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201156 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201026

BUG=509025
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/1314013002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201138

BUG=521768
TBR=jbroman@chromium.org

Review URL: https://codereview.chromium.org/1316723004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201025

BUG=510703
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/1302383003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201078

BUG=518816
TBR=miletus@chromium.org

Review URL: https://codereview.chromium.org/1318473004 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201073

BUG=522826
TBR=kojii@chromium.org

Review URL: https://codereview.chromium.org/1314943003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is using the new PermissionsHelper.setPermission() method that
prevents race conditions when trying to use testRunner.setPermission.

BUG=519008

Review URL: https://codereview.chromium.org/1314763003

git-svn-id: svn://svn.chromium.org/blink/trunk@201150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test was using removed internal methods and didn't set a minimum page
scale which is now needed for position-fixed elements to correctly get their
percentage based size.

BUG=225184

Review URL: https://codereview.chromium.org/1318543005

git-svn-id: svn://svn.chromium.org/blink/trunk@201149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=brucedawson, eae, leviw

Review URL: https://codereview.chromium.org/1305943004

git-svn-id: svn://svn.chromium.org/blink/trunk@201148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a long-standing bug where crashing reftests would not
show some crash logs on the layout tests results page.

single_test_runner.py has an optimization to not run reftests when
the base test crashes. This optimization accidentally failed to write
crash logs (done through write_test_result(...)) as well. This patch
fixes this bug and adds a small test.

Review URL: https://codereview.chromium.org/1312693002

git-svn-id: svn://svn.chromium.org/blink/trunk@201147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=bungeman@chromium.org
BUG=524623

Review URL: https://codereview.chromium.org/1306993006

git-svn-id: svn://svn.chromium.org/blink/trunk@201146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScrollableArea maintained its own special path for wheel handlers. This was
duplicating logic with other scrolls that used ScrollableArea::userScroll and
confusing (why isn't there a handleTouch? handleKey?).

I've removed ScrollableArea::handleWheel and its overrides and moved all the
WheelEvelt -> Scroll Delta logic into EventHandler from where it simply calls
ScrollableArea::userScroll like all other scroll paths.

I also made a slight change to the page step size of ScrollableArea: it's now
87.5% of the visible area *including* scrollbars. This was necessary since on
the root frame, the visible area excluding scrollbars is a somewhat arbitrary
calculation when  pinch-zoomed. While it would be possible to come up with some
scheme or make the step size different for root and non-root frames this would
unnecessarily complicate the code for little gain so I just based it off the
size of the frame rect.

BUG=443724

Review URL: https://codereview.chromium.org/1298973004

git-svn-id: svn://svn.chromium.org/blink/trunk@201145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521444

Review URL: https://codereview.chromium.org/1304193004

git-svn-id: svn://svn.chromium.org/blink/trunk@201144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1307383002

git-svn-id: svn://svn.chromium.org/blink/trunk@201143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524594

git-svn-id: svn://svn.chromium.org/blink/trunk@201142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using a method is deemed more readable than having a weirdly named
parameter. The "curve25519dh" value still needs to be passed in as the
first and only argument of the getKey() method.

This CL is part of a three-sided patch:
  [1] This CL.
  [2] https://codereview.chromium.org/1314893002/
  [3] https://codereview.chromium.org/1316693002/

BUG=486040

Review URL: https://codereview.chromium.org/1309723004

git-svn-id: svn://svn.chromium.org/blink/trunk@201141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGLengthContext::resolveRectangle would resolve oBB units as uSOU units
if the "viewport" provided was empty.
This would lead to incorrect rendering in certain cases - like with
filters on content with an empty bbox.

BUG=252696

Review URL: https://codereview.chromium.org/1313893003

git-svn-id: svn://svn.chromium.org/blink/trunk@201140 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Document call was changed to Frame::securityContext() to make the code more
RemoteFrame-friendly. However, callingWindow is guaranteed local. Revert to
getting the SecurityOrigin via Document.

BUG=524074
TEST=http/tests/security/location-change-from-detached-DOMWindow.html

Review URL: https://codereview.chromium.org/1311253005

git-svn-id: svn://svn.chromium.org/blink/trunk@201139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This restores some logic removed in https://codereview.chromium.org/1030323005/.
This seems to change some of Blink's behaviour back, and will hopefully resolve issues with unclipped render surfaces.

BUG=521768

Review URL: https://codereview.chromium.org/1300213004

git-svn-id: svn://svn.chromium.org/blink/trunk@201138 bbb929c8-8fbe-4397-9dbb-9b2b20218538