- 28 Feb, 2020 40 commits
-
-
Sajjad Mirza authored
After crrev.com/c/2079621, operator<< had two different definitions in two places. The one in sandbox_flags.h appears to be the incorrect one. Bug: 1056945 Change-Id: I9c575492276b493e55574292ee8d385c3cdbc309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079389Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#745338}
-
Rohit Rao authored
BUG=1027249 Change-Id: I719bef6dd78c7266ff8eb2f480a34a1effa3f927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076448 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745337}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 3d6d790e. Reason for revert: crbug.com/1056978 Original change's description: > Reland "[xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec" > > This is a reland of 21245a70 > > TBR=twellington@chromium.org > > Original change's description: > > [xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec > > > > Change-Id: Ib77234174ece4facb35596808fd964a18db04311 > > Bug: 1054944 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409 > > Commit-Queue: Cathy Li <chili@chromium.org> > > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#744352} > > Bug: 1054944 > Change-Id: I5f6c81e1740e418307c3365bd13969769d99472a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078794 > Commit-Queue: Cathy Li <chili@chromium.org> > Reviewed-by: Cathy Li <chili@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745237} TBR=dewittj@chromium.org,twellington@chromium.org,skym@chromium.org,chili@chromium.org Change-Id: I3e5cdad1b8d83f60f1c95edaf30b4f3c66c828b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079843Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745336}
-
Lijin Shen authored
1. update some color names to sync between codebase and go/clankcolors, most of which are marked as "needs update" 2. update colors which are marked as "do not use" Bug: 775198 Change-Id: I57c1f33a405616bd7bfec3648949a27aff94dd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073140 Commit-Queue: Lijin Shen <lazzzis@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#745335}
-
Jamie Walch authored
Most of these are from the old Chrome app. Change-Id: I7e2b7f1a87917239e589f90d0a7d39c3e8215593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079390Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#745334}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4b47b52e653..21c99c4478fb git log a4b47b52e653..21c99c4478fb --date=short --first-parent --format='%ad %ae %s' 2020-02-27 phoglund@google.com Use doubles for the histogram C++ API. Created with: gclient setdep -r src/third_party/catapult@21c99c4478fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: oysteine@google.com Change-Id: I6db17f56145d30ae35d5667e84a40a08be6106e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078540Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745333}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ifb694352a615882e517a142f2d22ea88a44fc338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079457Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745332}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e3e07bf979ea..b5eeba1bb3d7 git log e3e07bf979ea..b5eeba1bb3d7 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ed2234c..dcd1a26c (745105:745220) Created with: gclient setdep -r src/third_party/webrtc@b5eeba1bb3d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I53efbe80f5ae269e3ec8a0494143822ac34c9b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079624Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4017f982cd1d..211ec3001099 git log 4017f982cd1d..211ec3001099 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 rwkeane@google.com Add IPAddress Comparator 2020-02-27 rwkeane@google.com Discovery: E2E Test #3 Created with: gclient setdep -r src/third_party/openscreen/src@211ec3001099 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1719f0fb74e34067e914b973cd129306d33534f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079629Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fdf027a728e9..780e6bf8d438 git log fdf027a728e9..780e6bf8d438 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 ehmaldonado@google.com gclient: Allow setting GCLIENT_PY3 to 0 to run on Python 2. 2020-02-27 ehmaldonado@google.com git-cl: Run PostUpload hooks via CLI. 2020-02-27 ehmaldonado@google.com presubmit_support: Refactor and add tests for DoPostUploadExecuter. 2020-02-27 vapier@chromium.org my_activity: search gerrit review too Created with: gclient setdep -r src/third_party/depot_tools@780e6bf8d438 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324,chromium:984182 Tbr: agable@chromium.org Change-Id: Ia9f24c988a5ae885c745a6851746dd48b04799c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079626Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/21be4b46c82c..35bcc9f6d5e8 git log 21be4b46c82c..35bcc9f6d5e8 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 dschuff@chromium.org Don't do GN builds on mac/arm bots Created with: gclient setdep -r src/native_client@35bcc9f6d5e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056008 Tbr: mseaborn@chromium.org Change-Id: Iad77423468bacfa2b9d03b7525e4d4b7aac73856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079623Reviewed-by:
-
Edward Lemur authored
The masters and bots listed don't exists anymore. GetPreferredTryMasters is used by git-cl try to pick what bots to trigger. I want to remove support for it, since its not used and increases maintenance costs. Skipping presubmit because of unrelated pylint failures. No-Presubmit: true Change-Id: I3f539a2d08444fc1dd3851777aeb1b9a71407bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072643 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#745327}
-
Jiahe Zhang authored
To avoid smoothness issues, choose one from the supported intervals which is in perfect candence with |min_frame_sink_interval| instead of simply choose the closest one. Also, add a line to update display_frame_timebase in root_compositor_frame_sink_impl.cc when |use_preferred_interval_| is true but without a meaningful interval. Bug: 976583 Change-Id: I9e221dd759efc9c1cb0c40102d61695ff075ef9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013469 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745326}
-
Daniel Clark authored
Fix the polarity on a couple of null checks that were preventing AXObjectCacheImpl from registering as a lifecycle notification observer for popup documents. This failure to register was preventing AX focus events from being fired when focus changed inside of a popup. The week-picker-ax.html test was passing prematurely because of focus events received when opening the popup, without validating that additional events were fired when changing focus in the popup. Update that test to confirm that events are also fired for a focus change in the popup itself. There were a couple of analogous tests (date-picker-ax.html, month-picker.html) that were deleted when we purged old date popup tests in favor of new tests written for the new popup implementation (crrev.com/c/1967608). I don't see replacements for these in the new tests, so this change also restores those tests, updates them for the structure of the new form controls, and ensures that they are checking that focus events are fired due to changes in the popups and not just from events fired when the popups open. Bug: 1022920 Change-Id: Ifbccaff74131031ab60d61a715475eecdca0a7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074815Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745325}
-
Brandon Wylie authored
ChromeTabCreator and CustomTabActivityTabController both have their own instances of TabDelegateFactory that should be used with ReparentingTask. These were changed incorrectly in crrev.com/c/1980962. Bug: 1048602 Change-Id: I1cdac903b4794fe00f5e4ba0fb8a3d8e2bbcf4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076005Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#745324}
-
Qingsi Wang authored
Curve25519 is introduced behind the feature flag WebCryptoCurve25519. Bug: 1032821 Change-Id: I6051eca2027ecbcfd2236853aa4f691366802601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958596Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745323}
-
Thanh Nguyen authored
This CL does the following things: 1. Uses exact string match for non Latin locales and guards this under a Finch flag. 2. Consolidate Finch parameters for FuzzyAppSearch. Bug: 1053710 Change-Id: I69ba33d4fac5ddb64d21521d1eb4aa4e0f6517be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068065 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745322}
-
shrekshao authored
TextureManager::ExtractTypeFromStorageFormat returned type=0 for compressed texture formats, and that is passed into texture_manager()->SetLevelInfo thus ends up with INVALID_ENUM at glTexSubImage3DFn Bug: 1051217, 1056845 Change-Id: Ia3f9e455a02a97aaef4f1de1e526d0c01963c2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070827Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#745321}
-
Hiroki Sato authored
This change adds expand and collapse actions to ax_enums and wires them from ARC. This change also makes nodes with action of EXPAND or COLLAPSE have collapsed or expanded state. Bug: b:145260637 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: I292cfc0cac8c9ed5543abf3dbbd3464e8ad8c8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066432 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#745320}
-
Victor Fei authored
Currently, when we select an item through SelectionItemProvider, Windows Narrator announces "selected" but when we remove the selection, we do not hear "non-selected". This is due to not firing UIA_SelectionItem_ElementRemovedFromSelectionEvent when we unselect. This CL adds firing UIA_SelectionItem_ElementRemovedFromSelectionEvent for non-multiselected selection item, so we can properly notify Windows Narrator of the unselect action. Bug: 928949 Change-Id: Idbce6a2ecaaf3ff90231cf1a07d7a3bd06a23475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066591Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745319}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e413afc9bc3..66759fd96232 git log 0e413afc9bc3..66759fd96232 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 treehugger-gerrit@google.com Merge "Fix FtraceProcfsIntegrationTest.EnableDisableEvent" Created with: gclient setdep -r src/third_party/perfetto@66759fd96232 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If3f3003946ab6b14e227a607aeaed44c96a0dae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079622Reviewed-by:
-
Karan Bhatia authored
This CL adds a maximum memory limit for individual regular expression filters using the re2 |max_mem| option. The limit is initially set to 2 Kb. Manifest regex rules exceeding the limit are ignored and will cause an install warning instead of a hard error. To prevent a lot of warnings, we limit the number of such warnings to 10. In case of more than 10 such rules, we'll show a single warning listing all the affected rule IDs. New dynamic rules added using the chrome.declarativeNetRequest.updateDynamicRules call and exceeding the limit will cause an error. Earlier indexed rules (static or dynamic) which now exceed the memory limit will be ignored silently. This will be modified subsequently to raise an error in the extension console. BUG=974391 Change-Id: I759d651b851200613c8d3b2e4c7146fdd4749a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032028 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745317}
-
Rohit Rao authored
about:policy will need access to the BrowserState's SchemaRegistry. Rather than expose it directly on ChromeBrowserState, we will expose it via BrowserStatePolicyConnector, which allows us to keep all of the policy-related accessors in one class. BUG=1024115 Change-Id: Iac7f45bec1b38e4b23a237978b9b4863587fd257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076444 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745316}
-
Victor Fei authored
Refactored the PosInSet & SetSize algorithm, more specifically: - AXTree::ComputeSetSizePosInSetAndCache - AXTree::PopulateOrderedSetItemsMap To compute PosInSet & SetSize for ordered set items, we first need to parse ordered set items from DOM structure and store/populate it into a data structure, and from which we can perform PosInSet & SetSize computations. Previously, we store these ordered set items into std::vector<AXNode*>. Using std::vector works well when set items from various hierarchical levels are nested in DOM structure. However, for flattened structure where levels are distinguished by aria-level attributes, the previous algorithm did not work well. Although various changes (e.g. CL:1461539) have been made, the algorithm is still not robust enough for handling flattened structures, Bug:952904. The primary change in the current CL is to replace |items_to_be_populated| from std::vector to std::map (and renaming it to |items_map_to_be_populated|), where hierarchical levels are mapped to lists of ordered sets: std::map<base::Optional<int32_t>, // Hierarchical level std::vector<OrderedSetContent>> // Ordered sets on that level struct AXTree::OrderedSetContent { std::vector<AXNode*> set_items_; // Ordered set items AXNode* set_container_; // Ordered set container }; This new data structure enables AXTree::PopulateOrderedSetItemsMap to parse, sort, and store various ordered set items according to its ordered set and hierarchical level, which greatly cleans up PosInSet and SetSize algorithm, and more robust handlings for flattened ordered set structures. Bug: 952904 Change-Id: Ia856290b143afcf911d9083c735dd7bf9bb3ddf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036908Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745315}
-
Christopher Lam authored
This CL fixes an issue where validate_format.py would catch OWNERS files that were 'empty' because they only had OWNERS that were already in the list of <owner> emails. Bug: 1055668 Change-Id: Ie832a566d3c99cfaaa0ad621def8f990190b5bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076639 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745314}
-
Xiaoqian Dai authored
It seems the reason for that AlwaysOnTop container is still affected by workspace change - like when exiting tablet mode, workspace bounds will change, which then cause the windows in AlwaysOnTop container adjust its bounds. Since back gesture affordance is in OverlayContainer, I think it makes sense to just move back gesture nudge into the same container as well. Bug: 1056906, 1009005b Change-Id: I9d2eb122b5530eaa668603ff5dc7f9b70c90994f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079631 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Garrett Beaty authored
This reverts commit 16469ef3. Reason for revert: The recipe change that stops setting iossim breaks the builder on the beta branch: https://ci.chromium.org/p/chromium/builders/ci-beta/ios-simulator/463 Original change's description: > [ios]Removed usage of iossim in ios/build/bots/scripts/* > > Bug: 1011498 > Change-Id: Ie72335fb20a8ee5c47ba8edaf4ed8299068a7f40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067325 > Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744748} TBR=rohitrao@chromium.org,lindsayw@chromium.org,monufriienko@chromium.org,zhaoyangli@chromium.org Bug: 1011498, 1056905 Change-Id: I45689abac093072e819b19d38ed6855309045725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079521Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#745312}
-
Brandon Jones authored
Updates the IDL name to match a recent change to the WebXR spec, with a temporary typedef added to the old name for backwards compatibility, though the number of pages affected by this are expected to be vanishingly small since a typical page will never have the need to access this interface by name. Bug: 1050600 Change-Id: I06146eff4089f485f1b37b04b9b2c3cc3cc4ead6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055408 Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#745311}
-
Peng Huang authored
With fix a DCHECK crash in GpuDataManager. The crash is because OnGpuInfoUpdate() could be called due to any GPU info update, and the FeatureStatus is still not ready. Fix the problem by checking FeatureStatus availability first. Bug: 1055899 Change-Id: I911405c101ed28bb8b376e3c30c754cc9118ecff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078475 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745310}
-
Connie Wan authored
WebUI has access to the Browser, so this should allow interfacing with Mohnstrudel. It also allows us to clean up a good portion of TabStripController that was only being used by the Editor Bubble. Still left to do: make it so that the dialog doesn't necesesarily need to take a TabGroupHeader. Bug: 1055537 Change-Id: Ia341453a092a8083075d7a31b6e39705d883fbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072365 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745309}
-
Anand K. Mistry authored
The existing SMB integration is based on file_system_provider, which internally saves (if requested) mounts and restores them on login. Smbfs is no longer based on FSP, and therefore needs to use its own mechanism for saving and restoring mount on login. Bug: 939235 Change-Id: I3c6c96cc8c733c74b5e071167d7d9ebf3b9eb12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071537Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#745308}
-
Gyuyoung Kim authored
This CL migrates the legacy ReplicateWebTestRuntimeFlagsChanges IPC message to the new Mojo defined in WebTestClient interface. To do that, this CL needs to introduce WebTestControl interface to send messages from the browser process to the renderer. Then, WebTestRenderThreadObserver starts to handle incoming Mojo requests through the RegisterMojoInterfaces implementation. This CL renames the existing |web_test_control_map_| to |blink_test_control_map_| in order to add a new |web_test_control_map|. Lastly, this CL removes all things related to the legacy IPC of the ReplicateWebTestRuntimeFlagsChanges message. Bug: 1039247 Change-Id: Ia41ef43093d7279020bcb79986e3328ed0338f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063610Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#745307}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings files page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I8318818f7827ce47e9af9646c4541d0d2bb9963c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067391Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#745306}
-
Jinsuk Kim authored
This CL promotes the method to Tab's public method. Bug: 995903 Change-Id: I62ddc3d5c05929664aef6bef5b2a03934bcfa868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045617 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
dpapad authored
This test was reported as flaky (timeouts) on Linux CFI, but was disabled on all Linux bots at r629744, which seems unnecessary. Bug: 929288 Change-Id: Ifd5ffe065318e82a883f51673e4f730f6fb03342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079518 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#745304}
-
Ted Choc authored
The ModelList can and should be the single source of truth, and this remove the redundant list. BUG=1050813 Change-Id: I91aad1c8398470425f50a28e6c64791b18d4fe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078777Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#745303}
-
Ian Kilpatrick authored
Layout now generates some paint information on physical fragments. Specifically (for this bug at least) if a sub-tree contains any floats. This conflicted with the relayout boundary optimization. If a float was added we wouldn't paint it, as we'd stop layout at the relayout boundary, not telling the parent fragments that this subtree contained a float. This patch only allows relayout boundaries to occur at positioned objects which always have self painting layers (which is the most common self painting layer). For the sites that I found which use this optimization (devtools, facebook, bing) all occur on a positioned object. Bug: 1049973 Change-Id: Iafaf68bf9642788a71e8f882a154e6acd7cbef46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076078 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#745302}
-
Scott Violet authored
WebLayer's ShouldOverrideUrlLoading() defines a set of known scheme. Any URL that not in the set will fail to load if not initiated by a user gesture. The set is incomplete and needs to include some other schemes such as 'blob'. This patch moves from a regex in the java side to weblayer/browser/content_browser_client_impl.cc where it can use existing constants. BUG=1056259 TEST=covered by wpt Change-Id: I1d38e4f6a27099426786736aeeea6a2f24851882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074811Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745301}
-
Thomas Lukaszewicz authored
Removed the SetImageFromVectorIcon() function that used a default color value from a global call to GetInstanceForNativeUi() when not explicitly provided with a color value. Image buttons based on vector icons can now be created from CreateColorTrackingVectorImageButton(). These image buttons will update their colors to track the color values in their view hierarchy's native theme object. Bug: None Change-Id: I04c0f3794881b92832cd20a15b0b60c3efba976c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079214 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#745300}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1040828 Change-Id: I6819a779c2b7ce452335178bfdbf79656f9580ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073419Reviewed-by:
-
