- 08 Oct, 2019 40 commits
-
-
David Roger authored
Change-Id: Iff7379af735fbace57075d9b920a8873bb073da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840431Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#703629}
-
chrome://dinoEdward Jung authored
The dino is shifted up when ducking to close the gap. Over many crashes the dino would shift more and more to the right. This CL resets the x position on restart. Bug: 1001938 Change-Id: I1a2c83070c3dfc80811fec4d08876db1102734e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840211Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#703628}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in services/test to the recommended methods/types. Bug: 1007831 Change-Id: I63e66235a875bc298c784c743f4422adc58184c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837833 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#703627}
-
Fergal Daly authored
It's unclear why it needs it this time after https://crrev.com/c/1835683 but it does. Even before this change the scroll was happening before the scroller had finished unlocking everything it would have, so it seems reasonable and future-proof to give it plenty of time. Bug: 1011376 Change-Id: I799e93d01b8252dca4ebf567e6fb9c58da944c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846221Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703626}
-
Yoshisato Yanagisawa authored
Linux Chromium build uses headers and libraries in debian sysroot instead of system's to provide hermetic build environment. To compile simple chrome with Goma, builidng like this improve cache hit ratio because we can expect compile happens in hermetic way. Bug: 1003264 Change-Id: If7c5f80b5d732635f0b178efca0b9d4ca4a5c9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846427Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#703625}
-
Albert J. Wong authored
Orignal CL in: https://chromium-review.googlesource.com/c/chromium/src/+/1824321 Prior CL blew up because: https://bugs.chromium.org/p/chromium/issues/detail?id=1011283 Original Description: Currently ShouldCreateWebContents() does 3 separate things (1) Tells WebContentsImpl::CreateNewWindow() to suppress default popup creation logic. (2) Signals to the embedder that a window creation has been attempted (3) Allows the embedder to signal back, via use of the global routing_id maps, that a new WebContents has been created and needs partial initialization inside the content layer. This is super complex, especially since only one delegate uses (3). The new API creates 2 functions: bool IsWebContentsCreationOverridden() WebContents* CreateCustomWebContents() Breaking up the API makes it cleaner. If the WebContents initialization logic can get changed to absorb the single odd use case in (3) then CreateCustomWebContents() could be changed to have a void return type making the API even simpler. Bug: 545684 Change-Id: I894ae320b55fa410d6469ff07350f4a953952f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846477 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#703624}
-
Ankit Kumar 🌪️ authored
Promises are used in the document load pipeline. The promise is used for toggling between annotation mode. At the initial load of the document the promise is not needed. If the initial document load fails, the promise is rejected and there is no error handler as no entity requires this promise and no error handler is implemented. This throws an error in the Inspect console "Uncaught (in promise) undefined". This CL fixes the usage of promises in the document load pipeline. We only use promises when it is needed by an entity. Bug: 1001979 Change-Id: I7c3a4b6da49a71e343616142917e56247d426f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792404Reviewed-by:
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703623} -
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/08a5ac41e4a8..496c95ad404c git log 08a5ac41e4a8..496c95ad404c --date=short --no-merges --format='%ad %ae %s' 2019-10-08 dberris@chromium.org Follow-up Refactoring to 'Avoid Means' 2019-10-08 dberris@chromium.org Decrease Job Frozen Threshold 2019-10-08 simonhatch@chromium.org Pinpoint - Add UI to select measurement/statistic Created with: gclient setdep -r src/third_party/catapult@496c95ad404c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1011273,chromium:1011728,chromium:1005961 Change-Id: I41dd3a012efc831c11058d272ad77dc82fd802a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847098Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703622}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6da708e46496..66bd5d4deb12 Created with: gclient setdep -r src-internal@66bd5d4deb12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I826c1bf0e681a4cf19eb8725c7c33afb187fe28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703621}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8eb8385e2efc..720988d878a1 git log 8eb8385e2efc..720988d878a1 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 mchiasson@gmail.com Fixed compilation issue on clang 6.x Created with: gclient setdep -r src/third_party/dawn@720988d878a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I605b212e645380b4b12691e436d6bf71e40e5deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845886Reviewed-by:
-
Patrik Höglund authored
This reverts commit d95c3033. Reason for revert: Breaks the ClearDropTarget test: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/53031 Original change's description: > Don't invoke DropTarget's callback on destructor > > When BrowserRootView is being destroyed, we shouldn't call callbacks from > DropTarget. It might be already destroyed. > > Bug: 1001942 > Change-Id: Iddecc9334d814f9154d44ff32473c5fa167b3b23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844001 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703352} TBR=pkasting@chromium.org,sangwoo108@chromium.org Change-Id: Ie5bb03a7a2623a95cbd765e8f2935f6bb7ae3ce3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845758Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703619}
-
Rune Lillesveen authored
For shadow dom V0, <content> elements which are not inside shadow trees are not active insertion points and do not take part in shadow distributions. They are part of the flat tree and otherwise behave as any other elements. Call RecalcDescendantStyles to compute styles for its descendants. TEST=accessibility/table-row-role-crash.html TEST=fast/dom/shadow/content-element-outside-shadow.html TEST=fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content.html TEST=fast/dom/shadow/shadow-insertion-point-rendering.html Bug: 972752 Change-Id: I0037f5c3a1dc6d0f7746aa7e0eb9b118212e2047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846431Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#703618}
-
Jan Wilken Dörrie authored
This change implements wide string overloads to string_split.h and string_util.h. Since these functions are not supposed to be used by Cross-Platform code it is guarded by correpsonding #ifdef guards. Furthermore, this change performs some minor code clean-ups and performance improvements. Bug: 911896 Change-Id: I579b55a398307c890b30a027699b74a9afb1a77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823851 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#703617}
-
Jan Krcal authored
This CL adapts the default border color of toolbar button to be the same as the border color of ToolbarIconContainerView. Bug: 1011314 Change-Id: I25f4e0f64adf0338266dc25c52d12e3b20db8eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845226 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#703616}
-
Yutaka Hirano authored
We see some breakage on M78, so we are disabling the feature. After merging this change to M78 I will revert this change. Bug: 1006292 Change-Id: Ie56d2ac5cdd6ed8ea0fdf8c124a3f01c24731eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846832 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#703615}
-
Hirokazu Honda authored
CreateGpuMemoryBufferHandle() creates GpuMemoryBufferHandle from media::VideoFrame(). The fds and metadata are come from untrusted processes, e.g., ARC++ and renderer process. We must validate GpuMemoryBufferHandle. Bug: None Test: video_encode_accelerator_unittest on eve Change-Id: I74faf5f9a38562d7120cc09d76dbaeb0d67515eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839323 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703614}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d7c56db..d140f412 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1128a26e20c17328743cb6594f65f7d842649659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846547Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703613}
-
Hajime Hoshi authored
BackForwardCache: Add metrics to record why RenderFrameHost prevented the page from BackForwardCache This adds new metrics for eviction by back-forward navigation: BackForwardCache.DisabledForRenderFrameHostReason. This records the reason why the render frame host is prefented from entering back-forward cache. For example, the frame used a disallowed feature for back-forward cache. The original form of the reason is a string, and this histogram records them as integers by StringPieceHash. Bug: 1001087 Change-Id: Id6906b90dbefbcb4a79aa1fa959877a0cce3a582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828786 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703612}
-
Miyoung Shin authored
This change converts WebUsbService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I03f8d6b061eed920ffd68305702f73fff66fe871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844005Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#703611}
-
Adam Rice authored
Apply backpressure to blink::WebSocketChannel before the WebSocketStream handshake starts, rather than after it completes. This avoids a race condition where more of the first message is read than should be. Also fix flakiness in the external/wpt/websockets/stream-tentative/backpressure-receive.any.js by doubling the size of message used. BUG=1002780 Change-Id: I915c71a4b81b95375b7c4c584f7782d5336cba85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844911Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#703610}
-
Peter Boström authored
Replaces trivial cases of kHighlightPathKey with installing generators. Follow-up CLs will deal with creating new generators for more-complex cases. Bug: chromium:1007546 Change-Id: Id5911c450a3a8da43eb3cce4051265da6a995f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841660 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#703609}
-
Patrik Höglund authored
Example failures: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/27728 Tbr: tangltom@chromium.org Bug: 1012167 Change-Id: Ia708a9b3471d987f0d8897e4d9b2051d5c6a31fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845753Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a28cf7c08061..dd88df5d116c git log a28cf7c08061..dd88df5d116c --date=short --no-merges --format='%ad %ae %s' 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 036463457e5f..ae022faf53b9 (2 commits) 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 78225ef2..5c41949c (382 commits) Created with: gclient setdep -r src/third_party/skia@dd88df5d116c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None,chromium:None Change-Id: I409e6cde75fa624dd81cae43439154ba4ba2cc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846713Reviewed-by:
-
Hiroki Nakagawa authored
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - https://github.com/w3c/css-houdini-drafts/pull/958 - https://github.com/w3c/css-houdini-drafts/pull/967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e7ae514a47fe..1ad5811accae git log e7ae514a47fe..1ad5811accae --date=short --no-merges --format='%ad %ae %s' 2019-10-08 tandrii@google.com git cl upload --retry-failed: search back up to 5 patchsets. Created with: gclient setdep -r src/third_party/depot_tools@1ad5811accae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I6ad1a71754e65ed5aa6375eb47189592024ec5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846933Reviewed-by:
-
Hiroki Nakagawa authored
When off-the-main-thread dedicated worker script loading fails, a dedicated worker needs to terminate its worker thread. However, the current code does not do it. This CL fixes it by calling close() in that case. Off-the-main-thread dedicated worker script loading is used when PlzDedicatedWorker is enabled and/or ModuleDedicatedWorker is enabled. Bug: 900429 Change-Id: Iff6c1981ab8e43f9d294a1b9c3e4dc56b3a38650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843800 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This adds braces to multiline if statements to satisfy a presubmit check. Bug: 999554 Test: N/A Change-Id: I50319a0767d2a4edd68bbb4cbf1003407dd2a1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845883 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#703603}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I0e51bf7ca5d2224b117c479b96bfa08e1a164ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845881Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703602}
-
Renjie Tang authored
Change-Id: I5465711c5b812c3e63062233e866434f3cb5d21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846664Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#703601}
-
Maksim Sisov authored
Using aliases turned out to be problematic. More platform specific PlatformWindows we add, the more chances of compilation failures occur. That is, when I added an abstract interface for PlatformWindowWin, it broke compilation as not all the classes really needed to implement that interface method. It did not make sense to add there a default implementation and it was decided to stop using aliases. Bug: 990756 Change-Id: I82c4a419e98bdc22d0e9bf2fb86336dfc7c32b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844811Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#703600}
-
Hitoshi Yoshida authored
This test seems no longer crashing, and set it to run. Added an expectation file for failing cases. Bug: 939181 Change-Id: If7972f0c46c895357e3176e0850a769e440300fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846419Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#703599}
-
Nate Fischer authored
This changes WebView's "metrics collection" interval from every 30 minutes to every 5 minutes (consistent with Chrome for Android on Wifi). At the moment, if the app is used for less than 30 minutes, we only collect metrics logged during and shortly after startup, which biases analysis. This refactors GetUploadInterval to accept a boolean to indicate whether it should apply a different upload rate. WebView sets this to false because our upload mechanism is separate from the log collection mechanism, and the platform logging service has its own rate-limiting logic for cellular connections (as part of its API surface). Bug: 1003525 Test: Wait 5 minutes and verify we upload a second record (to work Test: around https://crbug.com/1003204, I'm selecting text to copy, Test: which triggers a "UserAction" and wakes up the metrics service) Change-Id: I76362fa57017a288149c357bd2bd8deabce9e178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836711 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703598}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cd2fb1efa170..08a5ac41e4a8 git log cd2fb1efa170..08a5ac41e4a8 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 dberris@chromium.org Prepare to Avoid Means in Change Detection Created with: gclient setdep -r src/third_party/catapult@08a5ac41e4a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1011273 Change-Id: I8eae70ab5bba3f0a7b2a53846056a5f8c5d3a1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846553Reviewed-by:
-
Michael Crouse authored
This change builds the first piece of the PredictionManager to handle the registration of OptimizationTargets and requests for whether a navigation should be targeted for a particular optimization. This change enables the PredictionManager to construct the feature map needed to execute the PredictionModel to produce a decision for an optimization target. The the next changes will handle loading PredictionModels from a store and fetching model updates and host model features from the remote Optimization Guide Service. Bug: 1001194 Change-Id: Ib0af48cd2c81d0d4dfe92e4a99916b44eee92498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833783 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703596}
-
Yusuke Sato authored
Several other clients like cras_audio do this already, and this follows the pattern. BUG=b:142141480 TEST=try Change-Id: Ia3caa61924bae636d42ac2e3dc1e996414e3a8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842911 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#703595}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f700582f2fa2..a28cf7c08061 git log f700582f2fa2..a28cf7c08061 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-07 emircan@google.com Fix dedicated allocations for protected images 2019-10-07 benjaminwagner@google.com Revert "Use integer patchset and issue variables." 2019-10-07 herb@google.com Add quailty of life calls to SkZip Created with: gclient setdep -r src/third_party/skia@a28cf7c08061 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I67daa64ba47b25e9d5448c717f46c78b253e5db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845880Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1aea8fc04d80..6da708e46496 Created with: gclient setdep -r src-internal@6da708e46496 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I1827ea9856116b4e560019d90fbbd8b3ce291779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845879Reviewed-by:
-
Gyuyoung Kim authored
This is a reland of 5d024fd7 Missed including "ip_address_space.mojom-blink.h" in worker_module_script_fetcher.cc Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I49cfab31ec57b183570cf4551e4cd1acd20a1a75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844752 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#703549} Bug: 1001360 Change-Id: I5279e2fba33e46fa7eb002deeda34421c4176f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846416Reviewed-by:
-
Joel Hockey authored
Bug: 996439 Change-Id: I95a6882119196e3f8c1448df71225d831b8db284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846636 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#703591}
-
Hwanseung Lee authored
Use enum class instead of enum for ButtonKey::ClickAction enum class is more type safety. Bug: 940736 Change-Id: Iaf2caca28d4fc72efb933761030f365454325e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844913 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#703590}
-
