GitLab

Many existing rebaselined tests had to be rebaselined again
because borders looked different.

Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia4114b66e322550b1a8dc5fc96568071d50a951e
Reviewed-on: https://chromium-review.googlesource.com/1027073
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553746}

When downloading to a file, if code deleted the SimpleURLLoader on
completion, and then tried to access the FilePath object passed to them
by the SimpleURLLoader, they're run into a use-after-free. This CL fixes
that.

Bug: 835963
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8b840544be743aa979145bf46c8d35de4b25c12c
Reviewed-on: https://chromium-review.googlesource.com/1024694
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553745}

This CL adds input event predictor in main thread event queue
under a flag kResampleInputEvents.
It is the basic structure for resample events, without only an
empty predictor. The input predictor handled events before the
event is dispatched. And apply current time to the event.

design doc:
https://docs.google.com/document/d/1DLfibi2NkV85p7AfEtNkvy24d283VRBSd3hz1Qh24Jw/edit?usp=sharing

Bug: 836352
Change-Id: I7c17a33b2e0e5e9a51920e54a9b8ce795537f4ef
Reviewed-on: https://chromium-review.googlesource.com/860429Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553744}

As dewittj@ pointed out, in StartupMaintenanceTask some raw pointers to
the objects on UI thread are being used in background thread, which is
unsafe. This CL fixes the issue by making copy of objects on UI thread
and bind them before hopping to background thread.

Fortunately other tasks didn't have the wrong implementation.

Bug: 832232
Change-Id: Ia8913ba6036b9c2ce357d53857f968fe1629c03d
Reviewed-on: https://chromium-review.googlesource.com/1027130
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553743}

There have been many fixes in the network service path since this was disabled, and running locally (100x) doesn't show any flakes.

TBR=cmumford@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I80466b2696bd58dc35ae254e47908bad99c1c5ac
Reviewed-on: https://chromium-review.googlesource.com/1028753
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553742}

See https://groups.google.com/a/chromium.org/d/msg/storage-dev/7LPVIl2dx_M/-rQaqjCTDAAJ
for some data and discussion.

Bug: 793109
Change-Id: I342af261c094fbf26a934737b56960fb2c244011
Reviewed-on: https://chromium-review.googlesource.com/1026164Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553741}

This method is needed for positioning the find bar in Views browser mode.

Bug: 834754
Change-Id: Id984e5281bf970c0c99af8696a6cebbb8ca4c2a3
Reviewed-on: https://chromium-review.googlesource.com/1028450Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553740}

Bug: 833716
Change-Id: I7295b8db2b0904ee30f78f3bc452236fefd4f3f0
Reviewed-on: https://chromium-review.googlesource.com/1026558
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553739}

Subpixel positioning was needed because text layout was performed at 1x
device scale factor and then rastered to the final display device scale
factor leading to glyph artifacts and inconsistent glyph positioning.
With pixel canvas enabled on chrome os, the text layout is now always
performed at the final display device scale factor. This, coupled with
the replacement of ui scale with display zoom, the text on Chrome OS
is now always rastered with the correct glyph positioning and it no
longer requires subpixel positioning.

Updates unittests.

Bug: 835187,824154,716662
Change-Id: Ibcf6314321777da81335769927d65d52911855df
Component: Text render, subpixel positioning, font
Reviewed-on: https://chromium-review.googlesource.com/1027005Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553738}

When using Android J, we have to use ListPopupWindow instead of
using AnchoredPopupWindow for autofill popups. This will resolve
the problem with selection of autofill items on Android J.

Bug: 820898
Change-Id: Ic8f695468df4e31494fcd26b43a032b968f72301
Reviewed-on: https://chromium-review.googlesource.com/1023985
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553737}

A valid use case in a browser test was recently presented to me. And
while I ultimately plan to support this in ScopedTaskEnvironment as
well, it isn't for now.

R=dpranke@chromium.org

Bug: None
Change-Id: Id4197c8a8cd567c5daaf4b1b39fe8f34fb8b3549
Reviewed-on: https://chromium-review.googlesource.com/1027809Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553736}

Thread/SequenceCheckerImpl is the right type for tests that went to
verify threading correctness (even when compiled in non-dcheck builds).

This presubmit was only aimed at plain Thread/SequenceChecker usage.

R=dpranke@chromium.org

Bug: 825327
Change-Id: I04ed1351728c84a60acee9fe9103e16405992015
Reviewed-on: https://chromium-review.googlesource.com/1028352Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553735}

This is necessary for out-of-process ash (go/mustash). Eliminate a call
to ash::Shell::GetRootWindowForNewWindows(). The notification is only
shown if the primary display is an internal Chromebook display (existing
behavior) and it will now always appear on that display instead of
potentially appearing on a secondary, non-internal display.

Bug: 756082
Test: manual test on device
Change-Id: Id56a87b56fd2e51a215a2dfeecfaee2417549257
Reviewed-on: https://chromium-review.googlesource.com/1028576Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553734}

R=eroman@chromium.org

Bug: 825327
Change-Id: I34f97a20ce9d7e3f61ae58bba839d2a7d490ddcd
Reviewed-on: https://chromium-review.googlesource.com/1002657Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553733}

This change adds media controls (play/pause, close) on the
Picture-in-Picture window for desktop (OverlayWindowViews). This adds
three vectorized icons used for these controls. These are currently
rendered as white when the user mouses over the window, and disappears
when the mouse is not hovering over the window.

The intended sizes of the icons are currently hardcoded. They will be
updated when we've determined how we want them to be sized or scaled.

Future work includes making the controls accessible and handling events
triggered by keyboard or touch inputs.

BUG: 836389
Change-Id: I37987286b531c1ce1ddcf867f72510194657053d
Reviewed-on: https://chromium-review.googlesource.com/1026519Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553732}

pkasting convinced me a while back that forcing an error on these wasn't
great as it blocks refactorings, I've now hit this as well a few times
recently (uploading refactorings with --bypass-hooks and
NOPRESUBMIT=True isn't great)

Warning still encourages developers to do the right thing. While the dev's
decision to continue is unfortunately hidden from the reviewer, these
methods already being named "Deprecated" is a strong enough hint to the
reviewer.

R=dpranke@chromium.org

Bug: None
Change-Id: I29a2624e5217e743ab46799b326577d52cb29d8c
Reviewed-on: https://chromium-review.googlesource.com/1028554Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553731}

TBR=ellyjones@chromium.org,liaoyuke@chromium.org

Bug: 828031
Change-Id: I1df91e8a002d3bbb6852d5fa40cbf4b8cae2680a
Reviewed-on: https://chromium-review.googlesource.com/1028669Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553730}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/96706998..69a2f03a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I66f0dc50ffeb7e5de1c5bec3c928740115afc81c
Reviewed-on: https://chromium-review.googlesource.com/1028184Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553729}

This was introduced in the following patch as a typo:
https://codereview.chromium.org/1927803002/diff/320001/components/arc/bluetooth/arc_bluetooth_bridge.cc

BUG=727843
TEST=Run CtsVerifier and confirm that non-bonded devices don't show up as paired

Change-Id: Id50a5564257a270b62bc78c63835e194af772cce
Reviewed-on: https://chromium-review.googlesource.com/1028574Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#553728}

WebViewTests and WebViewInteractiveTests now only run for the
GuestViewCrossProcessFrames enabled case.

Bug: 533069, 544782, 627962, 796344, 807116, 818161, 818205, 829846
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic3a971b553fe343466a440ed4363389cd9e89214
Reviewed-on: https://chromium-review.googlesource.com/1000137
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553727}

The FileReaders themselves will abort once they realize the context is
destroyed anyway, so it is pretty pointless (and potentially
problematic) to start new FileReaders after the context is destroyed.

Bug: 836724
Change-Id: I7bcbdf7d7905448df794df423a3fb0fe1697dd95
Reviewed-on: https://chromium-review.googlesource.com/1028555
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553726}

This new UMA will replace
DataReductionProxy.SavingsCleared.NegativeSystemClock and add on more
enum values for all the possible reasons the data savings could have
been cleared. This will be done in a follow up CL.

Bug: 812922
Change-Id: Ibc82d187045444b6ca7812e2fc2097549501c0aa
Reviewed-on: https://chromium-review.googlesource.com/1024880
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553725}

The LSI allocators previously did not store a copy of the last generated
LSI. As a result, many call sites would have to keep their own copies.

Now that the LSI allocators have their own copies, the call sites can be
updated to no longer store a separate copy.

RenderFrameProxy is one such call site.

BUG=759031

Change-Id: Id40e679f2c41876fd7e23aa8f2e70817445be420
Reviewed-on: https://chromium-review.googlesource.com/1024747
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553724}

Currently, we reset the media ID associated with Picture-in-Picture
when OnMediaDestroyed is called, which includes when the video stops
playing. This causes crashes when we attempt to control the video from
the Picture-in-Picture window, such as play/pause and close.

This also means that even if we leave Picture-in-Picture mode, the
video media player will still show the Picture-in-Picture interstitial
because the WebMediaPlayer isn't updated with the fact we've left
Picture-in-Picture mode.

It is okay to keep the id around; when another video is PiP'd, the ID
will be updated.

BUG: 726619
Change-Id: I0e665047b85f20bc7bb9795273a5640460e7612f
Reviewed-on: https://chromium-review.googlesource.com/1026974Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553723}

The exclusion space already didn't use it, but rather returned a pure
LayoutUnit set to LayoutUnit::Min() if there was no clearance to apply.
Do this everywhere, instead of using Optional<LayoutUnit> some places.

Better have one way of saying "no clearance", than two
(Optional<LayoutUnit> not set OR Optional<LayoutUnit> set to

LayoutUnit: :Min()).
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I3a858397c28ca83ba96ae4d749f97dfa5e7b0cb3
Reviewed-on: https://chromium-review.googlesource.com/1027810Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553722}

Ozone demo is intended to be the simplest possible program that uses the
ozone API to create a window and render to it. Porters use this to see if
their platform implements the API correctly without having to build or
run the entire browser.

Ozone demo recently started using skia infrastructure for rendering via
GL. However, this arguably makes the demo less useful to porters because
it is additional complexity that is not relevant to implementing the
platform window or rendering surface.

This splits the skia demo into a new executable and brings back the
"simple" renderer that just clears the screen to a solid color.

Bug: none
Test: ozone_demo, skia_demo
Change-Id: I8570d43949d68dcf87175c53057c7c72cf45ea6e
Reviewed-on: https://chromium-review.googlesource.com/1028579Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553721}

R=amineer@chromium.org

Change-Id: Ib73b7a656694a80810402b4a3e8f078448e54e9f
Reviewed-on: https://chromium-review.googlesource.com/1028723Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553720}

BUG=773295

Change-Id: Ia199631a83a21b3210baa7741f6591875075a3b5
Reviewed-on: https://chromium-review.googlesource.com/1024992
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553719}

There was an outstanding TODO to validate that during Apply the writes
to the |new_image| and copies from the |old_image| were within valid
ranges. During raw apply fuzzing a number of memory violations occurred
this is a fix for those.

Bug: 835341
Change-Id: I669304e93e51ba7cd2b862189fbc0a6f3cea1748
Reviewed-on: https://chromium-review.googlesource.com/1028575
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553718}

Eventually these tests should be renamed to not be specific to ResourceDispatcherHost.

Bug: 787614
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5cd54463f2bf296f58bbea40b0058fa802f35d13
Reviewed-on: https://chromium-review.googlesource.com/1026703
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553717}

The function implementation always returns asynchronously - either via
an delayed task, or  BluetoothLowEnergyConnectionFinder::Find callback,
which is run from InvokeCallbackAsync

BUG=829182

Change-Id: Id85b4b13fba166d10690eb258d034aab75a46b24
Reviewed-on: https://chromium-review.googlesource.com/1022372Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553716}

This interface allows interested classes, including
AwBrowserTerminator, ChromeStabilityMetricsProvider,
OutOfMemoryReporter, and DataReductionProxyPingbackClientImpl to
distinguish between child process crashes and kills on Android.
Previously, this was done by either passing a file descriptor to the
child process (AwBrowserTerminator) or by observing whether a crash
dump was successfully produced. This eliminates the need for the extra
descriptor for AwBrowserTerminator, as well as providing a more
accurate signal for classes that relied on checking for a crash dump.

Observers can use this interface in combination with observing child
process exits/disconnects. If an observer sees a child process
disconnect without having observed a crash signal for the child, it
can deduce that the child was killed.

Bug: crashpad:30
Change-Id: I6213d31f30d15b30d2a3987fe95229042371938b
Reviewed-on: https://chromium-review.googlesource.com/1026085
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553715}

Currently if an Async Trace event was processed by early tracing it is
given the category (EarlyJava) and if the finish of that same event
happened after native has loaded and regular tracing has started then it
is given a different category (Java).

This CL fixes this bug by keeping track of all async events started
during early tracing and making sure the finish event is also sent from
early tracing.

Bug: 822816
Change-Id: Idaec00c243b9b77195b91e8409e99076be158853
Reviewed-on: https://chromium-review.googlesource.com/1024911
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553714}

Test ChromeLoggingCapabilityTest.testPerformanceLogger is not flaky anymore on Android build.
Enabling test execution on Waterfall for Android builds.

Bug: chromedriver:2108
Change-Id: Iee167f37a195385ab5e65fb20261256cd28801fe
Reviewed-on: https://chromium-review.googlesource.com/1028618Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553713}

The ChromeOS debugging instructions include a HTTP link that should be
using HTTPS instead.

TBR=jcivelli@chromium.org

Change-Id: I678027a32b9de592c4d37849c546de265e3e7d48
Reviewed-on: https://chromium-review.googlesource.com/1028659Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553712}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=msw@chromium.org

Bug: 825327
Change-Id: I508ddefd5a91415253e907811a17b7d11c818a12
Reviewed-on: https://chromium-review.googlesource.com/1024712Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553711}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=kinuko@chromium.org

Bug: 825327
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ie66f2b93d069fae255bd65750a27e2aeef819ffd
Reviewed-on: https://chromium-review.googlesource.com/1024652Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553710}

Bug: 714018
Test: CQ & run chrome on eve

Change-Id: I7f6bb7a0165d99fb1890cdaa4e893f1fbb28ff51
Reviewed-on: https://chromium-review.googlesource.com/1026417
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553709}

TBR=perezju@chromium.org
NOTRY=true

Bug: 836447
Change-Id: I8058c3f219831333b7539e5d015d825cf53620e8
Reviewed-on: https://chromium-review.googlesource.com/1028715Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#553708}

This refactor CL allows useful GPU service flags like
--enable-gpu-service-logging (log all GL commands processed) and
--enable-gpu-debugging (check for GL error after every command) to be
used when running unittests (e.g. cc_unittests) that use
InProcessCommandBuffer.

There are no security implications of this change because

- only tests use the codepath updated here (Viz and android webview do
  not)

- flags are whitelist passed to child processes (renderer/GPU processes)

ParseGpuPreferences could not easily be added as a member of
GpuPreferences because of dependencies.

  - ParseGpuPreferences depends on gpu/command_buffer/service:gles2 to
    check if passthrough decoder is enabled.

  - gpu/command_buffer/service:gles2 has a dependency on
    gpu/command_buffer/service:service

  - GpuPreferences lives in gpu/command_buffer/service:service

  - Moving GpuPreferences to gpu/command_buffer/service:gles2 seems
    non-trivial. I did not want to introduce a new component just for
    GpuPreferences.

ParseGpuPreferences did not seem to belong to gpu_preferences_util.h
because that is IPC specific.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I76db4fe0eebd3eb7720fa24265f69093715c6137
Reviewed-on: https://chromium-review.googlesource.com/1019662Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553707}