- 03 Jun, 2019 40 commits
-
-
Frank Tang authored
Instead of set the pointer to nullptr during error, CHECK the error w/ u_errorName for better diagnostic. Bug: 950322 Change-Id: I9b0c0ba0d26a375a35a8e9c5df3431398c193e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623465Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665698}
-
Lambros Lambrou authored
The host installer package was trying to run the config-upgrade tool using the wrong path to the host binary. Bug: 970029 Change-Id: I1d63c0151343ef6fa8e45c7d56663c29ef6754f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642129 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#665697}
-
Esmael El-Moslimany authored
Bug: 967793 Change-Id: I94808c1645c87c81f789bd6e8165042ae4246574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640800Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#665696}
-
Christopher Cameron authored
Rename the following classes views::BridgedNativeWidgetHostImpl -> views::NativeWidgetMacNSWindowHost views::BridgedNativeWidgetImpl -> remote_cocoa::NativeWidgetMacNSWindowBridge remote_cocoa::BridgedNativeWidgetHostHelper -> remote_cocoa::NativeWidgetNSWindowHost remote_cocoa::mojom::BridgedNativeWidget -> remote_cocoa::mojom::NativeWidgetNSWindow remote_cocoa::mojom::BridgedNativeWidgetHost -> remote_cocoa::mojom::NativeWidgetNSWindowHost TBR=ellyjones (reviewed doc) Bug: 958255 Change-Id: I5eb9dd8170a7636968da08cb554efa7f955f7022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640804Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#665695}
-
Evan Stade authored
TBR=tsepez@chromium.org Change-Id: I92c4525694b3092cb5eccac07977f8663c058c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639520Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#665694}
-
Ahmed Fakhry authored
If neither feature is enabled, only DragToClose mode should be available BUG=969815 TEST=Manually, Added tests Change-Id: Iafaab2ef36a5c1f14bfcec266c3c558145a5f7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642147Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#665693}
-
Eric Aleshire authored
The signature for the function is changed for simplicity, as there is only one callsite for this helper. Confirmed test works on EG1. Bug: 922813 Change-Id: I2684bd847e072da5f060eb8766f8e27101081c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636279 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#665692}
-
Wei-Yin Chen (陳威尹) authored
Split the forced live thumbnail capturing out of the normal caching path. The forced live thumbnail is captured as low-res, and won't be saved to the cache. This makes it faster so that using it during the Tab-to-Grid transition animation won't affect the frame rate too much. Bug: 968829 Change-Id: I32ffa8553b5aefb29944781404292a8b891d8d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637979 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665691}
-
Chandani Shrestha authored
Reland of "DevTools: Make Settings Blackboxing Pane Accessible" Initially, the change https://chromium-review.googlesource.com/c/chromium/src/+/1605506 was reverted in order to revert "DevTools: Make Preferences Settings Pane Accessible" crrev.com/c/1618170. Both of the original changes had added axe tests for it in basic-a11y-test.js which was timing out in Ubuntu build 14.04. The change here only makes blackboxing pane accessible and doesn't add test in basic-a11y-test.js. Test for it will be added in a seperate PR. Original change: https://chromium-review.googlesource.com/c/chromium/src/+/1605506 Reverted change: https://chromium-review.googlesource.com/c/chromium/src/+/1618026 Change-Id: I51f80cfec544118d6173ca8fafd1b3eff50de6b1 Bug: 963183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636728 Commit-Queue: Chandani Shrestha <chshrest@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#665690}
-
Xiaocheng Hu authored
When a text node starts with a space run that contains newlines, it's possible that the text node's inline items can't be reused in relayout due to segment break transformation rules. This patch applies the rules to check if the newline is handled differently in relayout, and if so, stops reusing the old inline items. Bug: 969089 Change-Id: I163b2542154ea79971fb13922489441873c1712b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641989Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#665689}
-
Jimmy Gong authored
- Previously, only discovered printers would show the subtext in the make/model dialog. - This change will enable the subtext in the make/model dialog for manual printers. Bug: 955130 Test: end to end manual Change-Id: If1421bc0db890bdd8e66aa93abf0dc1a4e007289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635852Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#665688}
-
Andrew Luo authored
Bug: 968585 Change-Id: Iac1fb526167a0b3ba53a418db439cfdf4f6754ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639179Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665687}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I3252bc2dd7f73716e8d16618e8e1d70c6bc4207f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642028 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#665686}
-
Xiyuan Xia authored
- Make DocumentScanScanFunction a UIThreadExtensionFunction so that API -> DocumentScanInterface -> LorgnetteManagerClient runs on UI thread; - Update DocumentScanInterface to use OnceCallback; Bug: 966178 Change-Id: I0428299174dcd949ff06b2a17fb492aef0df7349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637874 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#665685}
-
Jeffrey Cohen authored
Bug: 969239 Change-Id: I90d3d7421394e8801969eda2dbc2bcce8e6832e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641367 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665684}
-
Bruno Santos authored
Bug: 927809 Change-Id: Ibd37e6fe3ec7fc43b1ae72d3d52e695b7fd865f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641991 Commit-Queue: Bruno Santos <brunoad@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#665683}
-
Peter Boström authored
Adds a syncable extension preference for pinned extensions to keep them in sync. This is used in place of the previous "visible extensions" paradigm. Notably extensions are not pinned by default, whereas before they were initially visible on the toolbar. Bug: chromium:959932 Change-Id: I23fa0d5314317c079841540e18449646f4da9076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598818 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665682}
-
Erik Chen authored
No longer used anywhere. Bug: 965663 Change-Id: I7ea45227ff810bcb6696ce6ce50063e1e5c2be26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637981Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665681}
-
Owen Min authored
If request it too large for the server, we move to the next request without retry. If there is no more request, we notifies the accomplishment to the caller as they are succeeded. Bug: 956237 Change-Id: Ie157c8b8d884d345d4212bbc86b8ceaa76428de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639238Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665680}
-
Pavel Yatsuk authored
This change removes whitespace between list items and bottom navbar. Screenshot before (with old styling): http://screen/BMAx13oRGeP Screenshot after: http://screen/4RB0K6kaYTX BUG=959317 R=mdjones@chromium.org Change-Id: I33927472dbb7c04639c80dd4314e388a92bd39a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639352Reviewed-by:
-
Xida Chen authored
This CL has no behavior change. Bug: None Change-Id: I0efcac8a947d15e1f7b87f00d0bea0bf385c5fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641517Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665678}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d6158eea..2c63dd53 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0dfd186b16de4be6bd222c5cd1931a96b8f263f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641427Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665677}
-
Adrienne Walker authored
This should help track down why deserialization issues are failing. Bug: 945482 Change-Id: I4fcb584eeb5d4dfcc6585236657effdc0c8fb669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642027Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#665676}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4867952e90e7..c05f3d1d130d git log 4867952e90e7..c05f3d1d130d --date=short --no-merges --format='%ad %ae %s' 2019-06-03 saklein@chromium.org Build API: Automatic copying of files into the chroot. 2019-06-03 dburger@chromium.org Remove test_vm as ignored builder during config skew check. Created with: gclient setdep -r src/third_party/chromite@c05f3d1d130d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I83f033b3f7a603c29e57c589742bcceedd5278ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665675}
-
Tibor Goldschwendt authored
This Python library will be used in Chrome's Android build system to modify Java files. Bug: 968274 Change-Id: I8d5aacf4009e6b91b276ee2967f9b454523add1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639206 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665674}
-
Liquan(Max) Gu authored
This CL added a paint phase check before FCP++ text paint hook: https://chromium-review.googlesource.com/c/chromium/src/+/1634613 But the CL missed the check in some other hooks, i.e., the one in ng text paint and svg text. This CL is to fix it. Bug:967989,969318 Change-Id: Ic9dc256e08e13dbd9657b1caa9725325e6ed0931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640331Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665673}
-
Yann Dago authored
Bug: 969889 Change-Id: I0df8a98a007691a2153b67caeaea3e22ea7ccadd TBR: pastarmovj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641988 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665672}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0c9d9fc86ee7f86267649b4326fb5aba528d3ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642007Reviewed-by:
-
Esmael El-Moslimany authored
Change-Id: I074a7ff55bda151c56bd7ab4f971517bbd84ae73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636564Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#665670}
-
Sergey Ulanov authored
rebaseline_cl tool wasn't rebaselining test expectations for fuchsia because the fuchsia try bot wasn't listed in builders.json. Bug: 958017 Change-Id: I7968b22d3cc0a31f3e4a5083b7017af982100cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640796 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#665669}
-
Nina Satragno authored
Add a "Retry" button that lets the user start the WebAuthn flow over after tapping a key that was not registered. Bug: 920464 Change-Id: I01e5ce9219153c5c23f55399d5fcc9374cabd306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627933 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#665668}
-
Kelvin Jiang authored
Add the function skeleton for getMatchedRules along with types required for it in the .idl. Once again, skipping presubmit as the idl parser fails weirdly as seen in crbug.com/956368 NOPRESUBMIT=true Bug: 967942 Change-Id: I76c79e3de1c008d43474dec4cbec3a7b476f5374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639518 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1c7a411305c5..72240f63d231 git log 1c7a411305c5..72240f63d231 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 benjhayden@chromium.org Migrate spa to LitElement Created with: gclient setdep -r src/third_party/catapult@72240f63d231 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:892932,chromium:953441,chromium:965442 TBR=charliea@google.com Change-Id: Iafda08047b2b989c74b2a51664ce392aed04fd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641509Reviewed-by:
-
Mike Wasserman authored
Move the mojo interfaces to pure virtual C++ interfaces. Add a static Get() function; defined in impl w/Shell usage. Rename the implementation to *Impl; minor cleanup. Disable SpokenFeedbackTest.SpeakingTextUnderMouseForShelfItem (see Issue 921182 for more details) TBR=dtseng@chromium.org Test: No ChromeVox or other Chrome OS a11y regressions. Bug: 958199, 921182 Change-Id: I3609b83a7fc10eaa34cbe1ad3228bb42ea77909f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636857 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#665665}
-
Esmael El-Moslimany authored
The issue https://github.com/Polymer/polymer/pull/3668 was fixed in Polymer 2. We can now wrap the <style> include attribute value if the 80 character line limit has been reached. Change-Id: I77d992e260d8ce203759b9cd1015438ac427990a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639043Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#665664}
-
Christian Biesinger authored
In the block axis, we do have to do layout for {min,max,fit}-content so we can determine the intrinsic size. MainAxisLengthIsDefinite here is called from ConstructAndAppendFlexItem via ChildHasIntrinsicMainAxisSize (which needs a better name). Bug: 968940 Change-Id: If74e6098280077fefe607e2c5b1f70f133ca1032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641510Reviewed-by:David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#665663}
-
Christian Biesinger authored
Change-Id: Id653fc50ffa05b4f3e9da4415cf944c6bcbc7aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642009 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Erik Chen authored
Previously, memory metrics were collected at each UMA upload interval. This timing is context dependent. The new logic samples Chrome's memory using a poisson process, with mean interval 5 minutes on Android and 30 minutes on desktop. Bug: 895474 Change-Id: I08482648996fde7c05ab8d957479c30a4e353a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637938Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665661}
-
Khushal authored
Ping the watchdog thread for Gpu_main during strike deletion to avoid hangs on mac. R=piman@chromium.org Bug: 969623 Change-Id: I36faa00db502e1b1cf0bbda262e5aaadd96f2cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641602 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#665660}
-
Jun Mukai authored
Two methods in AssistantClient interface is actually for the communication between ash and the browser (and the comment also said so). This CL replaces those two methods by C++ along with removing the comment. - OpenAssistantSettings(); this can be replaced as a single function. - SetDeviceActions(); this comes up with the idea of having an interface for holding browser-owned objects which are used by Ash. This is the superclass of AssistantClient so it's named so. Since AssistantImageDownloder and AssistantSetup are owned by AssistantClient, this CL makes the new ash::AssistantSetup own them. With that, the static GetInstance()s are removed. TBR=stevenjb@chromium.org Bug: 958193 Test: trybot Change-Id: I2d308e1d59777b952409f0c2c9bda1392d9b5154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638179 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665659}
-
