- 25 Mar, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ffc95da474e..d8f7a94b9dd6 Created with: gclient setdep -r src-internal@d8f7a94b9dd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iaa4ee60a80762c62c117d0036afb902c22657ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119924Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753169}
-
Ehimare Okoyomon authored
Disable the relevant radio buttons when cookie settings are managed by policy. Add the managed icon and string as well. ContentSettingManaged: https://screenshot.googleplex.com/XgDzZSKDnAZ.png TPCManaged: https://screenshot.googleplex.com/woXqLqAsqVX.png Bug: 1060118 Change-Id: Id896af4fc842795c123ed4b626278d36cf8db6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106584Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#753168}
-
Martin Šrámek authored
Since the corresponding setting was removed during the privacy settings redesign. We also back up its old value in case the redesign is rolled back. See https://docs.google.com/document/d/1gJVRKDO14ztyPyqiQpYKXPhmHyu9AgDh9v2nzd7yWaQ/ for the background. Bug: 1062698 Change-Id: I25cfddaec4646d2a588855c81cad36bfa6a5c590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107986 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#753167}
-
Kinuko Yasuda authored
Examples: https://test-results.appspot.com/data/layout_results/Linux_Tests__dbg__1_/87734/blink_web_tests/layout-test-results/results.html https://test-results.appspot.com/data/layout_results/Mac10_13_Tests__dbg_/17624/blink_web_tests/layout-test-results/results.html TBR=npm@chromium.org Bug: 1062984 Change-Id: I48c5ee507812447f4e8089aeb6d2086d430ed25a No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119779 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#753166}
-
chrome://settingsVictor Hugo Vianna Silva authored
Feature kEnablePasswordsAccountStorage disabled: https://screenshot.googleplex.com/AaNqS7OxpNw Feature enabled, user not opted in: https://screenshot.googleplex.com/RBR6E3yzmkk Feature enabled, user opted in: https://screenshot.googleplex.com/4GbzCGPeddp On click of the opt-in button, a reauth flow will be triggered. On click of the opt-out button, no reauth is triggered. The UI is only temporary and will be updated once mocks are available. Bug: 1049141 Change-Id: Iceb293f3809e8995056a7c36989a6abeb462db62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108030Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#753165}
-
Eriko Kurimoto authored
This CL adds upgrade-insecure-request wpts to test static-import from dedicated workers and shared workers. The test scheme is implemented in the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2102036. This CL only removes 'worker-import' and 'sharedworker-import' from the excluded subresource list in spec.src.json and auto-generates tests. Bug: 989399 Change-Id: I3b799d7743306a8b5fca0d7292360a88d9b36ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117591Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#753164}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b867e14cac14..0eff2a2b463f git log b867e14cac14..0eff2a2b463f --date=short --first-parent --format='%ad %ae %s' 2020-03-25 jiawei.shao@intel.com Add validations on the creation of bind groups with storage textures Created with: gclient setdep -r src/third_party/dawn@0eff2a2b463f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I048a7396eb511a87316205660b56c7487656d565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753163}
-
Mark Cogan authored
This CL updates the overscroll controller delegate protocol to also vend the fullscreen controller for the tab that's overscrolling. The delegate protocol already vends several other UI-specific objects, so this is in keeping with the existing protocol responsibilities. The OverscrollActionsControllerDelegate methods are also all updated to consistently follow ObjC style, passing the delegating object as the first argument in all cases. Since the OverscrollActionsController now gets the fullscreen controller from its delegate, there's no need for it to have a browser state injected, so that property is removed. Bug: 1063521 Change-Id: Ia42da793584d49225486887108403dd93022080d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116234 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#753162}
-
Nick Diego Yamane authored
Segfaults were observed when running under Wayland compositors that do not advertise primary selection protocol extension objects. For now, Ozone/Wayland supports only gtk_primary_selection version 1, which is likely not available in some compositors, such as, weston, sway, etc. This fixes the crashes by properly handling cases where the gtk primary selection protocol objects are not in place. R=msisov@igalia.com Bug: 1064410 Change-Id: Ia90b423208e64919f717442309a4c92cdb6749a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118237Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#753161}
-
Wei-Yin Chen (陳威尹) authored
Also update the default parameter of zooming-min-sdk-version to M. Bug: 964406 Change-Id: I90d35c365b690d788a6284a610a3828334e98cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114392 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753160}
-
Mathias Bynens authored
DevTools front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119672 Once that CL lands and rolls into Chromium, we can re-enable the test with its new expectations. Bug: chromium:1051186, chromium:1051822, chromium:1057096 Change-Id: I2bf3fff8443f96d3fcdc7b2e00fb721240f06b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119533Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#753159}
-
Wenbin Zhang authored
This CL added a argument for process_perf_results to allow skipping upload the results to perf dashboard. It is needed in the future when tester will skip the uploading step. Bug: chromium:1045256 Change-Id: I505dcf5625a193d030b44924f51fb51738a678a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113804Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#753158}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb656b90. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I62ffee94d8011f098ed3ecaa0f04878bc483fa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119835Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753157}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I00767e6e2df81b9ec3fe674cc2d31c0f0dca9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119921Reviewed-by:
-
Finnur Thorarinsson authored
The order of decoding is determined by a few things, which (if all else is equal) falls back on creation time (Date() timestamp) to enforce FIFO decoding. However, the granularity of that is milliseconds, so back to back requests occasionally have the same timestamp and then the decoding order is no longer deterministic, which messes up the tests. This CL removes the timestamp and replaces it with an ordinal, to ensure FIFO order for identical requests. Bug: 1054520, 1054502, 656015 Change-Id: Ia745548619f866b53dc7e9071c191eea6d4d1fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116055 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
dpapad authored
Given that JS Modules based tests no longer use |extraLibraries| to pull in dependencies the definition of most tests classes looks identical and can be automated with a for loop. Tests that are still defined individually are either - enabled/disabled conditionally on some platforms - make use of |featureList|, runMochaSuite() or mocha.grep() Bug: 1026426 Change-Id: Id13f2ba71487ca3031310db21a2b0f6bea9fb0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116929 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#753154}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a65af2905412..2ffc95da474e Created with: gclient setdep -r src-internal@2ffc95da474e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9c75bb469c05fdf623d8ca8ca0d0f30ceb8350bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119919Reviewed-by:
-
Simon Que authored
This builder was accidentally migrated in crrev.com/2117552. It was added between the original CL and the reland, and hence was silently included in the migration because the try builder def function set goma_backend=RBE_PROD by default. This will be properly migrated at a later time. Bug: 950413 Change-Id: Ib955db5dfae5e15a1bef466f703ea9ca7e5c6b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120120Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#753152}
-
Mark Cogan authored
Removes the unused RelaxedBoundsConstraintsHitTestSupport protocol and references to it in OverscrollActionsController. Change-Id: If4fb0ea6ad8a01ee82af2f91b4b75aa1dac728c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117115Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 1012975 Change-Id: Id5ad8e66deda9819e54b656a1b27b1906c849052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114397Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ec90f4c93f6..9686528ac8c7 git log 8ec90f4c93f6..9686528ac8c7 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6af71a8d..772d2084 (401 commits) 2020-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6fead3754375..107e4e989e94 (7 commits) Created with: gclient setdep -r src/third_party/skia@9686528ac8c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I164cd4b498deda038f30a85c77f3c286036c6c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119918Reviewed-by:
-
Minoru Chikamune authored
Bug: 1049056 Change-Id: Ibe54904d5e4bb688eb3d67ce13aa4291a737fb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119458Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#753148}
-
Miriam Polzer authored
Previously, get ChannelInfo() was obtaining the version of the current channel and was checking from policy/profile whether the user can modify the channel. Sometimes, when the update daemon was slow, the ui will not receive the data if the user can modify the channel, leading to it being shown by default and then, disabled. Old CL: https://crrev.com/c/1831769 Bug: 848750 Change-Id: Ia0aa6d3353e2e6c310642865f4dc437c9d449c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106852 Auto-Submit: Miriam Polzer <mpolzer@google.com> Commit-Queue: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#753147}
-
Noel Gordon authored
If the pointer is down anywhere in the app, hovering over the splitter bar or its child button shows their :hover effect even though they are not active and a resize-cursor as well. Block their hover and resize-cursor effect if the splitter is inactive (files-ng) so the splitter looks inert (aka non-interactive). Bug: 1062902, 1002790 Change-Id: I3fa170ea27682f52cc49ffe5d57bd2038c17d0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119463Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753146}
-
Anastasiia Nikolaienko authored
Bug: 1043108 Change-Id: Icdcd8d35a5fa1b0452d29ab666e3983ad46a006a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100939Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#753145}
-
tby authored
We've got a lot of dead code in search_result_ranker* from now-disabled experiments. I'm going to go through and clean it up, starting with the category and query-based mixed-types models. Bug: 1028447 Change-Id: I93f5d050df33d72ee4a1ce6362db87d8ee8ad1e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117915Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#753144}
-
Alex Danilo authored
Sets the end margin for the clear icon in the search box to 6px to align the end of the search box wrapper with the touch target. Increases the width calculation for the search wrapper to allow for the changed margin end change and keep the search wrapper width at 288px. Increases the width of the cr-input for the same reason as above. Bug: 1064514 Change-Id: Ic1e0ba7f31adef6f9b2230455ac8edd3bd5e54d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120111Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753143}
-
Ken Rockot authored
These were disabled across the board due to TSAN failures. They were also previously disabled specifically in low-end Android test environments. The low-end test bot that originally produced failures is no more. The TSAN failures also appear to be gone according to local testing. This attempts to turn the tests back on so we can see what happens. Bug: 626299,769903 Change-Id: Id75acf5948e45b72c714af31af74507987f2078f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119110 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#753142}
-
tby authored
Currently we have presubmits that check the structured metrics XML file is well-formatted (doesn't have duplicated metric names etc), but these only run when you `git cl upload`. It would be better if an invalid structured.xml file caused a compilation failure, because it will lead to confusing bugs when testing locally. This CL expands the compile-time validations to cover the cases currently checked only via presubmit. Bug: 1016655 Change-Id: Iec71eb7db629e566c10c7c997e509a5824373fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120070Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#753141}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d588fbe8cd72..a65af2905412 Created with: gclient setdep -r src-internal@a65af2905412 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033098 Tbr: jbudorick@google.com Change-Id: I62e48f21ead9a3a7ba894892bb7efcf030b656a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119915Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81c8f4b8027e..8ec90f4c93f6 git log 81c8f4b8027e..8ec90f4c93f6 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6c11cf2ad9ca..540bdf92531d (2 commits) Created with: gclient setdep -r src/third_party/skia@8ec90f4c93f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I03864795c66ce29a32c0edf23a5412ef9571ac76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119916Reviewed-by:
-
Bugs Nash authored
The Media App (currently behind a flag) requires FileHandling to be enabled to work. This patch removes the need for users to explicitly enable the FileHandling flag as well when enabling the MediaApp flag Bug: 1030935 Change-Id: I088466129a68b455e4b05793a98cbf2849a6cd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108242Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#753138}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f151e19. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2b6c0e69a544d73fddc100e7663f3f7ca4f6dcdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119552Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0800d29473f..107e4e989e94 git log d0800d29473f..107e4e989e94 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 ynovikov@chromium.org Lift SwANGLE dEQP-GLES3.functional.fbo.blit.conversion.* suppression Created with: gclient setdep -r src/third_party/angle@107e4e989e94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I7ee95b29b7cb444f9f2336a3be50897dbeebb5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119912Reviewed-by:
-
Brian Sheedy authored
Re-enables the BrowserMinidumpTest tests on Linux and the CrOS amd64 emulator, as the flakiness that caused them to be disabled should be properly attributed to the correct test now that pre/post test minidump checking has been enabled. Also fixes the test failing locally under certain GN arg configurations that caused the crash signature to change a bit. Bug: 1056235 Change-Id: I74c7407e8ded26652cf8fa833c5e11bd2dca9f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118576 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#753135}
-
Yuzu Saijo authored
This CL filters out RenderFrameHostImplBrowserTest.CheckIsCurrentBefore AndAfterUnload, which is failing deterministically. Bug: 1062923 Change-Id: Id016e1f79c8eb63fb8b977862f38d18d2d08d2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109513Reviewed-by:
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: I1233f791280d3b7aa56b7ee6713ebb2886fa6048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119348 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
nancy authored
Move LaunchManager's two functions to launch utils: GetLaunchFilesFromCommandLine CreateNewTabBrowser Follow up: 1. Move ExtensionAppLaunchManager's function to extensions, and remove ExtensionAppLaunchManager 2. Modify web_app::WebAppLaunchManager to remove the dependency on LaunchManager. 3. Remove LaunchManager. BUG=1061843 Change-Id: I29e333a4ef686ab76edee846cf35228ac55e5074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117930Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753132}
-
Maggie Cai authored
This CL adds the functionality to delete all entries with the given app id from the preferred app list. This CL also migrates the unit tests from the original preferred app tests. BUG=853604 Change-Id: I475c0c2776c7c2723b7cfdcdfb4a9dccd2ddcbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117141Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#753131}
-
Luciano Pacheco authored
Reduce the size of the input inside the <cr-input> to avoid long text to run over the "clear button". Bug: 1061311 Change-Id: I281d2388eeadb5001ac35b1b6dca14c301f437fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119340Reviewed-by:
-
