- 15 Dec, 2020 40 commits
-
-
Charlie Hu authored
Previous fix(https://chromium-review.googlesource.com/c/chromium/src/+/2181318) on uninitialized frame policy in javascript url navigation does not include a test case because it is a security fix. Since the fix has landed in M84 which is stable right now, this CL adds the test case for the fix. Bug: 1074340 Change-Id: Ia10a972183b02cdac28a2f29cabb7f13caf168e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297708 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#837169}
-
Ben Pastene authored
Change-Id: I5aaa8cc34eb8b660a894d08f8a47e4a39569249b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591452 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#837168}
-
Curt Clemens authored
Set a width for the cr-lottie element on the discovery page to avoid inconsistent rendering on different devices. See crrev.com/c/2587209 for the same fix applied to a different page with screenshots. Fixed: 1158586 Change-Id: I2b4018f833ee298ee182b4d26667e8586bf1356d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591871Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#837167}
-
Andres Medina authored
Bug: 1158622 Change-Id: Ic0da2e0942d030478b2c7570ee920f35cba63ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591908 Commit-Queue: Andres Medina <medinaandres@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#837166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/867d99d33c4f..97752ea021f7 2020-12-15 ddoman@chromium.org [resultdb] move cipd pin of infra/tools/rdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1150844 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I1221dbf39caffc6283d21a205572dc238a490c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593440Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837165}
-
Nick Burris authored
* Create ExternalAuthGoogleDelegate, owned by ExternalAuthUtils, which will be used to implement isGoogleSigned downstream, rather than doing so with an overriding subclass. * This is patch 1/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2587429 except ExternalAuthGoogleDelegate is not yet used in ExternalAuthUtils. That part will be implemented in the following chromium patch after downstream implements ExternalAuthGoogleDelegateImpl. Bug: 1154371 Change-Id: I4fd71fb81f6999be7eb26cfcb0cc121ce38f4590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593748Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#837164}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 34 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-03-15. TBR=chromium-metrics-reviews@google.com Change-Id: I9bd5a60744b3847f9533e76f90fe37811d86fda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593569Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#837163}
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2584978 Re-enable tests CL: https://crrev.com/c/2587035 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k Change-Id: I55a64e334d385338206fab77d75ea75b5d3f041a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592797Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837162}
-
Eric Lawrence [MSFT] authored
Deprecated macros should not suggest using them. Bug: 1010217 Change-Id: I31eb11f3ac54d7fb92566ae5f4ea1cda9a01c714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591749Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#837161}
-
Joe Mason authored
Adds a browser-side security check that the frame making a performance.measureMemory request is allowed to use the API, to guard against compromised renderers skipping the renderer-side security check. Currently it only checks that the frame is same-origin with the page's main frame. Once an accessor for crossOriginIsolated status is added on the browser side, the class can check that too. R=fdoray Bug: 1085129 Change-Id: I73b1955dafa0dec248e86783aee4e8d8e4cdcda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588249Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#837160}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0eb7753ae75..7e6afd2c7e30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbroman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1114792,chromium:897470 Tbr: jbroman@google.com Change-Id: I0f7fe0e8f94ea5217d2c512414470366e3f508e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593435Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837159}
-
Markus Handell authored
This change makes AVFoundationCaptureV2 accessible from chrome://flags via the zero-copy-video-capture flag so that the feature is togglable by consumers in the UI. Bug: 1127791 Change-Id: I59e960e9e025c416986ff68d8adcb573c50c5a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584981Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#837158}
-
Robert Ma authored
Upstream WPT has recently upgraded to pytest v4: https://github.com/web-platform-tests/wpt/pull/26704 Also take this chance to upgrade some other wheels used by WPT to the latest we have in CIPD, and remove a duplicate psutil spec. Change-Id: I102fd4b6717fdb1b778f92933afb4c7cf74f834a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592134Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#837157}
-
Yi Gu authored
Bug: 1148570, 1152282 Change-Id: If44349170f9670f080fc04a8ad4c18fa041a4392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593549 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#837156}
-
Anatoliy Potapchuk authored
This CL adds a new policy ManagedConfigurationPerOrigin, which will contain the links to the JSON key-value configuration for applications. We also add a new KeyedService, which which is responsible for processing of this data and storing it on disk. Bug: 1141849 Change-Id: Ieb37c7b9462bdac1b1cd48132af0d3a27f4e51ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577679 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#837155}
-
David Schinazi authored
https://quiche.googlesource.com/quiche.git/+log/fc51e436c68c..875334114827 $ git log fc51e436c..875334114 --date=short --no-merges --format='%ad %ae %s' 2020-12-14 ianswett Move CheckBandwidthGrowth in QUIC from Bbr2Startup to Bbr2NetworkModel. No functional change. 2020-12-14 mattm Internal QUICHE change 2020-12-14 ianswett Move the call to AdaptLowerBounds so it's called on every congestion event. It already exits early if it's not the end of the round, so this is not a functional change. In preparation for cr/305164640 2020-12-11 bnc Parse ACCEPT_CH frame in HttpDecoder. 2020-12-11 bnc Remove SpdyFrameType::MAX_FRAME_TYPE. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=renjietang@chromium.org Change-Id: Ib79d3dc0ddce020d1831902cbd097cd83c38f67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592150 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837154}
-
Nigel Tao authored
This is a test-only change. See crbug.com/1132828 for the rationale. Bug: 1132828 Change-Id: I8226bdd79012e1fb2cbe85d7a8c188846ace091a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584204 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by:
Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#837153}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f42fa3f3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ifa51c453dbac05f89829caa8ec2f1c180057b59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592135Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837152}
-
Yaron Friedman authored
BUG=783819 Change-Id: I45975dff6acc8a753aec5ac20ad658c96ad5e24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587459 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837151}
-
Xida Chen authored
This CL converts three base::Bind to base::BindOnce in this file. The function that takes the callback is already expecting a OnceCallback, so converting to base::BindOnce seems to be the right choice. Bug: 1152278 Change-Id: I0ed76be834d516ccdcb20200b30f172fa41f385a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592012Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837150}
-
dpapad authored
Bug: 1000989 Change-Id: Ifd726a85b530c9dbb31e5bbe7ff4c3b4f64f6094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589456 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#837149}
-
Xida Chen authored
This CL converts base::Bind to base::BindOnce in this file. The function is already expecting a OnceCallback so using BindOnce is the right choice. Bug: 1152278 Change-Id: I168b2049878b43cef21065a5bf6825ddfa64e68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593469Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837148}
-
Jérôme Lebel authored
Chrome can be started with the 2 following events: + Open the sign-in upgrade promo + Open an URL (from an external app) The opening the URL interrupts the sign-in promo, while its view controller is not fully presented yet. This patch prevent from the coordinator from dismissing its view controller before it is fully on the screen. Fixed: 1126170 Change-Id: I03287c9f830f650c10aa2476d6d693af3783c553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593107 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#837147}
-
Matt Menke authored
Wire NetworkIsolationKey through DomainReliabilityContext. This is the interesting CL of the bunch. To keep things simple, it keeps all pending beacons in a single list with a maximum size, even with different NetworkIsolationKeys. To upload a report, it selects all beacon with the same Key as the first (oldest) beacon and creates a report using them. On successful upload, it will remove just those beacons, and try to upload again (with backoff), if any beacons are left. This CL also adds some eviction tests, and removes some incorrect eviction DCHECKs, which assumed that all beacons currently being uploaded could not be evicted. That may be unlikely, but there's nothing from preventing it from actually happening, and it may be more likely once only beacons with a matching NIK are uploaded each time. Bug: 1138994 Change-Id: I37d97b679cc0309c5e128c239585555ab097369b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587669 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#837146}
-
Xida Chen authored
This CL converts the base::Bind to base::BindOnce in that file. It is a code health CL, no behaviour change is expected. Bug: 1152278 Change-Id: I5524c86ea0e9a58c2beb87c224d0d220630dead1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593747Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837145}
-
Sam Maier authored
This reverts commit 0f312f10. Reason for revert: Downstream fix has rolled Original change's description: > Keeping CastOptionsProvider to avoid crash. > > Bug: 1157603 > Change-Id: I04bf94d2e2d758cd871d5328513de135c2e155de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585843 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836743} TBR=mfoltz@chromium.org,mlamouri@chromium.org,zqzhang@chromium.org,tguilbert@chromium.org,smaier@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I725e928b3d5bce99df9a587e014e1ceb07f04892 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593452Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#837144}
-
Yi Gu authored
[CodeHealth] Convert c/b/ui/views/extensions and bookmark from base::Bind and base::Callback to Once/Repeating Bug: 1152282 Change-Id: I9b557a75a039844183ee49eae868036fa1cfa072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592248Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837143}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6df594ecc557..a885fded8b30 2020-12-15 pmalani@chromium.org usergroup_baseline: Add user typecd_ec to cros_ec-access 2020-12-15 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-15 saklein@chromium.org portage_testables: Fix DEPEND/RDEPEND quoting. 2020-12-15 saklein@chromium.org portage_testables: Add Package.package_info. 2020-12-15 mmortensen@google.com BundleDebugSymbols: Initial api/controller implementation and test. 2020-12-15 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-15 saklein@chromium.org Build API: Prevent entering the chroot for mock/validate calls. 2020-12-15 saklein@chromium.org lib/depgraph: Add functions to generate some common depgraphs 2020-12-15 vapier@chromium.org gs: ls/acl/rm: extend to support multiple paths 2020-12-14 sfrolov@google.com cros_sdk: Make fstrim run in background 2020-12-14 benreich@chromium.org uprev_lib: Avoid committing Manifest if package does not have one 2020-12-14 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I1ccd48753a9918630a14089f8fef0f710e576231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593668 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837142}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Jd9IBDXrEmKkgb_A4oF9p3iMEi3gg3iptnwf_dbG_RgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ia2da8ce09acf58e915e7b910c949cd77dca285e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593669Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837141}
-
Fredrik Söderqvist authored
When an HTMLImageElement's 'src' is set to the empty string, the state of the image request will be 'broken', and thus the promise should be rejected with an InvalidStateError exception per the rules at [1]. Move the intrinsic size check below the image existence check, and use a more direct method of getting at the size (no need to go through the BitmapImageSource interface when we're already fiddling with internals). Also add a check for IsLoaded() to better match the spec wording 'fully decodable'. [1] https://wicg.github.io/shape-detection-api/#image-sources-for-detection Bug: 789511 Change-Id: I69ac4a9081cfff7f9c7c8f7edf39667e3dd1eb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587165Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#837140}
-
Andrey Logvin authored
It was missed at https://crrev.com/c/2584603 Bug: 1155269 Change-Id: I7e0ac2e75210d909cba3905b2fae1aa39dbeeb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592997 Auto-Submit: Andrey Logvin <landrey@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837139}
-
Joe Downing authored
This CL adds a flag which will allow the website to request the 'elevated' It2Me host (with the UiAccess manifest value) is used instead of the base It2Me host which does not have access to elevated windows. The flag is overridden by the Chrome policy so if a network admin has specified that they do not want to allow elevated remote support hosts, this new flag is ignored. Change-Id: Ic84968f432db6ab041a5b4afdc38a2ac7be27a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586967 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#837138}
-
David Bienvenu authored
When session restore rebuilds the session restore commands, it was losing the workspace because it wasn't adding the workspace command to the list of rebuilt commands. This is most noticeable if you have a lot of windows open on different workspaces/virtual desktops. This CL also makes BrowserDesktopWindowTreeHostWin update the workspace on ::Show, if the workspace isn't set. This makes opening a new browser window immediately update the workspace, so it will be restored on session restore without the user having to focus the window. Bug: 1150225 Change-Id: I38ab861147041f4557e5ae8b62ec0c04763f1f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585990 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837137}
-
Peter Johnston authored
This change crrev.com/c/2380329 added an index to the interface name, following this now-deleted comment: // Interfaces with more than one IPv6 address will yield multiple // NetworkInterface objects, with friendly names to distinguish the // different IPs (e.g. "wlan" with three IPv6 IPs yields wlan-0, // wlan-1, wlan-2). This comment was incorrectly describing the previous behavior, and clients relied on `interface_name` not including an index. Bug: b/171599542 Bug: fuchsia:21155 Change-Id: Ied6972f15546a8f022f486e8c049bdf1dfb1e819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586317 Commit-Queue: Peter Johnston <peterjohnston@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#837136}
-
Andrew Grieve authored
This reverts commit 06e0fcb1. Reason for revert: No longer necessary. Original change's description: > Android: Fix cronet proguard failure when enable_chrome_android_internal=true > > Tested that all targets now build via: > autoninja -C out/Release $(build/android/list_java_targets.py --proguard-enabled) > > Bug: 1155547 > Change-Id: Ie32d62e108778c219a190e363be9c82b747a2a02 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574597 > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833824} TBR=pauljensen@chromium.org,agrieve@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1155547 Change-Id: I0361ac731d01e97012e21547201969cb3a492cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593769Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#837135}
-
David Maunder authored
FilePersistedTabDataStorageTest: 6744 ms -> 2003 ms (70% improvement) PersistedTabDataTest: 1621 ms -> 178 ms (89% improvement) Bug: 1158487 Change-Id: Ibe1c998aa4269955582c4a3d0548f61f5e939e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590344Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837134}
-
Jarryd authored
Bug: 1158461 Change-Id: Ifcf9beca09381e26f866f57c4be6a22225b2cccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590710Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837133}
-
Henrique Ferreiro authored
This is a reland of 1208732e Original change's description: > Remove unneeded CursorLoaderWin::SetPlatformWindow calls > > SetCursorNative is only called from WindowTreeHost::SetCursor, which > guarantees that the platform cursor has been set. > > Bug: 1097556 > Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810120} Bug: 1097556 Change-Id: I89b742a80ddd9fee7a77b5af1bee07b58c18f39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445550Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#837132}
-
Jarryd authored
Replace deprecated DISALLOW_COPY_AND_ASSIGN macro with deleted copy constructor and assignment operator on the base class. Change-Id: Id6ce85518a1db717784a9a6d5f38ea2f191a1d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590691Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837131}
-
Aga Wronska authored
Shows setup for Family Link users on tablet and clamshell if the device supports PIN for login. Does not change the behavior for other users. Bug: 1156890 Test: PinForLoginSetupScreenTest Change-Id: I2e1f8a29ae6fa2739ee57ade6f1351d46254da48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580402Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#837130}
-