- 06 Nov, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abc1b79a1564..41bb19c60930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ife96b3fd197f0dda10db78ad40757f5c96b0d618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523014Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824808}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b665312ca15..0891c367b8b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3268aab08638f3aafe9bd93734c83d7d4c95e281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824807}
-
Mathias Carlen authored
Add a TabHelper feature to the list Autofill Assistant features. This feature is about restructuring ownership lifecycle relationships in the Autofill Assistant stack. Bug: b/169389571 Change-Id: Ic59d239adf25cad574b075d4f6aba616af4ae972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521146Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824806}
-
Gauthier Ambard authored
This CL makes sure that the WebView is no longer in the view hierarchy when the quicklook screen for AR is presented. When the WKWebView is added/removed from the view hierarchy, the visibilitychange event is fired. Bug: 1132085 Change-Id: I4043a4d3e5e24dc52aa467a82c7a62e78dd8a492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463567Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824805}
-
Javier Fernandez authored
As per Unicode UAX#9 L1.4, line trailing whitespaces should always have the direction of the paragraph no matter the direction they had before line breaking. To accomplish that, in inline layout algorithm CreateLine, when an NGInlineItemResult is only trailing spaces, we ignore the bidi level coming from the NGInlineItem, and just use the base direction of the line. This should fix the case of an LTR line with trailing space and pre-wrap in an RTL line that would end up putting the trailing space to the right of the last LTR line instead of to the left of the line. This fixes css/css-text/white-space/eol-spaces-bidi-002.html with width of 7 characters. It is still not fixing the case for 8 characters. Bug: 316409, 1142926 Change-Id: Iab220f79ba0b2526fd51d5341363cc8e9087e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505486 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#824804}
-
Egor Pasko authored
The useSharedRelros() was renamed into provideSharedRelros(). Update stale comments to match the new name. No functional changes. Bug: None Change-Id: I278f1eccc650a24957a28825ffe4b107bda74577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521176Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824803}
-
Side Yilmaz authored
This CL removes deprecated GetLastUsedProfileKey function, while replacing last occurrence of the function with GetLastUsedRegularProfileKey method. Since both regular and off-the-record profile use the same offline content aggregator, it is safe to use regular profile in the factory class. Note: This CL does not change any code behaviour. Bug: 1041781, 1075562 Change-Id: Ida23b329e1f4da6ad37abefea7a49e6c4575420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519454Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824802}
-
Stanislav Pikulik authored
Unlike CLang in GCC with libstdc++ the expression std::max(alignof(T), sizeof(size_t))) is not recognized as an constant expression, which leads to the following error: requested alignment is not an integer constant. Bug: 819294 Change-Id: Ia1cad4d4b29b22960a7a824216f3d32d228f69cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521116Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#824801}
-
Yunke Zhou authored
Bug: 1134567 Change-Id: I8b278acaa2fab943ce136d7d7de578da7a63e992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520778Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#824800}
-
Findit authored
This reverts commit 37c7a793. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 824767 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM3YzdhNzkzMTA0NjU2ODAyYjRhNjkxNWYwYWI0YTRlZGQwNTY2YzkM Sample Failed Build: https://ci.chromium.org/b/8864392849428929040 Sample Failed Step: browser_tests Original change's description: > Put logic to disable Lite video on seek behind finch > > This CL moves the logic to disable lite videos on seek > behind experiment parameter, and also disables that by default. > > The param can be enabled again once we are reasonably confident > that it's not too aggressive and we can run an experiment to > verify that. > > Change-Id: I950b6d42750f11156ba0f0afad5989ac19832a7b > Bug: 1145646 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519719 > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824767} Change-Id: Ia1e4c0a2239fe64b3073ad3ebd5806cc41cfb51f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1145646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522621 Cr-Commit-Position: refs/heads/master@{#824799}
-
Peter Marshall authored
This CL plumbs in everything needed for a new HaTS Next survey that DevTools trigger. The survey config doesn't exist yet so this CL won't cause surveys to be shown yet. Bug: 1112738 Change-Id: I2ccd087ad510f849616bf567a14a96aa8f0f439b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517719Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824798}
-
Mikel Astiz authored
By enabling this feature by default, it will cause that small fraction of users redownload all their sync bookmarks, in order to determine their authoritative/final GUIDs. With this, the migration phase is considered complete and bookmarks are guaranteed to use the same GUID across syncing devices for all users. Metric Sync.BookmarkModelMetadataClientTagState suggests the majority of sync clients have knowledge of all authoritative bookmark GUIDs, first introduced in M81 and gradually being populated in the commit path with https://crrev.com/c/1981610. For the remaining few clients, it may take very long to receive the authoritative bookmark GUIDs, presumably due to inactive users or users that have just upgraded from old versions of the browser. To resolve this faster, the alternative is to redownload all bookmarks from the server (including their authoritative GUIDs). This is precisely achieved with the feature toggle enabled by default in this patch. The actual impact of this change will be measured using metric Sync.BookmarksModelMetadataCorruptionReason bucket MISSING_CLIENT_TAG_HASH, which prior to this patch was dominated by the soft counterpart of this logic, already enabled by default (feature toggle InvalidateBookmarkSyncMetadataIfClientTagMissingWhileInSync). Change-Id: Id9957b420e78f5f8d4f1dbd6a5853cf14c31d560 Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#824797}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604609790-b9d65003227996f3e38071970a83664b74f65abb.profdata to chrome-win32-master-1604629242-25a4011689f36cdb7c5ac3ab0a40a3994e18267e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7a2604b855566115216172bbd36688e3fc2ed035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522952Reviewed-by:
-
Mugdha Lakhani authored
Bug: 1144282 Change-Id: I06463b63fdcf1da40816a5c8fba014ff67bdd2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521148 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#824795}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I8a4f3a027e7dcf494777cf80b52eab2a90b55c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522690Reviewed-by:
-
Clemens Arbesser authored
This also refactors some of the calling methods to use GURL in favor of plain strings. Unfortunately, the browse_domains_allowlist is currently specified in an incompatible format without the http spec, so those are still plain strings. Bug: b/171776026 Change-Id: I4774209f71eef1b2ec6e5e8580d173e06bcd9ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517447 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#824793}
-
Alexander Cooper authored
Adds UseCounters and the necessary flag integration to conduct an origin trial for WebXRLightEstimation. The Origin Trial itself will not be enabled until after the I2E and the launch bug have been approved. I2E: https://groups.google.com/a/chromium.org/g/blink-dev/c/zt3gLmrhTHc/m/9jxodKr5CAAJ Bug: 1070819 Change-Id: I40f7de94cda4189445bce6996928619fc15f1d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522123 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#824792}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 52d33a46. With Chromium commits locally applied on WPT: 9a749c24 "[scroll-animations] Handle implicit 'auto' offsets correctly" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ifa4ef2138c9d62a2c360f46a8fc2a98ce94fa3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522231Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824791}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c2b2b5788575..a61d07a72763 2020-11-05 46493288+sfricke-samsung@users.noreply.github.com spirv-val: Fix SPV_KHR_fragment_shading_rate VUID label (#4014) 2020-11-05 46493288+sfricke-samsung@users.noreply.github.com spirv-val: Label Layer and ViewportIndex VUIDs (#4013) 2020-11-05 alanbaker@google.com Add dead function elimination to -O (#4015) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ic15c1ac4475321f5f2becc834cf77370ed9a5d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523015Reviewed-by:
-
Jordan Demeulenaere authored
This CL refactors ElementFinder so that the elements it matches have the same order than in the document. This is done with 2 changes: 1) Elements matched by the css_selector filter are now added in the same order than the parent element that was used to query the selector. 2) The results of the background tasks are now added in current_matches_ in the same order than the parent element that was used as the root of the background task. I will add relevant browser tests once we can easily check multiple matching elements (i.e. either via a new pick_at filter or getting the outerHTML of multiple elements). Change-Id: If1f7098d3467461a39a3b34773f1e02db0a73069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517577 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#824789}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0f76c73eff05..e9554189c71b 2020-11-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If1f35bdd0ecc548c4f9a0dd451576f60d3f2095b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522687Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e97171d2..24c7b2d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I954658d06f15af89b4381cabbb78390d6ea439bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522163Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824787}
-
Rakina Zata Amni authored
This allows us to experiment with having multiple bfcached pages in one tab. Bug: 1136658 Change-Id: I3bffb186cad637dbac6e05595e9e8eeb56ec70af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518313 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824786}
-
David Roger authored
This CL uses overflow-wrap: break-word; to avoid breaking the bubble layout. This should happen very rarely. Screenshot without the fix: https://drive.google.com/file/d/1SLsl065XjOnZGNt9Y8f3ymjdKUvTcMhK/view With the fix: https://drive.google.com/file/d/1SsJ5OnBA9cpHRCESRfbETA7fGfupdiLX/view Bug: None Change-Id: Icaf3e99abf1c6119b0c8e3f47b8ad263d6d58d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520905 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#824785}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604620781-8baad16a8ee2321f3de713350b41c3a35b5f14db.profdata to chrome-linux-master-1604642156-a25919d317c2bef6f3d61358a8f8892267c9f548.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2cd1529be77794c6f1a0a18dfd4d4e80a8c51407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523013Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3fee63a19d6..8b665312ca15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0cad7d7744c26698270c300eb2473208b8d48f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522161Reviewed-by:
-
Kenichi Ishibashi authored
This CL moves MakeSelfOwneReceiver() for resource reader/writer from ServiceWorkerStorageControlImpl to ServiceWorkerStorage. This move allows us to call LazyInitialize() if the internal storage hasn't been initialized yet. This behavior simplifies service worker storage service recovery steps because it would eliminate a need for force initialization after restart. As a side effect we need to update helper functions in service_worker_storage_unittest.cc Bug: 1133143 Change-Id: I43057adfbbc91d94dd5aedc22c684cb862ab26d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519345Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824782}
-
Sigurd Schneider authored
This CL allows the WorkerDevToolsAgentHost to get to the DedicatedWorkerHost of the associated dedicated worker, which was previously not possible. This is accomplished by re-using the dedicated worker token as devtools token, and by adding a lookup mechanism on the DedicatedWorkerServiceImpl which allows looking up the DedicatedWorkerHost based on said token. The CL then uses this mechanism to allow look-up of the COEP status on dedicated workers. Bug: chromium:1051466, chromium:1145158 Change-Id: Id038006e6437d3c622ca74979ac1ab4493bcd240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494861Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#824781}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b665312ca15..0891c367b8b2 2020-11-06 chinglinyu@google.com Merge "traced: provide options to set socket permissions." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I06d7478c34a985fac544646a8bcc1ab59169da48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522599Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604620781-6e005798045dacc8d1de821cf745cddceb8035b4.profdata to chrome-mac-master-1604642156-6de658d746d924ba0793cdd79cc80ba08c1ee69e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I45082c033d3775c4995ef0fb7ca5351913264713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522688Reviewed-by:
-
Simon Zünd authored
Trust Token Redemption can be short-circuited if a valid Signed-Redemption-Record (SRR) already exists. In this case, the network service aborts the request with a special error code. In DevTools, this is repoted as a failed request, even though it was technically a successful request served from cache. This CL handles this case better and emits a loadingFinisehd event instead of a loadingFailed event. R=caseq@chromium.org, sigurds@chromium.org Bug: chromium:1141652 Change-Id: Ie0408b7557928722ddb1964c1ad5d8bdf73aa831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516225Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
WrapExternalGpuMemoryBuffer() doesn't fill sizes and offsets of planes. This CL fills them on Linux and ChromeOS based on NativePixmapHandle acquired by the given GpuMemoryBuffer. Bug: b:172456191 Test: local playback appr.tc/?vsc=vp8&vrc=vp8 on atlas Test: video.DecodeAccelVD.* on atlas, cyan, hatch Test: Play videos on YouTube atlas Change-Id: Ie150d330e2e1df49deeafdac1f21b7669ebb790c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518311Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#824777}
-
yiyix authored
Add new attribute textRendering to canvas context 2d. Developers can now choose between auto, optimizeSpeed, optimizeLegibility and geometricPrecision for textRendering. Bug: 1144620 Change-Id: I2420967849b1080b667cf6803a8edecc06327297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511910Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#824776}
-
Asami Doi authored
The CL introduces new states to the CheckOfflineCapability feature. 1) The feature (CheckOfflineCapability) is disabled. 2) The feature is enabled (warn-only). 3) The feature is enabled (enforce). Currently, warn-only mode just records the metrics and it doesn't affect the result. It will show a warning message in another CL. Bug: 965802 Change-Id: I4a7c4b748c674004696f9587f4c988dfc2116d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508100Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824775}
-
Moe Ahmadi authored
NTP can show 10 custom links and 8 MV tiles. MV tiles appear as though they are custom links until they are modified and actually freeze into custom links. Thus, 9 MV tiles are requested from the MostVisitedSites making up to 10 custom links including the "Add shortcut" button. Given that the 9th MV tile is need only if custom links are enabled and is ignored otherwise, this CL changes the number of requested MV tiles to 8 and allows MostVisitedSites itself to decide when to return an additional tile. This CL does not change the user experience. It only facilitates integration of the Repeatable Queries into MostVisitedSites. Bug: 1145050 Change-Id: Ib784019e99abf98ee6a2a6373c5f1eeb834b9615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516383Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824774}
-
Yuki Shiino authored
Makes blink_type_info more friendly to use of forward declarations so that complete type definitions are not required. Bug: 839389 Change-Id: Ie6ec1bd350cd6bd60e569cc24717055871d5d44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521871 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824773}
-
Bartek Nowierski authored
The code wasn't accurate to begin with as it doesn't decommit enough. Line 318 does it correctly, thus superseding the code being removed. Name local variables more accurately, while at it. Change-Id: I44c6aae01bf263704354c4c331064f084873e2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519430 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67117aa5b601..abc1b79a1564 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645 Tbr: peria@google.com Change-Id: Ia0648530749b77e7aee75216750631dc8d3509f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522683Reviewed-by:
-
Robin Lewis authored
Login enforcement for policies is done only when cloud policies is enabled. This cl is the same as one reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/2503810 but which was reverted due to time out issues on win-asan build. This cl refactors the tests to decrease the number of scenarios being tested. Bug: 1142903 Change-Id: I97508f69ebefb15d1129f775743c27a5dac1a3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518267Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#824770}
-
Ramin Halavati authored
WindowAppleScript initialization with profile sometimes crashes and this can be due to unavailability of browser creation at that time. Code added to prevent crash and facilitate further investigation. Bug: 1144992 Change-Id: I4835f443cca7e29c7f66334b06ca0f878702ea4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516359Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#824769}
-
